2017-04-07 14:31:32

by Niklas Cassel

Subject: [PATCH net-next] bindings: net: stmmac: add missing note about LPI interrupt

From: Niklas Cassel <[email protected]>

The hardware has a LPI interrupt.
There is already code in the stmmac driver to parse and handle the
interrupt. However, this information was missing from the DT binding.

Signed-off-by: Niklas Cassel <[email protected]>
---
Documentation/devicetree/bindings/net/stmmac.txt | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/stmmac.txt b/Documentation/devicetree/bindings/net/stmmac.txt
index f652b0c384ce..8977abc266ac 100644
--- a/Documentation/devicetree/bindings/net/stmmac.txt
+++ b/Documentation/devicetree/bindings/net/stmmac.txt
@@ -8,8 +8,8 @@ Required properties:
that services interrupts for this device
- interrupts: Should contain the STMMAC interrupts
- interrupt-names: Should contain the interrupt names "macirq"
- "eth_wake_irq" if this interrupt is supported in the "interrupts"
- property
+ "eth_wake_irq" if this interrupt is supported in the "interrupts property
+ "eth_lpi" if this interrupt is supported in the "interrupts" property
- phy-mode: See ethernet.txt file in the same directory.
- snps,reset-gpio gpio number for phy reset.
- snps,reset-active-low boolean flag to indicate if phy reset is active low.
@@ -152,8 +152,8 @@ Examples:
compatible = "st,spear600-gmac";
reg = <0xe0800000 0x8000>;
interrupt-parent = <&vic1>;
- interrupts = <24 23>;
- interrupt-names = "macirq", "eth_wake_irq";
+ interrupts = <24 23 22>;
+ interrupt-names = "macirq", "eth_wake_irq", "eth_lpi";
mac-address = [000000000000]; /* Filled in by U-Boot */
max-frame-size = <3800>;
phy-mode = "gmii";
--
2.11.0

2017-04-07 16:48:26

by Sergei Shtylyov

Subject: Re: [PATCH net-next] bindings: net: stmmac: add missing note about LPI interrupt

Hello!

On 04/07/2017 05:30 PM, Niklas Cassel wrote:

> From: Niklas Cassel <[email protected]>
>
> The hardware has a LPI interrupt.
> There is already code in the stmmac driver to parse and handle the
> interrupt. However, this information was missing from the DT binding.
>
> Signed-off-by: Niklas Cassel <[email protected]>
> ---
> Documentation/devicetree/bindings/net/stmmac.txt | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/stmmac.txt b/Documentation/devicetree/bindings/net/stmmac.txt
> index f652b0c384ce..8977abc266ac 100644
> --- a/Documentation/devicetree/bindings/net/stmmac.txt
> +++ b/Documentation/devicetree/bindings/net/stmmac.txt
> @@ -8,8 +8,8 @@ Required properties:
> that services interrupts for this device
> - interrupts: Should contain the STMMAC interrupts
> - interrupt-names: Should contain the interrupt names "macirq"
> - "eth_wake_irq" if this interrupt is supported in the "interrupts"
> - property
> + "eth_wake_irq" if this interrupt is supported in the "interrupts property

Missed closing quote?

> + "eth_lpi" if this interrupt is supported in the "interrupts" property
> - phy-mode: See ethernet.txt file in the same directory.
> - snps,reset-gpio gpio number for phy reset.
> - snps,reset-active-low boolean flag to indicate if phy reset is active low.
[...]

MBR, Sergei

2017-04-10 07:43:20

by Niklas Cassel

Subject: Re: [PATCH net-next] bindings: net: stmmac: add missing note about LPI interrupt

On 04/07/2017 06:48 PM, Sergei Shtylyov wrote:
> Hello!
>
> On 04/07/2017 05:30 PM, Niklas Cassel wrote:
>
>> From: Niklas Cassel <[email protected]>
>>
>> The hardware has a LPI interrupt.
>> There is already code in the stmmac driver to parse and handle the
>> interrupt. However, this information was missing from the DT binding.
>>
>> Signed-off-by: Niklas Cassel <[email protected]>
>> ---
>> Documentation/devicetree/bindings/net/stmmac.txt | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/net/stmmac.txt b/Documentation/devicetree/bindings/net/stmmac.txt
>> index f652b0c384ce..8977abc266ac 100644
>> --- a/Documentation/devicetree/bindings/net/stmmac.txt
>> +++ b/Documentation/devicetree/bindings/net/stmmac.txt
>> @@ -8,8 +8,8 @@ Required properties:
>> that services interrupts for this device
>> - interrupts: Should contain the STMMAC interrupts
>> - interrupt-names: Should contain the interrupt names "macirq"
>> - "eth_wake_irq" if this interrupt is supported in the "interrupts"
>> - property
>> + "eth_wake_irq" if this interrupt is supported in the "interrupts property
>
> Missed closing quote?

Thanks for pointing it out.
Will send a v2.

>
>> + "eth_lpi" if this interrupt is supported in the "interrupts" property
>> - phy-mode: See ethernet.txt file in the same directory.
>> - snps,reset-gpio gpio number for phy reset.
>> - snps,reset-active-low boolean flag to indicate if phy reset is active low.
> [...]
>
> MBR, Sergei
>