From: Jani Nikula <[email protected]>
Date: Wed, 31 May 2017 18:50:43 +0300
> From: Chris Wilson <[email protected]>
>
> An error during suspend (e100e_pm_suspend),
...
> lead to complete failure:
...
> The unwind failures stems from commit 2800209994f8 ("e1000e: Refactor PM
> flows"), but it may be a later patch that introduced the non-recoverable
> behaviour.
>
> Fixes: 2800209994f8 ("e1000e: Refactor PM flows")
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99847
> Cc: Tvrtko Ursulin <[email protected]>
> Cc: Jeff Kirsher <[email protected]>
> Cc: Dave Ertman <[email protected]>
> Cc: Bruce Allan <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Signed-off-by: Chris Wilson <[email protected]>
> [Jani: bikeshed repainted]
> Signed-off-by: Jani Nikula <[email protected]>
Jeff, please make sure this gets submitted to me soon.
Thanks.
On Fri, 2017-06-02 at 14:14 -0400, David Miller wrote:
> From: Jani Nikula <[email protected]>
> Date: Wed, 31 May 2017 18:50:43 +0300
>
> > From: Chris Wilson <[email protected]>
> >
> > An error during suspend (e100e_pm_suspend),
>
> ...
> > lead to complete failure:
>
> ...
> > The unwind failures stems from commit 2800209994f8 ("e1000e:
> > Refactor PM
> > flows"), but it may be a later patch that introduced the non-
> > recoverable
> > behaviour.
> >
> > Fixes: 2800209994f8 ("e1000e: Refactor PM flows")
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99847
> > Cc: Tvrtko Ursulin <[email protected]>
> > Cc: Jeff Kirsher <[email protected]>
> > Cc: Dave Ertman <[email protected]>
> > Cc: Bruce Allan <[email protected]>
> > Cc: [email protected]
> > Cc: [email protected]
> > Signed-off-by: Chris Wilson <[email protected]>
> > [Jani: bikeshed repainted]
> > Signed-off-by: Jani Nikula <[email protected]>
>
> Jeff, please make sure this gets submitted to me soon.
Expect it later tonight, just finishing up testing.
> From: Intel-wired-lan [mailto:[email protected]] On Behalf
> Of Jeff Kirsher
> Sent: Tuesday, June 6, 2017 1:46 PM
> To: David Miller <[email protected]>; Nikula, Jani
> <[email protected]>
> Cc: Ursulin, Tvrtko <[email protected]>; [email protected]; intel-
> [email protected]; [email protected];
> [email protected]; [email protected]; Ertman, David M
> <[email protected]>; [email protected]; dri-
> [email protected]; [email protected]; [email protected]
> Subject: Re: [Intel-wired-lan] [PATCH v2 1/1] e1000e: Undo
> e1000e_pm_freeze if __e1000_shutdown fails
>
> On Fri, 2017-06-02 at 14:14 -0400, David Miller wrote:
> > From: Jani Nikula <[email protected]>
> > Date: Wed, 31 May 2017 18:50:43 +0300
> >
> > > From: Chris Wilson <[email protected]>
> > >
> > > An error during suspend (e100e_pm_suspend),
> >
> > ...
> > > lead to complete failure:
> >
> > ...
> > > The unwind failures stems from commit 2800209994f8 ("e1000e:
> > > Refactor PM
> > > flows"), but it may be a later patch that introduced the non-
> > > recoverable
> > > behaviour.
> > >
> > > Fixes: 2800209994f8 ("e1000e: Refactor PM flows")
> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99847
> > > Cc: Tvrtko Ursulin <[email protected]>
> > > Cc: Jeff Kirsher <[email protected]>
> > > Cc: Dave Ertman <[email protected]>
> > > Cc: Bruce Allan <[email protected]>
> > > Cc: [email protected]
> > > Cc: [email protected]
> > > Signed-off-by: Chris Wilson <[email protected]>
> > > [Jani: bikeshed repainted]
> > > Signed-off-by: Jani Nikula <[email protected]>
> >
> > Jeff, please make sure this gets submitted to me soon.
>
> Expect it later tonight, just finishing up testing.
Tested-by: Aaron Brown <[email protected]>
On Wed, Jun 07, 2017 at 01:07:33AM +0000, Brown, Aaron F wrote:
> > From: Intel-wired-lan [mailto:[email protected]] On Behalf
> > Of Jeff Kirsher
> > Sent: Tuesday, June 6, 2017 1:46 PM
> > To: David Miller <[email protected]>; Nikula, Jani
> > <[email protected]>
> > Cc: Ursulin, Tvrtko <[email protected]>; [email protected]; intel-
> > [email protected]; [email protected];
> > [email protected]; [email protected]; Ertman, David M
> > <[email protected]>; [email protected]; dri-
> > [email protected]; [email protected]; [email protected]
> > Subject: Re: [Intel-wired-lan] [PATCH v2 1/1] e1000e: Undo
> > e1000e_pm_freeze if __e1000_shutdown fails
> >
> > On Fri, 2017-06-02 at 14:14 -0400, David Miller wrote:
> > > From: Jani Nikula <[email protected]>
> > > Date: Wed, 31 May 2017 18:50:43 +0300
> > >
> > > > From: Chris Wilson <[email protected]>
> > > >
> > > > An error during suspend (e100e_pm_suspend),
> > >
> > > ...
> > > > lead to complete failure:
> > >
> > > ...
> > > > The unwind failures stems from commit 2800209994f8 ("e1000e:
> > > > Refactor PM
> > > > flows"), but it may be a later patch that introduced the non-
> > > > recoverable
> > > > behaviour.
> > > >
> > > > Fixes: 2800209994f8 ("e1000e: Refactor PM flows")
> > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99847
> > > > Cc: Tvrtko Ursulin <[email protected]>
> > > > Cc: Jeff Kirsher <[email protected]>
> > > > Cc: Dave Ertman <[email protected]>
> > > > Cc: Bruce Allan <[email protected]>
> > > > Cc: [email protected]
> > > > Cc: [email protected]
> > > > Signed-off-by: Chris Wilson <[email protected]>
> > > > [Jani: bikeshed repainted]
> > > > Signed-off-by: Jani Nikula <[email protected]>
> > >
> > > Jeff, please make sure this gets submitted to me soon.
> >
> > Expect it later tonight, just finishing up testing.
>
> Tested-by: Aaron Brown <[email protected]>
Hm, I seem to be blind, but I can't find it anywhere in -rc6. Does someone
have the sha1 from Linus' git for this patch?
Thanks, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
On 20 June 2017 at 18:49, Daniel Vetter <[email protected]> wrote:
> On Wed, Jun 07, 2017 at 01:07:33AM +0000, Brown, Aaron F wrote:
>> > From: Intel-wired-lan [mailto:[email protected]] On Behalf
>> > Of Jeff Kirsher
>> > Sent: Tuesday, June 6, 2017 1:46 PM
>> > To: David Miller <[email protected]>; Nikula, Jani
>> > <[email protected]>
>> > Cc: Ursulin, Tvrtko <[email protected]>; [email protected]; intel-
>> > [email protected]; [email protected];
>> > [email protected]; [email protected]; Ertman, David M
>> > <[email protected]>; [email protected]; dri-
>> > [email protected]; [email protected]; [email protected]
>> > Subject: Re: [Intel-wired-lan] [PATCH v2 1/1] e1000e: Undo
>> > e1000e_pm_freeze if __e1000_shutdown fails
>> >
>> > On Fri, 2017-06-02 at 14:14 -0400, David Miller wrote:
>> > > From: Jani Nikula <[email protected]>
>> > > Date: Wed, 31 May 2017 18:50:43 +0300
>> > >
>> > > > From: Chris Wilson <[email protected]>
>> > > >
>> > > > An error during suspend (e100e_pm_suspend),
>> > >
>> > > ...
>> > > > lead to complete failure:
>> > >
>> > > ...
>> > > > The unwind failures stems from commit 2800209994f8 ("e1000e:
>> > > > Refactor PM
>> > > > flows"), but it may be a later patch that introduced the non-
>> > > > recoverable
>> > > > behaviour.
>> > > >
>> > > > Fixes: 2800209994f8 ("e1000e: Refactor PM flows")
>> > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99847
>> > > > Cc: Tvrtko Ursulin <[email protected]>
>> > > > Cc: Jeff Kirsher <[email protected]>
>> > > > Cc: Dave Ertman <[email protected]>
>> > > > Cc: Bruce Allan <[email protected]>
>> > > > Cc: [email protected]
>> > > > Cc: [email protected]
>> > > > Signed-off-by: Chris Wilson <[email protected]>
>> > > > [Jani: bikeshed repainted]
>> > > > Signed-off-by: Jani Nikula <[email protected]>
>> > >
>> > > Jeff, please make sure this gets submitted to me soon.
>> >
>> > Expect it later tonight, just finishing up testing.
>>
>> Tested-by: Aaron Brown <[email protected]>
>
> Hm, I seem to be blind, but I can't find it anywhere in -rc6. Does someone
> have the sha1 from Linus' git for this patch?
Guys this is a pretty serious regression, just left blowing in the
wind, is anyone responsible for e1000e?
Dave.
On Wed, 2017-06-28 at 05:28 +1000, Dave Airlie wrote:
> On 20 June 2017 at 18:49, Daniel Vetter <[email protected]> wrote:
> > On Wed, Jun 07, 2017 at 01:07:33AM +0000, Brown, Aaron F wrote:
> > > > From: Intel-wired-lan [mailto:[email protected]]
> > > > On Behalf
> > > > Of Jeff Kirsher
> > > > Sent: Tuesday, June 6, 2017 1:46 PM
> > > > To: David Miller <[email protected]>; Nikula, Jani
> > > > <[email protected]>
> > > > Cc: Ursulin, Tvrtko <[email protected]>; daniel.vetter@ffwll
> > > > .ch; intel-
> > > > [email protected]; [email protected];
> > > > [email protected]; [email protected]; Ertman,
> > > > David M
> > > > <[email protected]>; [email protected]; dri-
> > > > [email protected]; [email protected]; airlied@gmail.
> > > > com
> > > > Subject: Re: [Intel-wired-lan] [PATCH v2 1/1] e1000e: Undo
> > > > e1000e_pm_freeze if __e1000_shutdown fails
> > > >
> > > > On Fri, 2017-06-02 at 14:14 -0400, David Miller wrote:
> > > > > From: Jani Nikula <[email protected]>
> > > > > Date: Wed, 31 May 2017 18:50:43 +0300
> > > > >
> > > > > > From: Chris Wilson <[email protected]>
> > > > > >
> > > > > > An error during suspend (e100e_pm_suspend),
> > > > >
> > > > > ...
> > > > > > lead to complete failure:
> > > > >
> > > > > ...
> > > > > > The unwind failures stems from commit 2800209994f8 ("e1000e:
> > > > > > Refactor PM
> > > > > > flows"), but it may be a later patch that introduced the non-
> > > > > > recoverable
> > > > > > behaviour.
> > > > > >
> > > > > > Fixes: 2800209994f8 ("e1000e: Refactor PM flows")
> > > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99847
> > > > > > Cc: Tvrtko Ursulin <[email protected]>
> > > > > > Cc: Jeff Kirsher <[email protected]>
> > > > > > Cc: Dave Ertman <[email protected]>
> > > > > > Cc: Bruce Allan <[email protected]>
> > > > > > Cc: [email protected]
> > > > > > Cc: [email protected]
> > > > > > Signed-off-by: Chris Wilson <[email protected]>
> > > > > > [Jani: bikeshed repainted]
> > > > > > Signed-off-by: Jani Nikula <[email protected]>
> > > > >
> > > > > Jeff, please make sure this gets submitted to me soon.
> > > >
> > > > Expect it later tonight, just finishing up testing.
> > >
> > > Tested-by: Aaron Brown <[email protected]>
> >
> > Hm, I seem to be blind, but I can't find it anywhere in -rc6. Does
> > someone
> > have the sha1 from Linus' git for this patch?
>
> Guys this is a pretty serious regression, just left blowing in the
> wind, is anyone responsible for e1000e?
This was submitted and accepted into David Miller's net-next tree. I can
see if Dave can pull it into his net tree. DOes stable need to pick this
up as well?
On Tue, Jun 27, 2017 at 10:51 PM, Jeff Kirsher
<[email protected]> wrote:
> This was submitted and accepted into David Miller's net-next tree. I can
> see if Dave can pull it into his net tree. DOes stable need to pick this
> up as well?
Nah if it landed somewhere at least I'm happy, we can carry the fixup
for a while longer locally.
Thanks, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch