2017-07-18 14:25:45

by Paul Kocialkowski

Subject: [PATCH v2] drm/i915: Explicit the connector name for DP link training result

This adds the connector name when printing a debug message about the DP
link training result. It is useful to figure out what connector is
failing when multiple DP connectors are used.

Signed-off-by: Paul Kocialkowski <[email protected]>
---
drivers/gpu/drm/i915/intel_dp_link_training.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_dp_link_training.c b/drivers/gpu/drm/i915/intel_dp_link_training.c
index b79c1c0e404c..05907fa8a553 100644
--- a/drivers/gpu/drm/i915/intel_dp_link_training.c
+++ b/drivers/gpu/drm/i915/intel_dp_link_training.c
@@ -321,12 +321,16 @@ intel_dp_start_link_train(struct intel_dp *intel_dp)
if (!intel_dp_link_training_channel_equalization(intel_dp))
goto failure_handling;

- DRM_DEBUG_KMS("Link Training Passed at Link Rate = %d, Lane count = %d",
+ DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Link Training Passed at Link Rate = %d, Lane count = %d",
+ intel_connector->base.base.id,
+ intel_connector->base.name,
intel_dp->link_rate, intel_dp->lane_count);
return;

failure_handling:
- DRM_DEBUG_KMS("Link Training failed at link rate = %d, lane count = %d",
+ DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Link Training failed at link rate = %d, lane count = %d",
+ intel_connector->base.base.id,
+ intel_connector->base.name,
intel_dp->link_rate, intel_dp->lane_count);
if (!intel_dp_get_link_train_fallback_values(intel_dp,
intel_dp->link_rate,
--
2.13.2

2017-07-18 18:55:55

by Dhinakaran Pandiyan

Subject: Re: [Intel-gfx] [PATCH v2] drm/i915: Explicit the connector name for DP link training result

On Tue, 2017-07-18 at 17:25 +0300, Paul Kocialkowski wrote:
> This adds the connector name when printing a debug message about the DP
> link training result. It is useful to figure out what connector is
> failing when multiple DP connectors are used.
>
> Signed-off-by: Paul Kocialkowski <[email protected]>
> ---
> drivers/gpu/drm/i915/intel_dp_link_training.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp_link_training.c b/drivers/gpu/drm/i915/intel_dp_link_training.c
> index b79c1c0e404c..05907fa8a553 100644
> --- a/drivers/gpu/drm/i915/intel_dp_link_training.c
> +++ b/drivers/gpu/drm/i915/intel_dp_link_training.c
> @@ -321,12 +321,16 @@ intel_dp_start_link_train(struct intel_dp *intel_dp)
> if (!intel_dp_link_training_channel_equalization(intel_dp))
> goto failure_handling;
>
> - DRM_DEBUG_KMS("Link Training Passed at Link Rate = %d, Lane count = %d",
> + DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Link Training Passed at Link Rate = %d, Lane count = %d",
> + intel_connector->base.base.id,
> + intel_connector->base.name,
> intel_dp->link_rate, intel_dp->lane_count);
> return;
>
> failure_handling:
> - DRM_DEBUG_KMS("Link Training failed at link rate = %d, lane count = %d",
> + DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Link Training failed at link rate = %d, lane count = %d",
> + intel_connector->base.base.id,
> + intel_connector->base.name,
> intel_dp->link_rate, intel_dp->lane_count);
> if (!intel_dp_get_link_train_fallback_values(intel_dp,
> intel_dp->link_rate,


Reviewed-by: Dhinakaran Pandiyan <[email protected]>

The choice of upper v/s lower case letters in these debug messages is a
bit odd.

Passed/failed
Link rate/link rate
Lane count/lane count

2017-07-18 19:13:47

by Navare, Manasi

Subject: Re: [PATCH v2] drm/i915: Explicit the connector name for DP link training result

On Tue, Jul 18, 2017 at 05:25:36PM +0300, Paul Kocialkowski wrote:
> This adds the connector name when printing a debug message about the DP
> link training result. It is useful to figure out what connector is
> failing when multiple DP connectors are used.
>

Thanks for the patch, this does make sense during the link training
failure debugging to know the connector name.
While at it feel free to change "Failed", "Link Rate, Lane Count", to upper case
in the failure_handling case to be consistent with the pass case.

Reviewed-by: Manasi Navare <[email protected]>

Manasi

> Signed-off-by: Paul Kocialkowski <[email protected]>
> ---
> drivers/gpu/drm/i915/intel_dp_link_training.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp_link_training.c b/drivers/gpu/drm/i915/intel_dp_link_training.c
> index b79c1c0e404c..05907fa8a553 100644
> --- a/drivers/gpu/drm/i915/intel_dp_link_training.c
> +++ b/drivers/gpu/drm/i915/intel_dp_link_training.c
> @@ -321,12 +321,16 @@ intel_dp_start_link_train(struct intel_dp *intel_dp)
> if (!intel_dp_link_training_channel_equalization(intel_dp))
> goto failure_handling;
>
> - DRM_DEBUG_KMS("Link Training Passed at Link Rate = %d, Lane count = %d",
> + DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Link Training Passed at Link Rate = %d, Lane count = %d",
> + intel_connector->base.base.id,
> + intel_connector->base.name,
> intel_dp->link_rate, intel_dp->lane_count);
> return;
>
> failure_handling:
> - DRM_DEBUG_KMS("Link Training failed at link rate = %d, lane count = %d",
> + DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Link Training failed at link rate = %d, lane count = %d",
> + intel_connector->base.base.id,
> + intel_connector->base.name,
> intel_dp->link_rate, intel_dp->lane_count);
> if (!intel_dp_get_link_train_fallback_values(intel_dp,
> intel_dp->link_rate,
> --
> 2.13.2
>

2017-07-19 06:33:15

by Daniel Vetter

Subject: Re: [PATCH v2] drm/i915: Explicit the connector name for DP link training result

On Tue, Jul 18, 2017 at 12:20:36PM -0700, Manasi Navare wrote:
> On Tue, Jul 18, 2017 at 05:25:36PM +0300, Paul Kocialkowski wrote:
> > This adds the connector name when printing a debug message about the DP
> > link training result. It is useful to figure out what connector is
> > failing when multiple DP connectors are used.
> >
>
> Thanks for the patch, this does make sense during the link training
> failure debugging to know the connector name.
> While at it feel free to change "Failed", "Link Rate, Lane Count", to upper case
> in the failure_handling case to be consistent with the pass case.
>
> Reviewed-by: Manasi Navare <[email protected]>

Applied, thanks.
-Daniel

>
> Manasi
>
> > Signed-off-by: Paul Kocialkowski <[email protected]>
> > ---
> > drivers/gpu/drm/i915/intel_dp_link_training.c | 8 ++++++--
> > 1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_dp_link_training.c b/drivers/gpu/drm/i915/intel_dp_link_training.c
> > index b79c1c0e404c..05907fa8a553 100644
> > --- a/drivers/gpu/drm/i915/intel_dp_link_training.c
> > +++ b/drivers/gpu/drm/i915/intel_dp_link_training.c
> > @@ -321,12 +321,16 @@ intel_dp_start_link_train(struct intel_dp *intel_dp)
> > if (!intel_dp_link_training_channel_equalization(intel_dp))
> > goto failure_handling;
> >
> > - DRM_DEBUG_KMS("Link Training Passed at Link Rate = %d, Lane count = %d",
> > + DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Link Training Passed at Link Rate = %d, Lane count = %d",
> > + intel_connector->base.base.id,
> > + intel_connector->base.name,
> > intel_dp->link_rate, intel_dp->lane_count);
> > return;
> >
> > failure_handling:
> > - DRM_DEBUG_KMS("Link Training failed at link rate = %d, lane count = %d",
> > + DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Link Training failed at link rate = %d, lane count = %d",
> > + intel_connector->base.base.id,
> > + intel_connector->base.name,
> > intel_dp->link_rate, intel_dp->lane_count);
> > if (!intel_dp_get_link_train_fallback_values(intel_dp,
> > intel_dp->link_rate,
> > --
> > 2.13.2
> >
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

2017-07-19 08:33:14

by Paul Kocialkowski

Subject: Re: [PATCH v2] drm/i915: Explicit the connector name for DP link training result

On Tue, 2017-07-18 at 12:20 -0700, Manasi Navare wrote:
> On Tue, Jul 18, 2017 at 05:25:36PM +0300, Paul Kocialkowski wrote:
> > This adds the connector name when printing a debug message about the
> > DP
> > link training result. It is useful to figure out what connector is
> > failing when multiple DP connectors are used.
> >
>
> Thanks for the patch, this does make sense during the link training
> failure debugging to know the connector name.
> While at it feel free to change "Failed", "Link Rate, Lane Count", to
> upper case
> in the failure_handling case to be consistent with the pass case.

Thanks for the review!

Now that the patch was merged, do you feel like I should make a follow-
up patch to fix consistency in the upper case use or is it enough of a
detail that we can just forget about it?

> Reviewed-by: Manasi Navare <[email protected]>
>
> Manasi
>
> > Signed-off-by: Paul Kocialkowski <[email protected]>
> > ---
> > drivers/gpu/drm/i915/intel_dp_link_training.c | 8 ++++++--
> > 1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_dp_link_training.c
> > b/drivers/gpu/drm/i915/intel_dp_link_training.c
> > index b79c1c0e404c..05907fa8a553 100644
> > --- a/drivers/gpu/drm/i915/intel_dp_link_training.c
> > +++ b/drivers/gpu/drm/i915/intel_dp_link_training.c
> > @@ -321,12 +321,16 @@ intel_dp_start_link_train(struct intel_dp
> > *intel_dp)
> > if (!intel_dp_link_training_channel_equalization(intel_dp))
> > goto failure_handling;
> >
> > - DRM_DEBUG_KMS("Link Training Passed at Link Rate = %d, Lane
> > count = %d",
> > + DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Link Training Passed at
> > Link Rate = %d, Lane count = %d",
> > + intel_connector->base.base.id,
> > + intel_connector->base.name,
> > intel_dp->link_rate, intel_dp->lane_count);
> > return;
> >
> > failure_handling:
> > - DRM_DEBUG_KMS("Link Training failed at link rate = %d, lane
> > count = %d",
> > + DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Link Training failed at
> > link rate = %d, lane count = %d",
> > + intel_connector->base.base.id,
> > + intel_connector->base.name,
> > intel_dp->link_rate, intel_dp->lane_count);
> > if (!intel_dp_get_link_train_fallback_values(intel_dp,
> > intel_dp-
> > >link_rate,
> > --
> > 2.13.2
> >
--
Paul Kocialkowski <[email protected]>
Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo, Finland

2017-07-19 08:49:57

by Jani Nikula

Subject: Re: [PATCH v2] drm/i915: Explicit the connector name for DP link training result

On Wed, 19 Jul 2017, Paul Kocialkowski <[email protected]> wrote:
> On Tue, 2017-07-18 at 12:20 -0700, Manasi Navare wrote:
>> On Tue, Jul 18, 2017 at 05:25:36PM +0300, Paul Kocialkowski wrote:
>> > This adds the connector name when printing a debug message about the
>> > DP
>> > link training result. It is useful to figure out what connector is
>> > failing when multiple DP connectors are used.
>> >
>>
>> Thanks for the patch, this does make sense during the link training
>> failure debugging to know the connector name.
>> While at it feel free to change "Failed", "Link Rate, Lane Count", to
>> upper case
>> in the failure_handling case to be consistent with the pass case.
>
> Thanks for the review!
>
> Now that the patch was merged, do you feel like I should make a follow-
> up patch to fix consistency in the upper case use or is it enough of a
> detail that we can just forget about it?

If it bothers you, send a patch, otherwise wait for it to bother someone
else enough to send a patch. ;)

But please avoid the overuse of all caps for regular words, or
capitalization except at the beginning of sentences. I'd go with
something like this all over the place:

"Link training failed, link rate %d, lane count %d\n"

But it hasn't bothered me enough to send a patch. ;)

BR,
Jani.



>
>> Reviewed-by: Manasi Navare <[email protected]>
>>
>> Manasi
>>
>> > Signed-off-by: Paul Kocialkowski <[email protected]>
>> > ---
>> > drivers/gpu/drm/i915/intel_dp_link_training.c | 8 ++++++--
>> > 1 file changed, 6 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/drivers/gpu/drm/i915/intel_dp_link_training.c
>> > b/drivers/gpu/drm/i915/intel_dp_link_training.c
>> > index b79c1c0e404c..05907fa8a553 100644
>> > --- a/drivers/gpu/drm/i915/intel_dp_link_training.c
>> > +++ b/drivers/gpu/drm/i915/intel_dp_link_training.c
>> > @@ -321,12 +321,16 @@ intel_dp_start_link_train(struct intel_dp
>> > *intel_dp)
>> > if (!intel_dp_link_training_channel_equalization(intel_dp))
>> > goto failure_handling;
>> >
>> > - DRM_DEBUG_KMS("Link Training Passed at Link Rate = %d, Lane
>> > count = %d",
>> > + DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Link Training Passed at
>> > Link Rate = %d, Lane count = %d",
>> > + intel_connector->base.base.id,
>> > + intel_connector->base.name,
>> > intel_dp->link_rate, intel_dp->lane_count);
>> > return;
>> >
>> > failure_handling:
>> > - DRM_DEBUG_KMS("Link Training failed at link rate = %d, lane
>> > count = %d",
>> > + DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Link Training failed at
>> > link rate = %d, lane count = %d",
>> > + intel_connector->base.base.id,
>> > + intel_connector->base.name,
>> > intel_dp->link_rate, intel_dp->lane_count);
>> > if (!intel_dp_get_link_train_fallback_values(intel_dp,
>> > intel_dp-
>> > >link_rate,
>> > --
>> > 2.13.2
>> >

--
Jani Nikula, Intel Open Source Technology Center