2017-08-17 11:55:34

by Laurentiu Tudor

Subject: [PATCH] staging: fsl-mc: be consistent when checking strcmp() returns

From: Laurentiu Tudor <[email protected]>

Throughout the driver we use == 0 / != 0 to check strcmp() returns except
this place, so fix it.

Signed-off-by: Laurentiu Tudor <[email protected]>
---
drivers/staging/fsl-mc/bus/dprc-driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/fsl-mc/bus/dprc-driver.c b/drivers/staging/fsl-mc/bus/dprc-driver.c
index 485abad..06df528 100644
--- a/drivers/staging/fsl-mc/bus/dprc-driver.c
+++ b/drivers/staging/fsl-mc/bus/dprc-driver.c
@@ -29,7 +29,7 @@ static bool fsl_mc_device_match(struct fsl_mc_device *mc_dev,
struct fsl_mc_obj_desc *obj_desc)
{
return mc_dev->obj_desc.id == obj_desc->id &&
- !strcmp(mc_dev->obj_desc.type, obj_desc->type);
+ strcmp(mc_dev->obj_desc.type, obj_desc->type) == 0;

}

--
2.9.4

2017-08-23 01:40:28

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: fsl-mc: be consistent when checking strcmp() returns

On Thu, Aug 17, 2017 at 02:55:04PM +0300, [email protected] wrote:
> From: Laurentiu Tudor <[email protected]>
>
> Throughout the driver we use == 0 / != 0 to check strcmp() returns except
> this place, so fix it.

You will just get someone else fixing it as it is not what checkpatch
recommends, so just leave it as-is please.

thanks,

greg k-h

2017-08-23 02:34:05

by Joe Perches

Subject: Re: [PATCH] staging: fsl-mc: be consistent when checking strcmp() returns

On Tue, 2017-08-22 at 18:40 -0700, Greg KH wrote:
> On Thu, Aug 17, 2017 at 02:55:04PM +0300, [email protected] wrote:
> > From: Laurentiu Tudor <[email protected]>
> >
> > Throughout the driver we use == 0 / != 0 to check strcmp() returns except
> > this place, so fix it.
>
> You will just get someone else fixing it as it is not what checkpatch
> recommends, so just leave it as-is please.

No. That's not correct.

checkpatch does not make a recommendation about
style use with the strcmp family of functions.

2017-08-23 05:38:45

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: fsl-mc: be consistent when checking strcmp() returns

On Tue, Aug 22, 2017 at 07:33:45PM -0700, Joe Perches wrote:
> On Tue, 2017-08-22 at 18:40 -0700, Greg KH wrote:
> > On Thu, Aug 17, 2017 at 02:55:04PM +0300, [email protected] wrote:
> > > From: Laurentiu Tudor <[email protected]>
> > >
> > > Throughout the driver we use == 0 / != 0 to check strcmp() returns except
> > > this place, so fix it.
> >
> > You will just get someone else fixing it as it is not what checkpatch
> > recommends, so just leave it as-is please.
>
> No. That's not correct.
>
> checkpatch does not make a recommendation about
> style use with the strcmp family of functions.

Ah, ok, nevermind then...

Laurentiu, can you resend this?

thanks,

greg k-h