2019-02-21 14:29:53

by Bo YU

[permalink] [raw]
Subject: [PATCH] staging/erofs: fix sparse's warnings on undeclared symbols in erofs

From: Bo Yu <[email protected]>

Fix sparse warnings:

drivers/staging/erofs/utils.c:134:6: warning: symbol
'erofs_try_to_release_workgroup' was not declared. Should it be static?

Fixes: 51232df5e4b26("staging: erofs: fix race when the managed cache is enabled")
Cc: Gao Xiang <[email protected]>
Cc: Chao Yu <[email protected]>
CC: Greg Kroah-Hartman <[email protected]>
Signed-off-by: Bo Yu <[email protected]>
---
drivers/staging/erofs/utils.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/erofs/utils.c b/drivers/staging/erofs/utils.c
index b535898ca753..33cd5ad55cb8 100644
--- a/drivers/staging/erofs/utils.c
+++ b/drivers/staging/erofs/utils.c
@@ -131,7 +131,7 @@ static void erofs_workgroup_unfreeze_final(struct erofs_workgroup *grp)
__erofs_workgroup_free(grp);
}

-bool erofs_try_to_release_workgroup(struct erofs_sb_info *sbi,
+static bool erofs_try_to_release_workgroup(struct erofs_sb_info *sbi,
struct erofs_workgroup *grp,
bool cleanup)
{
--
2.11.0



2019-02-21 14:37:00

by Gao Xiang

[permalink] [raw]
Subject: Re: [PATCH] staging/erofs: fix sparse's warnings on undeclared symbols in erofs

Hi Bo,

On 2019/2/21 22:28, Bo YU wrote:
> From: Bo Yu <[email protected]>
>
> Fix sparse warnings:
>
> drivers/staging/erofs/utils.c:134:6: warning: symbol
> 'erofs_try_to_release_workgroup' was not declared. Should it be static?
>
> Fixes: 51232df5e4b26("staging: erofs: fix race when the managed cache is enabled")
> Cc: Gao Xiang <[email protected]>
> Cc: Chao Yu <[email protected]>
> CC: Greg Kroah-Hartman <[email protected]>
> Signed-off-by: Bo Yu <[email protected]>
> ---
> drivers/staging/erofs/utils.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/erofs/utils.c b/drivers/staging/erofs/utils.c
> index b535898ca753..33cd5ad55cb8 100644
> --- a/drivers/staging/erofs/utils.c
> +++ b/drivers/staging/erofs/utils.c
> @@ -131,7 +131,7 @@ static void erofs_workgroup_unfreeze_final(struct erofs_workgroup *grp)
> __erofs_workgroup_free(grp);
> }
>
> -bool erofs_try_to_release_workgroup(struct erofs_sb_info *sbi,
> +static bool erofs_try_to_release_workgroup(struct erofs_sb_info *sbi,
> struct erofs_workgroup *grp,
> bool cleanup)
> {
>

Have you looked the latest kernel code?
It seems erofs_try_to_release_workgroup is already be claimed as static...

See:
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/tree/drivers/staging/erofs/utils.c?h=staging-next#n148

Thanks,
Gao Xiang


2019-02-22 01:00:06

by Bo YU

[permalink] [raw]
Subject: Re: [PATCH] staging/erofs: fix sparse's warnings on undeclared symbols in erofs

Hi,
On Thu, Feb 21, 2019 at 10:35:01PM +0800, Gao Xiang wrote:
>Hi Bo,
>
>On 2019/2/21 22:28, Bo YU wrote:
>> From: Bo Yu <[email protected]>
>>
>> Fix sparse warnings:
>>
>> drivers/staging/erofs/utils.c:134:6: warning: symbol
>> 'erofs_try_to_release_workgroup' was not declared. Should it be static?
>>
>> Fixes: 51232df5e4b26("staging: erofs: fix race when the managed cache is enabled")
>> Cc: Gao Xiang <[email protected]>
>> Cc: Chao Yu <[email protected]>
>> CC: Greg Kroah-Hartman <[email protected]>
>> Signed-off-by: Bo Yu <[email protected]>
>> ---
>> drivers/staging/erofs/utils.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/erofs/utils.c b/drivers/staging/erofs/utils.c
>> index b535898ca753..33cd5ad55cb8 100644
>> --- a/drivers/staging/erofs/utils.c
>> +++ b/drivers/staging/erofs/utils.c
>> @@ -131,7 +131,7 @@ static void erofs_workgroup_unfreeze_final(struct erofs_workgroup *grp)
>> __erofs_workgroup_free(grp);
>> }
>>
>> -bool erofs_try_to_release_workgroup(struct erofs_sb_info *sbi,
>> +static bool erofs_try_to_release_workgroup(struct erofs_sb_info *sbi,
>> struct erofs_workgroup *grp,
>> bool cleanup)
>> {
>>
>
>Have you looked the latest kernel code?
Emm...yeah.But i pulled linus tree not staging tree :(
Sorry for the noise.

>It seems erofs_try_to_release_workgroup is already be claimed as static...
>
>See:
>https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/tree/drivers/staging/erofs/utils.c?h=staging-next#n148
>
>Thanks,
>Gao Xiang
>

2019-02-22 01:31:49

by Gao Xiang

[permalink] [raw]
Subject: Re: [PATCH] staging/erofs: fix sparse's warnings on undeclared symbols in erofs



On 2019/2/22 8:57, YU Bo wrote:
> Hi,
> On Thu, Feb 21, 2019 at 10:35:01PM +0800, Gao Xiang wrote:
>> Hi Bo,
>>
>> On 2019/2/21 22:28, Bo YU wrote:
>>> From: Bo Yu <[email protected]>
>>>
>>> Fix sparse warnings:
>>>
>>> drivers/staging/erofs/utils.c:134:6: warning: symbol
>>> 'erofs_try_to_release_workgroup' was not declared. Should it be static?
>>>
>>> Fixes: 51232df5e4b26("staging: erofs: fix race when the managed cache is enabled")
>>> Cc: Gao Xiang <[email protected]>
>>> Cc: Chao Yu <[email protected]>
>>> CC: Greg Kroah-Hartman <[email protected]>
>>> Signed-off-by: Bo Yu <[email protected]>
>>> ---
>>>  drivers/staging/erofs/utils.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/staging/erofs/utils.c b/drivers/staging/erofs/utils.c
>>> index b535898ca753..33cd5ad55cb8 100644
>>> --- a/drivers/staging/erofs/utils.c
>>> +++ b/drivers/staging/erofs/utils.c
>>> @@ -131,7 +131,7 @@ static void erofs_workgroup_unfreeze_final(struct erofs_workgroup *grp)
>>>      __erofs_workgroup_free(grp);
>>>  }
>>>
>>> -bool erofs_try_to_release_workgroup(struct erofs_sb_info *sbi,
>>> +static bool erofs_try_to_release_workgroup(struct erofs_sb_info *sbi,
>>>                      struct erofs_workgroup *grp,
>>>                      bool cleanup)
>>>  {
>>>
>>
>> Have you looked the latest kernel code?
> Emm...yeah.But i pulled linus tree not staging tree :(
> Sorry for the noise.

That is ok. staging tree or linux-next includes the latest source code,
you can check them out :)

Thanks,
Gao Xiang

>
>> It seems erofs_try_to_release_workgroup is already be claimed as static...
>>
>> See:
>> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/tree/drivers/staging/erofs/utils.c?h=staging-next#n148
>>
>> Thanks,
>> Gao Xiang
>>