2020-11-27 19:19:26

by Tom Rix

Subject: [PATCH] scsi: qla2xxx: remove trailing semicolon in macro definition

From: Tom Rix <[email protected]>

The macro use will already have a semicolon.

Signed-off-by: Tom Rix <[email protected]>
---
drivers/scsi/qla2xxx/qla_def.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h
index ed9b10f8537d..86d249551b2d 100644
--- a/drivers/scsi/qla2xxx/qla_def.h
+++ b/drivers/scsi/qla2xxx/qla_def.h
@@ -4970,7 +4970,7 @@ struct secure_flash_update_block_pk {
} while (0)

#define QLA_QPAIR_MARK_NOT_BUSY(__qpair) \
- atomic_dec(&__qpair->ref_count); \
+ atomic_dec(&__qpair->ref_count) \


#define QLA_ENA_CONF(_ha) {\
--
2.18.4

2020-11-30 09:22:52

by Daniel Wagner

Subject: Re: [PATCH] scsi: qla2xxx: remove trailing semicolon in macro definition

Hi Tom,

On Fri, Nov 27, 2020 at 10:27:41AM -0800, [email protected] wrote:
> From: Tom Rix <[email protected]>
>
> The macro use will already have a semicolon.
>
> Signed-off-by: Tom Rix <[email protected]>

Reviewed-by: Daniel Wagner <[email protected]>

> ---
> drivers/scsi/qla2xxx/qla_def.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h
> index ed9b10f8537d..86d249551b2d 100644
> --- a/drivers/scsi/qla2xxx/qla_def.h
> +++ b/drivers/scsi/qla2xxx/qla_def.h
> @@ -4970,7 +4970,7 @@ struct secure_flash_update_block_pk {
> } while (0)
>
> #define QLA_QPAIR_MARK_NOT_BUSY(__qpair) \
> - atomic_dec(&__qpair->ref_count); \
> + atomic_dec(&__qpair->ref_count) \

Nitpick, please insert an additional tab after the remove so that the
backlashes align again.

Thanks,
Daniel

2020-11-30 09:36:52

by Daniel Wagner

Subject: Re: [PATCH] scsi: qla2xxx: remove trailing semicolon in macro definition

On Mon, Nov 30, 2020 at 01:29:19AM -0800, Maciej Żenczykowski wrote:
> On Mon, Nov 30, 2020 at 1:23 AM Daniel Wagner <[email protected]> wrote:
> > > #define QLA_QPAIR_MARK_NOT_BUSY(__qpair) \
> > > - atomic_dec(&__qpair->ref_count); \
> > > + atomic_dec(&__qpair->ref_count) \
> >
> > Nitpick, please insert an additional tab after the remove so that the
> > backlashes align again.
> >
>
> Uhm, if there's no semicolon, then presumably it's the final line of the
> macro, and thus there should be no tabs and no backslash at the end of the
> line.

Right! Didn't realize it. The backslash should be removed.

2020-11-30 16:22:26

by Tom Rix

Subject: Re: [PATCH] scsi: qla2xxx: remove trailing semicolon in macro definition

On 11/30/20 1:17 AM, Daniel Wagner wrote:
> Hi Tom,
>
> On Fri, Nov 27, 2020 at 10:27:41AM -0800, [email protected] wrote:
>> From: Tom Rix <[email protected]>
>>
>> The macro use will already have a semicolon.
>>
>> Signed-off-by: Tom Rix <[email protected]>
> Reviewed-by: Daniel Wagner <[email protected]>
>
>> ---
>> drivers/scsi/qla2xxx/qla_def.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h
>> index ed9b10f8537d..86d249551b2d 100644
>> --- a/drivers/scsi/qla2xxx/qla_def.h
>> +++ b/drivers/scsi/qla2xxx/qla_def.h
>> @@ -4970,7 +4970,7 @@ struct secure_flash_update_block_pk {
>> } while (0)
>>
>> #define QLA_QPAIR_MARK_NOT_BUSY(__qpair) \
>> - atomic_dec(&__qpair->ref_count); \
>> + atomic_dec(&__qpair->ref_count) \
> Nitpick, please insert an additional tab after the remove so that the
> backlashes align again.

How about removing the last escaped newline and the next empty line ?

Tom

>
> Thanks,
> Daniel
>

2020-11-30 16:35:00

by Daniel Wagner

Subject: Re: [PATCH] scsi: qla2xxx: remove trailing semicolon in macro definition

> >> #define QLA_QPAIR_MARK_NOT_BUSY(__qpair) \
> >> - atomic_dec(&__qpair->ref_count); \
> >> + atomic_dec(&__qpair->ref_count) \
> > Nitpick, please insert an additional tab after the remove so that the
> > backlashes align again.
>
> How about removing the last escaped newline and the next empty line ?

Yes please.