Correct kerneldoc warning:
drivers/clk/qcom/clk-alpha-pll.c:1450:
warning: expecting prototype for clk_lucid_pll_configure(). Prototype was for clk_trion_pll_configure() instead
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/clk/qcom/clk-alpha-pll.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/qcom/clk-alpha-pll.c b/drivers/clk/qcom/clk-alpha-pll.c
index 4406cf609aae..969d98fca5df 100644
--- a/drivers/clk/qcom/clk-alpha-pll.c
+++ b/drivers/clk/qcom/clk-alpha-pll.c
@@ -1439,7 +1439,7 @@ const struct clk_ops clk_alpha_pll_postdiv_fabia_ops = {
EXPORT_SYMBOL_GPL(clk_alpha_pll_postdiv_fabia_ops);
/**
- * clk_lucid_pll_configure - configure the lucid pll
+ * clk_trion_pll_configure - configure the lucid pll
*
* @pll: clk alpha pll
* @regmap: register map
--
2.32.0
The use of strncpy() is considered deprecated for NUL-terminated
strings[1]. Replace strncpy() with strscpy_pad(), to keep existing
pad-behavior of strncpy, similarly to commit 08de420a8014 ("rpmsg:
glink: Replace strncpy() with strscpy_pad()"). This fixes W=1 warning:
In function ‘qcom_glink_rx_close’,
inlined from ‘qcom_glink_work’ at ../drivers/rpmsg/qcom_glink_native.c:1638:4:
drivers/rpmsg/qcom_glink_native.c:1549:17: warning: ‘strncpy’ specified bound 32 equals destination size [-Wstringop-truncation]
1549 | strncpy(chinfo.name, channel->name, sizeof(chinfo.name));
[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/rpmsg/qcom_glink_native.c | 2 +-
drivers/rpmsg/qcom_smd.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c
index 07586514991f..5bc5a0a6a8a7 100644
--- a/drivers/rpmsg/qcom_glink_native.c
+++ b/drivers/rpmsg/qcom_glink_native.c
@@ -1546,7 +1546,7 @@ static void qcom_glink_rx_close(struct qcom_glink *glink, unsigned int rcid)
cancel_work_sync(&channel->intent_work);
if (channel->rpdev) {
- strncpy(chinfo.name, channel->name, sizeof(chinfo.name));
+ strscpy_pad(chinfo.name, channel->name, sizeof(chinfo.name));
chinfo.src = RPMSG_ADDR_ANY;
chinfo.dst = RPMSG_ADDR_ANY;
diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c
index 6ccfa12abd10..7c8c29f6c91d 100644
--- a/drivers/rpmsg/qcom_smd.c
+++ b/drivers/rpmsg/qcom_smd.c
@@ -1089,7 +1089,7 @@ static int qcom_smd_create_device(struct qcom_smd_channel *channel)
/* Assign public information to the rpmsg_device */
rpdev = &qsdev->rpdev;
- strncpy(rpdev->id.name, channel->name, RPMSG_NAME_SIZE);
+ strscpy_pad(rpdev->id.name, channel->name, RPMSG_NAME_SIZE);
rpdev->src = RPMSG_ADDR_ANY;
rpdev->dst = RPMSG_ADDR_ANY;
@@ -1323,7 +1323,7 @@ static void qcom_channel_state_worker(struct work_struct *work)
spin_unlock_irqrestore(&edge->channels_lock, flags);
- strncpy(chinfo.name, channel->name, sizeof(chinfo.name));
+ strscpy_pad(chinfo.name, channel->name, sizeof(chinfo.name));
chinfo.src = RPMSG_ADDR_ANY;
chinfo.dst = RPMSG_ADDR_ANY;
rpmsg_unregister_device(&edge->dev, &chinfo);
--
2.32.0
Correct kerneldoc warnings like:
drivers/remoteproc/qcom_common.c:68:
warning: expecting prototype for struct minidump_subsystem_toc. Prototype was for struct minidump_subsystem instead
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/remoteproc/qcom_common.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/remoteproc/qcom_common.c b/drivers/remoteproc/qcom_common.c
index 4b91e3c9eafa..020349f8979d 100644
--- a/drivers/remoteproc/qcom_common.c
+++ b/drivers/remoteproc/qcom_common.c
@@ -50,7 +50,7 @@ struct minidump_region {
};
/**
- * struct minidump_subsystem_toc: Subsystem's SMEM Table of content
+ * struct minidump_subsystem - Subsystem's SMEM Table of content
* @status : Subsystem toc init status
* @enabled : if set to 1, this region would be copied during coredump
* @encryption_status: Encryption status for this subsystem
@@ -68,7 +68,7 @@ struct minidump_subsystem {
};
/**
- * struct minidump_global_toc: Global Table of Content
+ * struct minidump_global_toc - Global Table of Content
* @status : Global Minidump init status
* @md_revision : Minidump revision
* @enabled : Minidump enable status
--
2.32.0
The qcom_glink.name is read from DTS but never used further, never
referenced, so drop it. This also fixes kerneldoc warning:
drivers/rpmsg/qcom_glink_native.c:125:
warning: Function parameter or member 'name' not described in 'qcom_glink'
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/rpmsg/qcom_glink_native.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c
index 5bc5a0a6a8a7..72a1c0fd091d 100644
--- a/drivers/rpmsg/qcom_glink_native.c
+++ b/drivers/rpmsg/qcom_glink_native.c
@@ -98,8 +98,6 @@ struct glink_core_rx_intent {
struct qcom_glink {
struct device *dev;
- const char *name;
-
struct mbox_client mbox_client;
struct mbox_chan *mbox_chan;
@@ -1755,10 +1753,6 @@ struct qcom_glink *qcom_glink_native_probe(struct device *dev,
if (ret)
dev_err(dev, "failed to add groups\n");
- ret = of_property_read_string(dev->of_node, "label", &glink->name);
- if (ret < 0)
- glink->name = dev->of_node->name;
-
glink->mbox_client.dev = dev;
glink->mbox_client.knows_txdone = true;
glink->mbox_chan = mbox_request_channel(&glink->mbox_client, 0);
--
2.32.0
Correct kerneldoc warnings like:
drivers/firmware/qcom_scm-legacy.c:133:
warning: Function parameter or member 'dev' not described in 'scm_legacy_call'
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/firmware/qcom_scm-legacy.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/firmware/qcom_scm-legacy.c b/drivers/firmware/qcom_scm-legacy.c
index 1829ba220576..7854af4abc62 100644
--- a/drivers/firmware/qcom_scm-legacy.c
+++ b/drivers/firmware/qcom_scm-legacy.c
@@ -120,6 +120,9 @@ static void __scm_legacy_do(const struct arm_smccc_args *smc,
/**
* scm_legacy_call() - Sends a command to the SCM and waits for the command to
* finish processing.
+ * @dev: device
+ * @desc: descriptor structure containing arguments and return values
+ * @res: results from SMC/HVC call
*
* A note on cache maintenance:
* Note that any buffers that are expected to be accessed by the secure world
@@ -211,6 +214,7 @@ int scm_legacy_call(struct device *dev, const struct qcom_scm_desc *desc,
/**
* scm_legacy_call_atomic() - Send an atomic SCM command with up to 5 arguments
* and 3 return values
+ * @unused: device, legacy argument, not used, can be NULL
* @desc: SCM call descriptor containing arguments
* @res: SCM call return values
*
--
2.32.0
Correct kerneldoc warnings like:
drivers/rpmsg/qcom_glink_ssr.c:45:
warning: expecting prototype for G(). Prototype was for GLINK_SSR_DO_CLEANUP() instead
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/rpmsg/qcom_glink_ssr.c | 2 +-
drivers/rpmsg/qcom_smd.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/rpmsg/qcom_glink_ssr.c b/drivers/rpmsg/qcom_glink_ssr.c
index dea929c6045d..776d64446879 100644
--- a/drivers/rpmsg/qcom_glink_ssr.c
+++ b/drivers/rpmsg/qcom_glink_ssr.c
@@ -39,7 +39,7 @@ struct cleanup_done_msg {
__le32 seq_num;
};
-/**
+/*
* G-Link SSR protocol commands
*/
#define GLINK_SSR_DO_CLEANUP 0
diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c
index 7c8c29f6c91d..e7e49d972d36 100644
--- a/drivers/rpmsg/qcom_smd.c
+++ b/drivers/rpmsg/qcom_smd.c
@@ -729,7 +729,7 @@ static int qcom_smd_write_fifo(struct qcom_smd_channel *channel,
}
/**
- * qcom_smd_send - write data to smd channel
+ * __qcom_smd_send - write data to smd channel
* @channel: channel handle
* @data: buffer of data to write
* @len: number of bytes to write
--
2.32.0
On 01/05/2022 12:35, Krzysztof Kozlowski wrote:
> Correct kerneldoc warning:
>
> drivers/clk/qcom/clk-alpha-pll.c:1450:
> warning: expecting prototype for clk_lucid_pll_configure(). Prototype was for clk_trion_pll_configure() instead
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
Any comments on entire set?
They are on the lists for more than two weeks and it's getting late to
apply it before merge window.
Best regards,
Krzysztof
Quoting Krzysztof Kozlowski (2022-05-01 03:35:14)
> diff --git a/drivers/firmware/qcom_scm-legacy.c b/drivers/firmware/qcom_scm-legacy.c
> index 1829ba220576..7854af4abc62 100644
> --- a/drivers/firmware/qcom_scm-legacy.c
> +++ b/drivers/firmware/qcom_scm-legacy.c
> @@ -120,6 +120,9 @@ static void __scm_legacy_do(const struct arm_smccc_args *smc,
> /**
> * scm_legacy_call() - Sends a command to the SCM and waits for the command to
> * finish processing.
> + * @dev: device
> + * @desc: descriptor structure containing arguments and return values
> + * @res: results from SMC/HVC call
I think only SMC call is possible so drop HVC to not be confusing.
> *
> * A note on cache maintenance:
> * Note that any buffers that are expected to be accessed by the secure world
Quoting Krzysztof Kozlowski (2022-05-01 03:35:15)
> Correct kerneldoc warnings like:
>
> drivers/remoteproc/qcom_common.c:68:
> warning: expecting prototype for struct minidump_subsystem_toc. Prototype was for struct minidump_subsystem instead
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
Reviewed-by: Stephen Boyd <[email protected]>
Quoting Krzysztof Kozlowski (2022-05-17 09:46:49)
> On 01/05/2022 12:35, Krzysztof Kozlowski wrote:
> > Correct kerneldoc warning:
> >
> > drivers/clk/qcom/clk-alpha-pll.c:1450:
> > warning: expecting prototype for clk_lucid_pll_configure(). Prototype was for clk_trion_pll_configure() instead
> >
> > Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> Any comments on entire set?
Please send a cover letter next time. Also they're simply "qcom" related
but otherwise I'm not sure why they aren't sent to individual subsystem
lists. They don't depend on each other to build, right?
Quoting Krzysztof Kozlowski (2022-05-01 03:35:17)
> The qcom_glink.name is read from DTS but never used further, never
> referenced, so drop it. This also fixes kerneldoc warning:
>
> drivers/rpmsg/qcom_glink_native.c:125:
> warning: Function parameter or member 'name' not described in 'qcom_glink'
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
Reviewed-by: Stephen Boyd <[email protected]>
Hi Krzysztof,
On 5/1/22 13:35, Krzysztof Kozlowski wrote:
> Correct kerneldoc warning:
>
> drivers/clk/qcom/clk-alpha-pll.c:1450:
> warning: expecting prototype for clk_lucid_pll_configure(). Prototype was for clk_trion_pll_configure() instead
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> drivers/clk/qcom/clk-alpha-pll.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/qcom/clk-alpha-pll.c b/drivers/clk/qcom/clk-alpha-pll.c
> index 4406cf609aae..969d98fca5df 100644
> --- a/drivers/clk/qcom/clk-alpha-pll.c
> +++ b/drivers/clk/qcom/clk-alpha-pll.c
> @@ -1439,7 +1439,7 @@ const struct clk_ops clk_alpha_pll_postdiv_fabia_ops = {
> EXPORT_SYMBOL_GPL(clk_alpha_pll_postdiv_fabia_ops);
>
> /**
> - * clk_lucid_pll_configure - configure the lucid pll
> + * clk_trion_pll_configure - configure the lucid pll
> *
> * @pll: clk alpha pll
> * @regmap: register map
this fix is done earlier, unfortunately the inclusion is still pending, in v5 series:
https://lore.kernel.org/linux-clk/[email protected]/
--
Best wishes,
Vladimir
Quoting Krzysztof Kozlowski (2022-05-01 03:35:18)
> Correct kerneldoc warnings like:
>
> drivers/rpmsg/qcom_glink_ssr.c:45:
> warning: expecting prototype for G(). Prototype was for GLINK_SSR_DO_CLEANUP() instead
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
Reviewed-by: Stephen Boyd <[email protected]>
> drivers/rpmsg/qcom_glink_ssr.c | 2 +-
> drivers/rpmsg/qcom_smd.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rpmsg/qcom_glink_ssr.c b/drivers/rpmsg/qcom_glink_ssr.c
> index dea929c6045d..776d64446879 100644
> --- a/drivers/rpmsg/qcom_glink_ssr.c
> +++ b/drivers/rpmsg/qcom_glink_ssr.c
> @@ -39,7 +39,7 @@ struct cleanup_done_msg {
> __le32 seq_num;
> };
>
> -/**
> +/*
> * G-Link SSR protocol commands
> */
> #define GLINK_SSR_DO_CLEANUP 0
> diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c
> index 7c8c29f6c91d..e7e49d972d36 100644
> --- a/drivers/rpmsg/qcom_smd.c
> +++ b/drivers/rpmsg/qcom_smd.c
> @@ -729,7 +729,7 @@ static int qcom_smd_write_fifo(struct qcom_smd_channel *channel,
> }
>
> /**
> - * qcom_smd_send - write data to smd channel
> + * __qcom_smd_send - write data to smd channel
> * @channel: channel handle
> * @data: buffer of data to write
> * @len: number of bytes to write
Not part of this patch but it says "flag to indicate if write has ca
wait" and I wonder what "ca" means.
On 19/05/2022 02:03, Stephen Boyd wrote:
> Quoting Krzysztof Kozlowski (2022-05-01 03:35:14)
>> diff --git a/drivers/firmware/qcom_scm-legacy.c b/drivers/firmware/qcom_scm-legacy.c
>> index 1829ba220576..7854af4abc62 100644
>> --- a/drivers/firmware/qcom_scm-legacy.c
>> +++ b/drivers/firmware/qcom_scm-legacy.c
>> @@ -120,6 +120,9 @@ static void __scm_legacy_do(const struct arm_smccc_args *smc,
>> /**
>> * scm_legacy_call() - Sends a command to the SCM and waits for the command to
>> * finish processing.
>> + * @dev: device
>> + * @desc: descriptor structure containing arguments and return values
>> + * @res: results from SMC/HVC call
>
> I think only SMC call is possible so drop HVC to not be confusing.
Sure.
Best regards,
Krzysztof
Quoting Krzysztof Kozlowski (2022-05-01 03:35:13)
> diff --git a/drivers/clk/qcom/clk-alpha-pll.c b/drivers/clk/qcom/clk-alpha-pll.c
> index 4406cf609aae..969d98fca5df 100644
> --- a/drivers/clk/qcom/clk-alpha-pll.c
> +++ b/drivers/clk/qcom/clk-alpha-pll.c
> @@ -1439,7 +1439,7 @@ const struct clk_ops clk_alpha_pll_postdiv_fabia_ops = {
> EXPORT_SYMBOL_GPL(clk_alpha_pll_postdiv_fabia_ops);
>
> /**
> - * clk_lucid_pll_configure - configure the lucid pll
> + * clk_trion_pll_configure - configure the lucid pll
configure the trion pll?
> *
> * @pll: clk alpha pll
> * @regmap: register map
On 19/05/2022 02:14, Stephen Boyd wrote:
> Quoting Krzysztof Kozlowski (2022-05-17 09:46:49)
>> On 01/05/2022 12:35, Krzysztof Kozlowski wrote:
>>> Correct kerneldoc warning:
>>>
>>> drivers/clk/qcom/clk-alpha-pll.c:1450:
>>> warning: expecting prototype for clk_lucid_pll_configure(). Prototype was for clk_trion_pll_configure() instead
>>>
>>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>>
>> Any comments on entire set?
>
> Please send a cover letter next time. Also they're simply "qcom" related
> but otherwise I'm not sure why they aren't sent to individual subsystem
> lists. They don't depend on each other to build, right?
Indeed, they can go via separate subsystems. I'll split the series in v2.
Best regards,
Krzysztof
On 19/05/2022 06:30, Vladimir Zapolskiy wrote:
> Hi Krzysztof,
>
> On 5/1/22 13:35, Krzysztof Kozlowski wrote:
>> Correct kerneldoc warning:
>>
>> drivers/clk/qcom/clk-alpha-pll.c:1450:
>> warning: expecting prototype for clk_lucid_pll_configure(). Prototype was for clk_trion_pll_configure() instead
>>
>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>> ---
>> drivers/clk/qcom/clk-alpha-pll.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/clk/qcom/clk-alpha-pll.c b/drivers/clk/qcom/clk-alpha-pll.c
>> index 4406cf609aae..969d98fca5df 100644
>> --- a/drivers/clk/qcom/clk-alpha-pll.c
>> +++ b/drivers/clk/qcom/clk-alpha-pll.c
>> @@ -1439,7 +1439,7 @@ const struct clk_ops clk_alpha_pll_postdiv_fabia_ops = {
>> EXPORT_SYMBOL_GPL(clk_alpha_pll_postdiv_fabia_ops);
>>
>> /**
>> - * clk_lucid_pll_configure - configure the lucid pll
>> + * clk_trion_pll_configure - configure the lucid pll
>> *
>> * @pll: clk alpha pll
>> * @regmap: register map
>
> this fix is done earlier, unfortunately the inclusion is still pending, in v5 series:
>
> https://lore.kernel.org/linux-clk/[email protected]/
>
I'll skip this one.
Best regards,
Krzysztof
On 19/05/2022 02:02, Stephen Boyd wrote:
> Quoting Krzysztof Kozlowski (2022-05-01 03:35:13)
>> diff --git a/drivers/clk/qcom/clk-alpha-pll.c b/drivers/clk/qcom/clk-alpha-pll.c
>> index 4406cf609aae..969d98fca5df 100644
>> --- a/drivers/clk/qcom/clk-alpha-pll.c
>> +++ b/drivers/clk/qcom/clk-alpha-pll.c
>> @@ -1439,7 +1439,7 @@ const struct clk_ops clk_alpha_pll_postdiv_fabia_ops = {
>> EXPORT_SYMBOL_GPL(clk_alpha_pll_postdiv_fabia_ops);
>>
>> /**
>> - * clk_lucid_pll_configure - configure the lucid pll
>> + * clk_trion_pll_configure - configure the lucid pll
>
> configure the trion pll?
Ah, copy paste :/
Best regards,
Krzysztof
On Sun, 1 May 2022 12:35:16 +0200, Krzysztof Kozlowski wrote:
> The use of strncpy() is considered deprecated for NUL-terminated
> strings[1]. Replace strncpy() with strscpy_pad(), to keep existing
> pad-behavior of strncpy, similarly to commit 08de420a8014 ("rpmsg:
> glink: Replace strncpy() with strscpy_pad()"). This fixes W=1 warning:
>
> In function ‘qcom_glink_rx_close’,
> inlined from ‘qcom_glink_work’ at ../drivers/rpmsg/qcom_glink_native.c:1638:4:
> drivers/rpmsg/qcom_glink_native.c:1549:17: warning: ‘strncpy’ specified bound 32 equals destination size [-Wstringop-truncation]
> 1549 | strncpy(chinfo.name, channel->name, sizeof(chinfo.name));
>
> [...]
Applied, thanks!
[4/8] rpmsg: qcom: glink: replace strncpy() with strscpy_pad()
commit: 766279a8f85df32345dbda03b102ca1ee3d5ddea
Best regards,
--
Bjorn Andersson <[email protected]>