2023-03-17 19:15:05

by Tom Rix

[permalink] [raw]
Subject: [PATCH] leds: flash: set varaiables mvflash_3,4ch_regs storage-class-specifier to static

smatch reports
drivers/leds/flash/leds-qcom-flash.c:103:18: warning:
symbol 'mvflash_3ch_regs' was not declared. Should it be static?
drivers/leds/flash/leds-qcom-flash.c:115:18: warning:
symbol 'mvflash_4ch_regs' was not declared. Should it be static?

These variables are only used in leds-qcom-flash.c,
so it should be static.

Signed-off-by: Tom Rix <[email protected]>
---
drivers/leds/flash/leds-qcom-flash.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/leds/flash/leds-qcom-flash.c b/drivers/leds/flash/leds-qcom-flash.c
index 406ed8761c78..90a24fa25a49 100644
--- a/drivers/leds/flash/leds-qcom-flash.c
+++ b/drivers/leds/flash/leds-qcom-flash.c
@@ -100,7 +100,7 @@ enum {
REG_MAX_COUNT,
};

-struct reg_field mvflash_3ch_regs[REG_MAX_COUNT] = {
+static struct reg_field mvflash_3ch_regs[REG_MAX_COUNT] = {
REG_FIELD(0x08, 0, 7), /* status1 */
REG_FIELD(0x09, 0, 7), /* status2 */
REG_FIELD(0x0a, 0, 7), /* status3 */
@@ -112,7 +112,7 @@ struct reg_field mvflash_3ch_regs[REG_MAX_COUNT] = {
REG_FIELD(0x4c, 0, 2), /* chan_en */
};

-struct reg_field mvflash_4ch_regs[REG_MAX_COUNT] = {
+static struct reg_field mvflash_4ch_regs[REG_MAX_COUNT] = {
REG_FIELD(0x06, 0, 7), /* status1 */
REG_FIELD(0x07, 0, 6), /* status2 */
REG_FIELD(0x09, 0, 7), /* status3 */
--
2.27.0



2023-03-23 19:58:46

by Pavel Machek

[permalink] [raw]
Subject: Re: [PATCH] leds: flash: set varaiables mvflash_3,4ch_regs storage-class-specifier to static

On Fri 2023-03-17 15:13:41, Tom Rix wrote:
> smatch reports
> drivers/leds/flash/leds-qcom-flash.c:103:18: warning:
> symbol 'mvflash_3ch_regs' was not declared. Should it be static?
> drivers/leds/flash/leds-qcom-flash.c:115:18: warning:
> symbol 'mvflash_4ch_regs' was not declared. Should it be static?
>
> These variables are only used in leds-qcom-flash.c,
> so it should be static.
>
> Signed-off-by: Tom Rix <[email protected]>

Acked-by: Pavel Machek <[email protected]>

BR,
Pavel

--
People of Russia, stop Putin before his war on Ukraine escalates.

Attachments:
(No filename) (595.00 B)
 signature.asc (201.00 B)
 Download all attachments

2023-03-30 13:02:53

by Lee Jones

[permalink] [raw]
Subject: Re: [PATCH] leds: flash: set varaiables mvflash_3,4ch_regs storage-class-specifier to static

On Fri, 17 Mar 2023, Tom Rix wrote:

> smatch reports
> drivers/leds/flash/leds-qcom-flash.c:103:18: warning:
> symbol 'mvflash_3ch_regs' was not declared. Should it be static?
> drivers/leds/flash/leds-qcom-flash.c:115:18: warning:
> symbol 'mvflash_4ch_regs' was not declared. Should it be static?
>
> These variables are only used in leds-qcom-flash.c,
> so it should be static.
>
> Signed-off-by: Tom Rix <[email protected]>
> ---
> drivers/leds/flash/leds-qcom-flash.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

I fixed-up some spelling / formatting issues and ...

Applied, thanks

--
Lee Jones [李琼斯]