[permalink] [raw]

* Peng Zhang <[email protected]> [230428 02:48]:
>
>
> 在 2023/4/25 22:09, Liam R. Howlett 写道:
> > Sometimes, during a tree walk, the user needs the next slot regardless
> > of if it is empty or not. Add an interface to get the next slot.
> >
> > Since there are no consecutive NULLs allowed in the tree, the mas_next()
> > function can only advance two slots at most. So use the new
> > mas_next_slot() interface to align both implementations.
> >
> > Signed-off-by: Liam R. Howlett <[email protected]>
> > ---
> > lib/maple_tree.c | 178 +++++++++++++++++++----------------------------
> > 1 file changed, 71 insertions(+), 107 deletions(-)
> >
> > diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> > index 31cbfd7b44728..fe6c9da6f2bd5 100644
> > --- a/lib/maple_tree.c
> > +++ b/lib/maple_tree.c
> > @@ -4619,15 +4619,16 @@ static inline int mas_next_node(struct ma_state *mas, struct maple_node *node,
> > if (mas->max >= max)
> > goto no_entry;
> > + min = mas->max + 1;
> > + if (min > max)
> > + goto no_entry;
> Unnecessary check due to mas->max < max.

Thanks, I will address this in v2.

> > +
> > level = 0;
> > do {
> > if (ma_is_root(node))
> > goto no_entry;
> > - min = mas->max + 1;
> > - if (min > max)
> > - goto no_entry;
> > -
> > + /* Walk up. */
> > if (unlikely(mas_ascend(mas)))
> > return 1;
> > @@ -4645,13 +4646,12 @@ static inline int mas_next_node(struct ma_state *mas, struct maple_node *node,
> > slots = ma_slots(node, mt);
> > pivot = mas_safe_pivot(mas, pivots, ++offset, mt);
> > while (unlikely(level > 1)) {
> > - /* Descend, if necessary */
> > + level--;
> > enode = mas_slot(mas, slots, offset);
> > if (unlikely(ma_dead_node(node)))
> > return 1;
> > mas->node = enode;
> > - level--;
> > node = mas_mn(mas);
> > mt = mte_node_type(mas->node);
> > slots = ma_slots(node, mt);
> > @@ -4680,85 +4680,84 @@ static inline int mas_next_node(struct ma_state *mas, struct maple_node *node,
> > return 0;
> > }
> > +static inline void mas_rewalk(struct ma_state *mas, unsigned long index)
> > +{
> > +retry:
> > + mas_set(mas, index);
> > + mas_state_walk(mas);
> > + if (mas_is_start(mas))
> > + goto retry;
> > +}
> > +
> > +static inline bool mas_rewalk_if_dead(struct ma_state *mas,
> > + struct maple_node *node, const unsigned long index)
> > +{
> > + if (unlikely(ma_dead_node(node))) {
> > + mas_rewalk(mas, index);
> > + return true;
> > + }
> > + return false;
> > +}
> > +
> > /*
> > - * mas_next_nentry() - Get the next node entry
> > - * @mas: The maple state
> > - * @max: The maximum value to check
> > - * @*range_start: Pointer to store the start of the range.
> > + * mas_next_slot() - Get the entry in the next slot
> > *
> > - * Sets @mas->offset to the offset of the next node entry, @mas->last to the
> > - * pivot of the entry.
> > + * @mas: The maple state
> > + * @max: The maximum starting range
> > *
> > - * Return: The next entry, %NULL otherwise
> > + * Return: The entry in the next slot which is possibly NULL
> > */
> > -static inline void *mas_next_nentry(struct ma_state *mas,
> > - struct maple_node *node, unsigned long max, enum maple_type type)
> > +void *mas_next_slot(struct ma_state *mas, unsigned long max)
> > {
> > - unsigned char count;
> > - unsigned long pivot;
> > - unsigned long *pivots;
> > void __rcu **slots;
> > + unsigned long *pivots;
> > + unsigned long pivot;
> > + enum maple_type type;
> > + struct maple_node *node;
> > + unsigned char data_end;
> > + unsigned long save_point = mas->last;
> > void *entry;
> > - if (mas->last == mas->max) {
> > - mas->index = mas->max;
> > - return NULL;
> > - }
> > -
> > - slots = ma_slots(node, type);
> > +retry:
> > + node = mas_mn(mas);
> > + type = mte_node_type(mas->node);
> > pivots = ma_pivots(node, type);
> > - count = ma_data_end(node, type, pivots, mas->max);
> > - if (unlikely(ma_dead_node(node)))
> > - return NULL;
> > -
> > - mas->index = mas_safe_min(mas, pivots, mas->offset);
> > - if (unlikely(ma_dead_node(node)))
> > - return NULL;
> > -
> > - if (mas->index > max)
> > - return NULL;
> > + data_end = ma_data_end(node, type, pivots, mas->max);
> > + pivot = mas_logical_pivot(mas, pivots, mas->offset, type);
> > + if (unlikely(mas_rewalk_if_dead(mas, node, save_point)))
> > + goto retry;
> > - if (mas->offset > count)
> > + if (pivot >= max)
> > return NULL;
> > - while (mas->offset < count) {
> > - pivot = pivots[mas->offset];
> > - entry = mas_slot(mas, slots, mas->offset);
> > - if (ma_dead_node(node))
> > - return NULL;
> > -
> > - mas->last = pivot;
> > - if (entry)
> > - return entry;
> > -
> > - if (pivot >= max)
> > - return NULL;
> > + if (likely(data_end > mas->offset)) {
> > + mas->offset++;
> > + mas->index = mas->last + 1;
> > + } else {
> > + if (mas_next_node(mas, node, max)) {
> > + mas_rewalk(mas, save_point);
> > + goto retry;
> > + }
> > - if (pivot >= mas->max)
> > + if (mas_is_none(mas))
> > return NULL;
> > - mas->index = pivot + 1;
> > - mas->offset++;
> > + mas->offset = 0;
> > + mas->index = mas->min;
> > + node = mas_mn(mas);
> > + type = mte_node_type(mas->node);
> > + pivots = ma_pivots(node, type);
> > }
> > - pivot = mas_logical_pivot(mas, pivots, mas->offset, type);
> > + slots = ma_slots(node, type);
> > + mas->last = mas_logical_pivot(mas, pivots, mas->offset, type);
> > entry = mas_slot(mas, slots, mas->offset);
> > - if (ma_dead_node(node))
> > - return NULL;
> > + if (unlikely(mas_rewalk_if_dead(mas, node, save_point)))
> > + goto retry;
> > - mas->last = pivot;
> > return entry;
> > }
> > -static inline void mas_rewalk(struct ma_state *mas, unsigned long index)
> > -{
> > -retry:
> > - mas_set(mas, index);
> > - mas_state_walk(mas);
> > - if (mas_is_start(mas))
> > - goto retry;
> > -}
> > -
> > /*
> > * mas_next_entry() - Internal function to get the next entry.
> > * @mas: The maple state
> > @@ -4774,47 +4773,18 @@ static inline void mas_rewalk(struct ma_state *mas, unsigned long index)
> > static inline void *mas_next_entry(struct ma_state *mas, unsigned long limit)
> > {
> > void *entry = NULL;
> > - struct maple_node *node;
> > - unsigned long last;
> > - enum maple_type mt;
> > if (mas->last >= limit)
> > return NULL;
> > - last = mas->last;
> > -retry:
> > - node = mas_mn(mas);
> > - mt = mte_node_type(mas->node);
> > - mas->offset++;
> > - if (unlikely(mas->offset >= mt_slots[mt])) {
> > - mas->offset = mt_slots[mt] - 1;
> > - goto next_node;
> > - }
> > -
> > - while (!mas_is_none(mas)) {
> > - entry = mas_next_nentry(mas, node, limit, mt);
> > - if (unlikely(ma_dead_node(node))) {
> > - mas_rewalk(mas, last);
> > - goto retry;
> > - }
> > -
> > - if (likely(entry))
> > - return entry;
> > -
> > - if (unlikely((mas->last >= limit)))
> > - return NULL;
> > + entry = mas_next_slot_limit(mas, limit);
> > + if (entry)
> > + return entry;
> > -next_node:
> > - if (unlikely(mas_next_node(mas, node, limit))) {
> > - mas_rewalk(mas, last);
> > - goto retry;
> > - }
> > - mas->offset = 0;
> > - node = mas_mn(mas);
> > - mt = mte_node_type(mas->node);
> > - }
> > + if (mas_is_none(mas))
> > + return NULL;
> > - return NULL;
> > + return mas_next_slot_limit(mas, limit);
> > }
> > /*
> > @@ -4845,10 +4815,8 @@ static inline void *mas_prev_nentry(struct ma_state *mas, unsigned long limit,
> > slots = ma_slots(mn, mt);
> > pivots = ma_pivots(mn, mt);
> > count = ma_data_end(mn, mt, pivots, mas->max);
> > - if (unlikely(ma_dead_node(mn))) {
> > - mas_rewalk(mas, index);
> > + if (unlikely(mas_rewalk_if_dead(mas, mn, index)))
> > goto retry;
> > - }
> > offset = mas->offset - 1;
> > if (offset >= mt_slots[mt])
> > @@ -4861,10 +4829,8 @@ static inline void *mas_prev_nentry(struct ma_state *mas, unsigned long limit,
> > pivot = pivots[offset];
> > }
> > - if (unlikely(ma_dead_node(mn))) {
> > - mas_rewalk(mas, index);
> > + if (unlikely(mas_rewalk_if_dead(mas, mn, index)))
> > goto retry;
> > - }
> > while (offset && !mas_slot(mas, slots, offset)) {
> > pivot = pivots[--offset];
> > @@ -4881,10 +4847,8 @@ static inline void *mas_prev_nentry(struct ma_state *mas, unsigned long limit,
> > min = mas_safe_min(mas, pivots, offset);
> > entry = mas_slot(mas, slots, offset);
> > - if (unlikely(ma_dead_node(mn))) {
> > - mas_rewalk(mas, index);
> > + if (unlikely(mas_rewalk_if_dead(mas, mn, index)))
> > goto retry;
> > - }
> > mas->offset = offset;
> > mas->last = pivot;

2023-05-04 03:14:42

* kernel test robot <[email protected]> [230425 21:42]:
> Hi Liam,
>
> kernel test robot noticed the following build errors:
>
> [auto build test ERROR on akpm-mm/mm-everything]
> [also build test ERROR on linus/master v6.3 next-20230425]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Liam-R-Howlett/maple_tree-Fix-static-analyser-cppcheck-issue/20230425-233958
> base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
> patch link: https://lore.kernel.org/r/20230425140955.3834476-34-Liam.Howlett%40oracle.com
> patch subject: [PATCH 33/34] maple_tree: Add testing for mas_{prev,next}_range()
> config: hexagon-randconfig-r045-20230424 (https://download.01.org/0day-ci/archive/20230426/[email protected]/config)
> compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project 437b7602e4a998220871de78afcb020b9c14a661)
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://github.com/intel-lab-lkp/linux/commit/571139f33a7ede9db66c7892c40e88ed66a32bc5
> git remote add linux-review https://github.com/intel-lab-lkp/linux
> git fetch --no-tags linux-review Liam-R-Howlett/maple_tree-Fix-static-analyser-cppcheck-issue/20230425-233958
> git checkout 571139f33a7ede9db66c7892c40e88ed66a32bc5
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon olddefconfig
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash
>
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <[email protected]>
> | Link: https://lore.kernel.org/oe-kbuild-all/[email protected]/

Thanks. This will be fixed in v2.

>
> All errors (new ones prefixed by >>):
>
> >> lib/test_maple_tree.c:3437:17: error: call to undeclared function 'mas_find_range'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
> void *entry = mas_find_range(&mas, ULONG_MAX);
> ^
> >> lib/test_maple_tree.c:3437:9: error: incompatible integer to pointer conversion initializing 'void *' with an expression of type 'int' [-Wint-conversion]
> void *entry = mas_find_range(&mas, ULONG_MAX);
> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> lib/test_maple_tree.c:3443:2: error: call to undeclared function 'mas_find_range'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
> mas_contiguous(&mas, test, ULONG_MAX) {
> ^
> include/linux/maple_tree.h:545:22: note: expanded from macro 'mas_contiguous'
> while (((__entry) = mas_find_range((__mas), (__max))) != NULL)
> ^
> >> lib/test_maple_tree.c:3443:2: error: incompatible integer to pointer conversion assigning to 'void *' from 'int' [-Wint-conversion]
> mas_contiguous(&mas, test, ULONG_MAX) {
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/linux/maple_tree.h:545:20: note: expanded from macro 'mas_contiguous'
> while (((__entry) = mas_find_range((__mas), (__max))) != NULL)
> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> lib/test_maple_tree.c:3453:2: error: incompatible integer to pointer conversion assigning to 'void *' from 'int' [-Wint-conversion]
> mas_contiguous(&mas, test, ULONG_MAX) {
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/linux/maple_tree.h:545:20: note: expanded from macro 'mas_contiguous'
> while (((__entry) = mas_find_range((__mas), (__max))) != NULL)
> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> lib/test_maple_tree.c:3464:2: error: incompatible integer to pointer conversion assigning to 'void *' from 'int' [-Wint-conversion]
> mas_contiguous(&mas, test, 340) {
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/linux/maple_tree.h:545:20: note: expanded from macro 'mas_contiguous'
> while (((__entry) = mas_find_range((__mas), (__max))) != NULL)
> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> lib/test_maple_tree.c:3476:7: error: incompatible integer to pointer conversion assigning to 'void *' from 'int' [-Wint-conversion]
> test = mas_find_range(&mas, ULONG_MAX);
> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >> lib/test_maple_tree.c:3482:9: error: call to undeclared function 'mas_find_range_rev'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
> test = mas_find_range_rev(&mas, 0);
> ^
> lib/test_maple_tree.c:3482:7: error: incompatible integer to pointer conversion assigning to 'void *' from 'int' [-Wint-conversion]
> test = mas_find_range_rev(&mas, 0);
> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
> lib/test_maple_tree.c:3487:7: error: incompatible integer to pointer conversion assigning to 'void *' from 'int' [-Wint-conversion]
> test = mas_find_range_rev(&mas, 0);
> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
> lib/test_maple_tree.c:3493:7: error: incompatible integer to pointer conversion assigning to 'void *' from 'int' [-Wint-conversion]
> test = mas_find_range_rev(&mas, 340);
> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 11 errors generated.
>
>
> vim +/mas_find_range +3437 lib/test_maple_tree.c
>
> 3358
> 3359 static noinline void __init check_slot_iterators(struct maple_tree *mt)
> 3360 {
> 3361 MA_STATE(mas, mt, 0, 0);
> 3362 unsigned long i, index = 40;
> 3363 unsigned char offset = 0;
> 3364 void *test;
> 3365
> 3366 mt_set_non_kernel(99999);
> 3367
> 3368 mas_lock(&mas);
> 3369 for (i = 0; i <= index; i++) {
> 3370 unsigned long end = 5;
> 3371 if (i > 20 && i < 35)
> 3372 end = 9;
> 3373 mas_set_range(&mas, i*10, i*10 + end);
> 3374 mas_store_gfp(&mas, xa_mk_value(i), GFP_KERNEL);
> 3375 }
> 3376
> 3377 i = 21;
> 3378 mas_set(&mas, i*10);
> 3379 MAS_BUG_ON(&mas, mas_walk(&mas) != xa_mk_value(i));
> 3380 MAS_BUG_ON(&mas, mas_prev_range(&mas, 0) != NULL);
> 3381 MAS_BUG_ON(&mas, mas.index != 206);
> 3382 MAS_BUG_ON(&mas, mas.last != 209);
> 3383
> 3384 i--;
> 3385 MAS_BUG_ON(&mas, mas_prev_range(&mas, 0) != xa_mk_value(i));
> 3386 MAS_BUG_ON(&mas, mas.index != 200);
> 3387 MAS_BUG_ON(&mas, mas.last != 205);
> 3388
> 3389 i = 25;
> 3390 mas_set(&mas, i*10);
> 3391 MAS_BUG_ON(&mas, mas_walk(&mas) != xa_mk_value(i));
> 3392 MAS_BUG_ON(&mas, mas.offset != 0);
> 3393
> 3394 /* Previous range is in another node */
> 3395 i--;
> 3396 MAS_BUG_ON(&mas, mas_prev_range(&mas, 0) != xa_mk_value(i));
> 3397 MAS_BUG_ON(&mas, mas.index != 240);
> 3398 MAS_BUG_ON(&mas, mas.last != 249);
> 3399
> 3400 /* Shift back with mas_next */
> 3401 i++;
> 3402 MAS_BUG_ON(&mas, mas_next_range(&mas, ULONG_MAX) != xa_mk_value(i));
> 3403 MAS_BUG_ON(&mas, mas.index != 250);
> 3404 MAS_BUG_ON(&mas, mas.last != 259);
> 3405
> 3406 i = 33;
> 3407 mas_set(&mas, i*10);
> 3408 MAS_BUG_ON(&mas, mas_walk(&mas) != xa_mk_value(i));
> 3409 MAS_BUG_ON(&mas, mas.index != 330);
> 3410 MAS_BUG_ON(&mas, mas.last != 339);
> 3411
> 3412 /* Next range is in another node */
> 3413 i++;
> 3414 MAS_BUG_ON(&mas, mas_next_range(&mas, ULONG_MAX) != xa_mk_value(i));
> 3415 MAS_BUG_ON(&mas, mas.offset != 0);
> 3416 MAS_BUG_ON(&mas, mas.index != 340);
> 3417 MAS_BUG_ON(&mas, mas.last != 349);
> 3418
> 3419 /* Next out of range */
> 3420 i++;
> 3421 MAS_BUG_ON(&mas, mas_next_range(&mas, i*10 - 1) != NULL);
> 3422 /* maple state does not move */
> 3423 MAS_BUG_ON(&mas, mas.offset != 0);
> 3424 MAS_BUG_ON(&mas, mas.index != 340);
> 3425 MAS_BUG_ON(&mas, mas.last != 349);
> 3426
> 3427 /* Prev out of range */
> 3428 i--;
> 3429 MAS_BUG_ON(&mas, mas_prev_range(&mas, i*10 + 1) != NULL);
> 3430 /* maple state does not move */
> 3431 MAS_BUG_ON(&mas, mas.offset != 0);
> 3432 MAS_BUG_ON(&mas, mas.index != 340);
> 3433 MAS_BUG_ON(&mas, mas.last != 349);
> 3434
> 3435 mas_set(&mas, 210);
> 3436 for (i = 210; i<= 350; i += 10) {
> > 3437 void *entry = mas_find_range(&mas, ULONG_MAX);
> 3438
> 3439 MAS_BUG_ON(&mas, entry != xa_mk_value(i/10));
> 3440 }
> 3441
> 3442 mas_set(&mas, 0);
> > 3443 mas_contiguous(&mas, test, ULONG_MAX) {
> 3444 MAS_BUG_ON(&mas, test != xa_mk_value(0));
> 3445 MAS_BUG_ON(&mas, mas.index != 0);
> 3446 MAS_BUG_ON(&mas, mas.last != 5);
> 3447 }
> 3448 MAS_BUG_ON(&mas, test != NULL);
> 3449 MAS_BUG_ON(&mas, mas.index != 6);
> 3450 MAS_BUG_ON(&mas, mas.last != 9);
> 3451
> 3452 mas_set(&mas, 6);
> 3453 mas_contiguous(&mas, test, ULONG_MAX) {
> 3454 MAS_BUG_ON(&mas, test != xa_mk_value(1));
> 3455 MAS_BUG_ON(&mas, mas.index != 10);
> 3456 MAS_BUG_ON(&mas, mas.last != 15);
> 3457 }
> 3458 MAS_BUG_ON(&mas, test != NULL);
> 3459 MAS_BUG_ON(&mas, mas.index != 16);
> 3460 MAS_BUG_ON(&mas, mas.last != 19);
> 3461
> 3462 i = 210;
> 3463 mas_set(&mas, i);
> 3464 mas_contiguous(&mas, test, 340) {
> 3465 MAS_BUG_ON(&mas, test != xa_mk_value(i/10));
> 3466 MAS_BUG_ON(&mas, mas.index != i);
> 3467 MAS_BUG_ON(&mas, mas.last != i+9);
> 3468 i+=10;
> 3469 offset = mas.offset;
> 3470 }
> 3471 /* Hit the limit, iterator is at the limit. */
> 3472 MAS_BUG_ON(&mas, offset != mas.offset);
> 3473 MAS_BUG_ON(&mas, test != NULL);
> 3474 MAS_BUG_ON(&mas, mas.index != 340);
> 3475 MAS_BUG_ON(&mas, mas.last != 349);
> 3476 test = mas_find_range(&mas, ULONG_MAX);
> 3477 MAS_BUG_ON(&mas, test != xa_mk_value(35));
> 3478 MAS_BUG_ON(&mas, mas.index != 350);
> 3479 MAS_BUG_ON(&mas, mas.last != 355);
> 3480
> 3481
> > 3482 test = mas_find_range_rev(&mas, 0);
> 3483 MAS_BUG_ON(&mas, test != xa_mk_value(34));
> 3484 MAS_BUG_ON(&mas, mas.index != 340);
> 3485 MAS_BUG_ON(&mas, mas.last != 349);
> 3486 mas_set(&mas, 345);
> 3487 test = mas_find_range_rev(&mas, 0);
> 3488 MAS_BUG_ON(&mas, test != xa_mk_value(34));
> 3489 MAS_BUG_ON(&mas, mas.index != 340);
> 3490 MAS_BUG_ON(&mas, mas.last != 349);
> 3491
> 3492 offset = mas.offset;
> 3493 test = mas_find_range_rev(&mas, 340);
> 3494 MAS_BUG_ON(&mas, offset != mas.offset);
> 3495 MAS_BUG_ON(&mas, test != NULL);
> 3496 MAS_BUG_ON(&mas, mas.index != 340);
> 3497 MAS_BUG_ON(&mas, mas.last != 349);
> 3498
> 3499 mas_unlock(&mas);
> 3500 mt_set_non_kernel(0);
> 3501 }
> 3502
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests

Subject: [PATCH 00/34] Maple tree mas_{next,prev}_range() and cleanup

Subject: [PATCH 03/34] maple_tree: Avoid unnecessary ascending

Subject: [PATCH 02/34] maple_tree: Clean up mas_parent_enum()

Subject: [PATCH 04/34] maple_tree: Clean up mas_dfs_postorder()

Subject: [PATCH 01/34] maple_tree: Fix static analyser cppcheck issue

Subject: [PATCH 05/34] maple_tree: Add format option to mt_dump()

Subject: [PATCH 06/34] maple_tree: Add debug BUG_ON and WARN_ON variants

Subject: [PATCH 08/34] maple_tree: Change RCU checks to WARN_ON() instead of BUG_ON()

Subject: [PATCH 07/34] maple_tree: Convert BUG_ON() to MT_BUG_ON()

Subject: [PATCH 09/34] maple_tree: Convert debug code to use MT_WARN_ON() and MAS_WARN_ON()

Subject: [PATCH 10/34] maple_tree: Use MAS_BUG_ON() when setting a leaf node as a parent

Subject: [PATCH 11/34] maple_tree: Use MAS_BUG_ON() in mas_set_height()

Subject: [PATCH 12/34] maple_tree: Use MAS_BUG_ON() from mas_topiary_range()

Subject: [PATCH 13/34] maple_tree: Use MAS_WR_BUG_ON() in mas_store_prealloc()

Subject: [PATCH 14/34] maple_tree: Use MAS_BUG_ON() prior to calling mas_meta_gap()

Subject: [PATCH 15/34] maple_tree: Return error on mte_pivots() out of range

Subject: [PATCH 16/34] maple_tree: Make test code work without debug enabled

Subject: [PATCH 18/34] mm: Update vma_iter_store() to use MAS_WARN_ON()

Subject: [PATCH 17/34] mm: Update validate_mm() to use vma iterator

Subject: [PATCH 20/34] maple_tree: Remove unnecessary check from mas_destroy()

Subject: [PATCH 19/34] maple_tree: Add __init and __exit to test module

Subject: [PATCH 22/34] mm/mmap: Change do_vmi_align_munmap() for maple tree iterator changes

Subject: [PATCH 21/34] maple_tree: mas_start() reset depth on dead node

Subject: [PATCH 25/34] maple_tree: Clear up index and last setting in single entry tree

Subject: [PATCH 31/34] maple_tree: Add mas_next_range() and mas_find_range() interfaces

Subject: [PATCH 30/34] maple_tree: Fix comments for mas_next_entry() and mas_prev_entry()

Subject: [PATCH 32/34] maple_tree: Add mas_prev_range() and mas_find_range_rev interface

Subject: [PATCH 26/34] maple_tree: Update testing code for mas_{next,prev,walk}

Subject: [PATCH 24/34] maple_tree: Try harder to keep active node with mas_prev()

Subject: [PATCH 28/34] maple_tree: Revise limit checks in mas_empty_area{_rev}()

Subject: [PATCH 23/34] maple_tree: Try harder to keep active node after mas_next()

Subject: [PATCH 27/34] maple_tree: Introduce mas_next_slot() interface

Subject: [PATCH 29/34] maple_tree: Introduce mas_prev_slot() interface

Subject: Re: [PATCH 02/34] maple_tree: Clean up mas_parent_enum()

Subject: [PATCH 33/34] maple_tree: Add testing for mas_{prev,next}_range()

Subject: [PATCH 34/34] mm: Add vma_iter_{next,prev}_range() to vma iterator

Subject: Re: [PATCH 27/34] maple_tree: Introduce mas_next_slot() interface

Subject: Re: [PATCH 33/34] maple_tree: Add testing for mas_{prev,next}_range()

Subject: Re: [PATCH 16/34] maple_tree: Make test code work without debug enabled

Subject: Re: [PATCH 01/34] maple_tree: Fix static analyser cppcheck issue

Subject: Re: [PATCH 02/34] maple_tree: Clean up mas_parent_enum()

Subject: Re: [PATCH 03/34] maple_tree: Avoid unnecessary ascending

Subject: Re: [PATCH 15/34] maple_tree: Return error on mte_pivots() out of range

Subject: Re: [PATCH 20/34] maple_tree: Remove unnecessary check from mas_destroy()

Subject: Re: [PATCH 27/34] maple_tree: Introduce mas_next_slot() interface

Subject: Re: [PATCH 02/34] maple_tree: Clean up mas_parent_enum()

Subject: Re: [PATCH 18/34] mm: Update vma_iter_store() to use MAS_WARN_ON()

Subject: Re: [PATCH 18/34] mm: Update vma_iter_store() to use MAS_WARN_ON()

Subject: Re: [PATCH 25/34] maple_tree: Clear up index and last setting in single entry tree

Subject: Re: [PATCH 25/34] maple_tree: Clear up index and last setting in single entry tree

Subject: Re: [PATCH 21/34] maple_tree: mas_start() reset depth on dead node

Subject: Re: [PATCH 27/34] maple_tree: Introduce mas_next_slot() interface

Subject: Re: [PATCH 28/34] maple_tree: Revise limit checks in mas_empty_area{_rev}()

Subject: Re: [PATCH 29/34] maple_tree: Introduce mas_prev_slot() interface

Subject: Re: [PATCH 27/34] maple_tree: Introduce mas_next_slot() interface

Subject: Re: [PATCH 10/34] maple_tree: Use MAS_BUG_ON() when setting a leaf node as a parent

Subject: Re: [PATCH 11/34] maple_tree: Use MAS_BUG_ON() in mas_set_height()

Subject: Re: [PATCH 10/34] maple_tree: Use MAS_BUG_ON() when setting a leaf node as a parent

Subject: Re: [PATCH 29/34] maple_tree: Introduce mas_prev_slot() interface

Subject: Re: [PATCH 11/34] maple_tree: Use MAS_BUG_ON() in mas_set_height()

Subject: Re: [PATCH 27/34] maple_tree: Introduce mas_next_slot() interface

Subject: Re: [PATCH 23/34] maple_tree: Try harder to keep active node after mas_next()

Attachments:

Subject: Re: [PATCH 26/34] maple_tree: Update testing code for mas_{next,prev,walk}

Subject: Re: [PATCH 26/34] maple_tree: Update testing code for mas_{next,prev,walk}

Subject: Re: [PATCH 33/34] maple_tree: Add testing for mas_{prev,next}_range()

Subject: [PATCH 19/34] maple_tree: Add init and exit to test module