smatch reports
sound/pci/emu10k1/emumixer.c:519:39: warning: symbol
'emu1010_routing_info' was not declared. Should it be static?
sound/pci/emu10k1/emumixer.c:859:36: warning: symbol
'emu1010_pads_info' was not declared. Should it be static?
These variables are only used in their defining file, so it should be static
Signed-off-by: Tom Rix <[email protected]>
---
sound/pci/emu10k1/emumixer.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/pci/emu10k1/emumixer.c b/sound/pci/emu10k1/emumixer.c
index 3a7f25f81504..26ed7e2fe053 100644
--- a/sound/pci/emu10k1/emumixer.c
+++ b/sound/pci/emu10k1/emumixer.c
@@ -516,7 +516,7 @@ struct snd_emu1010_routing_info {
unsigned n_ins;
};
-const struct snd_emu1010_routing_info emu1010_routing_info[] = {
+static const struct snd_emu1010_routing_info emu1010_routing_info[] = {
{
/* rev1 1010 */
.src_regs = emu1010_src_regs,
@@ -856,7 +856,7 @@ struct snd_emu1010_pads_info {
unsigned n_adc_ctls, n_dac_ctls;
};
-const struct snd_emu1010_pads_info emu1010_pads_info[] = {
+static const struct snd_emu1010_pads_info emu1010_pads_info[] = {
{
/* rev1 1010 */
.adc_ctls = snd_emu1010_adc_pads,
--
2.27.0
On Thu, May 18, 2023 at 08:38:26AM -0400, Tom Rix wrote:
>smatch reports
^^^^^^ is this the best word to use here?
>sound/pci/emu10k1/emumixer.c:519:39: warning: symbol
> 'emu1010_routing_info' was not declared. Should it be static?
>sound/pci/emu10k1/emumixer.c:859:36: warning: symbol
> 'emu1010_pads_info' was not declared. Should it be static?
>
>These variables are only used in their defining file, so it should be static
^^ they
>
>Signed-off-by: Tom Rix <[email protected]>
>
Reviewed-by: Oswald Buddenhagen <[email protected]>
(also amending one of the still pending patches. thanks!)
regards
On 5/18/23 6:58 AM, Oswald Buddenhagen wrote:
> On Thu, May 18, 2023 at 08:38:26AM -0400, Tom Rix wrote:
>> smatch reports
> ^^^^^^ is this the best word to use here?
I have been running smatch against the whole tree for a while, using
this preamble.
Many fixes later, for the most part the tree has been cleaned of this
class of problems.
Tom
>
>> sound/pci/emu10k1/emumixer.c:519:39: warning: symbol
>> 'emu1010_routing_info' was not declared. Should it be static?
>> sound/pci/emu10k1/emumixer.c:859:36: warning: symbol
>> 'emu1010_pads_info' was not declared. Should it be static?
>>
>> These variables are only used in their defining file, so it should be
>> static
> ^^ they
>>
>> Signed-off-by: Tom Rix <[email protected]>
>>
> Reviewed-by: Oswald Buddenhagen <[email protected]>
>
> (also amending one of the still pending patches. thanks!)
>
> regards
>
On Thu, 18 May 2023 15:58:51 +0200,
Oswald Buddenhagen wrote:
>
> On Thu, May 18, 2023 at 08:38:26AM -0400, Tom Rix wrote:
> > smatch reports
> ^^^^^^ is this the best word to use here?
Note that smatch is a name of a static analysis tool :)
> > sound/pci/emu10k1/emumixer.c:519:39: warning: symbol
> > 'emu1010_routing_info' was not declared. Should it be static?
> > sound/pci/emu10k1/emumixer.c:859:36: warning: symbol
> > 'emu1010_pads_info' was not declared. Should it be static?
> >
> > These variables are only used in their defining file, so it should be static
> ^^ they
> >
> > Signed-off-by: Tom Rix <[email protected]>
> >
> Reviewed-by: Oswald Buddenhagen <[email protected]>
>
> (also amending one of the still pending patches. thanks!)
Applied the patch now, thanks.
Takashi