The controller id cannot be negative.
Fixes: 84a9582fd203 ("serial: core: Start managing serial controllers to enable runtime PM")
Reported-by: Andy Shevchenko <[email protected]>
Closes: https://lore.kernel.org/linux-serial/[email protected]/#t
Signed-off-by: Tony Lindgren <[email protected]>
---
include/linux/serial_core.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h
--- a/include/linux/serial_core.h
+++ b/include/linux/serial_core.h
@@ -459,7 +459,7 @@ struct uart_port {
struct serial_rs485 *rs485);
int (*iso7816_config)(struct uart_port *,
struct serial_iso7816 *iso7816);
- int ctrl_id; /* optional serial core controller id */
+ unsigned int ctrl_id; /* optional serial core controller id */
unsigned int irq; /* irq number */
unsigned long irqflags; /* irq flags */
unsigned int uartclk; /* base uart clock */
--
2.41.0
On Thu, Jul 20, 2023 at 08:10:14AM +0300, Tony Lindgren wrote:
> The controller id cannot be negative.
>
What does this mean for a changelog?
And you forgot to cc: linux-serial?
And I never got patch 0/3?
something went wrong here...
> Fixes: 84a9582fd203 ("serial: core: Start managing serial controllers to enable runtime PM")
> Reported-by: Andy Shevchenko <[email protected]>
> Closes: https://lore.kernel.org/linux-serial/[email protected]/#t
This isn't a bug report to close, is it?
thanks,
greg k-h
* Greg Kroah-Hartman <[email protected]> [230720 19:33]:
> On Thu, Jul 20, 2023 at 08:10:14AM +0300, Tony Lindgren wrote:
> > The controller id cannot be negative.
> >
>
> What does this mean for a changelog?
Just let's fix it while at it and adding port_id in the following patch.
If you prefer I can squash the change into the fix adding port_id.
> And you forgot to cc: linux-serial?
>
> And I never got patch 0/3?
>
> something went wrong here...
Thanks for letting me know, I'll check what went wrong..
> > Fixes: 84a9582fd203 ("serial: core: Start managing serial controllers to enable runtime PM")
> > Reported-by: Andy Shevchenko <[email protected]>
> > Closes: https://lore.kernel.org/linux-serial/[email protected]/#t
>
> This isn't a bug report to close, is it?
OK will leave it out. I added it as checkpatch.pl now warns if Reported-by
is added without Closes.
Regards,
Tony
On Fri, Jul 21, 2023 at 08:43:26AM +0300, Tony Lindgren wrote:
> * Greg Kroah-Hartman <[email protected]> [230720 19:33]:
> > On Thu, Jul 20, 2023 at 08:10:14AM +0300, Tony Lindgren wrote:
> > > The controller id cannot be negative.
> > >
> >
> > What does this mean for a changelog?
>
> Just let's fix it while at it and adding port_id in the following patch.
> If you prefer I can squash the change into the fix adding port_id.
A separate patch like this is fine, just properly document it please :)
thanks,
greg k-h
* Greg Kroah-Hartman <[email protected]> [230721 06:00]:
> On Fri, Jul 21, 2023 at 08:43:26AM +0300, Tony Lindgren wrote:
> > * Greg Kroah-Hartman <[email protected]> [230720 19:33]:
> > > On Thu, Jul 20, 2023 at 08:10:14AM +0300, Tony Lindgren wrote:
> > > > The controller id cannot be negative.
> > > >
> > >
> > > What does this mean for a changelog?
> >
> > Just let's fix it while at it and adding port_id in the following patch.
> > If you prefer I can squash the change into the fix adding port_id.
>
> A separate patch like this is fine, just properly document it please :)
OK will do.
Looks like linux-serial not getting added is caused by MAINTAINERS
not listing serial_base_bus.c, serial_ctrl.c and serial_port.c. This
causes get_maintainer.pl to not show linux-serial for a patch touching
serial_base_bus.c.. And this will causes git send-email to not pick up
linux-serial.. I'll send a patch for MAINTAINERS file too.
Regards,
Tony
* Tony Lindgren <[email protected]> [230721 06:19]:
> Looks like linux-serial not getting added is caused by MAINTAINERS
> not listing serial_base_bus.c, serial_ctrl.c and serial_port.c. This
> causes get_maintainer.pl to not show linux-serial for a patch touching
> serial_base_bus.c.. And this will causes git send-email to not pick up
> linux-serial.. I'll send a patch for MAINTAINERS file too.
And the TTY LAYER is missing the list entries.. Does something like below
make sense to you guys to include lkml and linux-serial for TTY LAYER?
Regards,
Tony
8< ---------------------
diff --git a/MAINTAINERS b/MAINTAINERS
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -21628,11 +21628,17 @@ F: Documentation/translations/zh_TW/
TTY LAYER
M: Greg Kroah-Hartman <[email protected]>
M: Jiri Slaby <[email protected]>
+L: [email protected]
+L: [email protected]
S: Supported
T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
F: Documentation/driver-api/serial/
F: drivers/tty/
+F: drivers/tty/serial/serial_base.h
+F: drivers/tty/serial/serial_base_bus.c
F: drivers/tty/serial/serial_core.c
+F: drivers/tty/serial/serial_ctrl.c
+F: drivers/tty/serial/serial_port.c
F: include/linux/selection.h
F: include/linux/serial.h
F: include/linux/serial_core.h
--
2.41.0
* Greg Kroah-Hartman <[email protected]> [230721 07:07]:
> On Fri, Jul 21, 2023 at 09:57:01AM +0300, Tony Lindgren wrote:
> > * Tony Lindgren <[email protected]> [230721 06:19]:
> > > Looks like linux-serial not getting added is caused by MAINTAINERS
> > > not listing serial_base_bus.c, serial_ctrl.c and serial_port.c. This
> > > causes get_maintainer.pl to not show linux-serial for a patch touching
> > > serial_base_bus.c.. And this will causes git send-email to not pick up
> > > linux-serial.. I'll send a patch for MAINTAINERS file too.
> >
> > And the TTY LAYER is missing the list entries.. Does something like below
> > make sense to you guys to include lkml and linux-serial for TTY LAYER?
> >
> > Regards,
> >
> > Tony
> >
> > 8< ---------------------
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -21628,11 +21628,17 @@ F: Documentation/translations/zh_TW/
> > TTY LAYER
> > M: Greg Kroah-Hartman <[email protected]>
> > M: Jiri Slaby <[email protected]>
> > +L: [email protected]
> > +L: [email protected]
> > S: Supported
> > T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
> > F: Documentation/driver-api/serial/
> > F: drivers/tty/
> > +F: drivers/tty/serial/serial_base.h
> > +F: drivers/tty/serial/serial_base_bus.c
> > F: drivers/tty/serial/serial_core.c
> > +F: drivers/tty/serial/serial_ctrl.c
> > +F: drivers/tty/serial/serial_port.c
> > F: include/linux/selection.h
> > F: include/linux/serial.h
> > F: include/linux/serial_core.h
> > --
> > 2.41.0
>
> Seems sane to me, I've always wondered why some serial patches didn't
> end up on the linux-serial list.
OK will send. Also I noticed that using git send-email --cc-cover does
not work for the cover letter.. It tries to use the first patch that
is the cover letter or something like that. I'm going back to my custom
email scripts for now rather than try to have git handle things
automagically.
Regards,
Tony
On Fri, Jul 21, 2023 at 09:57:01AM +0300, Tony Lindgren wrote:
> * Tony Lindgren <[email protected]> [230721 06:19]:
> > Looks like linux-serial not getting added is caused by MAINTAINERS
> > not listing serial_base_bus.c, serial_ctrl.c and serial_port.c. This
> > causes get_maintainer.pl to not show linux-serial for a patch touching
> > serial_base_bus.c.. And this will causes git send-email to not pick up
> > linux-serial.. I'll send a patch for MAINTAINERS file too.
>
> And the TTY LAYER is missing the list entries.. Does something like below
> make sense to you guys to include lkml and linux-serial for TTY LAYER?
>
> Regards,
>
> Tony
>
> 8< ---------------------
> diff --git a/MAINTAINERS b/MAINTAINERS
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -21628,11 +21628,17 @@ F: Documentation/translations/zh_TW/
> TTY LAYER
> M: Greg Kroah-Hartman <[email protected]>
> M: Jiri Slaby <[email protected]>
> +L: [email protected]
> +L: [email protected]
> S: Supported
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
> F: Documentation/driver-api/serial/
> F: drivers/tty/
> +F: drivers/tty/serial/serial_base.h
> +F: drivers/tty/serial/serial_base_bus.c
> F: drivers/tty/serial/serial_core.c
> +F: drivers/tty/serial/serial_ctrl.c
> +F: drivers/tty/serial/serial_port.c
> F: include/linux/selection.h
> F: include/linux/serial.h
> F: include/linux/serial_core.h
> --
> 2.41.0
Seems sane to me, I've always wondered why some serial patches didn't
end up on the linux-serial list.
thanks,
greg k-h
On Fri, Jul 21, 2023 at 10:17:53AM +0300, Tony Lindgren wrote:
> * Greg Kroah-Hartman <[email protected]> [230721 07:07]:
...
> Also I noticed that using git send-email --cc-cover does
> not work for the cover letter.. It tries to use the first patch that
> is the cover letter or something like that. I'm going back to my custom
> email scripts for now rather than try to have git handle things
> automagically.
I have my script [1] that shows good enough results to send patches.
I suggest give it a try :-)
[1]: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh
--
With Best Regards,
Andy Shevchenko
* Andy Shevchenko <[email protected]> [230721 10:10]:
> On Fri, Jul 21, 2023 at 10:17:53AM +0300, Tony Lindgren wrote:
> > * Greg Kroah-Hartman <[email protected]> [230721 07:07]:
>
> ...
>
> > Also I noticed that using git send-email --cc-cover does
> > not work for the cover letter.. It tries to use the first patch that
> > is the cover letter or something like that. I'm going back to my custom
> > email scripts for now rather than try to have git handle things
> > automagically.
>
> I have my script [1] that shows good enough results to send patches.
> I suggest give it a try :-)
Thanks I'll check if your get_maintainer.pl options help. I was trying
to use .gitconfig [sendemail.linux] style options with git send-email
--identity=linux based on an example Krzysztof posted somewhere a
while back. Sorry could not find it though, maybe Krzysztof has a
link for it.
Regards,
Tony
> [1]: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh