[permalink] [raw]

Subject: Re: [PATCH V2 7/8] arm64: dts: ti: k3-am65-wakeup: Use generic temperature-sensor for node name

On 9/3/20 6:30 PM, Nishanth Menon wrote:
> Use temperature-sensor@ naming for nodes following standard conventions of device
> tree (section 2.2.2 Generic Names recommendation in [1]).
>
> [1] https://github.com/devicetree-org/devicetree-specification/tree/v0.3
>
> Suggested-by: Suman Anna <[email protected]>
> Suggested-by: Vignesh Raghavendra <[email protected]>
> Signed-off-by: Nishanth Menon <[email protected]>
> Reviewed-by: Lokesh Vutla <[email protected]>
> Reviewed-by: Suman Anna <[email protected]>

Acked-by: Vignesh Raghavendra <[email protected]>

> ---
> Changes:
> v2: None (picked acks/reviews)
> v1: https://lore.kernel.org/linux-arm-kernel/[email protected]/
>
> arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
> index bb498be2f0a4..ed42f13e7663 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
> @@ -95,7 +95,7 @@
> clock-names = "gpio";
> };
>
> - wkup_vtm0: thermal@42050000 {
> + wkup_vtm0: temperature-sensor@42050000 {
> compatible = "ti,am654-vtm";
> reg = <0x42050000 0x25c>;
> power-domains = <&k3_pds 80 TI_SCI_PD_EXCLUSIVE>;
>

2020-09-03 15:10:06

by Suman Anna

[permalink] [raw]

Subject: Re: [PATCH V2 2/8] arm64: dts: ti: k3-am65-main: Use lower case hexadecimal

On 9/3/20 8:00 AM, Nishanth Menon wrote:
> Device tree convention uses lower case a-f for hexadecimals. Fix the
> same.
>
> Signed-off-by: Nishanth Menon <[email protected]>

Acked-by: Suman Anna <[email protected]>

> ---
> Change:
> v2: - new
>
> arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> index 76e0edc4ad5c..d53d1ead4bb6 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> @@ -344,9 +344,9 @@
> <0x4090 0x3>; /* SERDES1 lane select */
> };
>
> - dss_oldi_io_ctrl: dss_oldi_io_ctrl@41E0 {
> + dss_oldi_io_ctrl: dss_oldi_io_ctrl@41e0 {
> compatible = "syscon";
> - reg = <0x0000041E0 0x14>;
> + reg = <0x0000041e0 0x14>;
> };
>
> ehrpwm_tbclk: syscon@4140 {
>

2020-09-03 15:39:25

by Vignesh Raghavendra

[permalink] [raw]

Subject: Re: [PATCH V2 4/8] arm64: dts: ti: k3-am65*: Use generic clock for syscon clock names

On 9/3/20 6:30 PM, Nishanth Menon wrote:
> serdes and ehrpwm_tbclk nodes should be using clock@ naming for nodes
> following standard conventions of device tree (section 2.2.2 Generic
> Names recommendation in [1]).
>
> [1] https://github.com/devicetree-org/devicetree-specification/tree/v0.3
>
> Suggested-by: Suman Anna <[email protected]>
> Signed-off-by: Nishanth Menon <[email protected]>
> Reviewed-by: Lokesh Vutla <[email protected]>
> Acked-by: Suman Anna <[email protected]>
> ---
> Change:
> v2: added ehrpwm_tbclk based on review comments.
> v1: https://lore.kernel.org/linux-arm-kernel/[email protected]/
>
> arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> index a2fc508e59a6..63a1299cb0b2 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> @@ -327,12 +327,12 @@
> reg = <0x00000210 0x4>;
> };
>
> - serdes0_clk: serdes_clk@4080 {
> + serdes0_clk: clock@4080 {
> compatible = "syscon";
> reg = <0x00004080 0x4>;
> };
>
> - serdes1_clk: serdes_clk@4090 {
> + serdes1_clk: clock@4090 {
> compatible = "syscon";
> reg = <0x00004090 0x4>;
> };
> @@ -349,7 +349,7 @@
> reg = <0x0000041e0 0x14>;
> };
>
> - ehrpwm_tbclk: syscon@4140 {
> + ehrpwm_tbclk: clock@4140 {
> compatible = "ti,am654-ehrpwm-tbclk", "syscon";
> reg = <0x4140 0x18>;
> #clock-cells = <1>;
>

Acked-by: Vignesh Raghavendra <[email protected]>

2020-09-07 12:02:05

by Nishanth Menon

[permalink] [raw]

Subject: Re: [PATCH V2 0/8] arm64: dts: ti: k3-*: Squash up node_name_chars_strict warnings + hex usage

On 08:00-20200903, Nishanth Menon wrote:
> Hi,
>
> This is a respin of v2 of the series posted as [1].
>
> As part of this cleanup, I ran a cross check of nodes that are
> part of K3 as of right now, Vs what is "generic" definition as per 0.3
> dt specification [2].
>
> Changes in v2:
> - Based off 20200903
> - Picked up Acks and reviewed-by from previous versions (please comment
> if you disagree).
> - Dropped tsadc rename [3] based on review
> - Added 2 patches to fixup hexadecimal usage caught as part of review
> - few additional fixups.
I have applied the following to branch ti-k3-next on [1].

[1/8] arm64: dts: ti: k3-j721e: Use lower case hexadecimal
commit: 1aedefe13ba263d0d7d1cfbb38aadebbd5bab34e
[2/8] arm64: dts: ti: k3-am65-main: Use lower case hexadecimal
commit: 05e393c596c4495d79f0cbeacb0f0a0e0b6f89d5
[3/8] arm64: dts: ti: k3-am65*: Use generic gpio for node names
commit: 91e5f404e42bc189bb0e447d30041de737ad24bf
[4/8] arm64: dts: ti: k3-am65*: Use generic clock for syscon clock names
commit: 86e67b591e6d993d98567143451883a5618c196e
[5/8] arm64: dts: ti: k3-*: Use generic pinctrl for node names
commit: dcccf77067e4274953e8944d9730bb7ae2964c28
[6/8] arm64: dts: ti: k3-am65-base-board Use generic camera for node name instead of ov5640
commit: 4c19fb9ce266561ab122880a02e873ee8c3668e4
[7/8] arm64: dts: ti: k3-am65-wakeup: Use generic temperature-sensor for node name
commit: 9a8ecd414322ceb377cecb4795e3f3d7d7020952
[8/8] arm64: dts: ti: k3-*: Fix up node_name_chars_strict warnings
commit: e5c956c4f36cdd59e775f2285af9a1683374c5a5

[1] git://git.kernel.org/pub/scm/linux/kernel/git/nmenon/linux.git
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D