LinuxLists.cc - linux-next: Tree for October 23

2008-10-24 00:20:57

2008-10-24 17:50:07

by Jesse Barnes

[permalink] [raw]

Subject: Re: [PATCH] PCI hotplug printk format

On Thursday, October 23, 2008 6:14 pm Randy Dunlap wrote:
> I made this patch for linux-next, but now mainline has this same
> code/warning.
>
>
> From: Randy Dunlap <[email protected]>
>
> Fix printk format warning:
>
> linux-next-20081023/drivers/pci/hotplug/acpiphp_ibm.c:207: warning: format
> '%08lx' expects type 'long unsigned int', but argument 3 has type 'long
> long unsigned int'
>
> Signed-off-by: Randy Dunlap <[email protected]>

Spoke too soon, this one was already merged.

Jesse

2008-10-25 08:24:40

by Geert Uytterhoeven

[permalink] [raw]

Subject: Re: [PATCH] ftrace: handle archs that do not support irqs_disabled_flags

On Fri, 24 Oct 2008, Steven Rostedt wrote:
> Some architectures do not support a way to read the irq flags that
> is set from "local_irq_save(flags)" to determine if interrupts were
> disabled or enabled. Ftrace uses this information to display to the user
> if the trace occurred with interrupts enabled or disabled.

Both alpha

#define irqs_disabled() (getipl() == IPL_MAX)

and m68k

static inline int irqs_disabled(void)
{
unsigned long flags;
local_save_flags(flags);
return flags & ~ALLOWINT;
}

do have irqs_disabled(), but they don't have irqs_disabled_flags().

M68knommu has both, but they don't check the same thing:

#define irqs_disabled() \
({ \
unsigned long flags; \
local_save_flags(flags); \
((flags & 0x0700) == 0x0700); \
})

static inline int irqs_disabled_flags(unsigned long flags)
{
if (flags & 0x0700)
return 0;
else
return 1;
}

Is there a semantic difference between them (except that the latter takes the
flags as a parameter)?

Or can we just extract the core logic of irqs_disabled() into
irqs_disabled_flags()?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2008-10-26 07:20:17

by Or Gerlitz

[permalink] [raw]

Subject: Re: [ofa-general] Re: linux-next: Tree for October 23

Randy Dunlap wrote:
> Building with CONFIG_INFINIBAND=m, kconfig allows CONFIG_NET_9P_RDMA=m,
> so one module wants symbols from the other (net/9p wants symbols from rmda_*).
>
> ERROR: "rdma_destroy_id" [net/9p/9pnet_rdma.ko] undefined!
> ERROR: "rdma_connect" [net/9p/9pnet_rdma.ko] undefined!
> ...
> Is this supposed to be allowed/possible? Otherwise NET_9P_RDMA might have to depend on INFINBAND=y...
No, there's no need to config INFINIBAND at built it. What's the value
of CONFIG_INFINIBAND_ADDR_TRANS ?

Or.

2008-10-26 18:50:08

On Fri, 31 Oct 2008, Ingo Molnar wrote:
> * Geert Uytterhoeven <[email protected]> wrote:
> > On Fri, 31 Oct 2008, Alexey Dobriyan wrote:
> > > On Thu, Oct 23, 2008 at 08:34:33PM +0400, Alexey Dobriyan wrote:
> > > > On Thu, Oct 23, 2008 at 07:27:48PM +0200, Frederic Weisbecker wrote:
> > > > > When tracing is enabled, some arch have included <linux/irqflags.h>
> > > > > on their <asm/system.h> but others like alpha or m68k don't.
> > > > >
> > > > > Build error on alpha:
> > > > >
> > > > > kernel/trace/trace.c: In function 'tracing_generic_entry_update':
> > > > > kernel/trace/trace.c:658: error: implicit declaration of function 'irqs_disabled_flags'
> > >
> > > FYI, this error still exists in mainline (7f82f000ed030d1108b4de47d9e2d556092980c6).
> >
> > Now it hit mainline (I can't be bothered to develop _new_ code to
> > fix things in -next ;-), I'm implementing irqs_disabled_flags() for
> > m68k. Stay tuned...
>
> this (now mainline) commit should have fixed it:
>
> 9244489: ftrace: handle archs that do not support irqs_disabled_flags
>
> can you still see problems?

Yes, the "undefined reference to `save_stack_trace'", as already pointed out
by Al. I'm trying his fix now...

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds