2023-09-12 05:23:03

by Steven Rostedt

[permalink] [raw]
Subject: Re: [FIX PATCH v2] selftests: tracing: Fix to unmount tracefs for recovering environment

On Tue, 12 Sep 2023 10:10:39 +0900
"Masami Hiramatsu (Google)" <[email protected]> wrote:

> From: Masami Hiramatsu (Google) <[email protected]>
>
> Fix to unmount the tracefs if the ftracetest mounted it for recovering
> system environment. If the tracefs is already mounted, this does nothing.
>
> Suggested-by: Mark Brown <[email protected]>
> Link: https://lore.kernel.org/all/[email protected]/
> Fixes: cbd965bde74c ("ftrace/selftests: Return the skip code when tracing directory not configured in kernel")
> Signed-off-by: Masami Hiramatsu (Google) <[email protected]>
> ---
> Changes in v2:
> - use -n option explictly for testing the string is non-zero.
> ---
> tool

Reviewed-by: Steven Rostedt (Google) <[email protected]>

-- Steve


2023-09-12 19:51:27

by Shuah Khan

[permalink] [raw]
Subject: Re: [FIX PATCH v2] selftests: tracing: Fix to unmount tracefs for recovering environment

On 9/11/23 19:24, Steven Rostedt wrote:
> On Tue, 12 Sep 2023 10:10:39 +0900
> "Masami Hiramatsu (Google)" <[email protected]> wrote:
>
>> From: Masami Hiramatsu (Google) <[email protected]>
>>
>> Fix to unmount the tracefs if the ftracetest mounted it for recovering
>> system environment. If the tracefs is already mounted, this does nothing.
>>
>> Suggested-by: Mark Brown <[email protected]>
>> Link: https://lore.kernel.org/all/[email protected]/
>> Fixes: cbd965bde74c ("ftrace/selftests: Return the skip code when tracing directory not configured in kernel")
>> Signed-off-by: Masami Hiramatsu (Google) <[email protected]>
>> ---
>> Changes in v2:
>> - use -n option explictly for testing the string is non-zero.
>> ---
>> tool
>
> Reviewed-by: Steven Rostedt (Google) <[email protected]>
>
> -- Steve

Thank you all. Applied to linux-kselftest fixes branch for next rc

thanks,
-- Shuah

2023-09-13 03:04:20

by Masami Hiramatsu

[permalink] [raw]
Subject: Re: [FIX PATCH v2] selftests: tracing: Fix to unmount tracefs for recovering environment

On Tue, 12 Sep 2023 09:35:58 -0600
Shuah Khan <[email protected]> wrote:

> On 9/11/23 19:24, Steven Rostedt wrote:
> > On Tue, 12 Sep 2023 10:10:39 +0900
> > "Masami Hiramatsu (Google)" <[email protected]> wrote:
> >
> >> From: Masami Hiramatsu (Google) <[email protected]>
> >>
> >> Fix to unmount the tracefs if the ftracetest mounted it for recovering
> >> system environment. If the tracefs is already mounted, this does nothing.
> >>
> >> Suggested-by: Mark Brown <[email protected]>
> >> Link: https://lore.kernel.org/all/[email protected]/
> >> Fixes: cbd965bde74c ("ftrace/selftests: Return the skip code when tracing directory not configured in kernel")
> >> Signed-off-by: Masami Hiramatsu (Google) <[email protected]>
> >> ---
> >> Changes in v2:
> >> - use -n option explictly for testing the string is non-zero.
> >> ---
> >> tool
> >
> > Reviewed-by: Steven Rostedt (Google) <[email protected]>
> >
> > -- Steve
>
> Thank you all. Applied to linux-kselftest fixes branch for next rc
>

Thanks Shuah!


> thanks,
> -- Shuah


--
Masami Hiramatsu (Google) <[email protected]>