The HP EliteBook 840 G8 seems to be circulating with different
subsystem-IDs. alsa-info.sh showed on my box:
!!DMI Information
!!---------------
Manufacturer: HP
Product Name: HP EliteBook 840 G8 Notebook PC
Product Version: SBKPF
Firmware Version: T37 Ver. 01.15.02
System SKU: 5S7R6EC#ABD
Board Vendor: HP
Board Name: 8AB8
..
!!HDA-Intel Codec information
!!---------------------------
--startcollapse--
Codec: Realtek ALC285
Address: 0
AFG Function Id: 0x1 (unsol 1)
Vendor Id: 0x10ec0285
Subsystem Id: 0x103c8ab9
Revision Id: 0x100002
So an additional quirk enabled mute led for me:
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9752,6 +9752,7 @@
SND_PCI_QUIRK(0x103c, 0x8aa3, "HP ProBook 450 G9 (MB 8AA1)",
ALC236_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8aa8, "HP EliteBook 640 G9 (MB 8AA6)",
ALC236_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8aab, "HP EliteBook 650 G9 (MB 8AA9)",
ALC236_FIXUP_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x8ab9, "HP EliteBook 840 G8 (MB 8AB8)",
ALC285_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8abb, "HP ZBook Firefly 14 G9",
ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8ad1, "HP EliteBook 840 14 inch G9 Notebook
PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8ad2, "HP EliteBook 860 16 inch G9 Notebook
PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
On Sun, 18 Feb 2024 13:16:03 +0100,
Hans Peter wrote:
>
> The HP EliteBook 840 G8 seems to be circulating with different
> subsystem-IDs. alsa-info.sh showed on my box:
>
> !!DMI Information
> !!---------------
>
> Manufacturer: HP
> Product Name: HP EliteBook 840 G8 Notebook PC
> Product Version: SBKPF
> Firmware Version: T37 Ver. 01.15.02
> System SKU: 5S7R6EC#ABD
> Board Vendor: HP
> Board Name: 8AB8
>
> ...
>
> !!HDA-Intel Codec information
> !!---------------------------
> --startcollapse--
>
> Codec: Realtek ALC285
> Address: 0
> AFG Function Id: 0x1 (unsol 1)
> Vendor Id: 0x10ec0285
> Subsystem Id: 0x103c8ab9
> Revision Id: 0x100002
>
>
> So an additional quirk enabled mute led for me:
>
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -9752,6 +9752,7 @@
> SND_PCI_QUIRK(0x103c, 0x8aa3, "HP ProBook 450 G9 (MB 8AA1)",
> ALC236_FIXUP_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x8aa8, "HP EliteBook 640 G9 (MB 8AA6)",
> ALC236_FIXUP_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x8aab, "HP EliteBook 650 G9 (MB 8AA9)",
> ALC236_FIXUP_HP_GPIO_LED),
> + SND_PCI_QUIRK(0x103c, 0x8ab9, "HP EliteBook 840 G8 (MB 8AB8)",
> ALC285_FIXUP_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x8abb, "HP ZBook Firefly 14 G9",
> ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x8ad1, "HP EliteBook 840 14 inch G9 Notebook
> PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x8ad2, "HP EliteBook 860 16 inch G9 Notebook
> PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
Could you repost a proper patch with your Signed-off-by tag? It's a
legal requirement. See Documentation/process/submitting-patches.rst
for details.
Also the information of your device could be a bit more concise.
Last but not least, the patch doesn't seem cleanly applicable. Your
mailer seems breaking the lines. Please fix your setup, or use
git-send-email to resubmit.
thanks,
Takashi
I apologize, this is my first patch ever.
On my HP EliteBook 840 G8 Notebook PC (ProdId 5S7R6EC#ABD, built 2022 for
german market) the Mute LED ist always on. The mute button itself works as
expected. alsa-info.sh shows a different subsystem-id 0x8ab9 for Realtek
ALC285 Codec, thus the existing quirks for HP 840 G8 don't work.
Therefore, add a new quirk for this type of EliteBook.
Signed-off-by: Hans Peter <[email protected]>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 0ec1312bffd5..26a90c92c3b8 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9927,6 +9927,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x8aa3, "HP ProBook 450 G9 (MB 8AA1)", ALC236_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8aa8, "HP EliteBook 640 G9 (MB 8AA6)", ALC236_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8aab, "HP EliteBook 650 G9 (MB 8AA9)", ALC236_FIXUP_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x8ab9, "HP EliteBook 840 G8 (MB 8AB8)", ALC285_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8abb, "HP ZBook Firefly 14 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8ad1, "HP EliteBook 840 14 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8ad2, "HP EliteBook 860 16 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
--
2.43.2
On Mon, 19 Feb 2024 17:00:57 +0100,
Hans Peter wrote:
>
> I apologize, this is my first patch ever.
>
> On my HP EliteBook 840 G8 Notebook PC (ProdId 5S7R6EC#ABD, built 2022 for
> german market) the Mute LED ist always on. The mute button itself works as
> expected. alsa-info.sh shows a different subsystem-id 0x8ab9 for Realtek
> ALC285 Codec, thus the existing quirks for HP 840 G8 don't work.
> Therefore, add a new quirk for this type of EliteBook.
>
> Signed-off-by: Hans Peter <[email protected]>
Thanks, now it's better, but could you rather resubmit without hanging
on an existing thread? Keep the subject without reply prefix (at best
put "v2" in the patch prefix, e.g. [PATCH v2] ALSA: hda/realtek: ...
Takashi