2017-08-14 14:19:27

by Dave Jones

Subject: Re: nvmet_fc: add defer_req callback for deferment of cmd buffer return

On Fri, Aug 11, 2017 at 07:44:19PM +0000, Linux Kernel wrote:
> Web: https://git.kernel.org/torvalds/c/0fb228d30b8d72bfee51f57e638d412324d44a11
> Commit: 0fb228d30b8d72bfee51f57e638d412324d44a11
> Parent: 758f3735580c21b8a36d644128af6608120a1dde
> Refname: refs/heads/master
> Author: James Smart <[email protected]>
> AuthorDate: Tue Aug 1 15:12:39 2017 -0700
> Committer: Christoph Hellwig <[email protected]>
> CommitDate: Thu Aug 10 11:06:38 2017 +0200
>
> nvmet_fc: add defer_req callback for deferment of cmd buffer return


> +
> + /* Cleanup defer'ed IOs in queue */
> + list_for_each_entry(deferfcp, &queue->avail_defer_list, req_list) {
> + list_del(&deferfcp->req_list);
> + kfree(deferfcp);
> + }

Shouldn't this be list_for_each_entry_safe ?

Dave

2017-08-14 16:38:32

by Christoph Hellwig

Subject: Re: nvmet_fc: add defer_req callback for deferment of cmd buffer return

On Mon, Aug 14, 2017 at 10:19:24AM -0400, Dave Jones wrote:
> > +
> > + /* Cleanup defer'ed IOs in queue */
> > + list_for_each_entry(deferfcp, &queue->avail_defer_list, req_list) {
> > + list_del(&deferfcp->req_list);
> > + kfree(deferfcp);
> > + }
>
> Shouldn't this be list_for_each_entry_safe ?

It should. James, can you send a fixup?

2017-08-14 17:57:38

by James Smart

Subject: Re: nvmet_fc: add defer_req callback for deferment of cmd buffer return

On 8/14/2017 9:38 AM, Christoph Hellwig wrote:
> On Mon, Aug 14, 2017 at 10:19:24AM -0400, Dave Jones wrote:
>> > +
>> > + /* Cleanup defer'ed IOs in queue */
>> > + list_for_each_entry(deferfcp, &queue->avail_defer_list, req_list) {
>> > + list_del(&deferfcp->req_list);
>> > + kfree(deferfcp);
>> > + }
>>
>> Shouldn't this be list_for_each_entry_safe ?
>
> It should. James, can you send a fixup?
>

yes - I was had already identified this fix and in the process of
putting it out.

-- james