2018-01-18 10:45:14

by Sudeep Holla

Subject: [PATCH -next] of: platform: fix OF node refcount leak

We need to call of_node_put() for device nodes obtained with
of_find_node_by_path().

Fixes: 3aa0582fdb82 ("of: platform: populate /firmware/ node from of_platform_default_populate_init()")
Reported-by: Loys Ollivier <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Frank Rowand <[email protected]>
Signed-off-by: Sudeep Holla <[email protected]>
---
drivers/of/platform.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

Hi Rob,

You had Acked the original patch and it's queued via ARM SoC. So can you
please provide ack on this if you are OK with the change.

Regards,
Sudeep

diff --git a/drivers/of/platform.c b/drivers/of/platform.c
index 6a01dab597c7..c00d81dfac0b 100644
--- a/drivers/of/platform.c
+++ b/drivers/of/platform.c
@@ -514,8 +514,10 @@ static int __init of_platform_default_populate_init(void)
of_platform_device_create(node, NULL, NULL);

node = of_find_node_by_path("/firmware");
- if (node)
+ if (node) {
of_platform_populate(node, NULL, NULL, NULL);
+ of_node_put(node);
+ }

/* Populate everything else. */
of_platform_default_populate(NULL, NULL, NULL);
--
2.7.4

2018-01-18 15:00:53

by Rob Herring

Subject: Re: [PATCH -next] of: platform: fix OF node refcount leak

On Thu, Jan 18, 2018 at 4:43 AM, Sudeep Holla <[email protected]> wrote:
> We need to call of_node_put() for device nodes obtained with
> of_find_node_by_path().
>
> Fixes: 3aa0582fdb82 ("of: platform: populate /firmware/ node from of_platform_default_populate_init()")
> Reported-by: Loys Ollivier <[email protected]>
> Cc: Rob Herring <[email protected]>
> Cc: Frank Rowand <[email protected]>
> Signed-off-by: Sudeep Holla <[email protected]>
> ---
> drivers/of/platform.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> Hi Rob,
>
> You had Acked the original patch and it's queued via ARM SoC. So can you
> please provide ack on this if you are OK with the change.

Acked-by: Rob Herring <[email protected]>

2018-01-19 15:38:38

by Sudeep Holla

Subject: Re: [PATCH -next] of: platform: fix OF node refcount leak

Hi Andy,

On 18/01/18 10:43, Sudeep Holla wrote:
> We need to call of_node_put() for device nodes obtained with
> of_find_node_by_path().
>
> Fixes: 3aa0582fdb82 ("of: platform: populate /firmware/ node from of_platform_default_populate_init()")
> Reported-by: Loys Ollivier <[email protected]>
> Cc: Rob Herring <[email protected]>
> Cc: Frank Rowand <[email protected]>
> Signed-off-by: Sudeep Holla <[email protected]>
> ---
> drivers/of/platform.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>

Can you pick up this with other fixes you would send after v4.16-rc1 or
do you prefer me to route through ARM-SoC directly ? Let me know.

--
Regards,
Sudeep

2018-01-19 23:34:53

by Andy Gross

Subject: Re: [PATCH -next] of: platform: fix OF node refcount leak

On 19 January 2018 at 09:37, Sudeep Holla <[email protected]> wrote:
> Hi Andy,
>
> On 18/01/18 10:43, Sudeep Holla wrote:
>> We need to call of_node_put() for device nodes obtained with
>> of_find_node_by_path().
>>
>> Fixes: 3aa0582fdb82 ("of: platform: populate /firmware/ node from of_platform_default_populate_init()")
>> Reported-by: Loys Ollivier <[email protected]>
>> Cc: Rob Herring <[email protected]>
>> Cc: Frank Rowand <[email protected]>
>> Signed-off-by: Sudeep Holla <[email protected]>
>> ---
>> drivers/of/platform.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>
> Can you pick up this with other fixes you would send after v4.16-rc1 or
> do you prefer me to route through ARM-SoC directly ? Let me know.

I can pick this up for fixes, no problem. I can send it along right
now if you like. This is a pretty low risk patch.

Regards,

Andy

2018-01-22 11:13:52

by Sudeep Holla

Subject: Re: [PATCH -next] of: platform: fix OF node refcount leak

On 19/01/18 23:34, Andy Gross wrote:
> On 19 January 2018 at 09:37, Sudeep Holla <[email protected]> wrote:
>> Hi Andy,
>>
>> On 18/01/18 10:43, Sudeep Holla wrote:
>>> We need to call of_node_put() for device nodes obtained with
>>> of_find_node_by_path().
>>>
>>> Fixes: 3aa0582fdb82 ("of: platform: populate /firmware/ node from of_platform_default_populate_init()")
>>> Reported-by: Loys Ollivier <[email protected]>
>>> Cc: Rob Herring <[email protected]>
>>> Cc: Frank Rowand <[email protected]>
>>> Signed-off-by: Sudeep Holla <[email protected]>
>>> ---
>>> drivers/of/platform.c | 4 +++-
>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>
>> Can you pick up this with other fixes you would send after v4.16-rc1 or
>> do you prefer me to route through ARM-SoC directly ? Let me know.
>
> I can pick this up for fixes, no problem. I can send it along right
> now if you like. This is a pretty low risk patch.
>

Thanks Andy.

--
Regards,
Sudeep