LinuxLists.cc - 2.6.29-rc1: Reported regressions from 2.6.28

[permalink] [raw]

Subject: [Bug #12399] USB wakeup problem on Toshiba Portege R500

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.28. Please verify if it still should be listed and let me know
(either way).

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12399
Subject : USB wakeup problem on Toshiba Portege R500
Submitter : Rafael J. Wysocki <[email protected]>
Date : 2009-01-08 7:35 (4 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=6fd9086a518d4f14213a32fe6c9ac17fabebbc1e
References : http://marc.info/?l=linux-kernel&m=123140019117968&w=4

2009-01-11 13:33:21

[permalink] [raw]

Subject: [Bug #12414] iwl4965 cannot use "ap auto" on latest 2.6.28/29?

2009-01-11 13:33:36

[permalink] [raw]

Subject: [Bug #12415] WARNING: at drivers/net/wireless/iwlwifi/iwl-sta.c:689

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.28. Please verify if it still should be listed and let me know
(either way).

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12415
Subject : WARNING: at drivers/net/wireless/iwlwifi/iwl-sta.c:689
Submitter : Christian Borntraeger <[email protected]>
Date : 2009-01-05 10:36 (7 days old)
References : http://marc.info/?l=linux-wireless&m=123115178019082&w=4

2009-01-11 13:34:00

[permalink] [raw]

Subject: [Bug #12402] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.28. Please verify if it still should be listed and let me know
(either way).

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12402
Subject : 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108
Submitter : Alexander Beregalov <[email protected]>
Date : 2009-01-09 04:41 (3 days old)
References : http://thread.gmane.org/gmane.comp.file-systems.xfs.general/27548
Handled-By : Christoph Hellwig <[email protected]>

2009-01-11 13:34:32

[permalink] [raw]

Subject: [Bug #12400] git-latest: kernel oops in IOMMU setup

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.28. Please verify if it still should be listed and let me know
(either way).

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12400
Subject : git-latest: kernel oops in IOMMU setup
Submitter : Dirk Hohndel <[email protected]>
Date : 2009-01-08 20:05 (4 days old)
References : http://marc.info/?l=linux-kernel&m=123144520124853&w=4
Handled-By : Dirk Hohndel <[email protected]>
Patch : http://marc.info/?l=linux-kernel&m=123152033725557&w=4

2009-01-11 13:34:51

[permalink] [raw]

Subject: [Bug #12416] Recent change to kernel spikes out ccache/distcc

2009-01-11 13:35:16

[permalink] [raw]

Subject: [Bug #12418] Repeated ioctl(4, 0x40046445, ..) loop in glxgears

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.28. Please verify if it still should be listed and let me know
(either way).

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12418
Subject : Repeated ioctl(4, 0x40046445, ..) loop in glxgears
Submitter : Pallipadi, Venkatesh <[email protected]>
Date : 2009-01-07 22:43 (5 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=7c1c2871a6a3a114853ec6836e9035ac1c0c7f7a
References : http://marc.info/?l=linux-kernel&m=123136836213319&w=4

2009-01-11 13:35:43

[permalink] [raw]

Subject: [Bug #12417] glx performance drop with: "x86: PAT: implement track/untrack of pfnmap regions for x86 - v3"

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.28. Please verify if it still should be listed and let me know
(either way).

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12417
Subject : glx performance drop with: "x86: PAT: implement track/untrack of pfnmap regions for x86 - v3"
Submitter : Alexey Fisher <[email protected]>
Date : 2009-01-06 18:46 (6 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=5899329b19100c0b82dc78e9b21ed8b920c9ffb3
References : http://marc.info/?l=linux-kernel&m=123126782822696&w=4
Handled-By : Pallipadi, Venkatesh <[email protected]>

2009-01-11 13:35:59

[permalink] [raw]

Subject: [Bug #12419] possible circular locking dependency on i915 dma

2009-01-11 13:36:30

[permalink] [raw]

Subject: [Bug #12428] Build error on latest git

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.28. Please verify if it still should be listed and let me know
(either way).

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12428
Subject : Build error on latest git
Submitter : Petr Titera <[email protected]>
Date : 2009-01-11 9:49 (1 days old)
References : http://marc.info/?l=linux-kernel&m=123166856318712&w=4
Handled-By : Petr Titera <[email protected]>
Patch : http://marc.info/?l=linux-kernel&m=123167509024996&w=4

2009-01-11 13:36:49

[permalink] [raw]

Subject: [Bug #12422] 2.6.28-git can't resume from str

2009-01-11 13:37:08

[permalink] [raw]

Subject: [Bug #12420] WARNING: at drivers/ata/libata-sff.c:1017 ata_sff_hsm_move+0x45e/0x750()

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.28. Please verify if it still should be listed and let me know
(either way).

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12420
Subject : WARNING: at drivers/ata/libata-sff.c:1017 ata_sff_hsm_move+0x45e/0x750()
Submitter : Christian Borntraeger <[email protected]>
Date : 2009-01-09 12:34 (3 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=871af1210f13966ab911ed2166e4ab2ce775b99d
References : http://marc.info/?l=linux-kernel&m=123150457832109&w=4

2009-01-11 13:37:41

[permalink] [raw]

Subject: [Bug #12427] cpumask change causes sparc build bustage

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.28. Please verify if it still should be listed and let me know
(either way).

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12427
Subject : cpumask change causes sparc build bustage
Submitter : David Miller <[email protected]>
Date : 2009-01-11 8:31 (1 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=588235bb53f2c215f0d4b08fd30b461fedc3338e
References : http://marc.info/?l=linux-kernel&m=123166268013838&w=4
Handled-By : David Miller <[email protected]>
Patch : http://marc.info/?l=linux-kernel&m=123167571525706&w=4

2009-01-11 13:46:49

by Jaswinder Singh

[permalink] [raw]

Subject: Re: 2.6.29-rc1: Reported regressions from 2.6.28

On Sun, Jan 11, 2009 at 4:42 PM, Rafael J. Wysocki <[email protected]> wrote:
>
> Regressions with patches
> ------------------------
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12428
> Subject : Build error on latest git
> Submitter : Petr Titera <[email protected]>
> Date : 2009-01-11 9:49 (1 days old)
> References : http://marc.info/?l=linux-kernel&m=123166856318712&w=4
> Handled-By : Petr Titera <[email protected]>
> Patch : http://marc.info/?l=linux-kernel&m=123167509024996&w=4
>
>

This is a wrong fix, asm/smp.h should only be included when CONFIG_SMP
is defined.

I am still in the process of cleaning non-smp data from asm/smp.h for x86

Attach patch is the solution for the time being

Ingo, can you please put this in urgent queue.

Thanks
--
JSR

Attachments:

(No filename) (827.00 B)
0001-x86-mpparse.c-fix-compilation-error.patch (747.00 B)
Download all attachments

2009-01-11 13:49:15

[permalink] [raw]

Subject: Re: 2.6.29-rc1: Reported regressions from 2.6.28

* Rafael J. Wysocki <[email protected]> wrote:

> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12420
> Subject : WARNING: at drivers/ata/libata-sff.c:1017 ata_sff_hsm_move+0x45e/0x750()
> Submitter : Christian Borntraeger <[email protected]>
> Date : 2009-01-09 12:34 (3 days old)
> First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=871af1210f13966ab911ed2166e4ab2ce775b99d
> References : http://marc.info/?l=linux-kernel&m=123150457832109&w=4

I can trigger it too and it is pretty much resolved - false positive
WARN_ON() triggered by new (but correct) libata usage.

> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12417
> Subject : glx performance drop with: "x86: PAT: implement track/untrack of pfnmap regions for x86 - v3"
> Submitter : Alexey Fisher <[email protected]>
> Date : 2009-01-06 18:46 (6 days old)
> First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=5899329b19100c0b82dc78e9b21ed8b920c9ffb3
> References : http://marc.info/?l=linux-kernel&m=123126782822696&w=4
> Handled-By : Pallipadi, Venkatesh <[email protected]>

Should be solved by Venki's PAT fixes in tip/x86/urgent:

0e95c19: x86, pat: fix reserve_memtype() for legacy 1MB range
74edd61: x86 PAT: remove CPA WARN_ON for zero pte
e722dc8: x86 PAT: ioremap_wc should take resource_size_t parameter
b61e53c: x86 PAT: return compatible mapping to remap_pfn_range callers
e104ba3: x86 PAT: change track_pfn_vma_new to take pgprot_t pointer param
3cedb0d: x86 PAT: consolidate old memtype new memtype check into a function
e61304a: x86 PAT: remove PFNMAP type on track_pfn_vma_new() error

Soon to be sent to Linus.

Ingo

2009-01-11 13:54:00

[permalink] [raw]

Subject: Re: 2.6.29-rc1: Reported regressions from 2.6.28

* Jaswinder Singh Rajput <[email protected]> wrote:

> On Sun, Jan 11, 2009 at 4:42 PM, Rafael J. Wysocki <[email protected]> wrote:
> >
> > Regressions with patches
> > ------------------------
> >
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12428
> > Subject : Build error on latest git
> > Submitter : Petr Titera <[email protected]>
> > Date : 2009-01-11 9:49 (1 days old)
> > References : http://marc.info/?l=linux-kernel&m=123166856318712&w=4
> > Handled-By : Petr Titera <[email protected]>
> > Patch : http://marc.info/?l=linux-kernel&m=123167509024996&w=4
>
> This is a wrong fix, asm/smp.h should only be included when CONFIG_SMP
> is defined.
>
> I am still in the process of cleaning non-smp data from asm/smp.h for
> x86
>
> Attach patch is the solution for the time being
>
> Ingo, can you please put this in urgent queue.

yes, it already is - see below.

Ingo

----------------->
>From 8b5a33599c541cf5bf66304343d08ff2795d038b Mon Sep 17 00:00:00 2001
From: Jaswinder Singh Rajput <[email protected]>
Date: Sun, 11 Jan 2009 18:38:55 +0530
Subject: [PATCH] x86: fix mpparse.c build error on latest git

Fix this by reintroducing asm/smp.h include in mpparse.c - later on
I will fix this by removing non-smp data from smp.h.

Reported-by: Petr Titera <[email protected]>
Signed-off-by: Jaswinder Singh Rajput <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>
---
arch/x86/kernel/mpparse.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kernel/mpparse.c b/arch/x86/kernel/mpparse.c
index c0601c2..a649a4c 100644
--- a/arch/x86/kernel/mpparse.c
+++ b/arch/x86/kernel/mpparse.c
@@ -27,6 +27,7 @@
#include <asm/e820.h>
#include <asm/trampoline.h>
#include <asm/setup.h>
+#include <asm/smp.h>

#include <mach_apic.h>
#ifdef CONFIG_X86_32

2009-01-11 13:57:19

[permalink] [raw]

Subject: Re: [Bug #12422] 2.6.28-git can't resume from str

On Sun, Jan 11, 2009 at 7:16 PM, Rafael J. Wysocki <[email protected]> wrote:
> This message has been generated automatically as a part of a report
> of recent regressions.
>
> The following bug entry is on the current list of known regressions
> from 2.6.28. Please verify if it still should be listed and let me know
> (either way).
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12422
> Subject : 2.6.28-git can't resume from str
> Submitter : Jeff Chua <[email protected]>
> Date : 2009-01-10 1:39 (2 days old)
> References : http://marc.info/?l=linux-kernel&m=123155157909282&w=4

Latest git pull still not fixed.

Jeff.

2009-01-11 13:59:41

[permalink] [raw]

Subject: Re: [Bug #12414] iwl4965 cannot use "ap auto" on latest 2.6.28/29?

On Sun, Jan 11, 2009 at 7:16 PM, Rafael J. Wysocki <[email protected]> wrote:
> This message has been generated automatically as a part of a report
> of recent regressions.
>
> The following bug entry is on the current list of known regressions
> from 2.6.28. Please verify if it still should be listed and let me know
> (either way).
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12414
> Subject : iwl4965 cannot use "ap auto" on latest 2.6.28/29?
> Submitter : Jeff Chua <[email protected]>
> Date : 2009-01-05 4:13 (7 days old)
> References : http://marc.info/?l=linux-kernel&m=123112882127823&w=4

Latest git pull still not fixed.

Jeff.

2009-01-11 14:10:34

by Daniel Drake

[permalink] [raw]

Subject: Re: [Bug #12422] 2.6.28-git can't resume from str

Rafael J. Wysocki wrote:
> This message has been generated automatically as a part of a report
> of recent regressions.
>
> The following bug entry is on the current list of known regressions
> from 2.6.28. Please verify if it still should be listed and let me know
> (either way).
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12422
> Subject : 2.6.28-git can't resume from str
> Submitter : Jeff Chua <[email protected]>
> Date : 2009-01-10 1:39 (2 days old)
> References : http://marc.info/?l=linux-kernel&m=123155157909282&w=4

The bisection looks invalid. It is unlikely to be this commit at fault.
Jeff, do you even have that camera?

It is also easy to revert that commit by hand. Just delete the
unusual_devs entry for it.

Daniel

2009-01-11 14:18:53

[permalink] [raw]

Subject: Re: [Bug #12422] 2.6.28-git can't resume from str

Am Sonntag 11 Januar 2009 schrieb Daniel Drake:
> Rafael J. Wysocki wrote:
> > This message has been generated automatically as a part of a report
> > of recent regressions.
> >
> > The following bug entry is on the current list of known regressions
> > from 2.6.28. Please verify if it still should be listed and let me know
> > (either way).
> >
> >
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12422
> > Subject : 2.6.28-git can't resume from str
> > Submitter : Jeff Chua <[email protected]>
> > Date : 2009-01-10 1:39 (2 days old)
> > References : http://marc.info/?l=linux-kernel&m=123155157909282&w=4
>
> The bisection looks invalid. It is unlikely to be this commit at fault.
> Jeff, do you even have that camera?
>
> It is also easy to revert that commit by hand. Just delete the
> unusual_devs entry for it.

I found a nearby commit during bisect, which looks much saner:

http://marc.info/?l=linux-kernel&m=123167815028388&w=2

2009-01-11 14:52:20

by Oleksij Rempel

[permalink] [raw]

Subject: Re: [Bug #12420] WARNING: at drivers/ata/libata-sff.c:1017 ata_sff_hsm_move+0x45e/0x750()

Rafael J. Wysocki schrieb:
> This message has been generated automatically as a part of a report
> of recent regressions.
>
> The following bug entry is on the current list of known regressions
> from 2.6.28. Please verify if it still should be listed and let me know
> (either way).
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12420
> Subject : WARNING: at drivers/ata/libata-sff.c:1017 ata_sff_hsm_move+0x45e/0x750()
> Submitter : Christian Borntraeger <[email protected]>
> Date : 2009-01-09 12:34 (3 days old)
> First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=871af1210f13966ab911ed2166e4ab2ce775b99d
> References : http://marc.info/?l=linux-kernel&m=123150457832109&w=4
>

I just realised, this warning message normally should inculde DMI System
Product Name ( Hardware Name ), but my board do not support this filed (
it geve only "System Product Name" ) and use only DMI Board Product Name
instead. It should be "5LD2-VM".

------------[ cut here ]------------
WARNING: at drivers/ata/libata-sff.c:1017 ata_sff_hsm_move+0x480/0x6c2()
Hardware name: System Product Name
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Should be like:
Hradware name: P5LD2-VM

See my dmidecoe:

Handle 0x0001, DMI type 1, 27 bytes
System Information
Manufacturer: stem manufacturer
Product Name: System Product Name
Version: System Version
Serial Number: System Serial Number
UUID: [------------cuted out--------------]
Wake-up Type: PCI PME#
SKU Number: <BAD INDEX>
Family: <BAD INDEX>

Handle 0x0002, DMI type 2, 15 bytes
Base Board Information
Manufacturer: ASUSTeK Computer INC.
Product Name: P5LD2-VM
Version: Rev 1.xx
Serial Number: MB-1234567890
Asset Tag: To Be Filled By O.E.M.
Features:
Board is a hosting board
Board is replaceable
Location In Chassis: To Be Filled By O.E.M.
Chassis Handle: 0x0003
Type: Motherboard
Contained Object Handles: 0

2009-01-11 16:10:34

[permalink] [raw]

Subject: Re: [Bug #12422] 2.6.28-git can't resume from str

On Sun, Jan 11, 2009 at 10:08 PM, Daniel Drake <[email protected]> wrote:
> Rafael J. Wysocki wrote:
>>
>> This message has been generated automatically as a part of a report
>> of recent regressions.
>>
>> The following bug entry is on the current list of known regressions
>> from 2.6.28. Please verify if it still should be listed and let me know
>> (either way).
>>
>>
>> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12422
>> Subject : 2.6.28-git can't resume from str
>> Submitter : Jeff Chua <[email protected]>
>> Date : 2009-01-10 1:39 (2 days old)
>> References : http://marc.info/?l=linux-kernel&m=123155157909282&w=4
>
> The bisection looks invalid. It is unlikely to be this commit at fault.

I have doubt about this too, but it's was git bisect zero into. All I
know is a0e280e0f33f6c859a235fb69a875ed8f3420388 is definitely good.

> Jeff, do you even have that camera?

No, I don't have this.

> It is also easy to revert that commit by hand. Just delete the unusual_devs
> entry for it.

I'm lost reverting this. Right now, I'm just use "git diff" and throw
away everything after a0e280e0f33f6c859a235fb69a875ed8f3420388, and my
system can STD, STR without an problem resuming.

Thanks,
Jeff.

2009-01-11 16:13:44

[permalink] [raw]

Subject: Re: [Bug #12422] 2.6.28-git can't resume from str

On Sun, Jan 11, 2009 at 10:18 PM, Christian Borntraeger
<[email protected]> wrote:
> Am Sonntag 11 Januar 2009 schrieb Daniel Drake:
>> Rafael J. Wysocki wrote:
>> > This message has been generated automatically as a part of a report
>> > of recent regressions.
>> >
>> > The following bug entry is on the current list of known regressions
>> > from 2.6.28. Please verify if it still should be listed and let me know
>> > (either way).
>> >
>> >
>> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12422
>> > Subject : 2.6.28-git can't resume from str
>> > Submitter : Jeff Chua <[email protected]>
>> > Date : 2009-01-10 1:39 (2 days old)
>> > References : http://marc.info/?l=linux-kernel&m=123155157909282&w=4
>>
>> The bisection looks invalid. It is unlikely to be this commit at fault.
>> Jeff, do you even have that camera?
>>
>> It is also easy to revert that commit by hand. Just delete the
>> unusual_devs entry for it.
>
> I found a nearby commit during bisect, which looks much saner:
>
> http://marc.info/?l=linux-kernel&m=123167815028388&w=2

This was committed earlier than
a0e280e0f33f6c859a235fb69a875ed8f3420388, and
a0e280e0f33f6c859a235fb69a875ed8f3420388 was the last working kernel
that is able to suspend/resume. Go one before, and suspend/resume
breaks.

Thanks,
Jeff.

2009-01-11 16:18:56

[permalink] [raw]

Subject: Re: [Bug #12422] 2.6.28-git can't resume from str

Am Sonntag 11 Januar 2009 schrieb Jeff Chua:
> > I found a nearby commit during bisect, which looks much saner:
> >
> > http://marc.info/?l=linux-kernel&m=123167815028388&w=2
>
> This was committed earlier than
> a0e280e0f33f6c859a235fb69a875ed8f3420388, and
> a0e280e0f33f6c859a235fb69a875ed8f3420388 was the last working kernel
> that is able to suspend/resume. Go one before, and suspend/resume
> breaks.

Yes, I am aware that this patch fixes one of the many S2R problems in
2.6.29-rc. Thats why I had

commit a0e280e0f33f6c859a235fb69a875ed8f3420388
Author: Heiko Carstens <[email protected]>
Date: Wed Jan 7 16:19:46 2009 +0100

stop_machine/cpu hotplug: fix disable_nonboot_cpus

as an additional patch applied during my bisect.

Christian

2009-01-11 16:30:41

[permalink] [raw]

Subject: Re: [Bug #12422] 2.6.28-git can't resume from str

* Jeff Chua <[email protected]> wrote:

> On Sun, Jan 11, 2009 at 10:18 PM, Christian Borntraeger
> <[email protected]> wrote:
> > Am Sonntag 11 Januar 2009 schrieb Daniel Drake:
> >> Rafael J. Wysocki wrote:
> >> > This message has been generated automatically as a part of a report
> >> > of recent regressions.
> >> >
> >> > The following bug entry is on the current list of known regressions
> >> > from 2.6.28. Please verify if it still should be listed and let me know
> >> > (either way).
> >> >
> >> >
> >> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12422
> >> > Subject : 2.6.28-git can't resume from str
> >> > Submitter : Jeff Chua <[email protected]>
> >> > Date : 2009-01-10 1:39 (2 days old)
> >> > References : http://marc.info/?l=linux-kernel&m=123155157909282&w=4
> >>
> >> The bisection looks invalid. It is unlikely to be this commit at fault.
> >> Jeff, do you even have that camera?
> >>
> >> It is also easy to revert that commit by hand. Just delete the
> >> unusual_devs entry for it.
> >
> > I found a nearby commit during bisect, which looks much saner:
> >
> > http://marc.info/?l=linux-kernel&m=123167815028388&w=2
>
> This was committed earlier than
> a0e280e0f33f6c859a235fb69a875ed8f3420388, and
> a0e280e0f33f6c859a235fb69a875ed8f3420388 was the last working kernel
> that is able to suspend/resume. Go one before, and suspend/resume
> breaks.

so you mean a0e280e0f33f6c859a235fb69a875ed8f3420388 seems good, while the
next step in Linus's tree, 52fefcec97c25b15887e6a9a885ca54e7f7c0928 is
already broken?

Does 52fefcec97c25b15887e6a9a885ca54e7f7c0928 start working if you do:

git checkout 52fefcec97c25b15887e6a9a885ca54e7f7c0928
git revert a0e280e0f33f6c859a235fb69a875ed8f3420388

?

That would implicate a0e280e0f33f6c859a235fb69a875ed8f3420388 + some
layout/timing problem - which does not trigger for some reason if pure
a0e280e0f33f6c859a235fb69a875ed8f3420388 is tried.

Ingo

2009-01-11 16:36:36

[permalink] [raw]

Subject: Re: [Bug #12422] 2.6.28-git can't resume from str

Am Sonntag 11 Januar 2009 schrieb Ingo Molnar:
>
> * Jeff Chua <[email protected]> wrote:
>
> > On Sun, Jan 11, 2009 at 10:18 PM, Christian Borntraeger
> > <[email protected]> wrote:
> > > Am Sonntag 11 Januar 2009 schrieb Daniel Drake:
> > >> Rafael J. Wysocki wrote:
> > >> > This message has been generated automatically as a part of a report
> > >> > of recent regressions.
> > >> >
> > >> > The following bug entry is on the current list of known regressions
> > >> > from 2.6.28. Please verify if it still should be listed and let me
know
> > >> > (either way).
> > >> >
> > >> >
> > >> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12422
> > >> > Subject : 2.6.28-git can't resume from str
> > >> > Submitter : Jeff Chua <[email protected]>
> > >> > Date : 2009-01-10 1:39 (2 days old)
> > >> > References : http://marc.info/?l=linux-kernel&m=123155157909282&w=4
> > >>
> > >> The bisection looks invalid. It is unlikely to be this commit at fault.
> > >> Jeff, do you even have that camera?
> > >>
> > >> It is also easy to revert that commit by hand. Just delete the
> > >> unusual_devs entry for it.
> > >
> > > I found a nearby commit during bisect, which looks much saner:
> > >
> > > http://marc.info/?l=linux-kernel&m=123167815028388&w=2
> >
> > This was committed earlier than
> > a0e280e0f33f6c859a235fb69a875ed8f3420388, and
> > a0e280e0f33f6c859a235fb69a875ed8f3420388 was the last working kernel
> > that is able to suspend/resume. Go one before, and suspend/resume
> > breaks.
>
> so you mean a0e280e0f33f6c859a235fb69a875ed8f3420388 seems good, while the
> next step in Linus's tree, 52fefcec97c25b15887e6a9a885ca54e7f7c0928 is
> already broken?

I guess Jeff, meant the other way around.
Since a0e280e0f33f6c859a235fb69a875ed8f3420388 is a fix for a known S2R
problem , the earlier patch (before) does of course not work.

2009-01-11 16:39:23

[permalink] [raw]

Subject: Re: [Bug #12422] 2.6.28-git can't resume from str

* Christian Borntraeger <[email protected]> wrote:

> Am Sonntag 11 Januar 2009 schrieb Ingo Molnar:
> >
> > * Jeff Chua <[email protected]> wrote:
> >
> > > On Sun, Jan 11, 2009 at 10:18 PM, Christian Borntraeger
> > > <[email protected]> wrote:
> > > > Am Sonntag 11 Januar 2009 schrieb Daniel Drake:
> > > >> Rafael J. Wysocki wrote:
> > > >> > This message has been generated automatically as a part of a report
> > > >> > of recent regressions.
> > > >> >
> > > >> > The following bug entry is on the current list of known regressions
> > > >> > from 2.6.28. Please verify if it still should be listed and let me
> know
> > > >> > (either way).
> > > >> >
> > > >> >
> > > >> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12422
> > > >> > Subject : 2.6.28-git can't resume from str
> > > >> > Submitter : Jeff Chua <[email protected]>
> > > >> > Date : 2009-01-10 1:39 (2 days old)
> > > >> > References : http://marc.info/?l=linux-kernel&m=123155157909282&w=4
> > > >>
> > > >> The bisection looks invalid. It is unlikely to be this commit at fault.
> > > >> Jeff, do you even have that camera?
> > > >>
> > > >> It is also easy to revert that commit by hand. Just delete the
> > > >> unusual_devs entry for it.
> > > >
> > > > I found a nearby commit during bisect, which looks much saner:
> > > >
> > > > http://marc.info/?l=linux-kernel&m=123167815028388&w=2
> > >
> > > This was committed earlier than
> > > a0e280e0f33f6c859a235fb69a875ed8f3420388, and
> > > a0e280e0f33f6c859a235fb69a875ed8f3420388 was the last working kernel
> > > that is able to suspend/resume. Go one before, and suspend/resume
> > > breaks.
> >
> > so you mean a0e280e0f33f6c859a235fb69a875ed8f3420388 seems good, while the
> > next step in Linus's tree, 52fefcec97c25b15887e6a9a885ca54e7f7c0928 is
> > already broken?
>
> I guess Jeff, meant the other way around.
> Since a0e280e0f33f6c859a235fb69a875ed8f3420388 is a fix for a known S2R
> problem , the earlier patch (before) does of course not work.

ah, okay.

So i suspect that at every bisection point, this should be done:

git cherry-pick a0e280e0f33f6c859a235fb69a875ed8f3420388

To make sure the bisection finds the secondary breakage too.

(the cherry-pick will fail harmlessly on kernels that have that commit
already - so it can be done unconditionally at every bisection point.)

Ingo

2009-01-11 16:56:40

[permalink] [raw]

Subject: Re: [Bug #12422] 2.6.28-git can't resume from str

On Mon, Jan 12, 2009 at 12:39 AM, Ingo Molnar <[email protected]> wrote:
> * Christian Borntraeger <[email protected]> wrote
>> I guess Jeff, meant the other way around.
>> Since a0e280e0f33f6c859a235fb69a875ed8f3420388 is a fix for a known S2R
>> problem , the earlier patch (before) does of course not work.
> ah, okay.
> So i suspect that at every bisection point, this should be done:
> git cherry-pick a0e280e0f33f6c859a235fb69a875ed8f3420388

I started with the latest git, and did this ...

git bisect start
git bisect bad
git bisect good a0e280e0f33f6c859a235fb69a875ed8f3420388

Everything in-between should have
a0e280e0f33f6c859a235fb69a875ed8f3420388 applied?

Jeff.

2009-01-11 18:08:05

[permalink] [raw]

Subject: Re: [Bug #12422] 2.6.28-git can't resume from str

* Jeff Chua <[email protected]> wrote:

> On Mon, Jan 12, 2009 at 12:39 AM, Ingo Molnar <[email protected]> wrote:
> > * Christian Borntraeger <[email protected]> wrote
> >> I guess Jeff, meant the other way around.
> >> Since a0e280e0f33f6c859a235fb69a875ed8f3420388 is a fix for a known S2R
> >> problem , the earlier patch (before) does of course not work.
> > ah, okay.
> > So i suspect that at every bisection point, this should be done:
> > git cherry-pick a0e280e0f33f6c859a235fb69a875ed8f3420388
>
> I started with the latest git, and did this ...
>
> git bisect start
> git bisect bad
> git bisect good a0e280e0f33f6c859a235fb69a875ed8f3420388
>
> Everything in-between should have
> a0e280e0f33f6c859a235fb69a875ed8f3420388 applied?

not necessarily - if an intermediate tree that is checked happened to have
been based on some earlier -rc, it might have that bug included. Safest is
to always cherry-pick that commit. (if it has no dependencies)

Ingo

2009-01-11 18:55:48

[permalink] [raw]

Subject: Re: [Bug #12414] iwl4965 cannot use "ap auto" on latest 2.6.28/29?

On Sunday 11 January 2009, Jeff Chua wrote:
> On Sun, Jan 11, 2009 at 7:16 PM, Rafael J. Wysocki <[email protected]> wrote:
> > This message has been generated automatically as a part of a report
> > of recent regressions.
> >
> > The following bug entry is on the current list of known regressions
> > from 2.6.28. Please verify if it still should be listed and let me know
> > (either way).
> >
> >
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12414
> > Subject : iwl4965 cannot use "ap auto" on latest 2.6.28/29?
> > Submitter : Jeff Chua <[email protected]>
> > Date : 2009-01-05 4:13 (7 days old)
> > References : http://marc.info/?l=linux-kernel&m=123112882127823&w=4
>
> Latest git pull still not fixed.

Thanks for the update.

Rafael

2009-01-11 19:01:47

[permalink] [raw]

Subject: Re: 2.6.29-rc1: Reported regressions from 2.6.28

On Sunday 11 January 2009, Ingo Molnar wrote:
>
> * Jaswinder Singh Rajput <[email protected]> wrote:
>
> > On Sun, Jan 11, 2009 at 4:42 PM, Rafael J. Wysocki <[email protected]> wrote:
> > >
> > > Regressions with patches
> > > ------------------------
> > >
> > > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12428
> > > Subject : Build error on latest git
> > > Submitter : Petr Titera <[email protected]>
> > > Date : 2009-01-11 9:49 (1 days old)
> > > References : http://marc.info/?l=linux-kernel&m=123166856318712&w=4
> > > Handled-By : Petr Titera <[email protected]>
> > > Patch : http://marc.info/?l=linux-kernel&m=123167509024996&w=4
> >
> > This is a wrong fix, asm/smp.h should only be included when CONFIG_SMP
> > is defined.
> >
> > I am still in the process of cleaning non-smp data from asm/smp.h for
> > x86
> >
> > Attach patch is the solution for the time being
> >
> > Ingo, can you please put this in urgent queue.
>
> yes, it already is - see below.

Link to this patch was added to the bug entry. Pleaes let me know or close the
bug when it's merged.

Thanks,
Rafael

2009-01-11 21:14:24

by Maxim Levitsky

[permalink] [raw]

Subject: Re: [Bug #12399] USB wakeup problem on Toshiba Portege R500

On Sun, 2009-01-11 at 12:12 +0100, Rafael J. Wysocki wrote:
> This message has been generated automatically as a part of a report
> of recent regressions.
>
> The following bug entry is on the current list of known regressions
> from 2.6.28. Please verify if it still should be listed and let me know
> (either way).
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12399
> Subject : USB wakeup problem on Toshiba Portege R500
> Submitter : Rafael J. Wysocki <[email protected]>
> Date : 2009-01-08 7:35 (4 days old)
> First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=6fd9086a518d4f14213a32fe6c9ac17fabebbc1e
> References : http://marc.info/?l=linux-kernel&m=123140019117968&w=4
>

Happens here on aspire 5720G, and yes unloading ehci_hcd makes
suspend/resume work, otherwise system resumes immediately.

best regards,
Maxim Levitsky

2009-01-11 23:07:53

by Matthias Heinz

[permalink] [raw]

Subject: Re: 2.6.29-rc1: Reported regressions from 2.6.28

Am Sonntag, 11. Januar 2009 schrieb Rafael J. Wysocki:
> If you know of any other unresolved regressions from 2.6.28, please let me
> know either and I'll add them to the list. Also, please let me know if any
> of the entries below are invalid.

Unresolved regressions
----------------------

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12174
Subject : No backlight control on Samsung x360

I think this is a common bug on systems with a broken(?) bios, exposing wrong
driver names. With 2.6.27 it was at least possible to control the backlight
over the NVID interface.

2009-01-12 00:45:19

by Matthias Heinz

[permalink] [raw]

Subject: Re: 2.6.29-rc1: Reported regressions from 2.6.28

2009-01-12 11:16:33

[permalink] [raw]

Subject: Re: [Bug #12415] WARNING: at drivers/net/wireless/iwlwifi/iwl-sta.c:689

Am Sonntag 11 Januar 2009 schrieb Rafael J. Wysocki:
> This message has been generated automatically as a part of a report
> of recent regressions.
>
> The following bug entry is on the current list of known regressions
> from 2.6.28. Please verify if it still should be listed and let me know
> (either way).
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12415
> Subject : WARNING: at drivers/net/wireless/iwlwifi/iwl-sta.c:689
> Submitter : Christian Borntraeger <[email protected]>
> Date : 2009-01-05 10:36 (7 days old)
> References : http://marc.info/?l=linux-wireless&m=123115178019082&w=4

Meanwhile I have updated the device firmware and the kernel level. The
problems has disappeared.

Christian

2009-01-12 12:48:50

[permalink] [raw]

Subject: Re: [Bug #12415] WARNING: at drivers/net/wireless/iwlwifi/iwl-sta.c:689

On Monday 12 January 2009, Christian Borntraeger wrote:
> Am Sonntag 11 Januar 2009 schrieb Rafael J. Wysocki:
> > This message has been generated automatically as a part of a report
> > of recent regressions.
> >
> > The following bug entry is on the current list of known regressions
> > from 2.6.28. Please verify if it still should be listed and let me know
> > (either way).
> >
> >
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12415
> > Subject : WARNING: at drivers/net/wireless/iwlwifi/iwl-sta.c:689
> > Submitter : Christian Borntraeger <[email protected]>
> > Date : 2009-01-05 10:36 (7 days old)
> > References : http://marc.info/?l=linux-wireless&m=123115178019082&w=4
>
> Meanwhile I have updated the device firmware and the kernel level. The
> problems has disappeared.

Thanks for the update, the bug has been closed.

Rafael

2009-01-13 01:20:41

[permalink] [raw]

Subject: Re: [Bug #12422] 2.6.28-git can't resume from str

On Mon, Jan 12, 2009 at 2:07 AM, Ingo Molnar <[email protected]> wrote:
>> Everything in-between should have
>> a0e280e0f33f6c859a235fb69a875ed8f3420388 applied?
> not necessarily - if an intermediate tree that is checked happened to have
> been based on some earlier -rc, it might have that bug included. Safest is
> to always cherry-pick that commit. (if it has no dependencies)

Thanks for pointing this out. My bisect was thrown off course because
I didn't "cherry-pick" that commit.

After cherry picking, I ended up with the same commit as was reported by
Christian Borntraeger -- "Regression 2.6.28-git: suspend/resume
failure. git bisected to usb suspend/resume patch".

I was trying to bisect further, but ended up with this strange behavior...

# start with a "fresh linux git download".
# ls
. .. .git .gitignore .mailmap COPYING
CREDITS Documentation Kbuild MAINTAINERS Makefile README
REPORTING-BUGS arch block crypto drivers firmware
fs include init ipc kernel lib
mm net samples scripts security sound
usr virt

# git bisect bad ae04d1401577bb63151480a053057de58b8e10bb
# git bisect good a3a798c88a14b35e5d4ca30716dbc9eb9a1ddfe2
Bisecting: 579 revisions left to test after this
[079899c2384023cd8efcd3806680b4f1d2abbd54] Btrfs: Change
find_extent_buffer to use TestSetPageLocked

# ls
. .. .git fs

Is this a bug or a feature?

Jeff.

2009-01-13 01:28:36

[permalink] [raw]

Subject: Re: [Bug #12422] 2.6.28-git can't resume from str

* Jeff Chua <[email protected]> wrote:

> On Mon, Jan 12, 2009 at 2:07 AM, Ingo Molnar <[email protected]> wrote:
> >> Everything in-between should have
> >> a0e280e0f33f6c859a235fb69a875ed8f3420388 applied?
> > not necessarily - if an intermediate tree that is checked happened to have
> > been based on some earlier -rc, it might have that bug included. Safest is
> > to always cherry-pick that commit. (if it has no dependencies)
>
> Thanks for pointing this out. My bisect was thrown off course because
> I didn't "cherry-pick" that commit.
>
> After cherry picking, I ended up with the same commit as was reported by
> Christian Borntraeger -- "Regression 2.6.28-git: suspend/resume
> failure. git bisected to usb suspend/resume patch".
>
> I was trying to bisect further, but ended up with this strange behavior...
>
> # start with a "fresh linux git download".
> # ls
> . .. .git .gitignore .mailmap COPYING
> CREDITS Documentation Kbuild MAINTAINERS Makefile README
> REPORTING-BUGS arch block crypto drivers firmware
> fs include init ipc kernel lib
> mm net samples scripts security sound
> usr virt
>
> # git bisect bad ae04d1401577bb63151480a053057de58b8e10bb
> # git bisect good a3a798c88a14b35e5d4ca30716dbc9eb9a1ddfe2
> Bisecting: 579 revisions left to test after this
> [079899c2384023cd8efcd3806680b4f1d2abbd54] Btrfs: Change
> find_extent_buffer to use TestSetPageLocked
>
> # ls
> . .. .git fs
>
> Is this a bug or a feature?

that's a feature - the btrfs history looks like this. You can mark get out
of that bisection set by doing this:

git bisect good 34353029534a08e41cfb8be647d734b9ce9ebff8

Ingo

2009-01-13 02:09:45

by Linus Torvalds

[permalink] [raw]

Subject: Re: [Bug #12422] 2.6.28-git can't resume from str

On Tue, 13 Jan 2009, Jeff Chua wrote:
>
> I was trying to bisect further, but ended up with this strange behavior...
>
> # git bisect good a3a798c88a14b35e5d4ca30716dbc9eb9a1ddfe2
> Bisecting: 579 revisions left to test after this
> [079899c2384023cd8efcd3806680b4f1d2abbd54] Btrfs: Change
> find_extent_buffer to use TestSetPageLocked
>
> # ls
> . .. .git fs
>
> Is this a bug or a feature?

You bisected into the btrfs development chain. Just say "git bisect good"
when this happens, and you'll be ok.

[ Unless, of course, you were to be actually trying to bisect a btrfs bug.
If so, you'd need to compile btrfs as a module and insert it and do the
bisection based on that ]

Linus

2009-01-13 03:24:51

by Jaswinder Singh

[permalink] [raw]

Subject: Re: 2.6.29-rc1: Reported regressions from 2.6.28

Hello Rafael,

On Mon, Jan 12, 2009 at 12:30 AM, Rafael J. Wysocki <[email protected]> wrote:
> On Sunday 11 January 2009, Ingo Molnar wrote:
>>
>> * Jaswinder Singh Rajput <[email protected]> wrote:
>>
>> > On Sun, Jan 11, 2009 at 4:42 PM, Rafael J. Wysocki <[email protected]> wrote:
>> > >
>> > > Regressions with patches
>> > > ------------------------
>> > >
>> > > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12428
>> > > Subject : Build error on latest git
>> > > Submitter : Petr Titera <[email protected]>
>> > > Date : 2009-01-11 9:49 (1 days old)
>> > > References : http://marc.info/?l=linux-kernel&m=123166856318712&w=4
>> > > Handled-By : Petr Titera <[email protected]>
>> > > Patch : http://marc.info/?l=linux-kernel&m=123167509024996&w=4
>> >
>> > This is a wrong fix, asm/smp.h should only be included when CONFIG_SMP
>> > is defined.
>> >
>> > I am still in the process of cleaning non-smp data from asm/smp.h for
>> > x86
>> >
>> > Attach patch is the solution for the time being
>> >
>> > Ingo, can you please put this in urgent queue.
>>
>> yes, it already is - see below.
>
> Link to this patch was added to the bug entry. Pleaes let me know or close the
> bug when it's merged.
>

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=4884d8e6a05026ec906355436cea9dc1acb1d09e

--
JSR

2009-01-13 04:28:30

[permalink] [raw]

Subject: Re: [Bug #12422] 2.6.28-git can't resume from str

On Tue, Jan 13, 2009 at 9:28 AM, Ingo Molnar <[email protected]> wrote:
> that's a feature - the btrfs history looks like this. You can mark get out
> of that bisection set by doing this:

On Tue, Jan 13, 2009 at 10:08 AM, Linus Torvalds
<[email protected]> wrote:
>> Is this a bug or a feature?
> You bisected into the btrfs development chain. Just say "git bisect good"
> when this happens, and you'll be ok.

Ingo, Linus,

Thanks for the explanation. For a while, I was repeating the same
thing just thinking my filesystem was corrupted.

Now, I'm can happily continue to bisect further.

Thanks,
Jeff.

2009-01-13 05:47:39

[permalink] [raw]

Subject: Re: [Bug #12422] 2.6.28-git can't resume from str

On Sun, Jan 11, 2009 at 7:16 PM, Rafael J. Wysocki <[email protected]> wrote:

> The following bug entry is on the current list of known regressions
> from 2.6.28. Please verify if it still should be listed and let me know
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12422
> Subject : 2.6.28-git can't resume from str
> Submitter : Jeff Chua <[email protected]>
> Date : 2009-01-10 1:39 (2 days old)
> References : http://marc.info/?l=linux-kernel&m=123155157909282&w=4

Fixed by reverting a0d4922da2e4ccb0973095d8d29f36f6b1b5f703.
7503bfbae89eba07b46441a5d1594647f6b8ab7d has already been reverted in
the Linus's latest git tree.

Thanks everyone for all the help.

Jeff.

2009-01-13 11:23:54

[permalink] [raw]

Subject: Re: 2.6.29-rc1: Reported regressions from 2.6.28

On Tuesday 13 January 2009, Jaswinder Singh Rajput wrote:
> Hello Rafael,
>
> On Mon, Jan 12, 2009 at 12:30 AM, Rafael J. Wysocki <[email protected]> wrote:
> > On Sunday 11 January 2009, Ingo Molnar wrote:
> >>
> >> * Jaswinder Singh Rajput <[email protected]> wrote:
> >>
> >> > On Sun, Jan 11, 2009 at 4:42 PM, Rafael J. Wysocki <[email protected]> wrote:
> >> > >
> >> > > Regressions with patches
> >> > > ------------------------
> >> > >
> >> > > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12428
> >> > > Subject : Build error on latest git
> >> > > Submitter : Petr Titera <[email protected]>
> >> > > Date : 2009-01-11 9:49 (1 days old)
> >> > > References : http://marc.info/?l=linux-kernel&m=123166856318712&w=4
> >> > > Handled-By : Petr Titera <[email protected]>
> >> > > Patch : http://marc.info/?l=linux-kernel&m=123167509024996&w=4
> >> >
> >> > This is a wrong fix, asm/smp.h should only be included when CONFIG_SMP
> >> > is defined.
> >> >
> >> > I am still in the process of cleaning non-smp data from asm/smp.h for
> >> > x86
> >> >
> >> > Attach patch is the solution for the time being
> >> >
> >> > Ingo, can you please put this in urgent queue.
> >>
> >> yes, it already is - see below.
> >
> > Link to this patch was added to the bug entry. Pleaes let me know or close the
> > bug when it's merged.
> >
>
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=4884d8e6a05026ec906355436cea9dc1acb1d09e

Thanks, the bug has been closed.

Rafael

2009-01-13 11:33:20

[permalink] [raw]

Subject: Re: [Bug #12422] 2.6.28-git can't resume from str

On Tuesday 13 January 2009, Jeff Chua wrote:
> On Sun, Jan 11, 2009 at 7:16 PM, Rafael J. Wysocki <[email protected]> wrote:
>
> > The following bug entry is on the current list of known regressions
> > from 2.6.28. Please verify if it still should be listed and let me know
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12422
> > Subject : 2.6.28-git can't resume from str
> > Submitter : Jeff Chua <[email protected]>
> > Date : 2009-01-10 1:39 (2 days old)
> > References : http://marc.info/?l=linux-kernel&m=123155157909282&w=4
>
> Fixed by reverting a0d4922da2e4ccb0973095d8d29f36f6b1b5f703.
> 7503bfbae89eba07b46441a5d1594647f6b8ab7d has already been reverted in
> the Linus's latest git tree.

Can you please check if the issue goes away when you apply the appended patch
instead of reverting commit a0d4922da2e4ccb0973095d8d29f36f6b1b5f703 ?

Rafael

---
drivers/usb/core/hcd-pci.c | 116 ++++++++++----------------------------------
drivers/usb/core/hcd.h | 1
drivers/usb/host/ehci-pci.c | 1
drivers/usb/host/ohci-pci.c | 1
drivers/usb/host/uhci-hcd.c | 1
5 files changed, 27 insertions(+), 93 deletions(-)

Index: linux-2.6/drivers/usb/core/hcd-pci.c
===================================================================
--- linux-2.6.orig/drivers/usb/core/hcd-pci.c
+++ linux-2.6/drivers/usb/core/hcd-pci.c
@@ -201,6 +201,7 @@ int usb_hcd_pci_suspend(struct pci_dev *
struct usb_hcd *hcd = pci_get_drvdata(dev);
int retval = 0;
int wake, w;
+ int has_pci_pm;

/* Root hub suspend should have stopped all downstream traffic,
* and all bus master traffic. And done so for both the interface
@@ -230,6 +231,15 @@ int usb_hcd_pci_suspend(struct pci_dev *

synchronize_irq(dev->irq);

+ /* Downstream ports from this root hub should already be quiesced, so
+ * there will be no DMA activity. Now we can shut down the upstream
+ * link (except maybe for PME# resume signaling) and enter some PCI
+ * low power state, if the hardware allows.
+ */
+ pci_disable_device(dev);
+
+ pci_save_state(dev);
+
/* Don't fail on error to enable wakeup. We rely on pci code
* to reject requests the hardware can't implement, rather
* than coding the same thing.
@@ -241,35 +251,6 @@ int usb_hcd_pci_suspend(struct pci_dev *
wake = w;
dev_dbg(&dev->dev, "wakeup: %d\n", wake);

- /* Downstream ports from this root hub should already be quiesced, so
- * there will be no DMA activity. Now we can shut down the upstream
- * link (except maybe for PME# resume signaling) and enter some PCI
- * low power state, if the hardware allows.
- */
- pci_disable_device(dev);
- done:
- return retval;
-}
-EXPORT_SYMBOL_GPL(usb_hcd_pci_suspend);
-
-/**
- * usb_hcd_pci_suspend_late - suspend a PCI-based HCD after IRQs are disabled
- * @dev: USB Host Controller being suspended
- * @message: Power Management message describing this state transition
- *
- * Store this function in the HCD's struct pci_driver as .suspend_late.
- */
-int usb_hcd_pci_suspend_late(struct pci_dev *dev, pm_message_t message)
-{
- int retval = 0;
- int has_pci_pm;
-
- /* We might already be suspended (runtime PM -- not yet written) */
- if (dev->current_state != PCI_D0)
- goto done;
-
- pci_save_state(dev);
-
/* Don't change state if we don't need to */
if (message.event == PM_EVENT_FREEZE ||
message.event == PM_EVENT_PRETHAW) {
@@ -315,7 +296,7 @@ int usb_hcd_pci_suspend_late(struct pci_
done:
return retval;
}
-EXPORT_SYMBOL_GPL(usb_hcd_pci_suspend_late);
+EXPORT_SYMBOL_GPL(usb_hcd_pci_suspend);

/**
* usb_hcd_pci_resume_early - resume a PCI-based HCD before IRQs are enabled
@@ -325,65 +306,8 @@ EXPORT_SYMBOL_GPL(usb_hcd_pci_suspend_la
*/
int usb_hcd_pci_resume_early(struct pci_dev *dev)
{
- int retval = 0;
- pci_power_t state = dev->current_state;
-
-#ifdef CONFIG_PPC_PMAC
- /* Reenable ASIC clocks for USB */
- if (machine_is(powermac)) {
- struct device_node *of_node;
-
- of_node = pci_device_to_OF_node(dev);
- if (of_node)
- pmac_call_feature(PMAC_FTR_USB_ENABLE,
- of_node, 0, 1);
- }
-#endif
-
- /* NOTE: chip docs cover clean "real suspend" cases (what Linux
- * calls "standby", "suspend to RAM", and so on). There are also
- * dirty cases when swsusp fakes a suspend in "shutdown" mode.
- */
- if (state != PCI_D0) {
-#ifdef DEBUG
- int pci_pm;
- u16 pmcr;
-
- pci_pm = pci_find_capability(dev, PCI_CAP_ID_PM);
- pci_read_config_word(dev, pci_pm + PCI_PM_CTRL, &pmcr);
- pmcr &= PCI_PM_CTRL_STATE_MASK;
- if (pmcr) {
- /* Clean case: power to USB and to HC registers was
- * maintained; remote wakeup is easy.
- */
- dev_dbg(&dev->dev, "resume from PCI D%d\n", pmcr);
- } else {
- /* Clean: HC lost Vcc power, D0 uninitialized
- * + Vaux may have preserved port and transceiver
- * state ... for remote wakeup from D3cold
- * + or not; HCD must reinit + re-enumerate
- *
- * Dirty: D0 semi-initialized cases with swsusp
- * + after BIOS init
- * + after Linux init (HCD statically linked)
- */
- dev_dbg(&dev->dev, "resume from previous PCI D%d\n",
- state);
- }
-#endif
-
- retval = pci_set_power_state(dev, PCI_D0);
- } else {
- /* Same basic cases: clean (powered/not), dirty */
- dev_dbg(&dev->dev, "PCI legacy resume\n");
- }
-
- if (retval < 0)
- dev_err(&dev->dev, "can't resume: %d\n", retval);
- else
- pci_restore_state(dev);
-
- return retval;
+ pci_restore_state(dev);
+ return 0;
}
EXPORT_SYMBOL_GPL(usb_hcd_pci_resume_early);

@@ -398,6 +322,18 @@ int usb_hcd_pci_resume(struct pci_dev *d
struct usb_hcd *hcd;
int retval;

+#ifdef CONFIG_PPC_PMAC
+ /* Reenable ASIC clocks for USB */
+ if (machine_is(powermac)) {
+ struct device_node *of_node;
+
+ of_node = pci_device_to_OF_node(dev);
+ if (of_node)
+ pmac_call_feature(PMAC_FTR_USB_ENABLE,
+ of_node, 0, 1);
+ }
+#endif
+
hcd = pci_get_drvdata(dev);
if (hcd->state != HC_STATE_SUSPENDED) {
dev_dbg(hcd->self.controller,
@@ -405,6 +341,8 @@ int usb_hcd_pci_resume(struct pci_dev *d
return 0;
}

+ pci_enable_wake(dev, PCI_D0, false);
+
retval = pci_enable_device(dev);
if (retval < 0) {
dev_err(&dev->dev, "can't re-enable after resume, %d!\n",
Index: linux-2.6/drivers/usb/core/hcd.h
===================================================================
--- linux-2.6.orig/drivers/usb/core/hcd.h
+++ linux-2.6/drivers/usb/core/hcd.h
@@ -257,7 +257,6 @@ extern void usb_hcd_pci_remove(struct pc

#ifdef CONFIG_PM
extern int usb_hcd_pci_suspend(struct pci_dev *dev, pm_message_t msg);
-extern int usb_hcd_pci_suspend_late(struct pci_dev *dev, pm_message_t msg);
extern int usb_hcd_pci_resume_early(struct pci_dev *dev);
extern int usb_hcd_pci_resume(struct pci_dev *dev);
#endif /* CONFIG_PM */
Index: linux-2.6/drivers/usb/host/ehci-pci.c
===================================================================
--- linux-2.6.orig/drivers/usb/host/ehci-pci.c
+++ linux-2.6/drivers/usb/host/ehci-pci.c
@@ -432,7 +432,6 @@ static struct pci_driver ehci_pci_driver

#ifdef CONFIG_PM
.suspend = usb_hcd_pci_suspend,
- .suspend_late = usb_hcd_pci_suspend_late,
.resume_early = usb_hcd_pci_resume_early,
.resume = usb_hcd_pci_resume,
#endif
Index: linux-2.6/drivers/usb/host/ohci-pci.c
===================================================================
--- linux-2.6.orig/drivers/usb/host/ohci-pci.c
+++ linux-2.6/drivers/usb/host/ohci-pci.c
@@ -487,7 +487,6 @@ static struct pci_driver ohci_pci_driver

#ifdef CONFIG_PM
.suspend = usb_hcd_pci_suspend,
- .suspend_late = usb_hcd_pci_suspend_late,
.resume_early = usb_hcd_pci_resume_early,
.resume = usb_hcd_pci_resume,
#endif
Index: linux-2.6/drivers/usb/host/uhci-hcd.c
===================================================================
--- linux-2.6.orig/drivers/usb/host/uhci-hcd.c
+++ linux-2.6/drivers/usb/host/uhci-hcd.c
@@ -942,7 +942,6 @@ static struct pci_driver uhci_pci_driver

#ifdef CONFIG_PM
.suspend = usb_hcd_pci_suspend,
- .suspend_late = usb_hcd_pci_suspend_late,
.resume_early = usb_hcd_pci_resume_early,
.resume = usb_hcd_pci_resume,
#endif /* PM */

2009-01-13 13:30:28

[permalink] [raw]

Subject: Re: [Bug #12422] 2.6.28-git can't resume from str

On Tue, Jan 13, 2009 at 7:32 PM, Rafael J. Wysocki <[email protected]> wrote:
> On Tuesday 13 January 2009, Jeff Chua wrote:
>> On Sun, Jan 11, 2009 at 7:16 PM, Rafael J. Wysocki <[email protected]> wrote:
>>
>> > The following bug entry is on the current list of known regressions
>> > from 2.6.28. Please verify if it still should be listed and let me know
>> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12422
>> > Subject : 2.6.28-git can't resume from str
>> > Submitter : Jeff Chua <[email protected]>
>> > Date : 2009-01-10 1:39 (2 days old)
>> > References : http://marc.info/?l=linux-kernel&m=123155157909282&w=4
>>
>> Fixed by reverting a0d4922da2e4ccb0973095d8d29f36f6b1b5f703.
>> 7503bfbae89eba07b46441a5d1594647f6b8ab7d has already been reverted in
>> the Linus's latest git tree.
>
> Can you please check if the issue goes away ...
> instead of reverting commit a0d4922da2e4ccb0973095d8d29f36f6b1b5f703

Confirmed. This commit works. STR still ok.

But now, a different problem. STD "almost" ok. Suspend-to-disk hangs
after counting to 100%. Power-cycle and boot ok able to resume. ...
Again, this is another problem with/without your latest patch. Another
issue is with iwl4965 not able to attach to my hidden AP. Will try to
bisect soon.

Thanks for the patch.

Jeff.

2009-01-14 07:35:37

by Oleksij Rempel

[permalink] [raw]

Subject: Re: [Bug #12420] WARNING: at drivers/ata/libata-sff.c:1017 ata_sff_hsm_move+0x45e/0x750()

2009-01-14 07:39:15

by Oleksij Rempel

[permalink] [raw]

Subject: Re: [Bug #12417] glx performance drop with: "x86: PAT: implement track/untrack of pfnmap regions for x86 - v3"

2009-01-14 07:41:53

[permalink] [raw]

Subject: Re: [Bug #12420] WARNING: at drivers/ata/libata-sff.c:1017 ata_sff_hsm_move+0x45e/0x750()

Am Mittwoch 14 Januar 2009 schrieb Alexey Rempel:
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12420
> > Subject : WARNING: at drivers/ata/libata-sff.c:1017
ata_sff_hsm_move+0x45e/0x750()
> > Submitter : Christian Borntraeger <[email protected]>
> > Date : 2009-01-09 12:34 (3 days old)
> > First-Bad-Commit:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=871af1210f13966ab911ed2166e4ab2ce775b99d
> > References : http://marc.info/?l=linux-kernel&m=123150457832109&w=4

> This warning was disabled in latest git.

Yes. After the discussion had a conclusion, I decided to to send a patch
myself and Jeff sent it to Linus.

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=a0f79f7ad3e52b908786462cf5446ebe20fe14fa

2009-01-14 07:50:46

by Pallipadi, Venkatesh

[permalink] [raw]

Subject: RE: [Bug #12417] glx performance drop with: "x86: PAT: implement track/untrack of pfnmap regions for x86 - v3"

>-----Original Message-----
>From: Alexey Fisher [mailto:[email protected]]
>Sent: Tuesday, January 13, 2009 11:39 PM
>To: Rafael J. Wysocki
>Cc: Linux Kernel Mailing List; Kernel Testers List; H. Peter
>Anvin; Pallipadi, Venkatesh; Siddha, Suresh B
>Subject: Re: [Bug #12417] glx performance drop with: "x86:
>PAT: implement track/untrack of pfnmap regions for x86 - v3"
>
>Rafael J. Wysocki schrieb:
>> This message has been generated automatically as a part of a report
>> of recent regressions.
>>
>> The following bug entry is on the current list of known regressions
>> from 2.6.28. Please verify if it still should be listed and
>let me know
>> (either way).
>>
>>
>> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12417
>> Subject : glx performance drop with: "x86: PAT:
>implement track/untrack of pfnmap regions for x86 - v3"
>> Submitter : Alexey Fisher <[email protected]>
>> Date : 2009-01-06 18:46 (6 days old)
>> First-Bad-Commit:
>http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.gi
>t;a=commit;h=5899329b19100c0b82dc78e9b21ed8b920c9ffb3
>> References : http://marc.info/?l=linux-kernel&m=123126782822696&w=4
>> Handled-By : Pallipadi, Venkatesh <[email protected]>
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe
>kernel-testers" in
>> the body of a message to [email protected]
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>There is no more warnings on the xorg start, but x server will
>completly
>freeze on glxgears.
>

Yes. But, that is a different bug with DRM changes. This fix just unmasks the bug now.

http://bugzilla.kernel.org/show_bug.cgi?id=12418

Thanks,
Venki-

2009-01-14 10:59:26

[permalink] [raw]

Subject: Re: [Bug #12420] WARNING: at drivers/ata/libata-sff.c:1017 ata_sff_hsm_move+0x45e/0x750()

On Wednesday 14 January 2009, Christian Borntraeger wrote:
> Am Mittwoch 14 Januar 2009 schrieb Alexey Rempel:
> > > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12420
> > > Subject : WARNING: at drivers/ata/libata-sff.c:1017
> ata_sff_hsm_move+0x45e/0x750()
> > > Submitter : Christian Borntraeger <[email protected]>
> > > Date : 2009-01-09 12:34 (3 days old)
> > > First-Bad-Commit:
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=871af1210f13966ab911ed2166e4ab2ce775b99d
> > > References : http://marc.info/?l=linux-kernel&m=123150457832109&w=4
>
>
> > This warning was disabled in latest git.
>
> Yes. After the discussion had a conclusion, I decided to to send a patch
> myself and Jeff sent it to Linus.
>
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=a0f79f7ad3e52b908786462cf5446ebe20fe14fa

Thanks, closed.

Rafael

2009-01-18 15:49:46