2023-02-09 09:50:22

by Oliver Graute

Subject: [PATCH RFC] linux: net: phy: realtek: changing LED behaviour for RTL8211F

This enable the LEDs for network activity and 100/1000Link for the RTL8211F

Signed-off-by: Oliver Graute <[email protected]>
---
drivers/net/phy/realtek.c | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c
index 3d99fd6664d7..5c796883cad3 100644
--- a/drivers/net/phy/realtek.c
+++ b/drivers/net/phy/realtek.c
@@ -416,6 +416,11 @@ static int rtl8211f_config_init(struct phy_device *phydev)
}
}

+ phy_write(phydev, RTL821x_PAGE_SELECT, 0xd04);
+ phy_write(phydev, 0x10, 0x15B);
+
+ phy_write(phydev, RTL821x_PAGE_SELECT, 0x0);
+
return genphy_soft_reset(phydev);
}

--
2.17.1

2023-02-09 10:58:52

by Simon Horman

Subject: Re: [PATCH RFC] linux: net: phy: realtek: changing LED behaviour for RTL8211F

On Thu, Feb 09, 2023 at 10:44:05AM +0100, Oliver Graute wrote:
> This enable the LEDs for network activity and 100/1000Link for the RTL8211F
>
> Signed-off-by: Oliver Graute <[email protected]>
> ---
> drivers/net/phy/realtek.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c
> index 3d99fd6664d7..5c796883cad3 100644
> --- a/drivers/net/phy/realtek.c
> +++ b/drivers/net/phy/realtek.c
> @@ -416,6 +416,11 @@ static int rtl8211f_config_init(struct phy_device *phydev)
> }
> }
>
> + phy_write(phydev, RTL821x_PAGE_SELECT, 0xd04);
> + phy_write(phydev, 0x10, 0x15B);
> +
> + phy_write(phydev, RTL821x_PAGE_SELECT, 0x0);
> +

nit: it looks like the indentation in the new lines above should
be using a single tab rather than 8 spaces.

> return genphy_soft_reset(phydev);
> }
>
> --
> 2.17.1
>

2023-02-09 12:39:40

by Oliver Graute

Subject: Re: [PATCH RFC] linux: net: phy: realtek: changing LED behaviour for RTL8211F

On 09/02/23, Simon Horman wrote:
> On Thu, Feb 09, 2023 at 10:44:05AM +0100, Oliver Graute wrote:
> > This enable the LEDs for network activity and 100/1000Link for the RTL8211F
> >
> > Signed-off-by: Oliver Graute <[email protected]>
> > ---
> > drivers/net/phy/realtek.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c
> > index 3d99fd6664d7..5c796883cad3 100644
> > --- a/drivers/net/phy/realtek.c
> > +++ b/drivers/net/phy/realtek.c
> > @@ -416,6 +416,11 @@ static int rtl8211f_config_init(struct phy_device *phydev)
> > }
> > }
> >
> > + phy_write(phydev, RTL821x_PAGE_SELECT, 0xd04);
> > + phy_write(phydev, 0x10, 0x15B);
> > +
> > + phy_write(phydev, RTL821x_PAGE_SELECT, 0x0);
> > +
>
> nit: it looks like the indentation in the new lines above should
> be using a single tab rather than 8 spaces.

thx, I will fix the indentation.

is this the right place to turn on the realtek phy LEDs for RTL8211F?

Best regards,

Oliver

2023-02-09 13:30:15

by Michael Walle

Subject: Re: [PATCH RFC] linux: net: phy: realtek: changing LED behaviour for RTL8211F

> is this the right place to turn on the realtek phy LEDs for RTL8211F?

Probably not. There are a few issues. This will only work one particular
board. Therefore, you'd need some kind of runtime configuration to also
support other boards. But lately any LED related patches for PHYs were
NAK'd because they need to integrate with the LED subsystem. See [1].

-michael

[1] https://lore.kernel.org/r/[email protected]/

2023-02-09 14:20:28

by Oliver Graute

Subject: Re: [PATCH RFC] linux: net: phy: realtek: changing LED behaviour for RTL8211F

On 09/02/23, Michael Walle wrote:
> > is this the right place to turn on the realtek phy LEDs for RTL8211F?
>
> Probably not. There are a few issues. This will only work one particular
> board. Therefore, you'd need some kind of runtime configuration to also
> support other boards. But lately any LED related patches for PHYs were
> NAK'd because they need to integrate with the LED subsystem. See [1].
>
> -michael
>
> [1] https://lore.kernel.org/r/[email protected]/

ok thx for this information.

Best Regards,

Oliver