Add support for winbond w25q01jv-im chip.
Signed-off-by: Delphine CC Chiu <[email protected]>
---
drivers/mtd/spi-nor/winbond.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
index ffaa24055259..2b02b05ceb0a 100644
--- a/drivers/mtd/spi-nor/winbond.c
+++ b/drivers/mtd/spi-nor/winbond.c
@@ -139,6 +139,9 @@ static const struct flash_info winbond_nor_parts[] = {
{ "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024)
NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
SPI_NOR_QUAD_READ) },
+ { "w25q01jv-im", INFO(0xef7021, 0, 64 * 1024, 2048)
+ NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
+ SPI_NOR_QUAD_READ) },
};
/**
--
2.25.1
Hi,
Am 2022-10-06 09:08, schrieb Delphine CC Chiu:
> Add support for winbond w25q01jv-im chip.
>
> Signed-off-by: Delphine CC Chiu <[email protected]>
> ---
> drivers/mtd/spi-nor/winbond.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/winbond.c
> b/drivers/mtd/spi-nor/winbond.c
> index ffaa24055259..2b02b05ceb0a 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -139,6 +139,9 @@ static const struct flash_info winbond_nor_parts[]
> = {
> { "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024)
> NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> SPI_NOR_QUAD_READ) },
> + { "w25q01jv-im", INFO(0xef7021, 0, 64 * 1024, 2048)
The name should be w25q01jvm.
> + NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> + SPI_NOR_QUAD_READ) },
That flash should support SFDP, so please try the following:
+ { "w25q01jvm", INFO(0xef7021, 0, 0, 0) PARSE_SFDP },
Also, we require an SFDP dump for new flash submissions, see [1].
-michael
[1]
https://lore.kernel.org/linux-mtd/[email protected]/
On Thu, Oct 06, 2022 at 01:52:33PM +0200, Michael Walle wrote:
> Hi,
>
> Am 2022-10-06 09:08, schrieb Delphine CC Chiu:
> > Add support for winbond w25q01jv-im chip.
> >
> > Signed-off-by: Delphine CC Chiu <[email protected]>
> > ---
> > drivers/mtd/spi-nor/winbond.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/mtd/spi-nor/winbond.c
> > b/drivers/mtd/spi-nor/winbond.c
> > index ffaa24055259..2b02b05ceb0a 100644
> > --- a/drivers/mtd/spi-nor/winbond.c
> > +++ b/drivers/mtd/spi-nor/winbond.c
> > @@ -139,6 +139,9 @@ static const struct flash_info winbond_nor_parts[]
> > = {
> > { "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024)
> > NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> > SPI_NOR_QUAD_READ) },
> > + { "w25q01jv-im", INFO(0xef7021, 0, 64 * 1024, 2048)
>
> The name should be w25q01jvm.
>
> > + NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> > + SPI_NOR_QUAD_READ) },
>
> That flash should support SFDP, so please try the following:
> + { "w25q01jvm", INFO(0xef7021, 0, 0, 0) PARSE_SFDP },
>
> Also, we require an SFDP dump for new flash submissions, see [1].
>
> -michael
>
> [1]
> https://lore.kernel.org/linux-mtd/[email protected]/
It looks like this was already attempted to be added:
https://lore.kernel.org/all/[email protected]/
Potin, do you have an update?
--
Patrick Williams
On Thu, Oct 06, 2022 at 01:52:33PM +0200, Michael Walle wrote:
> Hi,
>
> Am 2022-10-06 09:08, schrieb Delphine CC Chiu:
> > Add support for winbond w25q01jv-im chip.
> >
> > Signed-off-by: Delphine CC Chiu <[email protected]>
> > ---
> > drivers/mtd/spi-nor/winbond.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/mtd/spi-nor/winbond.c
> > b/drivers/mtd/spi-nor/winbond.c
> > index ffaa24055259..2b02b05ceb0a 100644
> > --- a/drivers/mtd/spi-nor/winbond.c
> > +++ b/drivers/mtd/spi-nor/winbond.c
> > @@ -139,6 +139,9 @@ static const struct flash_info winbond_nor_parts[]
> > = {
> > { "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024)
> > NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> > SPI_NOR_QUAD_READ) },
> > + { "w25q01jv-im", INFO(0xef7021, 0, 64 * 1024, 2048)
>
> The name should be w25q01jvm.
>
> > + NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> > + SPI_NOR_QUAD_READ) },
>
> That flash should support SFDP, so please try the following:
> + { "w25q01jvm", INFO(0xef7021, 0, 0, 0) PARSE_SFDP },
It seems like QEMU doesn't support SFDP yet. Is using PARSE_SFDP a hard
requirement or can we delay until the QEMU support can be written?
--
Patrick Williams
On Thu, Oct 06, 2022 at 03:40:48PM -0500, Patrick Williams wrote:
> On Thu, Oct 06, 2022 at 01:52:33PM +0200, Michael Walle wrote:
> > Hi,
> >
> > Am 2022-10-06 09:08, schrieb Delphine CC Chiu:
> > > Add support for winbond w25q01jv-im chip.
> > >
> > > Signed-off-by: Delphine CC Chiu <[email protected]>
> > > ---
> > > drivers/mtd/spi-nor/winbond.c | 3 +++
> > > 1 file changed, 3 insertions(+)
> > >
> > > diff --git a/drivers/mtd/spi-nor/winbond.c
> > > b/drivers/mtd/spi-nor/winbond.c
> > > index ffaa24055259..2b02b05ceb0a 100644
> > > --- a/drivers/mtd/spi-nor/winbond.c
> > > +++ b/drivers/mtd/spi-nor/winbond.c
> > > @@ -139,6 +139,9 @@ static const struct flash_info winbond_nor_parts[]
> > > = {
> > > { "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024)
> > > NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> > > SPI_NOR_QUAD_READ) },
> > > + { "w25q01jv-im", INFO(0xef7021, 0, 64 * 1024, 2048)
> >
> > The name should be w25q01jvm.
> >
> > > + NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> > > + SPI_NOR_QUAD_READ) },
> >
> > That flash should support SFDP, so please try the following:
> > + { "w25q01jvm", INFO(0xef7021, 0, 0, 0) PARSE_SFDP },
>
> It seems like QEMU doesn't support SFDP yet. Is using PARSE_SFDP a hard
> requirement or can we delay until the QEMU support can be written?
It turns out that there is some tentative support in QEMU for giving
SFDP information now. I've sent a patch building on top of that for the
w25q01jvq chip and updated Potin's patch-set to v4 that I mentioned
elsewhere in this thread.
It looks like the w25q01jvq I pointed to in Potin's patch-set and the
w25q01jvm being proposed here are slightly different chips.
--
Patrick Williams