ethtool expects ETHTOOL_GRXCLSRLALL to set ethtool_rxnfc->data with the
total number of entries in the rx classifier table. Surprisingly, mlx4
is missing this part (in principle ethtool could still move forward and
try the insert).
Tested: compiled and run command:
phh13:~# ethtool -N eth1 flow-type udp4 queue 4
Added rule with ID 255
Signed-off-by: Luigi Rizzo <[email protected]>
Change-Id: I18a72f08dfcfb6b9f6aa80fbc12d58553e1fda76
---
drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c b/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c
index d8313e2ee6002..c12da02c2d1bd 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c
@@ -1745,6 +1745,7 @@ static int mlx4_en_get_rxnfc(struct net_device *dev, struct ethtool_rxnfc *cmd,
err = mlx4_en_get_flow(dev, cmd, cmd->fs.location);
break;
case ETHTOOL_GRXCLSRLALL:
+ cmd->data = MAX_NUM_OF_FS_RULES;
while ((!err || err == -ENOENT) && priority < cmd->rule_cnt) {
err = mlx4_en_get_flow(dev, cmd, i);
if (!err)
--
2.24.0.432.g9d3f5f5b63-goog
From: Luigi Rizzo <[email protected]>
Date: Fri, 15 Nov 2019 12:12:25 -0800
> ethtool expects ETHTOOL_GRXCLSRLALL to set ethtool_rxnfc->data with the
> total number of entries in the rx classifier table. Surprisingly, mlx4
> is missing this part (in principle ethtool could still move forward and
> try the insert).
>
> Tested: compiled and run command:
> phh13:~# ethtool -N eth1 flow-type udp4 queue 4
> Added rule with ID 255
>
> Signed-off-by: Luigi Rizzo <[email protected]>
> Change-Id: I18a72f08dfcfb6b9f6aa80fbc12d58553e1fda76
Luigi, _always_ CC: the appropriate maintainer when making changes to the
kernel, as per the top-level MAINTAINERS file.
Tariq et al., please review.
On 11/16/2019 11:10 PM, David Miller wrote:
> From: Luigi Rizzo <[email protected]>
> Date: Fri, 15 Nov 2019 12:12:25 -0800
>
>> ethtool expects ETHTOOL_GRXCLSRLALL to set ethtool_rxnfc->data with the
>> total number of entries in the rx classifier table. Surprisingly, mlx4
>> is missing this part (in principle ethtool could still move forward and
>> try the insert).
>>
>> Tested: compiled and run command:
>> phh13:~# ethtool -N eth1 flow-type udp4 queue 4
>> Added rule with ID 255
>>
>> Signed-off-by: Luigi Rizzo <[email protected]>
>> Change-Id: I18a72f08dfcfb6b9f6aa80fbc12d58553e1fda76
>
> Luigi, _always_ CC: the appropriate maintainer when making changes to the
> kernel, as per the top-level MAINTAINERS file.
>
> Tariq et al., please review.
>
Reviewed-by: Tariq Toukan <[email protected]>
Thanks for your patch.
Tariq
On 16/11/2019 23:10, David Miller wrote:
> From: Luigi Rizzo <[email protected]>
> Date: Fri, 15 Nov 2019 12:12:25 -0800
>
>> ethtool expects ETHTOOL_GRXCLSRLALL to set ethtool_rxnfc->data with the
>> total number of entries in the rx classifier table. Surprisingly, mlx4
>> is missing this part (in principle ethtool could still move forward and
>> try the insert).
>>
>> Tested: compiled and run command:
>> phh13:~# ethtool -N eth1 flow-type udp4 queue 4
>> Added rule with ID 255
>>
>> Signed-off-by: Luigi Rizzo <[email protected]>
>> Change-Id: I18a72f08dfcfb6b9f6aa80fbc12d58553e1fda76
>
> Luigi, _always_ CC: the appropriate maintainer when making changes to the
> kernel, as per the top-level MAINTAINERS file.
You should also remove the Change-Id tag before submission.
From: Tariq Toukan <[email protected]>
Date: Sun, 17 Nov 2019 14:46:50 +0000
>
>
> On 11/16/2019 11:10 PM, David Miller wrote:
>> From: Luigi Rizzo <[email protected]>
>> Date: Fri, 15 Nov 2019 12:12:25 -0800
>>
>>> ethtool expects ETHTOOL_GRXCLSRLALL to set ethtool_rxnfc->data with the
>>> total number of entries in the rx classifier table. Surprisingly, mlx4
>>> is missing this part (in principle ethtool could still move forward and
>>> try the insert).
>>>
>>> Tested: compiled and run command:
>>> phh13:~# ethtool -N eth1 flow-type udp4 queue 4
>>> Added rule with ID 255
>>>
>>> Signed-off-by: Luigi Rizzo <[email protected]>
>>> Change-Id: I18a72f08dfcfb6b9f6aa80fbc12d58553e1fda76
>>
>> Luigi, _always_ CC: the appropriate maintainer when making changes to the
>> kernel, as per the top-level MAINTAINERS file.
>>
>> Tariq et al., please review.
>>
>
> Reviewed-by: Tariq Toukan <[email protected]>
Applied and queued up for -stable, with Change-Id: removed.
On Sun, Nov 17, 2019 at 10:29 AM David Miller <[email protected]> wrote:
>
> From: Tariq Toukan <[email protected]>
> Date: Sun, 17 Nov 2019 14:46:50 +0000
>
> >
> >
> > On 11/16/2019 11:10 PM, David Miller wrote:
> >> From: Luigi Rizzo <[email protected]>
> >> Date: Fri, 15 Nov 2019 12:12:25 -0800
> >>
> >>> ethtool expects ETHTOOL_GRXCLSRLALL to set ethtool_rxnfc->data with the
> >>> total number of entries in the rx classifier table. Surprisingly, mlx4
> >>> is missing this part (in principle ethtool could still move forward and
> >>> try the insert).
> >>>
> >>> Tested: compiled and run command:
> >>> phh13:~# ethtool -N eth1 flow-type udp4 queue 4
> >>> Added rule with ID 255
> >>>
> >>> Signed-off-by: Luigi Rizzo <[email protected]>
> >>> Change-Id: I18a72f08dfcfb6b9f6aa80fbc12d58553e1fda76
> >>
> >> Luigi, _always_ CC: the appropriate maintainer when making changes to the
> >> kernel, as per the top-level MAINTAINERS file.
> >>
> >> Tariq et al., please review.
> >>
> >
> > Reviewed-by: Tariq Toukan <[email protected]>
>
> Applied and queued up for -stable, with Change-Id: removed.
Thank you all, apologies for mistakes.
cheers
luigi