We need to pass struct netlink_skb_parms as parameter for
cn_proc_mcast_ctl, which
is a callback function supposed to take two parameter. Fixes the
following warning and
a kernel-doc notation of the function.
CC drivers/connector/cn_proc.o
drivers/connector/cn_proc.c: In function `cn_proc_init':
drivers/connector/cn_proc.c:263: warning: passing arg 3 of
`cn_add_callback' from incompatible pointer type
----
Signed-off-by: Rakib Mullick <[email protected]>
--- linus/drivers/connector/cn_proc.c 2009-10-09 17:38:22.000000000 +0600
+++ rakib/drivers/connector/cn_proc.c 2009-10-12 09:45:33.000000000 +0600
@@ -225,9 +225,10 @@ static void cn_proc_ack(int err, int rcv
/**
* cn_proc_mcast_ctl
- * @data: message sent from userspace via the connector
+ * @msg: message sent from userspace via the connector
+ * @nsp: remains unused but we need it to keep it
*/
-static void cn_proc_mcast_ctl(struct cn_msg *msg)
+static void cn_proc_mcast_ctl(struct cn_msg *msg, struct
netlink_skb_parms *nsp)
{
enum proc_cn_mcast_op *mc_op = NULL;
int err = 0;
From: Rakib Mullick <[email protected]>
Date: Mon, 12 Oct 2009 08:44:33 +0600
> */
> -static void cn_proc_mcast_ctl(struct cn_msg *msg)
> +static void cn_proc_mcast_ctl(struct cn_msg *msg, struct
> netlink_skb_parms *nsp)
Your patches are unusable because your email client corrupts the
patch, here you can see it is splitting up long lines.
Please fix this up and resubmit.
On 10/12/09, David Miller <[email protected]> wrote:
> From: Rakib Mullick <[email protected]>
> Date: Mon, 12 Oct 2009 08:44:33 +0600
>
>
> > */
> > -static void cn_proc_mcast_ctl(struct cn_msg *msg)
> > +static void cn_proc_mcast_ctl(struct cn_msg *msg, struct
> > netlink_skb_parms *nsp)
>
>
> Your patches are unusable because your email client corrupts the
> patch, here you can see it is splitting up long lines.
>
> Please fix this up and resubmit.
Oops..... sorry for that. This is the second time I'm facing this
problem. I'll try to fix it.
I'm resubmitting the patch. Here I've recreate the patch to split the
line into two.
And it just reaches its 80 line mark. Hopefully it will be okay.
Thanks,
----
Signed-off-by: Rakib Mullick <[email protected]>
--- linus/drivers/connector/cn_proc.c 2009-10-09 17:38:22.000000000 +0600
+++ rakib/drivers/connector/cn_proc.c 2009-10-13 12:29:37.000000000 +0600
@@ -225,9 +225,11 @@ static void cn_proc_ack(int err, int rcv
/**
* cn_proc_mcast_ctl
- * @data: message sent from userspace via the connector
+ * @msg: message sent from userspace via the connector
+ * @nsp: remains unused but we need it to keep it
*/
-static void cn_proc_mcast_ctl(struct cn_msg *msg)
+static void cn_proc_mcast_ctl(struct cn_msg *msg,
+ struct netlink_skb_parms *nsp)
{
enum proc_cn_mcast_op *mc_op = NULL;
int err = 0;
From: Rakib Mullick <[email protected]>
Date: Tue, 13 Oct 2009 11:27:49 +0600
> On 10/12/09, David Miller <[email protected]> wrote:
>> From: Rakib Mullick <[email protected]>
>> Date: Mon, 12 Oct 2009 08:44:33 +0600
>>
>>
>> > */
>> > -static void cn_proc_mcast_ctl(struct cn_msg *msg)
>> > +static void cn_proc_mcast_ctl(struct cn_msg *msg, struct
>> > netlink_skb_parms *nsp)
>>
>>
>> Your patches are unusable because your email client corrupts the
>> patch, here you can see it is splitting up long lines.
>>
>> Please fix this up and resubmit.
> Oops..... sorry for that. This is the second time I'm facing this
> problem. I'll try to fix it.
> I'm resubmitting the patch. Here I've recreate the patch to split the
> line into two.
> And it just reaches its 80 line mark. Hopefully it will be okay.
Upstream and my net-next-2.6 tree both have this function with
the proper parameters, maybe Andrew's -mm tree had some conflicts
and they weren't dealt with correctly.
On 10/13/09, David Miller <[email protected]> wrote:
> From: Rakib Mullick <[email protected]>
>
> Date: Tue, 13 Oct 2009 11:27:49 +0600
>
>
> > On 10/12/09, David Miller <[email protected]> wrote:
> >> From: Rakib Mullick <[email protected]>
> >> Date: Mon, 12 Oct 2009 08:44:33 +0600
> >>
> >>
> >> > */
> >> > -static void cn_proc_mcast_ctl(struct cn_msg *msg)
> >> > +static void cn_proc_mcast_ctl(struct cn_msg *msg, struct
> >> > netlink_skb_parms *nsp)
> >>
> >>
> >> Your patches are unusable because your email client corrupts the
> >> patch, here you can see it is splitting up long lines.
> >>
> >> Please fix this up and resubmit.
> > Oops..... sorry for that. This is the second time I'm facing this
> > problem. I'll try to fix it.
> > I'm resubmitting the patch. Here I've recreate the patch to split the
> > line into two.
> > And it just reaches its 80 line mark. Hopefully it will be okay.
>
>
> Upstream and my net-next-2.6 tree both have this function with
> the proper parameters, maybe Andrew's -mm tree had some conflicts
> and they weren't dealt with correctly.
>
Ah, sorry again. I should've check the upstream first. Sorry for noise.
Thanks,