2023-03-09 20:48:24

by Martin Kepplinger

[permalink] [raw]
Subject: [PATCH v1 00/14] arm64: dts: imx8mq-librem5: updates and fixes until march 2023

hi Shawn and all interested in the Librem 5 phone,

This is another round of updates to the phone DT description. Some are
clear fixes, but some are important updates like the CSI changes
that make the selfie cam work or the powersaving related things like
the ddrc opp table entry and voltage changes.

As previously this is all mixed together because the changes are small.
If you prefer separate, small "topic-patchsets", please say so.

thanks,
martin


Angus Ainslie (1):
arm64: dts: imx8mq-librem5: add the magnetometer mount matrix

Martin Kepplinger (4):
arm64: dts: imx8mq-librem5: lower the mipi csi 1 frequencies
arm64: dts: imx8mq-librem5: describe the clock for the csi sensors
arm64: dts: imx8mq-librem5: fix audio-1v8 regulator name
arm64: dts: imx8mq-librem5: add brightness levels to led-backlight

Sebastian Krzyszkowiak (9):
arm64: dts: imx8mq-librem5: Describe MIC_2V4 regulator
arm64: dts: imx8mq-librem5: Set charger parameters for each batch
arm64: dts: imx8mq-librem5: Set the DVS voltages lower
arm64: dts: imx8mq-librem5: Bump usdhc2 frequency to 100MHz
arm64: dts: imx8mq-librem5: Adjust proximity sensor's near levels
arm64: dts: imx8mq-librem5: Remove dis_u3_susphy_quirk from usb_dwc3_0
arm64: dts: imx8mq-librem5: Bump BUCK1 suspend voltage to 0.81V
arm64: dts: imx8mq-librem5: Reduce I2C frequency to 384kHz
arm64: dts: imx8mq-librem5: Add 166MHz to DDRC OPP table

.../boot/dts/freescale/imx8mq-librem5-r2.dts | 12 ++--
.../boot/dts/freescale/imx8mq-librem5-r3.dts | 2 +-
.../boot/dts/freescale/imx8mq-librem5-r3.dtsi | 10 ++-
.../boot/dts/freescale/imx8mq-librem5-r4.dts | 2 +-
.../boot/dts/freescale/imx8mq-librem5.dtsi | 70 ++++++++++++++-----
5 files changed, 67 insertions(+), 29 deletions(-)

--
2.30.2



2023-03-09 20:48:24

by Martin Kepplinger

[permalink] [raw]
Subject: [PATCH v1 06/14] arm64: dts: imx8mq-librem5: Set charger parameters for each batch

From: Sebastian Krzyszkowiak <[email protected]>

Correctly set regulation-voltage, termination-current and charge-current
for the different librem 5 board revisions.

Signed-off-by: Sebastian Krzyszkowiak <[email protected]>
Signed-off-by: Martin Kepplinger <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dts | 10 ++++------
arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dtsi | 2 --
arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 4 +++-
3 files changed, 7 insertions(+), 9 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dts
index 73bd431cbd6a8..4f69eb32b1c90 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dts
@@ -12,18 +12,16 @@ / {
compatible = "purism,librem5r2", "purism,librem5", "fsl,imx8mq";
};

-&bq25895 {
- ti,battery-regulation-voltage = <4192000>; /* uV */
- ti,charge-current = <1600000>; /* uA */
- ti,termination-current = <66000>; /* uA */
-};
-
&accel_gyro {
mount-matrix = "1", "0", "0",
"0", "-1", "0",
"0", "0", "1";
};

+&bq25895 {
+ ti,charge-current = <1600000>; /* uA */
+};
+
&proximity {
proximity-near-level = <120>;
};
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dtsi
index e4f8b47cce4f5..c1279e96effd7 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dtsi
@@ -22,9 +22,7 @@ &accel_gyro {
};

&bq25895 {
- ti,battery-regulation-voltage = <4200000>; /* uV */
ti,charge-current = <1500000>; /* uA */
- ti,termination-current = <144000>; /* uA */
};

&camera_front {
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
index f8698b6995343..509776a63259b 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
@@ -1147,7 +1147,9 @@ bq25895: charger@6a {
interrupt-parent = <&gpio3>;
interrupts = <3 IRQ_TYPE_EDGE_FALLING>;
phys = <&usb3_phy0>;
- ti,precharge-current = <130000>; /* uA */
+ ti,battery-regulation-voltage = <4208000>; /* uV */
+ ti,termination-current = <128000>; /* uA */
+ ti,precharge-current = <128000>; /* uA */
ti,minimum-sys-voltage = <3700000>; /* uV */
ti,boost-voltage = <5000000>; /* uV */
ti,boost-max-current = <1500000>; /* uA */
--
2.30.2


2023-03-09 20:49:00

by Martin Kepplinger

[permalink] [raw]
Subject: [PATCH v1 08/14] arm64: dts: imx8mq-librem5: add the magnetometer mount matrix

From: Angus Ainslie <[email protected]>

Userland needs the mount matrix to know the correct orientation of
the part.

Signed-off-by: Angus Ainslie <[email protected]>
Signed-off-by: Martin Kepplinger <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dtsi | 6 ++++++
arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dtsi
index c1279e96effd7..db81ed699de75 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dtsi
@@ -38,6 +38,12 @@ MX8MQ_IOMUXC_SPDIF_RX_GPIO5_IO4 0x83
};
};

+&magnetometer {
+ mount-matrix = "1", "0", "0",
+ "0", "-1", "0",
+ "0", "0", "-1";
+};
+
&proximity {
proximity-near-level = <25>;
};
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
index eaf35cff2f8a6..7e470135b86a4 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
@@ -981,7 +981,7 @@ &i2c2 {
pinctrl-0 = <&pinctrl_i2c2>;
status = "okay";

- magnetometer@1e {
+ magnetometer: magnetometer@1e {
compatible = "st,lsm9ds1-magn";
reg = <0x1e>;
pinctrl-names = "default";
--
2.30.2


2023-03-09 20:49:31

by Martin Kepplinger

[permalink] [raw]
Subject: [PATCH v1 07/14] arm64: dts: imx8mq-librem5: Set the DVS voltages lower

From: Sebastian Krzyszkowiak <[email protected]>

They're still in the operating range according to i.MX 8M Quad
datasheet. There's some headroom added over minimal values to
account for voltage drop.

Operational ranges (min - typ - max [selected]):
- VDD_SOC (BUCK1): 0.81 - 0.9 - 0.99 [0.88]
- VDD_ARM (BUCK2): 0.81 - 0.9 - 1.05 [0.84] (1000MHz)
0.90 - 1.0 - 1.05 [0.93] (1500MHz)
- VDD_GPU (BUCK3): 0.81 - 0.9 - 1.05 [0.85] (800MHz)
0.90 - 1.0 - 1.05 [ -- ] (1000MHz)
- VDD_VPU (BUCK4): 0.81 - 0.9 - 1.05 [ -- ] (550/500/588MHz)
0.90 - 1.0 - 1.05 [0.93] (660/600/800MHz)

Idle power consumption doesn't appear to be influenced much,
but a simple load test (`cat /dev/urandom | pigz - > /dev/null`
combined with running Animatch) seems to show about 0.3W of
difference.

Care is advised, as there may be differences between each
units in how low can they be undervolted - in my experience,
reaching that point usually makes the phone fail to boot.
In my case, it appears that my Birch phone can go down the most.

This is a somewhat conservative set of values that I've seen
working well on all my devices; I haven't tried very hard to
optimize it, so more experiments are welcome.

Signed-off-by: Sebastian Krzyszkowiak <[email protected]>
Signed-off-by: Martin Kepplinger <[email protected]>
---
.../boot/dts/freescale/imx8mq-librem5-r3.dts | 2 +-
.../boot/dts/freescale/imx8mq-librem5.dtsi | 22 ++++++++++++++-----
2 files changed, 17 insertions(+), 7 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts
index 4533a84fb0b95..077c5cd2586f7 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts
@@ -7,7 +7,7 @@

&a53_opp_table {
opp-1000000000 {
- opp-microvolt = <1000000>;
+ opp-microvolt = <950000>;
};
};

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
index 509776a63259b..eaf35cff2f8a6 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
@@ -839,8 +839,8 @@ buck1_reg: BUCK1 {
regulator-max-microvolt = <1300000>;
regulator-boot-on;
regulator-ramp-delay = <1250>;
- rohm,dvs-run-voltage = <900000>;
- rohm,dvs-idle-voltage = <850000>;
+ rohm,dvs-run-voltage = <880000>;
+ rohm,dvs-idle-voltage = <820000>;
rohm,dvs-suspend-voltage = <800000>;
regulator-always-on;
};
@@ -851,8 +851,8 @@ buck2_reg: BUCK2 {
regulator-max-microvolt = <1300000>;
regulator-boot-on;
regulator-ramp-delay = <1250>;
- rohm,dvs-run-voltage = <1000000>;
- rohm,dvs-idle-voltage = <900000>;
+ rohm,dvs-run-voltage = <950000>;
+ rohm,dvs-idle-voltage = <850000>;
regulator-always-on;
};

@@ -861,14 +861,14 @@ buck3_reg: BUCK3 {
regulator-min-microvolt = <700000>;
regulator-max-microvolt = <1300000>;
regulator-boot-on;
- rohm,dvs-run-voltage = <900000>;
+ rohm,dvs-run-voltage = <850000>;
};

buck4_reg: BUCK4 {
regulator-name = "buck4";
regulator-min-microvolt = <700000>;
regulator-max-microvolt = <1300000>;
- rohm,dvs-run-voltage = <1000000>;
+ rohm,dvs-run-voltage = <930000>;
};

buck5_reg: BUCK5 {
@@ -1403,3 +1403,13 @@ &wdog1 {
fsl,ext-reset-output;
status = "okay";
};
+
+&a53_opp_table {
+ opp-1000000000 {
+ opp-microvolt = <850000>;
+ };
+
+ opp-1500000000 {
+ opp-microvolt = <950000>;
+ };
+};
--
2.30.2


2023-03-09 20:49:31

by Martin Kepplinger

[permalink] [raw]
Subject: [PATCH v1 11/14] arm64: dts: imx8mq-librem5: Remove dis_u3_susphy_quirk from usb_dwc3_0

From: Sebastian Krzyszkowiak <[email protected]>

This reduces power consumption in system suspend by about 10%.

Signed-off-by: Sebastian Krzyszkowiak <[email protected]>
Signed-off-by: Martin Kepplinger <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
index 0b4b49fa1392a..f557632f574fa 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
@@ -1322,7 +1322,6 @@ &usb_dwc3_0 {
#address-cells = <1>;
#size-cells = <0>;
dr_mode = "otg";
- snps,dis_u3_susphy_quirk;
usb-role-switch;
status = "okay";

--
2.30.2


2023-03-09 20:49:31

by Martin Kepplinger

[permalink] [raw]
Subject: [PATCH v1 13/14] arm64: dts: imx8mq-librem5: Reduce I2C frequency to 384kHz

From: Sebastian Krzyszkowiak <[email protected]>

According to imx8mq errata (ERR007805):

> To meet the clock low period requirement in fast speed mode,
> SCL must be configured to 384KHz or less.

Note that the imx i2c driver already implements this erratum and works
around it. This is only for the description to reflect reality.

Signed-off-by: Sebastian Krzyszkowiak <[email protected]>
Signed-off-by: Martin Kepplinger <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
index 7e70663cffa30..35bde8d41e8e7 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
@@ -778,7 +778,7 @@ MX8MQ_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B 0x1f
};

&i2c1 {
- clock-frequency = <387000>;
+ clock-frequency = <384000>;
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_i2c1>;
status = "okay";
@@ -976,7 +976,7 @@ rtc@68 {
};

&i2c2 {
- clock-frequency = <387000>;
+ clock-frequency = <384000>;
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_i2c2>;
status = "okay";
@@ -1025,7 +1025,7 @@ accel_gyro: accel-gyro@6a {
};

&i2c3 {
- clock-frequency = <387000>;
+ clock-frequency = <384000>;
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_i2c3>;
status = "okay";
@@ -1115,7 +1115,7 @@ touchscreen@38 {
};

&i2c4 {
- clock-frequency = <387000>;
+ clock-frequency = <384000>;
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_i2c4>;
status = "okay";
--
2.30.2


2023-03-09 20:49:31

by Martin Kepplinger

[permalink] [raw]
Subject: [PATCH v1 05/14] arm64: dts: imx8mq-librem5: add brightness levels to led-backlight

Add brightness-levels and default-brightness-level properties to
the librem5 board description that have been used for a long time.

Signed-off-by: Martin Kepplinger <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
index 9f374da5c18aa..f8698b6995343 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
@@ -20,6 +20,8 @@ / {
backlight_dsi: backlight-dsi {
compatible = "led-backlight";
leds = <&led_backlight>;
+ brightness-levels = <255>;
+ default-brightness-level = <190>;
};

pmic_osc: clock-pmic {
--
2.30.2


2023-03-09 20:49:32

by Martin Kepplinger

[permalink] [raw]
Subject: [PATCH v1 10/14] arm64: dts: imx8mq-librem5: Adjust proximity sensor's near levels

From: Sebastian Krzyszkowiak <[email protected]>

Based on tests with my left ear (which appears to require lower levels
than the right one), one Birch, one Dogwood and three Evergreens.

It seems that the sensor reacts very weakly to hair, so let's make
the thresholds rather generous to compensate.

Signed-off-by: Sebastian Krzyszkowiak <[email protected]>
Signed-off-by: Martin Kepplinger <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dts | 2 +-
arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dtsi | 2 +-
arch/arm64/boot/dts/freescale/imx8mq-librem5-r4.dts | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dts
index 4f69eb32b1c90..2b3d437a642a9 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dts
@@ -23,5 +23,5 @@ &bq25895 {
};

&proximity {
- proximity-near-level = <120>;
+ proximity-near-level = <50>;
};
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dtsi
index db81ed699de75..7fd0176e4bd30 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dtsi
@@ -45,5 +45,5 @@ &magnetometer {
};

&proximity {
- proximity-near-level = <25>;
+ proximity-near-level = <10>;
};
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-r4.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-r4.dts
index 1056b7981bdbd..97577c0a77158 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-r4.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-r4.dts
@@ -23,5 +23,5 @@ &lcd_panel {
};

&proximity {
- proximity-near-level = <10>;
+ proximity-near-level = <5>;
};
--
2.30.2


2023-03-09 20:49:32

by Martin Kepplinger

[permalink] [raw]
Subject: [PATCH v1 09/14] arm64: dts: imx8mq-librem5: Bump usdhc2 frequency to 100MHz

From: Sebastian Krzyszkowiak <[email protected]>

RS9116 card already limits itself to 50MHz by being a high-speed card,
while AP6275S can work at 100MHz just fine (technically it should work
at 200MHz as well since it's a SDR104 card, but it doesn't appear to be
the case in practice and further research will be needed to find out why).

Signed-off-by: Sebastian Krzyszkowiak <[email protected]>
Signed-off-by: Martin Kepplinger <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
index 7e470135b86a4..0b4b49fa1392a 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
@@ -1389,7 +1389,7 @@ &usdhc2 {
mmc-pwrseq = <&usdhc2_pwrseq>;
post-power-on-delay-ms = <1000>;
cd-gpios = <&gpio2 12 GPIO_ACTIVE_LOW>;
- max-frequency = <50000000>;
+ max-frequency = <100000000>;
disable-wp;
cap-sdio-irq;
keep-power-in-suspend;
--
2.30.2


2023-03-09 20:49:32

by Martin Kepplinger

[permalink] [raw]
Subject: [PATCH v1 14/14] arm64: dts: imx8mq-librem5: Add 166MHz to DDRC OPP table

From: Sebastian Krzyszkowiak <[email protected]>

This is the lowest frequency supported by older iMX8MQ SoC
revisions.

Signed-off-by: Sebastian Krzyszkowiak <[email protected]>
Signed-off-by: Martin Kepplinger <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
index 35bde8d41e8e7..ceced6bc4e898 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
@@ -329,6 +329,10 @@ opp-100000000 {
opp-hz = /bits/ 64 <100000000>;
};

+ opp-166000000 {
+ opp-hz = /bits/ 64 <166935483>;
+ };
+
opp-800000000 {
opp-hz = /bits/ 64 <800000000>;
};
--
2.30.2


2023-03-09 20:49:32

by Martin Kepplinger

[permalink] [raw]
Subject: [PATCH v1 12/14] arm64: dts: imx8mq-librem5: Bump BUCK1 suspend voltage to 0.81V

From: Sebastian Krzyszkowiak <[email protected]>

0.8V is outside of the operating voltage specified for imx8mq, see
chapter 3.1.4 "Operating ranges" of the IMX8MDQLQCEC document.

Signed-off-by: Sebastian Krzyszkowiak <[email protected]>
Signed-off-by: Martin Kepplinger <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
index f557632f574fa..7e70663cffa30 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
@@ -841,7 +841,7 @@ buck1_reg: BUCK1 {
regulator-ramp-delay = <1250>;
rohm,dvs-run-voltage = <880000>;
rohm,dvs-idle-voltage = <820000>;
- rohm,dvs-suspend-voltage = <800000>;
+ rohm,dvs-suspend-voltage = <810000>;
regulator-always-on;
};

--
2.30.2


2023-03-14 07:28:44

by Shawn Guo

[permalink] [raw]
Subject: Re: [PATCH v1 11/14] arm64: dts: imx8mq-librem5: Remove dis_u3_susphy_quirk from usb_dwc3_0

On Thu, Mar 09, 2023 at 09:46:05PM +0100, Martin Kepplinger wrote:
> From: Sebastian Krzyszkowiak <[email protected]>
>
> This reduces power consumption in system suspend by about 10%.

Is there any other impact than this nice power gain? Otherwise,
I would wonder why the quirk was enabled in the first place.

Shawn

>
> Signed-off-by: Sebastian Krzyszkowiak <[email protected]>
> Signed-off-by: Martin Kepplinger <[email protected]>
> ---
> arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> index 0b4b49fa1392a..f557632f574fa 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> @@ -1322,7 +1322,6 @@ &usb_dwc3_0 {
> #address-cells = <1>;
> #size-cells = <0>;
> dr_mode = "otg";
> - snps,dis_u3_susphy_quirk;
> usb-role-switch;
> status = "okay";
>
> --
> 2.30.2
>

2023-03-15 13:07:57

by Angus Ainslie

[permalink] [raw]
Subject: Re: [PATCH v1 11/14] arm64: dts: imx8mq-librem5: Remove dis_u3_susphy_quirk from usb_dwc3_0

Hi Shawn,

On 2023-03-14 00:28, Shawn Guo wrote:
> On Thu, Mar 09, 2023 at 09:46:05PM +0100, Martin Kepplinger wrote:
>> From: Sebastian Krzyszkowiak <[email protected]>
>>
>> This reduces power consumption in system suspend by about 10%.
>
> Is there any other impact than this nice power gain? Otherwise,
> I would wonder why the quirk was enabled in the first place.
>

This comes from the early days of board bring-up and IIRC it seemed to
stabilize flashing using the mfgtools over USB. Whatever gremlin was in
those early boards is long gone and this is no longer needed.

Cheers
Angus

> Shawn
>
>>
>> Signed-off-by: Sebastian Krzyszkowiak <[email protected]>
>> Signed-off-by: Martin Kepplinger <[email protected]>
>> ---
>> arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
>> b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
>> index 0b4b49fa1392a..f557632f574fa 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
>> @@ -1322,7 +1322,6 @@ &usb_dwc3_0 {
>> #address-cells = <1>;
>> #size-cells = <0>;
>> dr_mode = "otg";
>> - snps,dis_u3_susphy_quirk;
>> usb-role-switch;
>> status = "okay";
>>
>> --
>> 2.30.2
>>

2023-03-27 01:49:35

by Shawn Guo

[permalink] [raw]
Subject: Re: [PATCH v1 00/14] arm64: dts: imx8mq-librem5: updates and fixes until march 2023

On Thu, Mar 09, 2023 at 09:45:54PM +0100, Martin Kepplinger wrote:
> hi Shawn and all interested in the Librem 5 phone,
>
> This is another round of updates to the phone DT description. Some are
> clear fixes, but some are important updates like the CSI changes
> that make the selfie cam work or the powersaving related things like
> the ddrc opp table entry and voltage changes.
>
> As previously this is all mixed together because the changes are small.
> If you prefer separate, small "topic-patchsets", please say so.
>
> thanks,
> martin
>
>
> Angus Ainslie (1):
> arm64: dts: imx8mq-librem5: add the magnetometer mount matrix
>
> Martin Kepplinger (4):
> arm64: dts: imx8mq-librem5: lower the mipi csi 1 frequencies
> arm64: dts: imx8mq-librem5: describe the clock for the csi sensors
> arm64: dts: imx8mq-librem5: fix audio-1v8 regulator name
> arm64: dts: imx8mq-librem5: add brightness levels to led-backlight
>
> Sebastian Krzyszkowiak (9):
> arm64: dts: imx8mq-librem5: Describe MIC_2V4 regulator
> arm64: dts: imx8mq-librem5: Set charger parameters for each batch
> arm64: dts: imx8mq-librem5: Set the DVS voltages lower
> arm64: dts: imx8mq-librem5: Bump usdhc2 frequency to 100MHz
> arm64: dts: imx8mq-librem5: Adjust proximity sensor's near levels
> arm64: dts: imx8mq-librem5: Remove dis_u3_susphy_quirk from usb_dwc3_0
> arm64: dts: imx8mq-librem5: Bump BUCK1 suspend voltage to 0.81V
> arm64: dts: imx8mq-librem5: Reduce I2C frequency to 384kHz
> arm64: dts: imx8mq-librem5: Add 166MHz to DDRC OPP table

Applied all, thanks!