I run spell checker and found typos in selftest/bpf/ files.
Fixed all of the detected typos.
This patch is an extra credit for kselftest task
in the Linux kernel bug fixing spring unpaid 2023.
Best regards,
Taichi Nishimura
Signed-off-by: Taichi Nishimura <[email protected]>
---
tools/testing/selftests/bpf/prog_tests/migrate_reuseport.c | 2 +-
tools/testing/selftests/bpf/prog_tests/trampoline_count.c | 2 +-
tools/testing/selftests/bpf/progs/btf_dump_test_case_syntax.c | 2 +-
tools/testing/selftests/bpf/progs/dynptr_fail.c | 2 +-
tools/testing/selftests/bpf/progs/strobemeta.h | 2 +-
tools/testing/selftests/bpf/progs/test_cls_redirect.c | 4 ++--
tools/testing/selftests/bpf/progs/test_subprogs.c | 2 +-
tools/testing/selftests/bpf/progs/test_xdp_vlan.c | 2 +-
tools/testing/selftests/bpf/test_cpp.cpp | 2 +-
tools/testing/selftests/bpf/veristat.c | 4 ++--
10 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/tools/testing/selftests/bpf/prog_tests/migrate_reuseport.c b/tools/testing/selftests/bpf/prog_tests/migrate_reuseport.c
index eb2feaac81fe..653b0a20fab9 100644
--- a/tools/testing/selftests/bpf/prog_tests/migrate_reuseport.c
+++ b/tools/testing/selftests/bpf/prog_tests/migrate_reuseport.c
@@ -488,7 +488,7 @@ static void run_test(struct migrate_reuseport_test_case *test_case,
goto close_servers;
}
- /* Tie requests to the first four listners */
+ /* Tie requests to the first four listeners */
err = start_clients(test_case);
if (!ASSERT_OK(err, "start_clients"))
goto close_clients;
diff --git a/tools/testing/selftests/bpf/prog_tests/trampoline_count.c b/tools/testing/selftests/bpf/prog_tests/trampoline_count.c
index 564b75bc087f..353451a0c88c 100644
--- a/tools/testing/selftests/bpf/prog_tests/trampoline_count.c
+++ b/tools/testing/selftests/bpf/prog_tests/trampoline_count.c
@@ -74,7 +74,7 @@ void serial_test_trampoline_count(void)
if (!ASSERT_EQ(link, NULL, "ptr_is_null"))
goto cleanup;
- /* and finaly execute the probe */
+ /* and finally execute the probe */
prog_fd = bpf_program__fd(prog);
if (!ASSERT_GE(prog_fd, 0, "bpf_program__fd"))
goto cleanup;
diff --git a/tools/testing/selftests/bpf/progs/btf_dump_test_case_syntax.c b/tools/testing/selftests/bpf/progs/btf_dump_test_case_syntax.c
index 4ee4748133fe..daa8753bb171 100644
--- a/tools/testing/selftests/bpf/progs/btf_dump_test_case_syntax.c
+++ b/tools/testing/selftests/bpf/progs/btf_dump_test_case_syntax.c
@@ -51,7 +51,7 @@ typedef void (*printf_fn_t)(const char *, ...);
* typedef int (*fn_t)(int);
* typedef char * const * (*fn_ptr2_t)(s_t, fn_t);
*
- * - `fn_complext_t`: pointer to a function returning struct and accepting
+ * - `fn_complex_t`: pointer to a function returning struct and accepting
* union and struct. All structs and enum are anonymous and defined inline.
*
* - `signal_t: pointer to a function accepting a pointer to a function as an
diff --git a/tools/testing/selftests/bpf/progs/dynptr_fail.c b/tools/testing/selftests/bpf/progs/dynptr_fail.c
index 78debc1b3820..b979ee9f5a37 100644
--- a/tools/testing/selftests/bpf/progs/dynptr_fail.c
+++ b/tools/testing/selftests/bpf/progs/dynptr_fail.c
@@ -623,7 +623,7 @@ static int release_twice_callback_fn(__u32 index, void *data)
}
/* Test that releasing a dynptr twice, where one of the releases happens
- * within a calback function, fails
+ * within a callback function, fails
*/
SEC("?raw_tp")
__failure __msg("arg 1 is an unacquired reference")
diff --git a/tools/testing/selftests/bpf/progs/strobemeta.h b/tools/testing/selftests/bpf/progs/strobemeta.h
index 753718595c26..e562be6356f3 100644
--- a/tools/testing/selftests/bpf/progs/strobemeta.h
+++ b/tools/testing/selftests/bpf/progs/strobemeta.h
@@ -135,7 +135,7 @@ struct strobe_value_loc {
* tpidr_el0 for aarch64).
* TLS_IMM_EXEC: absolute address of GOT entry containing offset
* from thread pointer;
- * TLS_GENERAL_DYN: absolute addres of double GOT entry
+ * TLS_GENERAL_DYN: absolute address of double GOT entry
* containing tls_index_t struct;
*/
int64_t offset;
diff --git a/tools/testing/selftests/bpf/progs/test_cls_redirect.c b/tools/testing/selftests/bpf/progs/test_cls_redirect.c
index 2833ad722cb7..a8ba39848bbf 100644
--- a/tools/testing/selftests/bpf/progs/test_cls_redirect.c
+++ b/tools/testing/selftests/bpf/progs/test_cls_redirect.c
@@ -600,7 +600,7 @@ static INLINING ret_t get_next_hop(buf_t *pkt, encap_headers_t *encap,
return TC_ACT_SHOT;
}
- /* Skip the remainig next hops (may be zero). */
+ /* Skip the remaining next hops (may be zero). */
return skip_next_hops(pkt, encap->unigue.hop_count -
encap->unigue.next_hop - 1);
}
@@ -610,7 +610,7 @@ static INLINING ret_t get_next_hop(buf_t *pkt, encap_headers_t *encap,
*
* fill_tuple(&t, foo, sizeof(struct iphdr), 123, 321)
*
- * clang will substitue a costant for sizeof, which allows the verifier
+ * clang will substitute a costant for sizeof, which allows the verifier
* to track it's value. Based on this, it can figure out the constant
* return value, and calling code works while still being "generic" to
* IPv4 and IPv6.
diff --git a/tools/testing/selftests/bpf/progs/test_subprogs.c b/tools/testing/selftests/bpf/progs/test_subprogs.c
index f8e9256cf18d..a8d602d7c88a 100644
--- a/tools/testing/selftests/bpf/progs/test_subprogs.c
+++ b/tools/testing/selftests/bpf/progs/test_subprogs.c
@@ -47,7 +47,7 @@ static __noinline int sub5(int v)
return sub1(v) - 1; /* compensates sub1()'s + 1 */
}
-/* unfortunately verifier rejects `struct task_struct *t` as an unkown pointer
+/* unfortunately verifier rejects `struct task_struct *t` as an unknown pointer
* type, so we need to accept pointer as integer and then cast it inside the
* function
*/
diff --git a/tools/testing/selftests/bpf/progs/test_xdp_vlan.c b/tools/testing/selftests/bpf/progs/test_xdp_vlan.c
index 134768f6b788..c19324f228a3 100644
--- a/tools/testing/selftests/bpf/progs/test_xdp_vlan.c
+++ b/tools/testing/selftests/bpf/progs/test_xdp_vlan.c
@@ -98,7 +98,7 @@ bool parse_eth_frame(struct ethhdr *eth, void *data_end, struct parse_pkt *pkt)
return true;
}
-/* Hint, VLANs are choosen to hit network-byte-order issues */
+/* Hint, VLANs are chosen to hit network-byte-order issues */
#define TESTVLAN 4011 /* 0xFAB */
// #define TO_VLAN 4000 /* 0xFA0 (hint 0xOA0 = 160) */
diff --git a/tools/testing/selftests/bpf/test_cpp.cpp b/tools/testing/selftests/bpf/test_cpp.cpp
index 0bd9990e83fa..f4936834f76f 100644
--- a/tools/testing/selftests/bpf/test_cpp.cpp
+++ b/tools/testing/selftests/bpf/test_cpp.cpp
@@ -91,7 +91,7 @@ static void try_skeleton_template()
skel.detach();
- /* destructor will destory underlying skeleton */
+ /* destructor will destroy underlying skeleton */
}
int main(int argc, char *argv[])
diff --git a/tools/testing/selftests/bpf/veristat.c b/tools/testing/selftests/bpf/veristat.c
index f961b49b8ef4..83231456d3c5 100644
--- a/tools/testing/selftests/bpf/veristat.c
+++ b/tools/testing/selftests/bpf/veristat.c
@@ -144,7 +144,7 @@ static struct env {
struct verif_stats *prog_stats;
int prog_stat_cnt;
- /* baseline_stats is allocated and used only in comparsion mode */
+ /* baseline_stats is allocated and used only in comparison mode */
struct verif_stats *baseline_stats;
int baseline_stat_cnt;
@@ -882,7 +882,7 @@ static int process_obj(const char *filename)
* that BPF object file is incomplete and has to be statically
* linked into a final BPF object file; instead of bailing
* out, report it into stderr, mark it as skipped, and
- * proceeed
+ * proceed
*/
fprintf(stderr, "Failed to open '%s': %d\n", filename, -errno);
env.files_skipped++;
--
2.25.1
Hi--
On 2/14/23 07:28, Taichi Nishimura wrote:
> I run spell checker and found typos in selftest/bpf/ files.
> Fixed all of the detected typos.
>
> This patch is an extra credit for kselftest task
> in the Linux kernel bug fixing spring unpaid 2023.
>
> Best regards,
> Taichi Nishimura
>
> Signed-off-by: Taichi Nishimura <[email protected]>
> ---
> tools/testing/selftests/bpf/prog_tests/migrate_reuseport.c | 2 +-
> tools/testing/selftests/bpf/prog_tests/trampoline_count.c | 2 +-
> tools/testing/selftests/bpf/progs/btf_dump_test_case_syntax.c | 2 +-
> tools/testing/selftests/bpf/progs/dynptr_fail.c | 2 +-
> tools/testing/selftests/bpf/progs/strobemeta.h | 2 +-
> tools/testing/selftests/bpf/progs/test_cls_redirect.c | 4 ++--
> tools/testing/selftests/bpf/progs/test_subprogs.c | 2 +-
> tools/testing/selftests/bpf/progs/test_xdp_vlan.c | 2 +-
> tools/testing/selftests/bpf/test_cpp.cpp | 2 +-
> tools/testing/selftests/bpf/veristat.c | 4 ++--
> 10 files changed, 12 insertions(+), 12 deletions(-)
>
Issues here:
> @@ -610,7 +610,7 @@ static INLINING ret_t get_next_hop(buf_t *pkt, encap_headers_t *encap,
> *
> * fill_tuple(&t, foo, sizeof(struct iphdr), 123, 321)
> *
> - * clang will substitue a costant for sizeof, which allows the verifier
> + * clang will substitute a costant for sizeof, which allows the verifier
constant
> * to track it's value. Based on this, it can figure out the constant
its value.
> * return value, and calling code works while still being "generic" to
> * IPv4 and IPv6.
The other changes look good. Thanks.
After fixing the issues above:
Reviewed-by: Randy Dunlap <[email protected]>
--
~Randy
Hi Randy,
Thank you for your reviewing.
I fixed costant and it's to constant and its, respectively.
Best regards,
Taichi Nishimura
Signed-off-by: Taichi Nishimura <[email protected]>
---
tools/testing/selftests/bpf/progs/test_cls_redirect.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/bpf/progs/test_cls_redirect.c b/tools/testing/selftests/bpf/progs/test_cls_redirect.c
index a8ba39848bbf..66b304982245 100644
--- a/tools/testing/selftests/bpf/progs/test_cls_redirect.c
+++ b/tools/testing/selftests/bpf/progs/test_cls_redirect.c
@@ -610,8 +610,8 @@ static INLINING ret_t get_next_hop(buf_t *pkt, encap_headers_t *encap,
*
* fill_tuple(&t, foo, sizeof(struct iphdr), 123, 321)
*
- * clang will substitute a costant for sizeof, which allows the verifier
- * to track it's value. Based on this, it can figure out the constant
+ * clang will substitute a constant for sizeof, which allows the verifier
+ * to track its value. Based on this, it can figure out the constant
* return value, and calling code works while still being "generic" to
* IPv4 and IPv6.
*/
--
2.25.1
On 2/14/23 19:21, Taichi Nishimura wrote:
> Hi Randy,
>
> Thank you for your reviewing.
> I fixed costant and it's to constant and its, respectively.
>
> Best regards,
> Taichi Nishimura
>
> Signed-off-by: Taichi Nishimura <[email protected]>
Looks good. Thanks.
Acked-by: Randy Dunlap <[email protected]>
> ---
> tools/testing/selftests/bpf/progs/test_cls_redirect.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/bpf/progs/test_cls_redirect.c b/tools/testing/selftests/bpf/progs/test_cls_redirect.c
> index a8ba39848bbf..66b304982245 100644
> --- a/tools/testing/selftests/bpf/progs/test_cls_redirect.c
> +++ b/tools/testing/selftests/bpf/progs/test_cls_redirect.c
> @@ -610,8 +610,8 @@ static INLINING ret_t get_next_hop(buf_t *pkt, encap_headers_t *encap,
> *
> * fill_tuple(&t, foo, sizeof(struct iphdr), 123, 321)
> *
> - * clang will substitute a costant for sizeof, which allows the verifier
> - * to track it's value. Based on this, it can figure out the constant
> + * clang will substitute a constant for sizeof, which allows the verifier
> + * to track its value. Based on this, it can figure out the constant
> * return value, and calling code works while still being "generic" to
> * IPv4 and IPv6.
> */
--
~Randy
On 2/14/23 7:21 PM, Taichi Nishimura wrote:
> Hi Randy,
>
> Thank you for your reviewing.
> I fixed costant and it's to constant and its, respectively.
>
> Best regards,
> Taichi Nishimura
>
> Signed-off-by: Taichi Nishimura <[email protected]>
> ---
> tools/testing/selftests/bpf/progs/test_cls_redirect.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/bpf/progs/test_cls_redirect.c b/tools/testing/selftests/bpf/progs/test_cls_redirect.c
> index a8ba39848bbf..66b304982245 100644
> --- a/tools/testing/selftests/bpf/progs/test_cls_redirect.c
> +++ b/tools/testing/selftests/bpf/progs/test_cls_redirect.c
> @@ -610,8 +610,8 @@ static INLINING ret_t get_next_hop(buf_t *pkt, encap_headers_t *encap,
> *
> * fill_tuple(&t, foo, sizeof(struct iphdr), 123, 321)
> *
> - * clang will substitute a costant for sizeof, which allows the verifier
> - * to track it's value. Based on this, it can figure out the constant
> + * clang will substitute a constant for sizeof, which allows the verifier
> + * to track its value. Based on this, it can figure out the constant
This does not apply. Ensure the diff is generated by git, and against the
bpf-next tree. Please include everything in v1 also, resubmit and tag for
bpf-next in the subject.