Tegra PMC has blink functionality that allows 32KHz clock out to
blink pin of the Tegra.
This patch adds id for this blink clock to use for enabling or
disabling blink output through device tree.
Signed-off-by: Sowjanya Komatineni <[email protected]>
---
include/dt-bindings/soc/tegra-pmc.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/dt-bindings/soc/tegra-pmc.h b/include/dt-bindings/soc/tegra-pmc.h
index f7c866404456..a99a457471ee 100644
--- a/include/dt-bindings/soc/tegra-pmc.h
+++ b/include/dt-bindings/soc/tegra-pmc.h
@@ -9,7 +9,8 @@
#define TEGRA_PMC_CLK_OUT_1 0
#define TEGRA_PMC_CLK_OUT_2 1
#define TEGRA_PMC_CLK_OUT_3 2
+#define TEGRA_PMC_CLK_BLINK 3
-#define TEGRA_PMC_CLK_MAX 3
+#define TEGRA_PMC_CLK_MAX 4
#endif /* _DT_BINDINGS_SOC_TEGRA_PMC_H */
--
2.7.4
21.12.2019 01:26, Sowjanya Komatineni пишет:
> Tegra PMC has blink functionality that allows 32KHz clock out to
> blink pin of the Tegra.
>
> This patch adds id for this blink clock to use for enabling or
> disabling blink output through device tree.
>
> Signed-off-by: Sowjanya Komatineni <[email protected]>
> ---
> include/dt-bindings/soc/tegra-pmc.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/dt-bindings/soc/tegra-pmc.h b/include/dt-bindings/soc/tegra-pmc.h
> index f7c866404456..a99a457471ee 100644
> --- a/include/dt-bindings/soc/tegra-pmc.h
> +++ b/include/dt-bindings/soc/tegra-pmc.h
> @@ -9,7 +9,8 @@
> #define TEGRA_PMC_CLK_OUT_1 0
> #define TEGRA_PMC_CLK_OUT_2 1
> #define TEGRA_PMC_CLK_OUT_3 2
> +#define TEGRA_PMC_CLK_BLINK 3
>
> -#define TEGRA_PMC_CLK_MAX 3
> +#define TEGRA_PMC_CLK_MAX 4
>
> #endif /* _DT_BINDINGS_SOC_TEGRA_PMC_H */
>
Could you please explain the reason of separating CLK_OUT and BLINK PMC
patches?
Also, you only documented CLK_OUT clocks in the DT binding and no BLINK.
On Fri, 20 Dec 2019 14:26:53 -0800, Sowjanya Komatineni wrote:
> Tegra PMC has blink functionality that allows 32KHz clock out to
> blink pin of the Tegra.
>
> This patch adds id for this blink clock to use for enabling or
> disabling blink output through device tree.
>
> Signed-off-by: Sowjanya Komatineni <[email protected]>
> ---
> include/dt-bindings/soc/tegra-pmc.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Please add Acked-by/Reviewed-by tags when posting new versions. However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for acks received on the version they apply.
If a tag was not added on purpose, please state why and what changed.
On 12/22/19 1:55 PM, Dmitry Osipenko wrote:
> 21.12.2019 01:26, Sowjanya Komatineni пишет:
>> Tegra PMC has blink functionality that allows 32KHz clock out to
>> blink pin of the Tegra.
>>
>> This patch adds id for this blink clock to use for enabling or
>> disabling blink output through device tree.
>>
>> Signed-off-by: Sowjanya Komatineni <[email protected]>
>> ---
>> include/dt-bindings/soc/tegra-pmc.h | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/dt-bindings/soc/tegra-pmc.h b/include/dt-bindings/soc/tegra-pmc.h
>> index f7c866404456..a99a457471ee 100644
>> --- a/include/dt-bindings/soc/tegra-pmc.h
>> +++ b/include/dt-bindings/soc/tegra-pmc.h
>> @@ -9,7 +9,8 @@
>> #define TEGRA_PMC_CLK_OUT_1 0
>> #define TEGRA_PMC_CLK_OUT_2 1
>> #define TEGRA_PMC_CLK_OUT_3 2
>> +#define TEGRA_PMC_CLK_BLINK 3
>>
>> -#define TEGRA_PMC_CLK_MAX 3
>> +#define TEGRA_PMC_CLK_MAX 4
>>
>> #endif /* _DT_BINDINGS_SOC_TEGRA_PMC_H */
>>
> Could you please explain the reason of separating CLK_OUT and BLINK PMC
> patches?
No specific reason just thought to have BLINK as separate patch as its
different register configuration to have fixed 32Khz clock out.
>
> Also, you only documented CLK_OUT clocks in the DT binding and no BLINK.
missed to add BLINK to dt-binding doc. Will add in v6.
On 12/26/19 10:17 AM, Rob Herring wrote:
> On Fri, 20 Dec 2019 14:26:53 -0800, Sowjanya Komatineni wrote:
>> Tegra PMC has blink functionality that allows 32KHz clock out to
>> blink pin of the Tegra.
>>
>> This patch adds id for this blink clock to use for enabling or
>> disabling blink output through device tree.
>>
>> Signed-off-by: Sowjanya Komatineni <[email protected]>
>> ---
>> include/dt-bindings/soc/tegra-pmc.h | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
> Please add Acked-by/Reviewed-by tags when posting new versions. However,
> there's no need to repost patches *only* to add the tags. The upstream
> maintainer will do that for acks received on the version they apply.
>
> If a tag was not added on purpose, please state why and what changed.
Sorry Rob, missed to add Acked-by tag for this patch in this series.
Will make sure of having all received Acked-by/Reviewed-by tags from
next time.
28.12.2019 00:30, Sowjanya Komatineni пишет:
>
> On 12/22/19 1:55 PM, Dmitry Osipenko wrote:
>> 21.12.2019 01:26, Sowjanya Komatineni пишет:
>>> Tegra PMC has blink functionality that allows 32KHz clock out to
>>> blink pin of the Tegra.
>>>
>>> This patch adds id for this blink clock to use for enabling or
>>> disabling blink output through device tree.
>>>
>>> Signed-off-by: Sowjanya Komatineni <[email protected]>
>>> ---
>>> include/dt-bindings/soc/tegra-pmc.h | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/include/dt-bindings/soc/tegra-pmc.h
>>> b/include/dt-bindings/soc/tegra-pmc.h
>>> index f7c866404456..a99a457471ee 100644
>>> --- a/include/dt-bindings/soc/tegra-pmc.h
>>> +++ b/include/dt-bindings/soc/tegra-pmc.h
>>> @@ -9,7 +9,8 @@
>>> #define TEGRA_PMC_CLK_OUT_1 0
>>> #define TEGRA_PMC_CLK_OUT_2 1
>>> #define TEGRA_PMC_CLK_OUT_3 2
>>> +#define TEGRA_PMC_CLK_BLINK 3
>>> -#define TEGRA_PMC_CLK_MAX 3
>>> +#define TEGRA_PMC_CLK_MAX 4
>>> #endif /* _DT_BINDINGS_SOC_TEGRA_PMC_H */
>>>
>> Could you please explain the reason of separating CLK_OUT and BLINK PMC
>> patches?
> No specific reason just thought to have BLINK as separate patch as its
> different register configuration to have fixed 32Khz clock out.
>>
>> Also, you only documented CLK_OUT clocks in the DT binding and no BLINK.
> missed to add BLINK to dt-binding doc. Will add in v6.
Ok