2023-01-31 09:00:35

by Jiapeng Chong

Subject: [PATCH] libata: clean up some inconsistent indenting

No functional modification involved.

drivers/ata/pata_serverworks.c:443 serverworks_init_one() warn: inconsistent indenting.

Reported-by: Abaci Robot <[email protected]>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3905
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/ata/pata_serverworks.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/ata/pata_serverworks.c b/drivers/ata/pata_serverworks.c
index c0bc4af0d196..c6bd9e95d4e8 100644
--- a/drivers/ata/pata_serverworks.c
+++ b/drivers/ata/pata_serverworks.c
@@ -434,10 +434,9 @@ static int serverworks_init_one(struct pci_dev *pdev, const struct pci_device_id
(pdev->device == PCI_DEVICE_ID_SERVERWORKS_CSB6IDE) ||
(pdev->device == PCI_DEVICE_ID_SERVERWORKS_CSB6IDE2)) {

- /* If the returned btr is the newer revision then
- select the right info block */
- if (rc == 3)
- ppi[0] = &info[3];
+ /* If the returned btr is the newer revision then select the right info block */
+ if (rc == 3)
+ ppi[0] = &info[3];

/* Is this the 3rd channel CSB6 IDE ? */
if (pdev->device == PCI_DEVICE_ID_SERVERWORKS_CSB6IDE2)
--
2.20.1.7.g153144c

2023-01-31 11:27:05

by Damien Le Moal

Subject: Re: [PATCH] libata: clean up some inconsistent indenting

On 1/31/23 17:54, Jiapeng Chong wrote:
> No functional modification involved.
>
> drivers/ata/pata_serverworks.c:443 serverworks_init_one() warn: inconsistent indenting.
>
> Reported-by: Abaci Robot <[email protected]>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3905
> Signed-off-by: Jiapeng Chong <[email protected]>
> ---
> drivers/ata/pata_serverworks.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/ata/pata_serverworks.c b/drivers/ata/pata_serverworks.c
> index c0bc4af0d196..c6bd9e95d4e8 100644
> --- a/drivers/ata/pata_serverworks.c
> +++ b/drivers/ata/pata_serverworks.c
> @@ -434,10 +434,9 @@ static int serverworks_init_one(struct pci_dev *pdev, const struct pci_device_id
> (pdev->device == PCI_DEVICE_ID_SERVERWORKS_CSB6IDE) ||
> (pdev->device == PCI_DEVICE_ID_SERVERWORKS_CSB6IDE2)) {
>
> - /* If the returned btr is the newer revision then
> - select the right info block */
> - if (rc == 3)
> - ppi[0] = &info[3];
> + /* If the returned btr is the newer revision then select the right info block */

Very long line. Please make that a proper multi-line comment.
And the patch title should be:

ata: pata_serverworks: clean up indentation

> + if (rc == 3)
> + ppi[0] = &info[3];
>
> /* Is this the 3rd channel CSB6 IDE ? */
> if (pdev->device == PCI_DEVICE_ID_SERVERWORKS_CSB6IDE2)

--
Damien Le Moal
Western Digital Research

2023-01-31 12:33:52

by Sergey Shtylyov

Subject: Re: [PATCH] libata: clean up some inconsistent indenting

On 1/31/23 2:26 PM, Damien Le Moal wrote:
[...]
>> No functional modification involved.
>>
>> drivers/ata/pata_serverworks.c:443 serverworks_init_one() warn: inconsistent indenting.
>>
>> Reported-by: Abaci Robot <[email protected]>
>> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3905
>> Signed-off-by: Jiapeng Chong <[email protected]>
>> ---
>> drivers/ata/pata_serverworks.c | 7 +++----
>> 1 file changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/ata/pata_serverworks.c b/drivers/ata/pata_serverworks.c
>> index c0bc4af0d196..c6bd9e95d4e8 100644
>> --- a/drivers/ata/pata_serverworks.c
>> +++ b/drivers/ata/pata_serverworks.c
>> @@ -434,10 +434,9 @@ static int serverworks_init_one(struct pci_dev *pdev, const struct pci_device_id
>> (pdev->device == PCI_DEVICE_ID_SERVERWORKS_CSB6IDE) ||
>> (pdev->device == PCI_DEVICE_ID_SERVERWORKS_CSB6IDE2)) {
>>
>> - /* If the returned btr is the newer revision then
>> - select the right info block */
>> - if (rc == 3)
>> - ppi[0] = &info[3];
>> + /* If the returned btr is the newer revision then select the right info block */
>
> Very long line. Please make that a proper multi-line comment.

Perhaps the material of a separate patch?

> And the patch title should be:
>
> ata: pata_serverworks: clean up indentation

Yes!

[...]

MBR, Sergey

2023-01-31 23:46:42

by Damien Le Moal

Subject: Re: [PATCH] libata: clean up some inconsistent indenting

On 2023/01/31 21:33, Sergey Shtylyov wrote:
> On 1/31/23 2:26 PM, Damien Le Moal wrote:
> [...]
>>> No functional modification involved.
>>>
>>> drivers/ata/pata_serverworks.c:443 serverworks_init_one() warn: inconsistent indenting.
>>>
>>> Reported-by: Abaci Robot <[email protected]>
>>> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3905
>>> Signed-off-by: Jiapeng Chong <[email protected]>
>>> ---
>>> drivers/ata/pata_serverworks.c | 7 +++----
>>> 1 file changed, 3 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/drivers/ata/pata_serverworks.c b/drivers/ata/pata_serverworks.c
>>> index c0bc4af0d196..c6bd9e95d4e8 100644
>>> --- a/drivers/ata/pata_serverworks.c
>>> +++ b/drivers/ata/pata_serverworks.c
>>> @@ -434,10 +434,9 @@ static int serverworks_init_one(struct pci_dev *pdev, const struct pci_device_id
>>> (pdev->device == PCI_DEVICE_ID_SERVERWORKS_CSB6IDE) ||
>>> (pdev->device == PCI_DEVICE_ID_SERVERWORKS_CSB6IDE2)) {
>>>
>>> - /* If the returned btr is the newer revision then
>>> - select the right info block */
>>> - if (rc == 3)
>>> - ppi[0] = &info[3];
>>> + /* If the returned btr is the newer revision then select the right info block */
>>
>> Very long line. Please make that a proper multi-line comment.
>
> Perhaps the material of a separate patch?

Since this patch touches this comment, the fix should be correct from the start.
I do not see the point of having a different patch fixing a patch that was ideal
to start with...

>
>> And the patch title should be:
>>
>> ata: pata_serverworks: clean up indentation
>
> Yes!
>
> [...]
>
> MBR, Sergey

--
Damien Le Moal
Western Digital Research