Remove MODULE_VERSION(), as it isn't needed at all: the only version
making sense is the kernel version.
Signed-off-by: Enrico Weigelt, metux IT consult <[email protected]>
---
net/8021q/vlan.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c
index f292e0267bb9..683e9e825b9e 100644
--- a/net/8021q/vlan.c
+++ b/net/8021q/vlan.c
@@ -36,15 +36,10 @@
#include "vlan.h"
#include "vlanproc.h"
-#define DRV_VERSION "1.8"
-
/* Global VLAN variables */
unsigned int vlan_net_id __read_mostly;
-const char vlan_fullname[] = "802.1Q VLAN Support";
-const char vlan_version[] = DRV_VERSION;
-
/* End of global variables definitions. */
static int vlan_group_prealloc_vid(struct vlan_group *vg,
@@ -687,7 +682,7 @@ static int __init vlan_proto_init(void)
{
int err;
- pr_info("%s v%s\n", vlan_fullname, vlan_version);
+ pr_info("802.1Q VLAN Support\n");
err = register_pernet_subsys(&vlan_net_ops);
if (err < 0)
@@ -743,4 +738,3 @@ module_init(vlan_proto_init);
module_exit(vlan_cleanup_module);
MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
--
2.11.0
Remove MODULE_VERSION(), as it isn't needed at all: the only version
making sense is the kernel version.
Signed-off-by: Enrico Weigelt, metux IT consult <[email protected]>
---
net/batman-adv/main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/batman-adv/main.c b/net/batman-adv/main.c
index 70fee9b42e25..1c2ccad94bf8 100644
--- a/net/batman-adv/main.c
+++ b/net/batman-adv/main.c
@@ -747,6 +747,5 @@ MODULE_LICENSE("GPL");
MODULE_AUTHOR(BATADV_DRIVER_AUTHOR);
MODULE_DESCRIPTION(BATADV_DRIVER_DESC);
MODULE_SUPPORTED_DEVICE(BATADV_DRIVER_DEVICE);
-MODULE_VERSION(BATADV_SOURCE_VERSION);
MODULE_ALIAS_RTNL_LINK("batadv");
MODULE_ALIAS_GENL_FAMILY(BATADV_NL_NAME);
--
2.11.0
Remove MODULE_VERSION(), as it isn't needed at all: the only version
making sense is the kernel version.
Signed-off-by: Enrico Weigelt, metux IT consult <[email protected]>
---
net/bridge/br.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/bridge/br.c b/net/bridge/br.c
index 401eeb9142eb..2502fdcbb8b2 100644
--- a/net/bridge/br.c
+++ b/net/bridge/br.c
@@ -399,5 +399,4 @@ static void __exit br_deinit(void)
module_init(br_init)
module_exit(br_deinit)
MODULE_LICENSE("GPL");
-MODULE_VERSION(BR_VERSION);
MODULE_ALIAS_RTNL_LINK("bridge");
--
2.11.0
Remove MODULE_VERSION(), as it isn't needed at all: the only version
making sense is the kernel version.
Signed-off-by: Enrico Weigelt <[email protected]>
---
net/ipv4/tcp_cubic.c | 1 -
net/ipv4/tcp_illinois.c | 1 -
net/ipv4/tcp_nv.c | 1 -
3 files changed, 3 deletions(-)
diff --git a/net/ipv4/tcp_cubic.c b/net/ipv4/tcp_cubic.c
index c7bf5b26bf0c..c6bcd445df04 100644
--- a/net/ipv4/tcp_cubic.c
+++ b/net/ipv4/tcp_cubic.c
@@ -537,4 +537,3 @@ module_exit(cubictcp_unregister);
MODULE_AUTHOR("Sangtae Ha, Stephen Hemminger");
MODULE_LICENSE("GPL");
MODULE_DESCRIPTION("CUBIC TCP");
-MODULE_VERSION("2.3");
diff --git a/net/ipv4/tcp_illinois.c b/net/ipv4/tcp_illinois.c
index 00e54873213e..8cc9967e82ef 100644
--- a/net/ipv4/tcp_illinois.c
+++ b/net/ipv4/tcp_illinois.c
@@ -355,4 +355,3 @@ module_exit(tcp_illinois_unregister);
MODULE_AUTHOR("Stephen Hemminger, Shao Liu");
MODULE_LICENSE("GPL");
MODULE_DESCRIPTION("TCP Illinois");
-MODULE_VERSION("1.0");
diff --git a/net/ipv4/tcp_nv.c b/net/ipv4/tcp_nv.c
index 95db7a11ba2a..b3879fb24d33 100644
--- a/net/ipv4/tcp_nv.c
+++ b/net/ipv4/tcp_nv.c
@@ -499,4 +499,3 @@ module_exit(tcpnv_unregister);
MODULE_AUTHOR("Lawrence Brakmo");
MODULE_LICENSE("GPL");
MODULE_DESCRIPTION("TCP NV");
-MODULE_VERSION("1.0");
--
2.11.0
Remove MODULE_VERSION(), as it isn't needed at all: the only version
making sense is the kernel version.
Signed-off-by: Enrico Weigelt, metux IT consult <[email protected]>
---
net/vmw_vsock/af_vsock.c | 1 -
net/vmw_vsock/hyperv_transport.c | 1 -
net/vmw_vsock/vmci_transport.c | 1 -
3 files changed, 3 deletions(-)
diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c
index d10916ab4526..cc196ffba3ed 100644
--- a/net/vmw_vsock/af_vsock.c
+++ b/net/vmw_vsock/af_vsock.c
@@ -2238,5 +2238,4 @@ module_exit(vsock_exit);
MODULE_AUTHOR("VMware, Inc.");
MODULE_DESCRIPTION("VMware Virtual Socket Family");
-MODULE_VERSION("1.0.2.0-k");
MODULE_LICENSE("GPL v2");
diff --git a/net/vmw_vsock/hyperv_transport.c b/net/vmw_vsock/hyperv_transport.c
index 630b851f8150..dae562f40896 100644
--- a/net/vmw_vsock/hyperv_transport.c
+++ b/net/vmw_vsock/hyperv_transport.c
@@ -929,6 +929,5 @@ module_init(hvs_init);
module_exit(hvs_exit);
MODULE_DESCRIPTION("Hyper-V Sockets");
-MODULE_VERSION("1.0.0");
MODULE_LICENSE("GPL");
MODULE_ALIAS_NETPROTO(PF_VSOCK);
diff --git a/net/vmw_vsock/vmci_transport.c b/net/vmw_vsock/vmci_transport.c
index 8b65323207db..bd39cca58ee6 100644
--- a/net/vmw_vsock/vmci_transport.c
+++ b/net/vmw_vsock/vmci_transport.c
@@ -2140,7 +2140,6 @@ module_exit(vmci_transport_exit);
MODULE_AUTHOR("VMware, Inc.");
MODULE_DESCRIPTION("VMCI transport for Virtual Sockets");
-MODULE_VERSION("1.0.5.0-k");
MODULE_LICENSE("GPL v2");
MODULE_ALIAS("vmware_vsock");
MODULE_ALIAS_NETPROTO(PF_VSOCK);
--
2.11.0
Remove MODULE_VERSION(), as it isn't needed at all: the only version
making sense is the kernel version.
Signed-off-by: Enrico Weigelt, metux IT consult <[email protected]>
---
net/tipc/core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/tipc/core.c b/net/tipc/core.c
index c2ff42900b53..8c0c45347c53 100644
--- a/net/tipc/core.c
+++ b/net/tipc/core.c
@@ -227,4 +227,3 @@ module_exit(tipc_exit);
MODULE_DESCRIPTION("TIPC: Transparent Inter Process Communication");
MODULE_LICENSE("Dual BSD/GPL");
-MODULE_VERSION(TIPC_MOD_VER);
--
2.11.0
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=394659
---Test result---
##############################
Test: CheckPatch - FAIL
Output:
net: ipv4: remove unneeded MODULE_VERSION() usage
WARNING: From:/Signed-off-by: email name mismatch: 'From: "Enrico Weigelt, metux IT consult" <[email protected]>' != 'Signed-off-by: Enrico Weigelt <[email protected]>'
total: 0 errors, 1 warnings, 0 checks, 9 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
"[PATCH] net: ipv4: remove unneeded MODULE_VERSION() usage" has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
##############################
Test: CheckGitLint - PASS
##############################
Test: CheckBuildK - PASS
---
Regards,
Linux Bluetooth
On Wed, 2 Dec 2020 13:49:53 +0100 Enrico Weigelt, metux IT consult
wrote:
> Remove MODULE_VERSION(), as it isn't needed at all: the only version
> making sense is the kernel version.
>
> Signed-off-by: Enrico Weigelt, metux IT consult <[email protected]>
Thanks for the patches. Please drop the "metux IT consult" from the
addresses. The from space is supposed to be for your name.
> diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c
> index f292e0267bb9..683e9e825b9e 100644
> --- a/net/8021q/vlan.c
> +++ b/net/8021q/vlan.c
> @@ -36,15 +36,10 @@
> #include "vlan.h"
> #include "vlanproc.h"
>
> -#define DRV_VERSION "1.8"
> -
> /* Global VLAN variables */
>
> unsigned int vlan_net_id __read_mostly;
>
> -const char vlan_fullname[] = "802.1Q VLAN Support";
> -const char vlan_version[] = DRV_VERSION;
This patches does not build. Please redo it more carefully.
You'll need to fix and resend the entire series. When you do so please
provide a cover letter, even if it only contains a couple of sentences
and separate the patches for bluetooth and batman-adv out as stand
alone patches, so the respective maintainers can pick them up.
On Fri, 2020-12-04 at 16:09 -0800, Jakub Kicinski wrote:
> On Wed, 2 Dec 2020 13:49:53 +0100 Enrico Weigelt, metux IT consult
> wrote:
> > Remove MODULE_VERSION(), as it isn't needed at all: the only version
> > making sense is the kernel version.
> >
> > Signed-off-by: Enrico Weigelt, metux IT consult <[email protected]>
>
> Thanks for the patches. Please drop the "metux IT consult" from the
> addresses. The from space is supposed to be for your name.
If you _really_ want this superfluous 'metux IT consult' content in your
signature, and I don't think you should, use parentheses around it.
Enrico Weigelt (metux IT consult) <[email protected]>
Using a comma makes copy/paste into an email client think it's two addresses.
On Wed, Dec 02, 2020 at 01:49:53PM +0100, Enrico Weigelt, metux IT consult wrote:
> Remove MODULE_VERSION(), as it isn't needed at all: the only version
> making sense is the kernel version.
>
> Signed-off-by: Enrico Weigelt, metux IT consult <[email protected]>
> ---
> net/8021q/vlan.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c
> index f292e0267bb9..683e9e825b9e 100644
> --- a/net/8021q/vlan.c
> +++ b/net/8021q/vlan.c
> @@ -36,15 +36,10 @@
> #include "vlan.h"
> #include "vlanproc.h"
>
> -#define DRV_VERSION "1.8"
> -
> /* Global VLAN variables */
>
> unsigned int vlan_net_id __read_mostly;
>
> -const char vlan_fullname[] = "802.1Q VLAN Support";
> -const char vlan_version[] = DRV_VERSION;
> -
> /* End of global variables definitions. */
>
> static int vlan_group_prealloc_vid(struct vlan_group *vg,
> @@ -687,7 +682,7 @@ static int __init vlan_proto_init(void)
> {
> int err;
>
> - pr_info("%s v%s\n", vlan_fullname, vlan_version);
> + pr_info("802.1Q VLAN Support\n");
How do we feel about deleting this not really informative message
altogether in a future patch?
On Sat, Dec 05, 2020 at 01:20:18PM +0200, Vladimir Oltean wrote:
> On Wed, Dec 02, 2020 at 01:49:53PM +0100, Enrico Weigelt, metux IT consult wrote:
> > Remove MODULE_VERSION(), as it isn't needed at all: the only version
> > making sense is the kernel version.
> >
> > Signed-off-by: Enrico Weigelt, metux IT consult <[email protected]>
> > ---
> > net/8021q/vlan.c | 8 +-------
> > 1 file changed, 1 insertion(+), 7 deletions(-)
> >
> > diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c
> > index f292e0267bb9..683e9e825b9e 100644
> > --- a/net/8021q/vlan.c
> > +++ b/net/8021q/vlan.c
> > @@ -36,15 +36,10 @@
> > #include "vlan.h"
> > #include "vlanproc.h"
> >
> > -#define DRV_VERSION "1.8"
> > -
> > /* Global VLAN variables */
> >
> > unsigned int vlan_net_id __read_mostly;
> >
> > -const char vlan_fullname[] = "802.1Q VLAN Support";
> > -const char vlan_version[] = DRV_VERSION;
> > -
> > /* End of global variables definitions. */
> >
> > static int vlan_group_prealloc_vid(struct vlan_group *vg,
> > @@ -687,7 +682,7 @@ static int __init vlan_proto_init(void)
> > {
> > int err;
> >
> > - pr_info("%s v%s\n", vlan_fullname, vlan_version);
> > + pr_info("802.1Q VLAN Support\n");
>
> How do we feel about deleting this not really informative message
> altogether in a future patch?
It too should be removed. If drivers are working properly, they are
quiet.
On Sat, 05 Dec 2020 08:06:40 +0100 Sven Eckelmann wrote:
> On Wednesday, 2 December 2020 13:49:54 CET Enrico Weigelt, metux IT consult wrote:
> > Remove MODULE_VERSION(), as it isn't needed at all: the only version
> > making sense is the kernel version.
>
> Is there some explanation besides an opinion? Some kind goal which you want to
> achieve with it maybe?
>
> At least for us it was an easy way to query the release cycle information via
> batctl. Which made it easier for us to roughly figure out what an reporter/
> inquirer was using - independent of whether he is using the in-kernel version
> or a backported version.
>
> Loosing this source of information and breaking parts of batctl and other
> tools (respondd, ...) is not the end of the world. But I would at least know
> why this is now necessary.
No, no, if it breaks your user space we can't do it, let's leave batman
alone, then.
I think this is mostly a clean up. In-tree the kernel version is usually
far more dependable because backports don't include version bumps.
Indeed it would be great if the clear motivation was spelled out in the
cover letter and/or patches.
On 05.12.20 08:06, Sven Eckelmann wrote:
Hi,
> Is there some explanation besides an opinion? Some kind goal which you want to
> achieve with it maybe?
Just a cleanup. I've been under the impression that this version is just
an relic from oot times.
> At least for us it was an easy way to query the release cycle information via
> batctl. Which made it easier for us to roughly figure out what an reporter/
> inquirer was using - independent of whether he is using the in-kernel version
> or a backported version.
Is the OOT scenario still valid ?
> Loosing this source of information and breaking parts of batctl and other
> tools (respondd, ...) is not the end of the world. But I would at least know
> why this is now necessary.
Okay, if this particular information indeed has a practical value, we
should keep it. Taking it as a NAK.
Perhaps we should add a comment what it's used for and make sure, the
version number is properly maintained.
The problem I see w/ those version fields is that we have lots of
changes in the kernel tree, w/o the version number being increased -
making this information at least doubtful.
--mtx
--
---
Hinweis: unverschl?sselte E-Mails k?nnen leicht abgeh?rt und manipuliert
werden ! F?r eine vertrauliche Kommunikation senden Sie bitte ihren
GPG/PGP-Schl?ssel zu.
---
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
[email protected] -- +49-151-27565287
On 05.12.20 16:53, Greg KH wrote:
>> How do we feel about deleting this not really informative message
>> altogether in a future patch?
>
> It too should be removed. If drivers are working properly, they are
> quiet.
Just sent a separate patch for removing this message. I'll rebase my
patch queue when this patch went through.
--mtx
--
---
Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert
werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren
GPG/PGP-Schlüssel zu.
---
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
[email protected] -- +49-151-27565287
On Tuesday, 8 December 2020 08:48:56 CET Enrico Weigelt, metux IT consult wrote:
> > Is there some explanation besides an opinion? Some kind goal which you want to
> > achieve with it maybe?
>
> Just a cleanup. I've been under the impression that this version is just
> an relic from oot times.
There are various entities which are loving to use the distro kernel and
replace the batman-adv module with a backport from a newer kernel version.
Similar to what is done in OpenWrt for the wifi drivers.
> > At least for us it was an easy way to query the release cycle information via
> > batctl. Which made it easier for us to roughly figure out what an reporter/
> > inquirer was using - independent of whether he is using the in-kernel version
> > or a backported version.
>
> Is the OOT scenario still valid ?
Since the backport is OOT - yes, it is still valid.
Kind regards,
Sven