2023-01-27 21:27:59

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [RFT PATCH v3 1/4] ARM: dts: exynos: add unit address to DWC3 node wrapper in Exynos5250

Neither simple-bus bindings nor dtc W=1 accept device nodes in soc@ node
which do not have unit address. Therefore usethe address space
of child device (actual DWC3 Controller) as the wrapper's address to
fix:

exynos5250-smdk5250.dtb: soc: usb3: {'compatible': ['samsung,exynos5250-dwusb3'],
... } should not be valid under {'type': 'object'}

exynos5250.dtsi:638.16-653.5: Warning (simple_bus_reg): /soc/usb3: missing or empty reg/ranges property

Signed-off-by: Krzysztof Kozlowski <[email protected]>

---

Changes since v1:
1. Use ranges with values and drop reg from usb-wrapper node.
2. Keep "usb" as wrapper's node name.
---
arch/arm/boot/dts/exynos5250.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 97e89859ba3d..a5db4ac213d5 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -635,17 +635,17 @@ i2s2: i2s@12d70000 {
#sound-dai-cells = <1>;
};

- usbdrd: usb3 {
+ usbdrd: usb@12000000 {
compatible = "samsung,exynos5250-dwusb3";
clocks = <&clock CLK_USB3>;
clock-names = "usbdrd30";
#address-cells = <1>;
#size-cells = <1>;
- ranges;
+ ranges = <0x0 0x12000000 0x10000>;

- usbdrd_dwc3: usb@12000000 {
+ usbdrd_dwc3: usb@0 {
compatible = "snps,dwc3";
- reg = <0x12000000 0x10000>;
+ reg = <0x0 0x10000>;
interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>;
phys = <&usbdrd_phy 0>, <&usbdrd_phy 1>;
phy-names = "usb2-phy", "usb3-phy";
--
2.34.1



2023-01-27 21:28:31

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [RFT PATCH v3 2/4] ARM: dts: exynos: add unit address to DWC3 node wrapper in Exynos54xx

Neither simple-bus bindings nor dtc W=1 accept device nodes in soc@ node
which do not have unit address. Therefore usethe address space
of child device (actual DWC3 Controller) as the wrapper's address to
fix:

exynos5422-odroidhc1.dtb: soc: usb3-0: {'compatible': ['samsung,exynos5250-dwusb3'],
... } should not be valid under {'type': 'object'}

exynos54xx.dtsi:145.21-159.5: Warning (simple_bus_reg): /soc/usb3-0: missing or empty reg/ranges property

Signed-off-by: Krzysztof Kozlowski <[email protected]>

---

Changes since v1:
1. Use ranges with values and drop reg from usb-wrapper node.
2. Keep "usb" as wrapper's node name.
---
arch/arm/boot/dts/exynos54xx.dtsi | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/arch/arm/boot/dts/exynos54xx.dtsi b/arch/arm/boot/dts/exynos54xx.dtsi
index 3ec43761d8b9..5c799886c275 100644
--- a/arch/arm/boot/dts/exynos54xx.dtsi
+++ b/arch/arm/boot/dts/exynos54xx.dtsi
@@ -142,15 +142,15 @@ hsi2c_7: i2c@12cd0000 {
status = "disabled";
};

- usbdrd3_0: usb3-0 {
+ usbdrd3_0: usb@12000000 {
compatible = "samsung,exynos5250-dwusb3";
#address-cells = <1>;
#size-cells = <1>;
- ranges;
+ ranges = <0x0 0x12000000 0x10000>;

- usbdrd_dwc3_0: usb@12000000 {
+ usbdrd_dwc3_0: usb@0 {
compatible = "snps,dwc3";
- reg = <0x12000000 0x10000>;
+ reg = <0x0 0x10000>;
interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>;
phys = <&usbdrd_phy0 0>, <&usbdrd_phy0 1>;
phy-names = "usb2-phy", "usb3-phy";
@@ -164,15 +164,15 @@ usbdrd_phy0: phy@12100000 {
#phy-cells = <1>;
};

- usbdrd3_1: usb3-1 {
+ usbdrd3_1: usb@12400000 {
compatible = "samsung,exynos5250-dwusb3";
#address-cells = <1>;
#size-cells = <1>;
- ranges;
+ ranges = <0x0 0x12400000 0x10000>;

- usbdrd_dwc3_1: usb@12400000 {
+ usbdrd_dwc3_1: usb@0 {
compatible = "snps,dwc3";
- reg = <0x12400000 0x10000>;
+ reg = <0x0 0x10000>;
phys = <&usbdrd_phy1 0>, <&usbdrd_phy1 1>;
phy-names = "usb2-phy", "usb3-phy";
snps,dis_u3_susphy_quirk;
--
2.34.1


2023-01-27 21:28:31

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [RFT PATCH v3 3/4] arm64: dts: exynos: add unit address to DWC3 node wrapper in Exynos5433

Neither simple-bus bindings nor dtc W=1 accept device nodes in soc@ node
which do not have unit address. Therefore usethe address space
of child device (actual DWC3 Controller) as the wrapper's address to
fix:

exynos5433-tm2e.dtb: soc@0: usbdrd: {'compatible': ['samsung,exynos5433-dwusb3'], ...
should not be valid under {'type': 'object'}

Signed-off-by: Krzysztof Kozlowski <[email protected]>

---

Changes since v2:
1. Fix typo/build error.

Changes since v1:
1. New patch
---
arch/arm64/boot/dts/exynos/exynos5433.dtsi | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
index 9da24fe958a3..5519a80576c5 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
@@ -1742,7 +1742,7 @@ hsi2c_11: i2c@14df0000 {
status = "disabled";
};

- usbdrd30: usbdrd {
+ usbdrd30: usb@15400000 {
compatible = "samsung,exynos5433-dwusb3";
clocks = <&cmu_fsys CLK_ACLK_USBDRD30>,
<&cmu_fsys CLK_SCLK_USBDRD30>,
@@ -1751,16 +1751,16 @@ usbdrd30: usbdrd {
clock-names = "aclk", "susp_clk", "phyclk", "pipe_pclk";
#address-cells = <1>;
#size-cells = <1>;
- ranges;
+ ranges = <0x0 0x15400000 0x10000>;
status = "disabled";

- usbdrd_dwc3: usb@15400000 {
+ usbdrd_dwc3: usb@0 {
compatible = "snps,dwc3";
clocks = <&cmu_fsys CLK_SCLK_USBDRD30>,
<&cmu_fsys CLK_ACLK_USBDRD30>,
<&cmu_fsys CLK_SCLK_USBDRD30>;
clock-names = "ref", "bus_early", "suspend";
- reg = <0x15400000 0x10000>;
+ reg = <0x0 0x10000>;
interrupts = <GIC_SPI 231 IRQ_TYPE_LEVEL_HIGH>;
phys = <&usbdrd30_phy 0>, <&usbdrd30_phy 1>;
phy-names = "usb2-phy", "usb3-phy";
@@ -1795,7 +1795,7 @@ usbhost30_phy: phy@15580000 {
status = "disabled";
};

- usbhost30: usbhost {
+ usbhost30: usb@15a00000 {
compatible = "samsung,exynos5433-dwusb3";
clocks = <&cmu_fsys CLK_ACLK_USBHOST30>,
<&cmu_fsys CLK_SCLK_USBHOST30>,
@@ -1804,16 +1804,16 @@ usbhost30: usbhost {
clock-names = "aclk", "susp_clk", "phyclk", "pipe_pclk";
#address-cells = <1>;
#size-cells = <1>;
- ranges;
+ ranges = <0x0 0x15a00000 0x10000>;
status = "disabled";

- usbhost_dwc3: usb@15a00000 {
+ usbhost_dwc3: usb@0 {
compatible = "snps,dwc3";
clocks = <&cmu_fsys CLK_SCLK_USBHOST30>,
<&cmu_fsys CLK_ACLK_USBHOST30>,
<&cmu_fsys CLK_SCLK_USBHOST30>;
clock-names = "ref", "bus_early", "suspend";
- reg = <0x15a00000 0x10000>;
+ reg = <0x0 0x10000>;
interrupts = <GIC_SPI 244 IRQ_TYPE_LEVEL_HIGH>;
phys = <&usbhost30_phy 0>, <&usbhost30_phy 1>;
phy-names = "usb2-phy", "usb3-phy";
--
2.34.1


2023-01-27 21:28:31

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [RFT PATCH v3 4/4] arm64: dts: exynos: add unit address to DWC3 node wrapper in Exynos7

Neither simple-bus bindings nor dtc W=1 accept device nodes in soc@ node
which do not have unit address. Therefore usethe address space
of child device (actual DWC3 Controller) as the wrapper's address to
fix:

exynos7-espresso.dtb: soc@0: usb: {'compatible': ['samsung,exynos7-dwusb3'], ...
should not be valid under {'type': 'object'}

Signed-off-by: Krzysztof Kozlowski <[email protected]>

---

Changes since v1:
1. New patch
---
arch/arm64/boot/dts/exynos/exynos7.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi
index 82fee1b7caab..b1fa68835b09 100644
--- a/arch/arm64/boot/dts/exynos/exynos7.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi
@@ -690,7 +690,7 @@ usbdrd_phy: phy@15500000 {
#phy-cells = <1>;
};

- usbdrd: usb {
+ usbdrd: usb@15400000 {
compatible = "samsung,exynos7-dwusb3";
clocks = <&clock_fsys0 ACLK_USBDRD300>,
<&clock_fsys0 SCLK_USBDRD300_SUSPENDCLK>,
@@ -699,11 +699,11 @@ usbdrd: usb {
"usbdrd30_axius_clk";
#address-cells = <1>;
#size-cells = <1>;
- ranges;
+ ranges = <0x0 0x15400000 0x10000>;

- usb@15400000 {
+ usb@0 {
compatible = "snps,dwc3";
- reg = <0x15400000 0x10000>;
+ reg = <0x0 0x10000>;
interrupts = <GIC_SPI 223 IRQ_TYPE_LEVEL_HIGH>;
phys = <&usbdrd_phy 0>, <&usbdrd_phy 1>;
phy-names = "usb2-phy", "usb3-phy";
--
2.34.1


2023-01-27 22:02:08

by Marek Szyprowski

[permalink] [raw]
Subject: Re: [RFT PATCH v3 1/4] ARM: dts: exynos: add unit address to DWC3 node wrapper in Exynos5250

On 27.01.2023 22:27, Krzysztof Kozlowski wrote:
> Neither simple-bus bindings nor dtc W=1 accept device nodes in soc@ node
> which do not have unit address. Therefore usethe address space
> of child device (actual DWC3 Controller) as the wrapper's address to
> fix:
>
> exynos5250-smdk5250.dtb: soc: usb3: {'compatible': ['samsung,exynos5250-dwusb3'],
> ... } should not be valid under {'type': 'object'}
>
> exynos5250.dtsi:638.16-653.5: Warning (simple_bus_reg): /soc/usb3: missing or empty reg/ranges property
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
Tested-by: Marek Szyprowski <[email protected]>
> ---
>
> Changes since v1:
> 1. Use ranges with values and drop reg from usb-wrapper node.
> 2. Keep "usb" as wrapper's node name.
> ---
> arch/arm/boot/dts/exynos5250.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index 97e89859ba3d..a5db4ac213d5 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -635,17 +635,17 @@ i2s2: i2s@12d70000 {
> #sound-dai-cells = <1>;
> };
>
> - usbdrd: usb3 {
> + usbdrd: usb@12000000 {
> compatible = "samsung,exynos5250-dwusb3";
> clocks = <&clock CLK_USB3>;
> clock-names = "usbdrd30";
> #address-cells = <1>;
> #size-cells = <1>;
> - ranges;
> + ranges = <0x0 0x12000000 0x10000>;
>
> - usbdrd_dwc3: usb@12000000 {
> + usbdrd_dwc3: usb@0 {
> compatible = "snps,dwc3";
> - reg = <0x12000000 0x10000>;
> + reg = <0x0 0x10000>;
> interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>;
> phys = <&usbdrd_phy 0>, <&usbdrd_phy 1>;
> phy-names = "usb2-phy", "usb3-phy";

Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland


2023-01-27 22:02:19

by Marek Szyprowski

[permalink] [raw]
Subject: Re: [RFT PATCH v3 2/4] ARM: dts: exynos: add unit address to DWC3 node wrapper in Exynos54xx

On 27.01.2023 22:27, Krzysztof Kozlowski wrote:
> Neither simple-bus bindings nor dtc W=1 accept device nodes in soc@ node
> which do not have unit address. Therefore usethe address space
> of child device (actual DWC3 Controller) as the wrapper's address to
> fix:
>
> exynos5422-odroidhc1.dtb: soc: usb3-0: {'compatible': ['samsung,exynos5250-dwusb3'],
> ... } should not be valid under {'type': 'object'}
>
> exynos54xx.dtsi:145.21-159.5: Warning (simple_bus_reg): /soc/usb3-0: missing or empty reg/ranges property
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
Tested-by: Marek Szyprowski <[email protected]>
> ---
>
> Changes since v1:
> 1. Use ranges with values and drop reg from usb-wrapper node.
> 2. Keep "usb" as wrapper's node name.
> ---
> arch/arm/boot/dts/exynos54xx.dtsi | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos54xx.dtsi b/arch/arm/boot/dts/exynos54xx.dtsi
> index 3ec43761d8b9..5c799886c275 100644
> --- a/arch/arm/boot/dts/exynos54xx.dtsi
> +++ b/arch/arm/boot/dts/exynos54xx.dtsi
> @@ -142,15 +142,15 @@ hsi2c_7: i2c@12cd0000 {
> status = "disabled";
> };
>
> - usbdrd3_0: usb3-0 {
> + usbdrd3_0: usb@12000000 {
> compatible = "samsung,exynos5250-dwusb3";
> #address-cells = <1>;
> #size-cells = <1>;
> - ranges;
> + ranges = <0x0 0x12000000 0x10000>;
>
> - usbdrd_dwc3_0: usb@12000000 {
> + usbdrd_dwc3_0: usb@0 {
> compatible = "snps,dwc3";
> - reg = <0x12000000 0x10000>;
> + reg = <0x0 0x10000>;
> interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>;
> phys = <&usbdrd_phy0 0>, <&usbdrd_phy0 1>;
> phy-names = "usb2-phy", "usb3-phy";
> @@ -164,15 +164,15 @@ usbdrd_phy0: phy@12100000 {
> #phy-cells = <1>;
> };
>
> - usbdrd3_1: usb3-1 {
> + usbdrd3_1: usb@12400000 {
> compatible = "samsung,exynos5250-dwusb3";
> #address-cells = <1>;
> #size-cells = <1>;
> - ranges;
> + ranges = <0x0 0x12400000 0x10000>;
>
> - usbdrd_dwc3_1: usb@12400000 {
> + usbdrd_dwc3_1: usb@0 {
> compatible = "snps,dwc3";
> - reg = <0x12400000 0x10000>;
> + reg = <0x0 0x10000>;
> phys = <&usbdrd_phy1 0>, <&usbdrd_phy1 1>;
> phy-names = "usb2-phy", "usb3-phy";
> snps,dis_u3_susphy_quirk;

Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland


2023-01-27 22:02:39

by Marek Szyprowski

[permalink] [raw]
Subject: Re: [RFT PATCH v3 3/4] arm64: dts: exynos: add unit address to DWC3 node wrapper in Exynos5433

On 27.01.2023 22:27, Krzysztof Kozlowski wrote:
> Neither simple-bus bindings nor dtc W=1 accept device nodes in soc@ node
> which do not have unit address. Therefore usethe address space
> of child device (actual DWC3 Controller) as the wrapper's address to
> fix:
>
> exynos5433-tm2e.dtb: soc@0: usbdrd: {'compatible': ['samsung,exynos5433-dwusb3'], ...
> should not be valid under {'type': 'object'}
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
Tested-by: Marek Szyprowski <[email protected]>
> ---
>
> Changes since v2:
> 1. Fix typo/build error.
>
> Changes since v1:
> 1. New patch
> ---
> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> index 9da24fe958a3..5519a80576c5 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> @@ -1742,7 +1742,7 @@ hsi2c_11: i2c@14df0000 {
> status = "disabled";
> };
>
> - usbdrd30: usbdrd {
> + usbdrd30: usb@15400000 {
> compatible = "samsung,exynos5433-dwusb3";
> clocks = <&cmu_fsys CLK_ACLK_USBDRD30>,
> <&cmu_fsys CLK_SCLK_USBDRD30>,
> @@ -1751,16 +1751,16 @@ usbdrd30: usbdrd {
> clock-names = "aclk", "susp_clk", "phyclk", "pipe_pclk";
> #address-cells = <1>;
> #size-cells = <1>;
> - ranges;
> + ranges = <0x0 0x15400000 0x10000>;
> status = "disabled";
>
> - usbdrd_dwc3: usb@15400000 {
> + usbdrd_dwc3: usb@0 {
> compatible = "snps,dwc3";
> clocks = <&cmu_fsys CLK_SCLK_USBDRD30>,
> <&cmu_fsys CLK_ACLK_USBDRD30>,
> <&cmu_fsys CLK_SCLK_USBDRD30>;
> clock-names = "ref", "bus_early", "suspend";
> - reg = <0x15400000 0x10000>;
> + reg = <0x0 0x10000>;
> interrupts = <GIC_SPI 231 IRQ_TYPE_LEVEL_HIGH>;
> phys = <&usbdrd30_phy 0>, <&usbdrd30_phy 1>;
> phy-names = "usb2-phy", "usb3-phy";
> @@ -1795,7 +1795,7 @@ usbhost30_phy: phy@15580000 {
> status = "disabled";
> };
>
> - usbhost30: usbhost {
> + usbhost30: usb@15a00000 {
> compatible = "samsung,exynos5433-dwusb3";
> clocks = <&cmu_fsys CLK_ACLK_USBHOST30>,
> <&cmu_fsys CLK_SCLK_USBHOST30>,
> @@ -1804,16 +1804,16 @@ usbhost30: usbhost {
> clock-names = "aclk", "susp_clk", "phyclk", "pipe_pclk";
> #address-cells = <1>;
> #size-cells = <1>;
> - ranges;
> + ranges = <0x0 0x15a00000 0x10000>;
> status = "disabled";
>
> - usbhost_dwc3: usb@15a00000 {
> + usbhost_dwc3: usb@0 {
> compatible = "snps,dwc3";
> clocks = <&cmu_fsys CLK_SCLK_USBHOST30>,
> <&cmu_fsys CLK_ACLK_USBHOST30>,
> <&cmu_fsys CLK_SCLK_USBHOST30>;
> clock-names = "ref", "bus_early", "suspend";
> - reg = <0x15a00000 0x10000>;
> + reg = <0x0 0x10000>;
> interrupts = <GIC_SPI 244 IRQ_TYPE_LEVEL_HIGH>;
> phys = <&usbhost30_phy 0>, <&usbhost30_phy 1>;
> phy-names = "usb2-phy", "usb3-phy";

Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland


2023-01-28 08:06:18

by Alim Akhtar

[permalink] [raw]
Subject: RE: [RFT PATCH v3 4/4] arm64: dts: exynos: add unit address to DWC3 node wrapper in Exynos7



> -----Original Message-----
> From: Krzysztof Kozlowski <[email protected]>
> Sent: Saturday, January 28, 2023 2:57 AM
> To: Rob Herring <[email protected]>; Krzysztof Kozlowski
> <[email protected]>; Alim Akhtar
> <[email protected]>; [email protected]; linux-arm-
> [email protected]; [email protected]; linux-
> [email protected]
> Cc: [email protected]; [email protected];
> ~postmarketos/[email protected]; Martin Jücker
> <[email protected]>; Henrik Grimler <[email protected]>; Sam
> Protsenko <[email protected]>; Chanho Park
> <[email protected]>; Marek Szyprowski
> <[email protected]>; Chanwoo Choi
> <[email protected]>; Krzysztof Kozlowski
> <[email protected]>
> Subject: [RFT PATCH v3 4/4] arm64: dts: exynos: add unit address to DWC3
> node wrapper in Exynos7
>
> Neither simple-bus bindings nor dtc W=1 accept device nodes in soc@ node
> which do not have unit address. Therefore usethe address space of child
> device (actual DWC3 Controller) as the wrapper's address to
> fix:
>
> exynos7-espresso.dtb: soc@0: usb: {'compatible': ['samsung,exynos7-
> dwusb3'], ...
> should not be valid under {'type': 'object'}
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
Reviewed-by: Alim Akhtar <[email protected]>

Tested on exynos7-espresso and xHCI driver still gets probed, so

Tested-by: Alim Akhtar <[email protected]>


>
> Changes since v1:
> 1. New patch
> ---
> arch/arm64/boot/dts/exynos/exynos7.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi
> b/arch/arm64/boot/dts/exynos/exynos7.dtsi
> index 82fee1b7caab..b1fa68835b09 100644
> --- a/arch/arm64/boot/dts/exynos/exynos7.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi
> @@ -690,7 +690,7 @@ usbdrd_phy: phy@15500000 {
> #phy-cells = <1>;
> };
>
> - usbdrd: usb {
> + usbdrd: usb@15400000 {
> compatible = "samsung,exynos7-dwusb3";
> clocks = <&clock_fsys0 ACLK_USBDRD300>,
> <&clock_fsys0 SCLK_USBDRD300_SUSPENDCLK>,
> @@ -699,11 +699,11 @@ usbdrd: usb {
> "usbdrd30_axius_clk";
> #address-cells = <1>;
> #size-cells = <1>;
> - ranges;
> + ranges = <0x0 0x15400000 0x10000>;
>
> - usb@15400000 {
> + usb@0 {
> compatible = "snps,dwc3";
> - reg = <0x15400000 0x10000>;
> + reg = <0x0 0x10000>;
> interrupts = <GIC_SPI 223
> IRQ_TYPE_LEVEL_HIGH>;
> phys = <&usbdrd_phy 0>, <&usbdrd_phy 1>;
> phy-names = "usb2-phy", "usb3-phy";
> --
> 2.34.1




2023-01-29 10:40:56

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [RFT PATCH v3 1/4] ARM: dts: exynos: add unit address to DWC3 node wrapper in Exynos5250

On Fri, 27 Jan 2023 22:27:10 +0100, Krzysztof Kozlowski wrote:
> Neither simple-bus bindings nor dtc W=1 accept device nodes in soc@ node
> which do not have unit address. Therefore usethe address space
> of child device (actual DWC3 Controller) as the wrapper's address to
> fix:
>
> exynos5250-smdk5250.dtb: soc: usb3: {'compatible': ['samsung,exynos5250-dwusb3'],
> ... } should not be valid under {'type': 'object'}
>
> [...]

Applied, thanks!

[1/4] ARM: dts: exynos: add unit address to DWC3 node wrapper in Exynos5250
https://git.kernel.org/krzk/linux/c/47fea512b4bd18b0a69142f85bf1863c221539ef
[2/4] ARM: dts: exynos: add unit address to DWC3 node wrapper in Exynos54xx
https://git.kernel.org/krzk/linux/c/27be20e3b9d125f2c1b066d1d238c67bf5b89dc3
[3/4] arm64: dts: exynos: add unit address to DWC3 node wrapper in Exynos5433
https://git.kernel.org/krzk/linux/c/becad83e0f2a54c8a43ece3f0437b72842278a42
[4/4] arm64: dts: exynos: add unit address to DWC3 node wrapper in Exynos7
https://git.kernel.org/krzk/linux/c/28dd277e54ebb499bc59c166078596767bbbbdd7

Best regards,
--
Krzysztof Kozlowski <[email protected]>