Remove unused function in afs/write.c.
This eliminates the following warning in afs/write.c:
fs/afs/write.c:749:5: warning: no previous prototype for ‘afs_page_mkwrite’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria <[email protected]>
Reviewed-by: Josh Triplett <[email protected]>
---
fs/afs/write.c | 21 ---------------------
1 file changed, 21 deletions(-)
diff --git a/fs/afs/write.c b/fs/afs/write.c
index a890db4..2dd54b9 100644
--- a/fs/afs/write.c
+++ b/fs/afs/write.c
@@ -741,24 +741,3 @@ out:
mutex_unlock(&inode->i_mutex);
return ret;
}
-
-/*
- * notification that a previously read-only page is about to become writable
- * - if it returns an error, the caller will deliver a bus error signal
- */
-int afs_page_mkwrite(struct vm_area_struct *vma, struct page *page)
-{
- struct afs_vnode *vnode = AFS_FS_I(vma->vm_file->f_mapping->host);
-
- _enter("{{%x:%u}},{%lx}",
- vnode->fid.vid, vnode->fid.vnode, page->index);
-
- /* wait for the page to be written to the cache before we allow it to
- * be modified */
-#ifdef CONFIG_AFS_FSCACHE
- fscache_wait_on_page_write(vnode->cache, page);
-#endif
-
- _leave(" = 0");
- return 0;
-}
--
1.7.9.5
Include appropriate header file fs/dlm/ast.h in fs/dlm/ast.c because it
contains function prototypes of some functions defined in fs/dlm/ast.c.
This also eliminates the following warning in fs/dlm/ast:
fs/dlm/ast.c:52:5: warning: no previous prototype for ‘dlm_add_lkb_callback’ [-Wmissing-prototypes]
fs/dlm/ast.c:113:5: warning: no previous prototype for ‘dlm_rem_lkb_callback’ [-Wmissing-prototypes]
fs/dlm/ast.c:174:6: warning: no previous prototype for ‘dlm_add_cb’ [-Wmissing-prototypes]
fs/dlm/ast.c:212:6: warning: no previous prototype for ‘dlm_callback_work’ [-Wmissing-prototypes]
fs/dlm/ast.c:267:5: warning: no previous prototype for ‘dlm_callback_start’ [-Wmissing-prototypes]
fs/dlm/ast.c:278:6: warning: no previous prototype for ‘dlm_callback_stop’ [-Wmissing-prototypes]
fs/dlm/ast.c:284:6: warning: no previous prototype for ‘dlm_callback_suspend’ [-Wmissing-prototypes]
fs/dlm/ast.c:292:6: warning: no previous prototype for ‘dlm_callback_resume’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria <[email protected]>
---
fs/dlm/ast.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/dlm/ast.c b/fs/dlm/ast.c
index 0e90f0c..42794c0 100644
--- a/fs/dlm/ast.c
+++ b/fs/dlm/ast.c
@@ -14,6 +14,7 @@
#include "dlm_internal.h"
#include "lock.h"
#include "user.h"
+#include "ast.h"
static uint64_t dlm_cb_seq;
static DEFINE_SPINLOCK(dlm_cb_seq_spin);
--
1.7.9.5
Mark functions as static in bio-integrity.c because it is not used
outside this file.
This eliminates the following warnings in bio-integrity.c:
fs/bio-integrity.c:224:5: warning: no previous prototype for ‘bio_integrity_tag’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria <[email protected]>
---
fs/bio-integrity.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/bio-integrity.c b/fs/bio-integrity.c
index 0bad24d..51d15ae 100644
--- a/fs/bio-integrity.c
+++ b/fs/bio-integrity.c
@@ -226,7 +226,8 @@ unsigned int bio_integrity_tag_size(struct bio *bio)
}
EXPORT_SYMBOL(bio_integrity_tag_size);
-int bio_integrity_tag(struct bio *bio, void *tag_buf, unsigned int len, int set)
+static int bio_integrity_tag(struct bio *bio, void *tag_buf, unsigned int len,
+ int set)
{
struct bio_integrity_payload *bip = bio->bi_integrity;
struct blk_integrity *bi = bdev_get_integrity(bio->bi_bdev);
--
1.7.9.5
Add prototype declaration to header file include/linux/bio.h because it
is used by more than one file.
This eliminates the following warning in bio-integrity.c:
fs/bio-integrity.c:214:14: warning: no previous prototype for ‘bio_integrity_tag_size’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria <[email protected]>
---
Some of the API functions like bio_integrity_tag_size appears to be
entirely unused. Such occurences should be pruned because they haven't
been used in any driver.
include/linux/bio.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/bio.h b/include/linux/bio.h
index 7065452..d6791bb 100644
--- a/include/linux/bio.h
+++ b/include/linux/bio.h
@@ -332,6 +332,7 @@ extern struct bio *bio_clone_fast(struct bio *, gfp_t, struct bio_set *);
extern struct bio *bio_clone_bioset(struct bio *, gfp_t, struct bio_set *bs);
extern struct bio_set *fs_bio_set;
+unsigned int bio_integrity_tag_size(struct bio *bio);
static inline struct bio *bio_alloc(gfp_t gfp_mask, unsigned int nr_iovecs)
{
--
1.7.9.5
Mark function as static in exofs/super.c because it is not used outside
this file.
This also eliminates the following warning in exofs/super.c:
fs/exofs/super.c:546:5: warning: no previous prototype for ‘__alloc_dev_table’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria <[email protected]>
Reviewed-by: Josh Triplett <[email protected]>
---
fs/exofs/super.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/exofs/super.c b/fs/exofs/super.c
index 9d97633..57f59a2 100644
--- a/fs/exofs/super.c
+++ b/fs/exofs/super.c
@@ -543,8 +543,8 @@ static int exofs_devs_2_odi(struct exofs_dt_device_info *dt_dev,
return !(odi->systemid_len || odi->osdname_len);
}
-int __alloc_dev_table(struct exofs_sb_info *sbi, unsigned numdevs,
- struct exofs_dev **peds)
+static int __alloc_dev_table(struct exofs_sb_info *sbi, unsigned numdevs,
+ struct exofs_dev **peds)
{
struct __alloc_ore_devs_and_exofs_devs {
/* Twice bigger table: See exofs_init_comps() and comment at
--
1.7.9.5
Mark functions as static in exofs/ore_raid.c because they are not used
outside this file.
This also eliminates the following warning in exofs/ore_raid.c:
fs/exofs/ore_raid.c:24:14: warning: no previous prototype for ‘_raid_page_alloc’ [-Wmissing-prototypes]
fs/exofs/ore_raid.c:29:6: warning: no previous prototype for ‘_raid_page_free’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria <[email protected]>
Reviewed-by: Josh Triplett <[email protected]>
---
fs/exofs/ore_raid.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/exofs/ore_raid.c b/fs/exofs/ore_raid.c
index 7682b97..4e2c032 100644
--- a/fs/exofs/ore_raid.c
+++ b/fs/exofs/ore_raid.c
@@ -21,12 +21,12 @@
#undef ORE_DBGMSG2
#define ORE_DBGMSG2 ORE_DBGMSG
-struct page *_raid_page_alloc(void)
+static struct page *_raid_page_alloc(void)
{
return alloc_page(GFP_KERNEL);
}
-void _raid_page_free(struct page *p)
+static void _raid_page_free(struct page *p)
{
__free_page(p);
}
--
1.7.9.5
Mark function as static in ext2/xattr_security.c because it is not
used outside this file.
This also elimiantes the following warning in ext2/xattr_security.c:
fs/ext2/xattr_security.c:45:5: warning: no previous prototype for ‘ext2_initxattrs’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria <[email protected]>
Reviewed-by: Josh Triplett <[email protected]>
---
fs/ext2/xattr_security.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/ext2/xattr_security.c b/fs/ext2/xattr_security.c
index cfedb2c..c0ebc4d 100644
--- a/fs/ext2/xattr_security.c
+++ b/fs/ext2/xattr_security.c
@@ -42,8 +42,8 @@ ext2_xattr_security_set(struct dentry *dentry, const char *name,
value, size, flags);
}
-int ext2_initxattrs(struct inode *inode, const struct xattr *xattr_array,
- void *fs_info)
+static int ext2_initxattrs(struct inode *inode, const struct xattr *xattr_array,
+ void *fs_info)
{
const struct xattr *xattr;
int err = 0;
--
1.7.9.5
On Sun, Feb 09, 2014 at 06:19:17PM +0530, Rashika Kheria wrote:
> Include appropriate header file fs/dlm/ast.h in fs/dlm/ast.c because it
> contains function prototypes of some functions defined in fs/dlm/ast.c.
>
> This also eliminates the following warning in fs/dlm/ast:
> fs/dlm/ast.c:52:5: warning: no previous prototype for ‘dlm_add_lkb_callback’ [-Wmissing-prototypes]
> fs/dlm/ast.c:113:5: warning: no previous prototype for ‘dlm_rem_lkb_callback’ [-Wmissing-prototypes]
> fs/dlm/ast.c:174:6: warning: no previous prototype for ‘dlm_add_cb’ [-Wmissing-prototypes]
> fs/dlm/ast.c:212:6: warning: no previous prototype for ‘dlm_callback_work’ [-Wmissing-prototypes]
> fs/dlm/ast.c:267:5: warning: no previous prototype for ‘dlm_callback_start’ [-Wmissing-prototypes]
> fs/dlm/ast.c:278:6: warning: no previous prototype for ‘dlm_callback_stop’ [-Wmissing-prototypes]
> fs/dlm/ast.c:284:6: warning: no previous prototype for ‘dlm_callback_suspend’ [-Wmissing-prototypes]
> fs/dlm/ast.c:292:6: warning: no previous prototype for ‘dlm_callback_resume’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <[email protected]>
Reviewed-by: Josh Triplett <[email protected]>
> fs/dlm/ast.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/dlm/ast.c b/fs/dlm/ast.c
> index 0e90f0c..42794c0 100644
> --- a/fs/dlm/ast.c
> +++ b/fs/dlm/ast.c
> @@ -14,6 +14,7 @@
> #include "dlm_internal.h"
> #include "lock.h"
> #include "user.h"
> +#include "ast.h"
>
> static uint64_t dlm_cb_seq;
> static DEFINE_SPINLOCK(dlm_cb_seq_spin);
> --
> 1.7.9.5
>
On Sun, Feb 09, 2014 at 06:22:53PM +0530, Rashika Kheria wrote:
> Mark functions as static in bio-integrity.c because it is not used
> outside this file.
>
> This eliminates the following warnings in bio-integrity.c:
> fs/bio-integrity.c:224:5: warning: no previous prototype for ‘bio_integrity_tag’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <[email protected]>
Reviewed-by: Josh Triplett <[email protected]>
> fs/bio-integrity.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/bio-integrity.c b/fs/bio-integrity.c
> index 0bad24d..51d15ae 100644
> --- a/fs/bio-integrity.c
> +++ b/fs/bio-integrity.c
> @@ -226,7 +226,8 @@ unsigned int bio_integrity_tag_size(struct bio *bio)
> }
> EXPORT_SYMBOL(bio_integrity_tag_size);
>
> -int bio_integrity_tag(struct bio *bio, void *tag_buf, unsigned int len, int set)
> +static int bio_integrity_tag(struct bio *bio, void *tag_buf, unsigned int len,
> + int set)
> {
> struct bio_integrity_payload *bip = bio->bi_integrity;
> struct blk_integrity *bi = bdev_get_integrity(bio->bi_bdev);
> --
> 1.7.9.5
>
On Sun, Feb 09, 2014 at 06:30:39PM +0530, Rashika Kheria wrote:
> Add prototype declaration to header file include/linux/bio.h because it
> is used by more than one file.
>
> This eliminates the following warning in bio-integrity.c:
> fs/bio-integrity.c:214:14: warning: no previous prototype for ‘bio_integrity_tag_size’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <[email protected]>
Reviewed-by: Josh Triplett <[email protected]>
> Some of the API functions like bio_integrity_tag_size appears to be
> entirely unused. Such occurences should be pruned because they haven't
> been used in any driver.
>
> include/linux/bio.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/bio.h b/include/linux/bio.h
> index 7065452..d6791bb 100644
> --- a/include/linux/bio.h
> +++ b/include/linux/bio.h
> @@ -332,6 +332,7 @@ extern struct bio *bio_clone_fast(struct bio *, gfp_t, struct bio_set *);
> extern struct bio *bio_clone_bioset(struct bio *, gfp_t, struct bio_set *bs);
>
> extern struct bio_set *fs_bio_set;
> +unsigned int bio_integrity_tag_size(struct bio *bio);
>
> static inline struct bio *bio_alloc(gfp_t gfp_mask, unsigned int nr_iovecs)
> {
> --
> 1.7.9.5
>
Mark function as static in ext3/dir.c because it is not used outside
this file.
This also eliminates the following warning in ext3/dir.c:
fs/ext3/dir.c:278:8: warning: no previous prototype for ‘ext3_dir_llseek’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria <[email protected]>
Reviewed-by: Josh Triplett <[email protected]>
---
fs/ext3/dir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext3/dir.c b/fs/ext3/dir.c
index e66e480..17742ee 100644
--- a/fs/ext3/dir.c
+++ b/fs/ext3/dir.c
@@ -275,7 +275,7 @@ static inline loff_t ext3_get_htree_eof(struct file *filp)
* NOTE: offsets obtained *before* ext3_set_inode_flag(dir, EXT3_INODE_INDEX)
* will be invalid once the directory was converted into a dx directory
*/
-loff_t ext3_dir_llseek(struct file *file, loff_t offset, int whence)
+static loff_t ext3_dir_llseek(struct file *file, loff_t offset, int whence)
{
struct inode *inode = file->f_mapping->host;
int dx_dir = is_dx_dir(inode);
--
1.7.9.5
Mark function as static in ext3/xattr_security.c because it is not used
outside this file.
This eliminates the following warning in ext3/xattr_security.c:
fs/ext3/xattr_security.c:46:5: warning: no previous prototype for ‘ext3_initxattrs’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria <[email protected]>
Reviewed-by: Josh Triplett <[email protected]>
---
fs/ext3/xattr_security.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/fs/ext3/xattr_security.c b/fs/ext3/xattr_security.c
index 3387664..722c2bf 100644
--- a/fs/ext3/xattr_security.c
+++ b/fs/ext3/xattr_security.c
@@ -43,8 +43,9 @@ ext3_xattr_security_set(struct dentry *dentry, const char *name,
name, value, size, flags);
}
-int ext3_initxattrs(struct inode *inode, const struct xattr *xattr_array,
- void *fs_info)
+static int ext3_initxattrs(struct inode *inode,
+ const struct xattr *xattr_array,
+ void *fs_info)
{
const struct xattr *xattr;
handle_t *handle = fs_info;
--
1.7.9.5
Mark functions as static in gfs2/rgrp.c because they are not used
outside this file.
This eliminates the following warning in gfs2/rgrp.c:
fs/gfs2/rgrp.c:1092:5: warning: no previous prototype for ‘gfs2_rgrp_bh_get’ [-Wmissing-prototypes]
fs/gfs2/rgrp.c:1157:5: warning: no previous prototype for ‘update_rgrp_lvb’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria <[email protected]>
Reviewed-by: Josh Triplett <[email protected]>
---
fs/gfs2/rgrp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c
index a1da213..551b9e9 100644
--- a/fs/gfs2/rgrp.c
+++ b/fs/gfs2/rgrp.c
@@ -1102,7 +1102,7 @@ static u32 count_unlinked(struct gfs2_rgrpd *rgd)
* Returns: errno
*/
-int gfs2_rgrp_bh_get(struct gfs2_rgrpd *rgd)
+static int gfs2_rgrp_bh_get(struct gfs2_rgrpd *rgd)
{
struct gfs2_sbd *sdp = rgd->rd_sbd;
struct gfs2_glock *gl = rgd->rd_gl;
@@ -1169,7 +1169,7 @@ fail:
return error;
}
-int update_rgrp_lvb(struct gfs2_rgrpd *rgd)
+static int update_rgrp_lvb(struct gfs2_rgrpd *rgd)
{
u32 rl_flags;
--
1.7.9.5
Mark functions as static in jbd2/journal.c because they are not used
outside this file.
This eliminates the following warning in jbd2/journal.c:
fs/jbd2/journal.c:125:5: warning: no previous prototype for ‘jbd2_verify_csum_type’ [-Wmissing-prototypes]
fs/jbd2/journal.c:146:5: warning: no previous prototype for ‘jbd2_superblock_csum_verify’ [-Wmissing-prototypes]
fs/jbd2/journal.c:154:6: warning: no previous prototype for ‘jbd2_superblock_csum_set’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria <[email protected]>
Reviewed-by: Josh Triplett <[email protected]>
---
fs/jbd2/journal.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
index 5fa344a..244b6f6 100644
--- a/fs/jbd2/journal.c
+++ b/fs/jbd2/journal.c
@@ -122,7 +122,7 @@ EXPORT_SYMBOL(__jbd2_debug);
#endif
/* Checksumming functions */
-int jbd2_verify_csum_type(journal_t *j, journal_superblock_t *sb)
+static int jbd2_verify_csum_type(journal_t *j, journal_superblock_t *sb)
{
if (!JBD2_HAS_INCOMPAT_FEATURE(j, JBD2_FEATURE_INCOMPAT_CSUM_V2))
return 1;
@@ -143,7 +143,7 @@ static __be32 jbd2_superblock_csum(journal_t *j, journal_superblock_t *sb)
return cpu_to_be32(csum);
}
-int jbd2_superblock_csum_verify(journal_t *j, journal_superblock_t *sb)
+static int jbd2_superblock_csum_verify(journal_t *j, journal_superblock_t *sb)
{
if (!JBD2_HAS_INCOMPAT_FEATURE(j, JBD2_FEATURE_INCOMPAT_CSUM_V2))
return 1;
@@ -151,7 +151,7 @@ int jbd2_superblock_csum_verify(journal_t *j, journal_superblock_t *sb)
return sb->s_checksum == jbd2_superblock_csum(j, sb);
}
-void jbd2_superblock_csum_set(journal_t *j, journal_superblock_t *sb)
+static void jbd2_superblock_csum_set(journal_t *j, journal_superblock_t *sb)
{
if (!JBD2_HAS_INCOMPAT_FEATURE(j, JBD2_FEATURE_INCOMPAT_CSUM_V2))
return;
--
1.7.9.5
Include appropriate header file fs/notify/fdinfo.h because it has
function prototypes of some function defined in fs/notify/fdinfo.c.
This eliminates the following warning in fs/notify/fdinfo.c:
fs/notify/fdinfo.c:103:5: warning: no previous prototype for ‘inotify_show_fdinfo’ [-Wmissing-prototypes]
fs/notify/fdinfo.c:146:5: warning: no previous prototype for ‘fanotify_show_fdinfo’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria <[email protected]>
Reviewed-by: Josh Triplett <[email protected]>
---
fs/notify/fdinfo.c | 1 +
fs/notify/fdinfo.h | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/fs/notify/fdinfo.c b/fs/notify/fdinfo.c
index 238a593..b9b7387 100644
--- a/fs/notify/fdinfo.c
+++ b/fs/notify/fdinfo.c
@@ -14,6 +14,7 @@
#include <linux/exportfs.h>
#include "inotify/inotify.h"
+#include "fdinfo.h"
#include "../fs/mount.h"
#if defined(CONFIG_PROC_FS)
diff --git a/fs/notify/fdinfo.h b/fs/notify/fdinfo.h
index 556afda..e8833eb 100644
--- a/fs/notify/fdinfo.h
+++ b/fs/notify/fdinfo.h
@@ -10,11 +10,11 @@ struct file;
#ifdef CONFIG_PROC_FS
#ifdef CONFIG_INOTIFY_USER
-extern int inotify_show_fdinfo(struct seq_file *m, struct file *f);
+int inotify_show_fdinfo(struct seq_file *m, struct file *f);
#endif
#ifdef CONFIG_FANOTIFY
-extern int fanotify_show_fdinfo(struct seq_file *m, struct file *f);
+int fanotify_show_fdinfo(struct seq_file *m, struct file *f);
#endif
#else /* CONFIG_PROC_FS */
--
1.7.9.5
Mark functions as static in ocfs/ioctl.c because they are not used
outside this file.
This eliminates the following warning in ocfs/ioctl.c:
fs/ocfs2/ioctl.c:145:5: warning: no previous prototype for ‘ocfs2_info_handle_blocksize’ [-Wmissing-prototypes]
fs/ocfs2/ioctl.c:169:5: warning: no previous prototype for ‘ocfs2_info_handle_clustersize’ [-Wmissing-prototypes]
fs/ocfs2/ioctl.c:194:5: warning: no previous prototype for ‘ocfs2_info_handle_maxslots’ [-Wmissing-prototypes]
fs/ocfs2/ioctl.c:219:5: warning: no previous prototype for ‘ocfs2_info_handle_label’ [-Wmissing-prototypes]
fs/ocfs2/ioctl.c:244:5: warning: no previous prototype for ‘ocfs2_info_handle_uuid’ [-Wmissing-prototypes]
fs/ocfs2/ioctl.c:269:5: warning: no previous prototype for ‘ocfs2_info_handle_fs_features’ [-Wmissing-prototypes]
fs/ocfs2/ioctl.c:296:5: warning: no previous prototype for ‘ocfs2_info_handle_journal_size’ [-Wmissing-prototypes]
fs/ocfs2/ioctl.c:321:5: warning: no previous prototype for ‘ocfs2_info_scan_inode_alloc’ [-Wmissing-prototypes]
fs/ocfs2/ioctl.c:368:5: warning: no previous prototype for ‘ocfs2_info_handle_freeinode’ [-Wmissing-prototypes]
fs/ocfs2/ioctl.c:463:6: warning: no previous prototype for ‘ocfs2_info_update_ffg’ [-Wmissing-prototypes]
fs/ocfs2/ioctl.c:470:5: warning: no previous prototype for ‘ocfs2_info_freefrag_scan_chain’ [-Wmissing-prototypes]
fs/ocfs2/ioctl.c:573:5: warning: no previous prototype for ‘ocfs2_info_freefrag_scan_bitmap’ [-Wmissing-prototypes]
fs/ocfs2/ioctl.c:653:5: warning: no previous prototype for ‘ocfs2_info_handle_freefrag’ [-Wmissing-prototypes]
fs/ocfs2/ioctl.c:724:5: warning: no previous prototype for ‘ocfs2_info_handle_unknown’ [-Wmissing-prototypes]
fs/ocfs2/ioctl.c:753:5: warning: no previous prototype for ‘ocfs2_info_handle_request’ [-Wmissing-prototypes]
fs/ocfs2/ioctl.c:812:5: warning: no previous prototype for ‘ocfs2_get_request_ptr’ [-Wmissing-prototypes]
fs/ocfs2/ioctl.c:850:5: warning: no previous prototype for ‘ocfs2_info_handle’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria <[email protected]>
Reviewed-by: Josh Triplett <[email protected]>
---
fs/ocfs2/ioctl.c | 80 +++++++++++++++++++++++++++---------------------------
1 file changed, 40 insertions(+), 40 deletions(-)
diff --git a/fs/ocfs2/ioctl.c b/fs/ocfs2/ioctl.c
index 8ca3c29..055b20c 100644
--- a/fs/ocfs2/ioctl.c
+++ b/fs/ocfs2/ioctl.c
@@ -143,8 +143,8 @@ bail:
return status;
}
-int ocfs2_info_handle_blocksize(struct inode *inode,
- struct ocfs2_info_request __user *req)
+static int ocfs2_info_handle_blocksize(struct inode *inode,
+ struct ocfs2_info_request __user *req)
{
int status = -EFAULT;
struct ocfs2_info_blocksize oib;
@@ -167,8 +167,8 @@ bail:
return status;
}
-int ocfs2_info_handle_clustersize(struct inode *inode,
- struct ocfs2_info_request __user *req)
+static int ocfs2_info_handle_clustersize(struct inode *inode,
+ struct ocfs2_info_request __user *req)
{
int status = -EFAULT;
struct ocfs2_info_clustersize oic;
@@ -192,8 +192,8 @@ bail:
return status;
}
-int ocfs2_info_handle_maxslots(struct inode *inode,
- struct ocfs2_info_request __user *req)
+static int ocfs2_info_handle_maxslots(struct inode *inode,
+ struct ocfs2_info_request __user *req)
{
int status = -EFAULT;
struct ocfs2_info_maxslots oim;
@@ -217,8 +217,8 @@ bail:
return status;
}
-int ocfs2_info_handle_label(struct inode *inode,
- struct ocfs2_info_request __user *req)
+static int ocfs2_info_handle_label(struct inode *inode,
+ struct ocfs2_info_request __user *req)
{
int status = -EFAULT;
struct ocfs2_info_label oil;
@@ -242,8 +242,8 @@ bail:
return status;
}
-int ocfs2_info_handle_uuid(struct inode *inode,
- struct ocfs2_info_request __user *req)
+static int ocfs2_info_handle_uuid(struct inode *inode,
+ struct ocfs2_info_request __user *req)
{
int status = -EFAULT;
struct ocfs2_info_uuid oiu;
@@ -267,8 +267,8 @@ bail:
return status;
}
-int ocfs2_info_handle_fs_features(struct inode *inode,
- struct ocfs2_info_request __user *req)
+static int ocfs2_info_handle_fs_features(struct inode *inode,
+ struct ocfs2_info_request __user *req)
{
int status = -EFAULT;
struct ocfs2_info_fs_features oif;
@@ -294,8 +294,8 @@ bail:
return status;
}
-int ocfs2_info_handle_journal_size(struct inode *inode,
- struct ocfs2_info_request __user *req)
+static int ocfs2_info_handle_journal_size(struct inode *inode,
+ struct ocfs2_info_request __user *req)
{
int status = -EFAULT;
struct ocfs2_info_journal_size oij;
@@ -319,9 +319,9 @@ bail:
return status;
}
-int ocfs2_info_scan_inode_alloc(struct ocfs2_super *osb,
- struct inode *inode_alloc, u64 blkno,
- struct ocfs2_info_freeinode *fi, u32 slot)
+static int ocfs2_info_scan_inode_alloc(struct ocfs2_super *osb,
+ struct inode *inode_alloc, u64 blkno,
+ struct ocfs2_info_freeinode *fi, u32 slot)
{
int status = 0, unlock = 0;
@@ -366,8 +366,8 @@ bail:
return status;
}
-int ocfs2_info_handle_freeinode(struct inode *inode,
- struct ocfs2_info_request __user *req)
+static int ocfs2_info_handle_freeinode(struct inode *inode,
+ struct ocfs2_info_request __user *req)
{
u32 i;
u64 blkno = -1;
@@ -461,19 +461,19 @@ static void o2ffg_update_stats(struct ocfs2_info_freefrag_stats *stats,
stats->ffs_free_chunks_real++;
}
-void ocfs2_info_update_ffg(struct ocfs2_info_freefrag *ffg,
- unsigned int chunksize)
+static void ocfs2_info_update_ffg(struct ocfs2_info_freefrag *ffg,
+ unsigned int chunksize)
{
o2ffg_update_histogram(&(ffg->iff_ffs.ffs_fc_hist), chunksize);
o2ffg_update_stats(&(ffg->iff_ffs), chunksize);
}
-int ocfs2_info_freefrag_scan_chain(struct ocfs2_super *osb,
- struct inode *gb_inode,
- struct ocfs2_dinode *gb_dinode,
- struct ocfs2_chain_rec *rec,
- struct ocfs2_info_freefrag *ffg,
- u32 chunks_in_group)
+static int ocfs2_info_freefrag_scan_chain(struct ocfs2_super *osb,
+ struct inode *gb_inode,
+ struct ocfs2_dinode *gb_dinode,
+ struct ocfs2_chain_rec *rec,
+ struct ocfs2_info_freefrag *ffg,
+ u32 chunks_in_group)
{
int status = 0, used;
u64 blkno;
@@ -571,9 +571,9 @@ bail:
return status;
}
-int ocfs2_info_freefrag_scan_bitmap(struct ocfs2_super *osb,
- struct inode *gb_inode, u64 blkno,
- struct ocfs2_info_freefrag *ffg)
+static int ocfs2_info_freefrag_scan_bitmap(struct ocfs2_super *osb,
+ struct inode *gb_inode, u64 blkno,
+ struct ocfs2_info_freefrag *ffg)
{
u32 chunks_in_group;
int status = 0, unlock = 0, i;
@@ -651,8 +651,8 @@ bail:
return status;
}
-int ocfs2_info_handle_freefrag(struct inode *inode,
- struct ocfs2_info_request __user *req)
+static int ocfs2_info_handle_freefrag(struct inode *inode,
+ struct ocfs2_info_request __user *req)
{
u64 blkno = -1;
char namebuf[40];
@@ -722,8 +722,8 @@ out_err:
return status;
}
-int ocfs2_info_handle_unknown(struct inode *inode,
- struct ocfs2_info_request __user *req)
+static int ocfs2_info_handle_unknown(struct inode *inode,
+ struct ocfs2_info_request __user *req)
{
int status = -EFAULT;
struct ocfs2_info_request oir;
@@ -751,8 +751,8 @@ bail:
* - distinguish different requests.
* - validate size of different requests.
*/
-int ocfs2_info_handle_request(struct inode *inode,
- struct ocfs2_info_request __user *req)
+static int ocfs2_info_handle_request(struct inode *inode,
+ struct ocfs2_info_request __user *req)
{
int status = -EFAULT;
struct ocfs2_info_request oir;
@@ -810,8 +810,8 @@ bail:
return status;
}
-int ocfs2_get_request_ptr(struct ocfs2_info *info, int idx,
- u64 *req_addr, int compat_flag)
+static int ocfs2_get_request_ptr(struct ocfs2_info *info, int idx,
+ u64 *req_addr, int compat_flag)
{
int status = -EFAULT;
u64 __user *bp = NULL;
@@ -848,8 +848,8 @@ bail:
* a better backward&forward compatibility, since a small piece of
* request will be less likely to be broken if disk layout get changed.
*/
-int ocfs2_info_handle(struct inode *inode, struct ocfs2_info *info,
- int compat_flag)
+static int ocfs2_info_handle(struct inode *inode, struct ocfs2_info *info,
+ int compat_flag)
{
int i, status = 0;
u64 req_addr;
--
1.7.9.5
Mark functions as static in ocfs2/journal.c because they are not used
outside this file.
This eliminates the following warning in ocfs2/journal.c:
fs/ocfs2/journal.c:106:6: warning: no previous prototype for ‘ocfs2_replay_map_set_state’ [-Wmissing-prototypes]
fs/ocfs2/journal.c:151:6: warning: no previous prototype for ‘ocfs2_queue_replay_slots’ [-Wmissing-prototypes]
fs/ocfs2/journal.c:169:6: warning: no previous prototype for ‘ocfs2_free_replay_slots’ [-Wmissing-prototypes]
fs/ocfs2/journal.c:1872:6: warning: no previous prototype for ‘ocfs2_queue_orphan_scan’ [-Wmissing-prototypes]
fs/ocfs2/journal.c:1921:6: warning: no previous prototype for‘ocfs2_orphan_scan_work’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria <[email protected]>
Reviewed-by: Josh Triplett <[email protected]>
---
fs/ocfs2/journal.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/fs/ocfs2/journal.c b/fs/ocfs2/journal.c
index 44fc3e5..3aa941a 100644
--- a/fs/ocfs2/journal.c
+++ b/fs/ocfs2/journal.c
@@ -103,7 +103,7 @@ struct ocfs2_replay_map {
unsigned char rm_replay_slots[0];
};
-void ocfs2_replay_map_set_state(struct ocfs2_super *osb, int state)
+static void ocfs2_replay_map_set_state(struct ocfs2_super *osb, int state)
{
if (!osb->replay_map)
return;
@@ -148,7 +148,7 @@ int ocfs2_compute_replay_slots(struct ocfs2_super *osb)
return 0;
}
-void ocfs2_queue_replay_slots(struct ocfs2_super *osb)
+static void ocfs2_queue_replay_slots(struct ocfs2_super *osb)
{
struct ocfs2_replay_map *replay_map = osb->replay_map;
int i;
@@ -166,7 +166,7 @@ void ocfs2_queue_replay_slots(struct ocfs2_super *osb)
replay_map->rm_state = REPLAY_DONE;
}
-void ocfs2_free_replay_slots(struct ocfs2_super *osb)
+static void ocfs2_free_replay_slots(struct ocfs2_super *osb)
{
struct ocfs2_replay_map *replay_map = osb->replay_map;
@@ -1869,7 +1869,7 @@ static inline unsigned long ocfs2_orphan_scan_timeout(void)
* hasn't happened. The node queues a scan and increments the
* sequence number in the LVB.
*/
-void ocfs2_queue_orphan_scan(struct ocfs2_super *osb)
+static void ocfs2_queue_orphan_scan(struct ocfs2_super *osb)
{
struct ocfs2_orphan_scan *os;
int status, i;
@@ -1918,7 +1918,7 @@ out:
}
/* Worker task that gets fired every ORPHAN_SCAN_SCHEDULE_TIMEOUT millsec */
-void ocfs2_orphan_scan_work(struct work_struct *work)
+static void ocfs2_orphan_scan_work(struct work_struct *work)
{
struct ocfs2_orphan_scan *os;
struct ocfs2_super *osb;
--
1.7.9.5
Mark functions as static in ocfs2/xattr.c because it is not used outside
this file.
This eliminates the following warning in ocfs2/xattr.c:
fs/ocfs2/xattr.c:7256:5: warning: no previous prototype for ‘ocfs2_initxattrs’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria <[email protected]>
Reviewed-by: Josh Triplett <[email protected]>
---
fs/ocfs2/xattr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/ocfs2/xattr.c b/fs/ocfs2/xattr.c
index 185fa3b7..7041df5 100644
--- a/fs/ocfs2/xattr.c
+++ b/fs/ocfs2/xattr.c
@@ -7256,8 +7256,8 @@ static int ocfs2_xattr_security_set(struct dentry *dentry, const char *name,
name, value, size, flags);
}
-int ocfs2_initxattrs(struct inode *inode, const struct xattr *xattr_array,
- void *fs_info)
+static int ocfs2_initxattrs(struct inode *inode, const struct xattr *xattr_array,
+ void *fs_info)
{
const struct xattr *xattr;
int err = 0;
--
1.7.9.5
Mark function as static in ocfs2/cluster/heartbeat.c because it is
not used outside this file.
This eliminates the following warning in ocfs2/cluster/heartbeat.c:
fs/ocfs2/cluster/heartbeat.c:2470:6: warning: no previous prototype for ‘o2hb_region_dec_user’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria <[email protected]>
Reviewed-by: Josh Triplett <[email protected]>
---
fs/ocfs2/cluster/heartbeat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ocfs2/cluster/heartbeat.c b/fs/ocfs2/cluster/heartbeat.c
index bf482df..ca10dec 100644
--- a/fs/ocfs2/cluster/heartbeat.c
+++ b/fs/ocfs2/cluster/heartbeat.c
@@ -2467,7 +2467,7 @@ unlock:
return ret;
}
-void o2hb_region_dec_user(const char *region_uuid)
+static void o2hb_region_dec_user(const char *region_uuid)
{
spin_lock(&o2hb_live_lock);
--
1.7.9.5
Mark function as static in proc/array.c because it is not used outside
this file.
This eliminates the following warning in proc/array.c:
fs/proc/array.c:712:5: warning: no previous prototype for ‘children_seq_release’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria <[email protected]>
Reviewed-by: Josh Triplett <[email protected]>
---
fs/proc/array.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/proc/array.c b/fs/proc/array.c
index 656e401..2265b11 100644
--- a/fs/proc/array.c
+++ b/fs/proc/array.c
@@ -699,7 +699,7 @@ static int children_seq_open(struct inode *inode, struct file *file)
return ret;
}
-int children_seq_release(struct inode *inode, struct file *file)
+static int children_seq_release(struct inode *inode, struct file *file)
{
seq_release(inode, file);
return 0;
--
1.7.9.5
Include appropriate header file in proc/proc_tty.c because header file
proc/internal.h contains function prototypes of functions defined in the
file.
This eliminates the following warning in proc/proc_tty.c:
fs/proc/proc_tty.c:175:13: warning: no previous prototype for ‘proc_tty_init’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria <[email protected]>
Reviewed-by: Josh Triplett <[email protected]>
---
fs/proc/proc_tty.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/proc/proc_tty.c b/fs/proc/proc_tty.c
index cb761f0..b42f6f6 100644
--- a/fs/proc/proc_tty.c
+++ b/fs/proc/proc_tty.c
@@ -14,6 +14,7 @@
#include <linux/tty.h>
#include <linux/seq_file.h>
#include <linux/bitops.h>
+#include "internal.h"
/*
* The /proc/tty directory inodes...
--
1.7.9.5
Add prototype declaration to header file include/linux/syscalls.h
because it is used by more than one file.
This eliminates the following warning in quota/compat.c:
fs/quota/compat.c:43:17: warning: no previous prototype for ‘sys32_quotactl’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria <[email protected]>
---
include/linux/syscalls.h | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h
index 40ed9e9..1f109ea 100644
--- a/include/linux/syscalls.h
+++ b/include/linux/syscalls.h
@@ -198,6 +198,11 @@ extern struct trace_event_functions exit_syscall_print_funcs;
} \
static inline long SYSC##name(__MAP(x,__SC_DECL,__VA_ARGS__))
+#ifdef CONFIG_QUOTACTL_COMPAT
+asmlinkage long sys32_quotactl(unsigned int cmd, const char __user *special,
+ qid_t id, void __user *addr);
+#endif
+
asmlinkage long sys_time(time_t __user *tloc);
asmlinkage long sys_stime(time_t __user *tptr);
asmlinkage long sys_gettimeofday(struct timeval __user *tv,
--
1.7.9.5
Move prototype declaration to header file reiserfs/reiserfs.h from
reiserfs/super.c because they are used by more than one file.
This eliminates the following warning in reiserfs/bitmap.c:
fs/reiserfs/bitmap.c:647:6: warning: no previous prototype for ‘show_alloc_options’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria <[email protected]>
Reviewed-by: Josh Triplett <[email protected]>
---
fs/reiserfs/reiserfs.h | 1 +
fs/reiserfs/super.c | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/reiserfs/reiserfs.h b/fs/reiserfs/reiserfs.h
index 8d06adf..83d4eac 100644
--- a/fs/reiserfs/reiserfs.h
+++ b/fs/reiserfs/reiserfs.h
@@ -2831,6 +2831,7 @@ void reiserfs_init_alloc_options(struct super_block *s);
*/
__le32 reiserfs_choose_packing(struct inode *dir);
+void show_alloc_options(struct seq_file *seq, struct super_block *s);
int reiserfs_init_bitmap_cache(struct super_block *sb);
void reiserfs_free_bitmap_cache(struct super_block *sb);
void reiserfs_cache_bitmap_metadata(struct super_block *sb, struct buffer_head *bh, struct reiserfs_bitmap_info *info);
diff --git a/fs/reiserfs/super.c b/fs/reiserfs/super.c
index 2c80335..16d5335 100644
--- a/fs/reiserfs/super.c
+++ b/fs/reiserfs/super.c
@@ -62,7 +62,6 @@ static int is_any_reiserfs_magic_string(struct reiserfs_super_block *rs)
static int reiserfs_remount(struct super_block *s, int *flags, char *data);
static int reiserfs_statfs(struct dentry *dentry, struct kstatfs *buf);
-void show_alloc_options(struct seq_file *seq, struct super_block *s);
static int reiserfs_sync_fs(struct super_block *s, int wait)
{
--
1.7.9.5
Move prototype declaration to header file include/linux/crash_dump.h
because it is used by more than file.
This eliminates the following warning in proc/vmcore.c:
fs/proc/vmcore.c:1088:6: warning: no previous prototype for ‘vmcore_cleanup’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria <[email protected]>
Reviewed-by: Josh Triplett <[email protected]>
---
include/linux/crash_dump.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/crash_dump.h b/include/linux/crash_dump.h
index 7032518..72ab536 100644
--- a/include/linux/crash_dump.h
+++ b/include/linux/crash_dump.h
@@ -25,6 +25,7 @@ extern int __weak remap_oldmem_pfn_range(struct vm_area_struct *vma,
extern ssize_t copy_oldmem_page(unsigned long, char *, size_t,
unsigned long, int);
+void vmcore_cleanup(void);
/* Architecture code defines this if there are other possible ELF
* machine types, e.g. on bi-arch capable hardware. */
--
1.7.9.5
On 02/09/2014 08:29 AM, Rashika Kheria wrote:
> Move prototype declaration to header file reiserfs/reiserfs.h from
> reiserfs/super.c because they are used by more than one file.
>
> This eliminates the following warning in reiserfs/bitmap.c:
> fs/reiserfs/bitmap.c:647:6: warning: no previous prototype for ‘show_alloc_options’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <[email protected]>
> Reviewed-by: Josh Triplett <[email protected]>
Acked-by: Jeff Mahoney <[email protected]>
> ---
> fs/reiserfs/reiserfs.h | 1 +
> fs/reiserfs/super.c | 1 -
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/reiserfs/reiserfs.h b/fs/reiserfs/reiserfs.h
> index 8d06adf..83d4eac 100644
> --- a/fs/reiserfs/reiserfs.h
> +++ b/fs/reiserfs/reiserfs.h
> @@ -2831,6 +2831,7 @@ void reiserfs_init_alloc_options(struct super_block *s);
> */
> __le32 reiserfs_choose_packing(struct inode *dir);
>
> +void show_alloc_options(struct seq_file *seq, struct super_block *s);
> int reiserfs_init_bitmap_cache(struct super_block *sb);
> void reiserfs_free_bitmap_cache(struct super_block *sb);
> void reiserfs_cache_bitmap_metadata(struct super_block *sb, struct buffer_head *bh, struct reiserfs_bitmap_info *info);
> diff --git a/fs/reiserfs/super.c b/fs/reiserfs/super.c
> index 2c80335..16d5335 100644
> --- a/fs/reiserfs/super.c
> +++ b/fs/reiserfs/super.c
> @@ -62,7 +62,6 @@ static int is_any_reiserfs_magic_string(struct reiserfs_super_block *rs)
>
> static int reiserfs_remount(struct super_block *s, int *flags, char *data);
> static int reiserfs_statfs(struct dentry *dentry, struct kstatfs *buf);
> -void show_alloc_options(struct seq_file *seq, struct super_block *s);
>
> static int reiserfs_sync_fs(struct super_block *s, int wait)
> {
>
--
Jeff Mahoney
SUSE Labs
On Sun, Feb 09 2014, Rashika Kheria wrote:
> Mark functions as static in bio-integrity.c because it is not used
> outside this file.
>
> This eliminates the following warnings in bio-integrity.c:
> fs/bio-integrity.c:224:5: warning: no previous prototype for ‘bio_integrity_tag’ [-Wmissing-prototypes]
Applied 3+4, thanks.
--
Jens Axboe
On Sun, Feb 09, 2014 at 06:41:21PM +0530, Rashika Kheria wrote:
> Mark functions as static in jbd2/journal.c because they are not used
> outside this file.
>
> This eliminates the following warning in jbd2/journal.c:
> fs/jbd2/journal.c:125:5: warning: no previous prototype for ‘jbd2_verify_csum_type’ [-Wmissing-prototypes]
> fs/jbd2/journal.c:146:5: warning: no previous prototype for ‘jbd2_superblock_csum_verify’ [-Wmissing-prototypes]
> fs/jbd2/journal.c:154:6: warning: no previous prototype for ‘jbd2_superblock_csum_set’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <[email protected]>
> Reviewed-by: Josh Triplett <[email protected]>
Looks fine to me, so you can add
Reviewed-by: Darrick J. Wong <[email protected]>
--D
> ---
> fs/jbd2/journal.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
> index 5fa344a..244b6f6 100644
> --- a/fs/jbd2/journal.c
> +++ b/fs/jbd2/journal.c
> @@ -122,7 +122,7 @@ EXPORT_SYMBOL(__jbd2_debug);
> #endif
>
> /* Checksumming functions */
> -int jbd2_verify_csum_type(journal_t *j, journal_superblock_t *sb)
> +static int jbd2_verify_csum_type(journal_t *j, journal_superblock_t *sb)
> {
> if (!JBD2_HAS_INCOMPAT_FEATURE(j, JBD2_FEATURE_INCOMPAT_CSUM_V2))
> return 1;
> @@ -143,7 +143,7 @@ static __be32 jbd2_superblock_csum(journal_t *j, journal_superblock_t *sb)
> return cpu_to_be32(csum);
> }
>
> -int jbd2_superblock_csum_verify(journal_t *j, journal_superblock_t *sb)
> +static int jbd2_superblock_csum_verify(journal_t *j, journal_superblock_t *sb)
> {
> if (!JBD2_HAS_INCOMPAT_FEATURE(j, JBD2_FEATURE_INCOMPAT_CSUM_V2))
> return 1;
> @@ -151,7 +151,7 @@ int jbd2_superblock_csum_verify(journal_t *j, journal_superblock_t *sb)
> return sb->s_checksum == jbd2_superblock_csum(j, sb);
> }
>
> -void jbd2_superblock_csum_set(journal_t *j, journal_superblock_t *sb)
> +static void jbd2_superblock_csum_set(journal_t *j, journal_superblock_t *sb)
> {
> if (!JBD2_HAS_INCOMPAT_FEATURE(j, JBD2_FEATURE_INCOMPAT_CSUM_V2))
> return;
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, Feb 09, 2014 at 06:58:34PM +0530, Rashika Kheria wrote:
> Add prototype declaration to header file include/linux/syscalls.h
> because it is used by more than one file.
>
> This eliminates the following warning in quota/compat.c:
> fs/quota/compat.c:43:17: warning: no previous prototype for ‘sys32_quotactl’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <[email protected]>
Reviewed-by: Josh Triplett <[email protected]>
> include/linux/syscalls.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h
> index 40ed9e9..1f109ea 100644
> --- a/include/linux/syscalls.h
> +++ b/include/linux/syscalls.h
> @@ -198,6 +198,11 @@ extern struct trace_event_functions exit_syscall_print_funcs;
> } \
> static inline long SYSC##name(__MAP(x,__SC_DECL,__VA_ARGS__))
>
> +#ifdef CONFIG_QUOTACTL_COMPAT
> +asmlinkage long sys32_quotactl(unsigned int cmd, const char __user *special,
> + qid_t id, void __user *addr);
> +#endif
> +
> asmlinkage long sys_time(time_t __user *tloc);
> asmlinkage long sys_stime(time_t __user *tptr);
> asmlinkage long sys_gettimeofday(struct timeval __user *tv,
> --
> 1.7.9.5
>
Hi,
On Sun, 2014-02-09 at 18:40 +0530, Rashika Kheria wrote:
> Mark functions as static in gfs2/rgrp.c because they are not used
> outside this file.
>
> This eliminates the following warning in gfs2/rgrp.c:
> fs/gfs2/rgrp.c:1092:5: warning: no previous prototype for ‘gfs2_rgrp_bh_get’ [-Wmissing-prototypes]
> fs/gfs2/rgrp.c:1157:5: warning: no previous prototype for ‘update_rgrp_lvb’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <[email protected]>
> Reviewed-by: Josh Triplett <[email protected]>
> ---
> fs/gfs2/rgrp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Now in the GFS2 -nmw tree. Thanks,
Steve.
> diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c
> index a1da213..551b9e9 100644
> --- a/fs/gfs2/rgrp.c
> +++ b/fs/gfs2/rgrp.c
> @@ -1102,7 +1102,7 @@ static u32 count_unlinked(struct gfs2_rgrpd *rgd)
> * Returns: errno
> */
>
> -int gfs2_rgrp_bh_get(struct gfs2_rgrpd *rgd)
> +static int gfs2_rgrp_bh_get(struct gfs2_rgrpd *rgd)
> {
> struct gfs2_sbd *sdp = rgd->rd_sbd;
> struct gfs2_glock *gl = rgd->rd_gl;
> @@ -1169,7 +1169,7 @@ fail:
> return error;
> }
>
> -int update_rgrp_lvb(struct gfs2_rgrpd *rgd)
> +static int update_rgrp_lvb(struct gfs2_rgrpd *rgd)
> {
> u32 rl_flags;
>
On Sun 09-02-14 18:34:10, Rashika Kheria wrote:
> Mark function as static in ext2/xattr_security.c because it is not
> used outside this file.
>
> This also elimiantes the following warning in ext2/xattr_security.c:
> fs/ext2/xattr_security.c:45:5: warning: no previous prototype for ‘ext2_initxattrs’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <[email protected]>
> Reviewed-by: Josh Triplett <[email protected]>
Thanks. I've merged the patch.
Honza
> ---
> fs/ext2/xattr_security.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ext2/xattr_security.c b/fs/ext2/xattr_security.c
> index cfedb2c..c0ebc4d 100644
> --- a/fs/ext2/xattr_security.c
> +++ b/fs/ext2/xattr_security.c
> @@ -42,8 +42,8 @@ ext2_xattr_security_set(struct dentry *dentry, const char *name,
> value, size, flags);
> }
>
> -int ext2_initxattrs(struct inode *inode, const struct xattr *xattr_array,
> - void *fs_info)
> +static int ext2_initxattrs(struct inode *inode, const struct xattr *xattr_array,
> + void *fs_info)
> {
> const struct xattr *xattr;
> int err = 0;
> --
> 1.7.9.5
>
--
Jan Kara <[email protected]>
SUSE Labs, CR
On Sun 09-02-14 18:36:27, Rashika Kheria wrote:
> Mark function as static in ext3/dir.c because it is not used outside
> this file.
>
> This also eliminates the following warning in ext3/dir.c:
> fs/ext3/dir.c:278:8: warning: no previous prototype for ‘ext3_dir_llseek’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <[email protected]>
> Reviewed-by: Josh Triplett <[email protected]>
Thanks. I've merged the patch.
Honza
> ---
> fs/ext3/dir.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext3/dir.c b/fs/ext3/dir.c
> index e66e480..17742ee 100644
> --- a/fs/ext3/dir.c
> +++ b/fs/ext3/dir.c
> @@ -275,7 +275,7 @@ static inline loff_t ext3_get_htree_eof(struct file *filp)
> * NOTE: offsets obtained *before* ext3_set_inode_flag(dir, EXT3_INODE_INDEX)
> * will be invalid once the directory was converted into a dx directory
> */
> -loff_t ext3_dir_llseek(struct file *file, loff_t offset, int whence)
> +static loff_t ext3_dir_llseek(struct file *file, loff_t offset, int whence)
> {
> struct inode *inode = file->f_mapping->host;
> int dx_dir = is_dx_dir(inode);
> --
> 1.7.9.5
>
--
Jan Kara <[email protected]>
SUSE Labs, CR
On Sun 09-02-14 18:39:11, Rashika Kheria wrote:
> Mark function as static in ext3/xattr_security.c because it is not used
> outside this file.
>
> This eliminates the following warning in ext3/xattr_security.c:
> fs/ext3/xattr_security.c:46:5: warning: no previous prototype for ‘ext3_initxattrs’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <[email protected]>
> Reviewed-by: Josh Triplett <[email protected]>
Thanks. I've merged the patch.
Honza
> ---
> fs/ext3/xattr_security.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ext3/xattr_security.c b/fs/ext3/xattr_security.c
> index 3387664..722c2bf 100644
> --- a/fs/ext3/xattr_security.c
> +++ b/fs/ext3/xattr_security.c
> @@ -43,8 +43,9 @@ ext3_xattr_security_set(struct dentry *dentry, const char *name,
> name, value, size, flags);
> }
>
> -int ext3_initxattrs(struct inode *inode, const struct xattr *xattr_array,
> - void *fs_info)
> +static int ext3_initxattrs(struct inode *inode,
> + const struct xattr *xattr_array,
> + void *fs_info)
> {
> const struct xattr *xattr;
> handle_t *handle = fs_info;
> --
> 1.7.9.5
>
--
Jan Kara <[email protected]>
SUSE Labs, CR
On Sun, 9 Feb 2014 19:03:54 +0530 Rashika Kheria <[email protected]> wrote:
> Move prototype declaration to header file include/linux/crash_dump.h
It adds a prototype rather than moving it.
> because it is used by more than file.
True, but you didn't notice the second user ;)
> --- a/include/linux/crash_dump.h
> +++ b/include/linux/crash_dump.h
> @@ -25,6 +25,7 @@ extern int __weak remap_oldmem_pfn_range(struct vm_area_struct *vma,
>
> extern ssize_t copy_oldmem_page(unsigned long, char *, size_t,
> unsigned long, int);
> +void vmcore_cleanup(void);
>
> /* Architecture code defines this if there are other possible ELF
> * machine types, e.g. on bi-arch capable hardware. */
Take a look over in powerpc...
From: Andrew Morton <[email protected]>
Subject: include-linux-crash_dumph-add-vmcore_cleanup-prototype-fix
clean up powerpc, remove unneeded EXPORT_SYMBOL
Cc: Josh Triplett <[email protected]>
Cc: Rashika Kheria <[email protected]>
Cc: Benjamin Herrenschmidt <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
---
arch/powerpc/include/asm/fadump.h | 1 -
fs/proc/vmcore.c | 1 -
2 files changed, 2 deletions(-)
--- a/arch/powerpc/include/asm/fadump.h~include-linux-crash_dumph-add-vmcore_cleanup-prototype-fix
+++ a/arch/powerpc/include/asm/fadump.h
@@ -210,7 +210,6 @@ extern int is_fadump_active(void);
extern void crash_fadump(struct pt_regs *, const char *);
extern void fadump_cleanup(void);
-extern void vmcore_cleanup(void);
#else /* CONFIG_FA_DUMP */
static inline int is_fadump_active(void) { return 0; }
static inline void crash_fadump(struct pt_regs *regs, const char *str) { }
--- a/fs/proc/vmcore.c~include-linux-crash_dumph-add-vmcore_cleanup-prototype-fix
+++ a/fs/proc/vmcore.c
@@ -1118,4 +1118,3 @@ void vmcore_cleanup(void)
}
free_elfcorebuf();
}
-EXPORT_SYMBOL_GPL(vmcore_cleanup);
_
On Sun, 9 Feb 2014 18:58:34 +0530 Rashika Kheria <[email protected]> wrote:
> Subject: [PATCH 19/21] fs: Add prototype declaration to header file include/linux/syscalls.h
The subjects are pretty meaningless - this really isn't an "fs" patch.
I'll rewrite it to
Subject: include/linux/syscalls.h: add sys32_quotactl() prototype
> --- a/include/linux/syscalls.h
> +++ b/include/linux/syscalls.h
> @@ -198,6 +198,11 @@ extern struct trace_event_functions exit_syscall_print_funcs;
> } \
> static inline long SYSC##name(__MAP(x,__SC_DECL,__VA_ARGS__))
>
> +#ifdef CONFIG_QUOTACTL_COMPAT
> +asmlinkage long sys32_quotactl(unsigned int cmd, const char __user *special,
> + qid_t id, void __user *addr);
> +#endif
> +
> asmlinkage long sys_time(time_t __user *tloc);
> asmlinkage long sys_stime(time_t __user *tptr);
> asmlinkage long sys_gettimeofday(struct timeval __user *tv,
Disagree with the ifdefs. If we were to do this, syscalls.h would
have a tremendous number of ifdefs in it. Take a look in
kernel/sys_ni.c.
Removing the ifdefs will cause a compile-time error to be deferred to
link time, which will inconvenience a small number of people a small
number of times. However it will make the code more readable by a
large number of people a large number of times. It's a good tradeoff.
--- a/include/linux/syscalls.h~include-linux-syscallsh-add-sys32_quotactl-prototype-fix
+++ a/include/linux/syscalls.h
@@ -198,11 +198,8 @@ extern struct trace_event_functions exit
} \
static inline long SYSC##name(__MAP(x,__SC_DECL,__VA_ARGS__))
-#ifdef CONFIG_QUOTACTL_COMPAT
asmlinkage long sys32_quotactl(unsigned int cmd, const char __user *special,
qid_t id, void __user *addr);
-#endif
-
asmlinkage long sys_time(time_t __user *tloc);
asmlinkage long sys_stime(time_t __user *tptr);
asmlinkage long sys_gettimeofday(struct timeval __user *tv,
_
On Sun, Feb 09, 2014 at 06:41:21PM +0530, Rashika Kheria wrote:
> Mark functions as static in jbd2/journal.c because they are not used
> outside this file.
>
> This eliminates the following warning in jbd2/journal.c:
> fs/jbd2/journal.c:125:5: warning: no previous prototype for ‘jbd2_verify_csum_type’ [-Wmissing-prototypes]
> fs/jbd2/journal.c:146:5: warning: no previous prototype for ‘jbd2_superblock_csum_verify’ [-Wmissing-prototypes]
> fs/jbd2/journal.c:154:6: warning: no previous prototype for ‘jbd2_superblock_csum_set’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <[email protected]>
> Reviewed-by: Josh Triplett <[email protected]>
Thanks, applied to the ext4 tree.
- Ted
Rashika Kheria <[email protected]> wrote:
> Remove unused function in afs/write.c.
>
> This eliminates the following warning in afs/write.c:
> fs/afs/write.c:749:5: warning: no previous prototype for ‘afs_page_mkwrite’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <[email protected]>
> Reviewed-by: Josh Triplett <[email protected]>
I would like to counter with the attached patch. Yes, I know that
afs_page_mkwrite() still won't be called after this patch - yet. I have
someone working on RxRPC and AFS stuff and I'd like to have him try and fix up
the missing stuff.
David
---
commit bf0e3d6fc98ba1567deea0a4182580d8041361aa
Author: David Howells <[email protected]>
Date: Thu Feb 13 13:40:57 2014 +0000
AFS: Actually use afs_page_mkwrite()
When afs_page_mkwrite() was added in commit:
9b3f26c9110dcea62716aca9b8c68ceb482227ef
FS-Cache: Make kAFS use FS-Cache
it wasn't actually called. It should be called, however, so that we don't see
local changes not associated with the old data version appearing in fscache's
cache (afs_page_mkwrite() holds up the write to a file's page through an
mmap'd page until that page has finished being written to the cache).
Signed-off-by: David Howells <[email protected]>
cc: Rashika Kheria <[email protected]>
cc: Josh Triplett <[email protected]>
diff --git a/fs/afs/file.c b/fs/afs/file.c
index 66d50fe2ee45..014792a8d34e 100644
--- a/fs/afs/file.c
+++ b/fs/afs/file.c
@@ -18,6 +18,7 @@
#include <linux/gfp.h>
#include "internal.h"
+static int afs_file_mmap(struct file *file, struct vm_area_struct *vma);
static int afs_readpage(struct file *file, struct page *page);
static void afs_invalidatepage(struct page *page, unsigned int offset,
unsigned int length);
@@ -35,7 +36,7 @@ const struct file_operations afs_file_operations = {
.write = do_sync_write,
.aio_read = generic_file_aio_read,
.aio_write = afs_file_write,
- .mmap = generic_file_readonly_mmap,
+ .mmap = afs_file_mmap,
.splice_read = generic_file_splice_read,
.fsync = afs_fsync,
.lock = afs_lock,
@@ -378,3 +379,25 @@ static int afs_releasepage(struct page *page, gfp_t gfp_flags)
_leave(" = T");
return 1;
}
+
+static const struct vm_operations_struct afs_vm_ops = {
+ .fault = filemap_fault,
+ .page_mkwrite = afs_page_mkwrite,
+ .remap_pages = generic_file_remap_pages,
+};
+
+/*
+ * Handle setting up a memory mapping on an AFS file.
+ *
+ * At the moment we only support read-only mappings as writable mappings must
+ * set up a writeback record.
+ */
+static int afs_file_mmap(struct file *file, struct vm_area_struct *vma)
+{
+ int ret;
+
+ ret = generic_file_readonly_mmap(file, vma);
+ if (ret == 0)
+ vma->vm_ops = &afs_vm_ops;
+ return ret;
+}
diff --git a/fs/afs/internal.h b/fs/afs/internal.h
index 6621f8008122..a074279bdab7 100644
--- a/fs/afs/internal.h
+++ b/fs/afs/internal.h
@@ -750,6 +750,7 @@ extern ssize_t afs_file_write(struct kiocb *, const struct iovec *,
unsigned long, loff_t);
extern int afs_writeback_all(struct afs_vnode *);
extern int afs_fsync(struct file *, loff_t, loff_t, int);
+extern int afs_page_mkwrite(struct vm_area_struct *, struct page *);
/*****************************************************************************/
diff --git a/fs/afs/write.c b/fs/afs/write.c
index a890db4b9898..a593c2c0970e 100644
--- a/fs/afs/write.c
+++ b/fs/afs/write.c
@@ -759,6 +759,13 @@ int afs_page_mkwrite(struct vm_area_struct *vma, struct page *page)
fscache_wait_on_page_write(vnode->cache, page);
#endif
+ /* TODO: Get the key from vma->vm_file, flush any overlapping
+ * contradictory writeback record, set up new a writeback record if
+ * needed and remove the R/O check from afs_file_mmap().
+ *
+ * The code can probably be common with much of afs_write_begin().
+ */
+
_leave(" = 0");
return 0;
}
On 02/09/2014 03:01 PM, Rashika Kheria wrote:
> Mark function as static in exofs/super.c because it is not used outside
> this file.
>
> This also eliminates the following warning in exofs/super.c:
> fs/exofs/super.c:546:5: warning: no previous prototype for ‘__alloc_dev_table’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <[email protected]>
> Reviewed-by: Josh Triplett <[email protected]>
Hi Rashika
Thanks for the fixes.
Do you need me to push it to Linus through my tree or do you need an:
ACK-by: Boaz Harrosh <[email protected]>
[Same for [PATCH 06/21] fs: Mark functions as static in exofs/ore_raid.c ]
Thanks again
Boaz
> ---
> fs/exofs/super.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/exofs/super.c b/fs/exofs/super.c
> index 9d97633..57f59a2 100644
> --- a/fs/exofs/super.c
> +++ b/fs/exofs/super.c
> @@ -543,8 +543,8 @@ static int exofs_devs_2_odi(struct exofs_dt_device_info *dt_dev,
> return !(odi->systemid_len || odi->osdname_len);
> }
>
> -int __alloc_dev_table(struct exofs_sb_info *sbi, unsigned numdevs,
> - struct exofs_dev **peds)
> +static int __alloc_dev_table(struct exofs_sb_info *sbi, unsigned numdevs,
> + struct exofs_dev **peds)
> {
> struct __alloc_ore_devs_and_exofs_devs {
> /* Twice bigger table: See exofs_init_comps() and comment at
>
On Thu, Feb 13, 2014 at 11:28 PM, Boaz Harrosh <[email protected]> wrote:
> On 02/09/2014 03:01 PM, Rashika Kheria wrote:
>> Mark function as static in exofs/super.c because it is not used outside
>> this file.
>>
>> This also eliminates the following warning in exofs/super.c:
>> fs/exofs/super.c:546:5: warning: no previous prototype for '__alloc_dev_table' [-Wmissing-prototypes]
>>
>> Signed-off-by: Rashika Kheria <[email protected]>
>> Reviewed-by: Josh Triplett <[email protected]>
>
> Hi Rashika
>
> Thanks for the fixes.
>
> Do you need me to push it to Linus through my tree or do you need an:
> ACK-by: Boaz Harrosh <[email protected]>
>
> [Same for [PATCH 06/21] fs: Mark functions as static in exofs/ore_raid.c ]
>
> Thanks again
> Boaz
>
Hi Boaz,
It would be nice if you could push it to Linus through you tree.
Thanks,
Rashika Kheria
>> ---
>> fs/exofs/super.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/exofs/super.c b/fs/exofs/super.c
>> index 9d97633..57f59a2 100644
>> --- a/fs/exofs/super.c
>> +++ b/fs/exofs/super.c
>> @@ -543,8 +543,8 @@ static int exofs_devs_2_odi(struct exofs_dt_device_info *dt_dev,
>> return !(odi->systemid_len || odi->osdname_len);
>> }
>>
>> -int __alloc_dev_table(struct exofs_sb_info *sbi, unsigned numdevs,
>> - struct exofs_dev **peds)
>> +static int __alloc_dev_table(struct exofs_sb_info *sbi, unsigned numdevs,
>> + struct exofs_dev **peds)
>> {
>> struct __alloc_ore_devs_and_exofs_devs {
>> /* Twice bigger table: See exofs_init_comps() and comment at
>>
>
--
Rashika Kheria
B.Tech CSE
IIIT Hyderabad