2017-03-27 07:33:52

by Gustavo A. R. Silva

Subject: [PATCH] staging: speakup: fix warning for static declaration

Fix the following sparse warning:
symbol 'spk_serial_out' was not declared. Should it be static?

Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/staging/speakup/serialio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/speakup/serialio.c b/drivers/staging/speakup/serialio.c
index 5e31aca..3fab1c3 100644
--- a/drivers/staging/speakup/serialio.c
+++ b/drivers/staging/speakup/serialio.c
@@ -243,7 +243,7 @@ unsigned char spk_serial_in_nowait(void)
}
EXPORT_SYMBOL_GPL(spk_serial_in_nowait);

-int spk_serial_out(struct spk_synth *in_synth, const char ch)
+static int spk_serial_out(struct spk_synth *in_synth, const char ch)
{
if (in_synth->alive && spk_wait_for_xmitr(in_synth)) {
outb_p(ch, speakup_info.port_tts);
--
2.5.0

2017-03-27 07:51:40

by Okash Khawaja

Subject: Re: [PATCH] staging: speakup: fix warning for static declaration

Hi Gustavo,

On Mon, Mar 27, 2017 at 01:37:29AM -0500, Gustavo A. R. Silva wrote:
> Fix the following sparse warning:
> symbol 'spk_serial_out' was not declared. Should it be static?
>
> Signed-off-by: Gustavo A. R. Silva <[email protected]>
> ---
> drivers/staging/speakup/serialio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/speakup/serialio.c b/drivers/staging/speakup/serialio.c
> index 5e31aca..3fab1c3 100644
> --- a/drivers/staging/speakup/serialio.c
> +++ b/drivers/staging/speakup/serialio.c
> @@ -243,7 +243,7 @@ unsigned char spk_serial_in_nowait(void)
> }
> EXPORT_SYMBOL_GPL(spk_serial_in_nowait);
>
> -int spk_serial_out(struct spk_synth *in_synth, const char ch)
> +static int spk_serial_out(struct spk_synth *in_synth, const char ch)
> {
> if (in_synth->alive && spk_wait_for_xmitr(in_synth)) {
> outb_p(ch, speakup_info.port_tts);
> --
> 2.5.0
>

Thanks for this :) Could you also move the function higher in the same
file - above line 139 where all static functions are defined?

Okash

2017-03-27 07:56:40

by Samuel Thibault

Subject: Re: [PATCH] staging: speakup: fix warning for static declaration

Gustavo A. R. Silva, on lun. 27 mars 2017 01:37:29 -0500, wrote:
> Fix the following sparse warning:
> symbol 'spk_serial_out' was not declared. Should it be static?
>
> Signed-off-by: Gustavo A. R. Silva <[email protected]>

Yes, indeed.

Reviewed-by: Samuel Thibault <[email protected]>

Thanks

> ---
> drivers/staging/speakup/serialio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/speakup/serialio.c b/drivers/staging/speakup/serialio.c
> index 5e31aca..3fab1c3 100644
> --- a/drivers/staging/speakup/serialio.c
> +++ b/drivers/staging/speakup/serialio.c
> @@ -243,7 +243,7 @@ unsigned char spk_serial_in_nowait(void)
> }
> EXPORT_SYMBOL_GPL(spk_serial_in_nowait);
>
> -int spk_serial_out(struct spk_synth *in_synth, const char ch)
> +static int spk_serial_out(struct spk_synth *in_synth, const char ch)
> {
> if (in_synth->alive && spk_wait_for_xmitr(in_synth)) {
> outb_p(ch, speakup_info.port_tts);
> --
> 2.5.0
>

--
Samuel
Je suis maintenant possesseur d'un ordinateur portable Compaq Armada
1592DT avec port infra-rouge. Auriez-vous connaissance de programmes
suceptibles d'utiliser ce port afin de servir de télécommande ?
-+- JN in NPC : ben quoi, c'est pas à ça que ça sert ?

2017-03-27 07:59:31

by Samuel Thibault

Subject: Re: [PATCH] staging: speakup: fix warning for static declaration

Okash Khawaja, on lun. 27 mars 2017 08:51:02 +0100, wrote:
> Thanks for this :) Could you also move the function higher in the same
> file - above line 139 where all static functions are defined?

I'd say no need for this. spk_serial_in is just above. Moving functions
just for the sake of static vs non-static does not make the code more
readable to my eyes :)
(and it makes tracking changes harder in git annotate)

Samuel

2017-03-27 08:40:26

by Okash Khawaja

Subject: Re: [PATCH] staging: speakup: fix warning for static declaration

On Mon, Mar 27, 2017 at 09:58:53AM +0200, Samuel Thibault wrote:
> Okash Khawaja, on lun. 27 mars 2017 08:51:02 +0100, wrote:
> > Thanks for this :) Could you also move the function higher in the same
> > file - above line 139 where all static functions are defined?
>
> I'd say no need for this. spk_serial_in is just above. Moving functions
> just for the sake of static vs non-static does not make the code more
> readable to my eyes :)
> (and it makes tracking changes harder in git annotate)
>
> Samuel

Fair enough. When I marked it as static and moved it higher, I
misinterpreted your comment as we neither want it static nor moved. You
probably meant the latter :)