2017-12-08 09:54:53

by Liu, Changcheng

Subject: [PATCH] tools/slabinfo-gnuplot: force to use bash shell

On some linux distributions, the default link of sh
is dash which deoesn't support split array like
${var//,/ }
It's better to force to use bash shell directly.

Signed-off-by: Liu Changcheng <[email protected]>

diff --git a/tools/vm/slabinfo-gnuplot.sh b/tools/vm/slabinfo-gnuplot.sh
index 35b0398..0cf28aa 100644
--- a/tools/vm/slabinfo-gnuplot.sh
+++ b/tools/vm/slabinfo-gnuplot.sh
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash

# Sergey Senozhatsky, 2015
# [email protected]
--
2.7.4

2017-12-08 10:33:32

by Sergey Senozhatsky

Subject: Re: [PATCH] tools/slabinfo-gnuplot: force to use bash shell

On (12/08/17 17:37), Liu, Changcheng wrote:
>
> On some linux distributions, the default link of sh
> is dash which deoesn't support split array like
> ${var//,/ }
> It's better to force to use bash shell directly.
>
> Signed-off-by: Liu Changcheng <[email protected]>

Reviewed-by: Sergey Senozhatsky <[email protected]>


-ss

> diff --git a/tools/vm/slabinfo-gnuplot.sh b/tools/vm/slabinfo-gnuplot.sh
> index 35b0398..0cf28aa 100644
> --- a/tools/vm/slabinfo-gnuplot.sh
> +++ b/tools/vm/slabinfo-gnuplot.sh
> @@ -1,4 +1,4 @@
> -#!/bin/sh
> +#!/bin/bash
>
> # Sergey Senozhatsky, 2015
> # [email protected]
> --
> 2.7.4
>

2017-12-08 22:02:49

by Andrew Morton

Subject: Re: [PATCH] tools/slabinfo-gnuplot: force to use bash shell

On Fri, 8 Dec 2017 19:33:15 +0900 Sergey Senozhatsky <[email protected]> wrote:

> On (12/08/17 17:37), Liu, Changcheng wrote:
> >
> > On some linux distributions, the default link of sh
> > is dash which deoesn't support split array like
> > ${var//,/ }
> > It's better to force to use bash shell directly.
> >
> > Signed-off-by: Liu Changcheng <[email protected]>
>
> Reviewed-by: Sergey Senozhatsky <[email protected]>

It would be better to rewrite the script to avoid bashisms. But...

akpm3:/usr/src/linux-4.15-rc2> grep -rl "/bin/bash" . | wc -l
164

I guess we lost that fight a long time ago.

2017-12-08 22:21:03

by Joe Perches

Subject: Re: [PATCH] tools/slabinfo-gnuplot: force to use bash shell

On Fri, 2017-12-08 at 14:02 -0800, Andrew Morton wrote:
> On Fri, 8 Dec 2017 19:33:15 +0900 Sergey Senozhatsky <[email protected]> wrote:
>
> > On (12/08/17 17:37), Liu, Changcheng wrote:
> > >
> > > On some linux distributions, the default link of sh
> > > is dash which deoesn't support split array like
> > > ${var//,/ }
> > > It's better to force to use bash shell directly.
> > >
> > > Signed-off-by: Liu Changcheng <[email protected]>
> >
> > Reviewed-by: Sergey Senozhatsky <[email protected]>
>
> It would be better to rewrite the script to avoid bashisms. But...
>
> akpm3:/usr/src/linux-4.15-rc2> grep -rl "/bin/bash" . | wc -l
> 164
>
> I guess we lost that fight a long time ago.

103 of those are in tools/ and I don't think those count.
If you take out samples/ and Documentation/ it's down to 24.

2017-12-08 23:59:07

by Sergey Senozhatsky

Subject: Re: [PATCH] tools/slabinfo-gnuplot: force to use bash shell

On (12/08/17 14:02), Andrew Morton wrote:
> > On (12/08/17 17:37), Liu, Changcheng wrote:
> > >
> > > On some linux distributions, the default link of sh
> > > is dash which deoesn't support split array like
> > > ${var//,/ }
> > > It's better to force to use bash shell directly.
> > >
> > > Signed-off-by: Liu Changcheng <[email protected]>
> >
> > Reviewed-by: Sergey Senozhatsky <[email protected]>
>
> It would be better to rewrite the script to avoid bashisms.

Hello Andrew,
what are the latest fashion trends? isn't it perl? so maybe
I can sit down someday and rewrite it in perl.

-ss