LinuxLists.cc - [PATCH 0/2] add ESP8089 WiFi chip driver

2017-07-23 08:25:40

by kernel test robot

[permalink] [raw]

Subject: [PATCH] staging: net: wireless: fix badzero.cocci warnings

drivers/staging/esp8089/esp_mac80211.c:596:33-34: WARNING comparing pointer to 0

Compare pointer-typed values to NULL rather than 0

Semantic patch information:
This makes an effort to choose between !x and x == NULL. !x is used
if it has previously been used with the function used to initialize x.
This relies on type information. More type information can be obtained
using the option -all_includes and the option -I to specify an
include path.

Generated by: scripts/coccinelle/null/badzero.cocci

Fixes: 5ebdb57b0b15 ("staging: net: wireless: add ESP8089 WiFi driver")
CC: Quentin Schulz <[email protected]>
Signed-off-by: Fengguang Wu <[email protected]>
---

esp_mac80211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/staging/esp8089/esp_mac80211.c
+++ b/drivers/staging/esp8089/esp_mac80211.c
@@ -593,7 +593,7 @@ static void hw_scan_timeout_report(struc
if (test_and_clear_bit(ESP_WL_FLAG_STOP_TXQ, &epub->wl.flags))
sip_trigger_txq_process(epub->sip);
/*check if normally complete or aborted like timeout/hw error */
- aborted = (epub->wl.scan_req != 0);
+ aborted = (epub->wl.scan_req != NULL);

if (aborted)
epub->wl.scan_req = NULL;

2017-07-23 08:39:34

Hi Ulf,

On Wed, Aug 30, 2017 at 03:43:49PM +0200, Ulf Hansson wrote:
> On 30 August 2017 at 14:44, Hans de Goede <[email protected]> wrote:
> > Hi,
> >
> >
> > On 21-07-17 16:35, Quentin Schulz wrote:
> >>
> >> From: Hans de Goede <[email protected]>
> >>
> >> Some sdio devices have a multiple stage bring-up process. Specifically
> >> the esp8089 (for which an out of tree driver is available) loads firmware
> >> on the first call to its sdio-drivers' probe function and then resets
> >> the device causing it to reboot from its RAM with the new firmware.
> >>
> >> When this sdio device reboots it comes back up in 1 bit 400 KHz mode
> >> again, and we need to walk through the whole ios negatiation and sdio
> >> setup
> >> again.
> >>
> >> There are 2 problems with this:
> >>
> >> 1) Typically these devices are soldered onto some (ARM) tablet / SBC
> >> PCB and as such are described in devicetree as "non-removable", which
> >> causes the mmc-core to scan them only once and not poll for the device
> >> dropping of the bus. Normally this is the right thing todo but in the
> >> eso8089 example we need the mmc-core to notice the module has disconnected
> >> (since it is now in 1 bit mode again it will not talk to the host in 4 bit
> >> mode). This can be worked around by using "broken-cd" in devicetree
> >> instead of "non-removable", but that is not a proper fix since the device
> >> really is non-removable.
> >>
> >> 2) When the mmc-core detects the device has disconnected it will poweroff
> >> the device, causing the RAM loaded firmware to be lost. This can be worked
> >> around in devicetree by using regulator-always-on (and avoiding the use of
> >> mmc-pwrseq), but again that is more of a hack then a proper fix.
> >>
> >> This commmit fixes 1) by adding a mmc_force_detect_change function which
> >> will cause scanning for device removal / insertion until a new device is
> >> detected. 2) Is fixed by a keep_power flag to the mmc_force_detect_change
> >> function which when set causes the mmc-core to keep the power to the
> >> device
> >> on during the rescan.
> >>
> >> Cc: Icenowy Zheng <[email protected]>
> >> Cc: Maxime Ripard <[email protected]>
> >> Cc: Chen-Yu Tsai <[email protected]>
> >> Signed-off-by: Hans de Goede <[email protected]>
> >
> >
> > So when I posted this patch quite a while back, there was some discussion
> > about this and a consensus that this is not the right solution.
> >
> > So first of all lets describe the problem:
> >
> > The esp8089 sdio wifi chip is really an ARM core with a wifi phy
> > connected to it (as many wifi chipsets are).
> >
> > But this one comes up in some really generic sdio capable boot-loader
> > mode and we need to feed it firmware and then reboot it into the
> > new firmware.
> >
> > The reboot is where the problems happens. It seems to fallback
> > from the negotiated 4 wire sdio mode to single wire spi mode then.
> >
> > The out of tree version of the driver deals with this by not setting
> > the non-removable flag as well as setting the broken_cd flag so that
> > the mmc core polls the device, after the reboot the poll fails
> > because the mmc-controller and the esp8089 are using a different
> > amount of wires so the mmc-cmd the poll uses times out.
> >
> > After which the esp8089 drivers remove function gets called, and
> > the mmc stack re-discovers the esp8089 by restarting the whole
> > number of wires (and speed) used negotiation. After which the
> > esp8089 driver's probe function gets called (again) and on
> > firmware loading is has set a global flag, so now it actually
> > acts as a wifi driver rather then trying to load the firmware
> > a second time.
> >
> > Since I did not want to rely on broken_cd polling I came up
> > with the hack which is this patch.
> >
> > So when this patch was first discussed we came to the conclusion
> > that what we really need is some sort of mmc_reprobe_device
> > function which the driver can call from probe which will
> > redo the number of wires (and speed) used negotiation,
> > while keeping the sdio_function device as is so that probe can
> > simply continue after this and we also don't need the ugly
> > global flag.
> >
> > The idea would be for this function to be some wrapper
> > around mmc_init_card() which resets the ios settings as is
> > normally done on remove and then call mmc_init_card()
> > passing in the existing card the same way as is done
> > one resume, so that the existing card / sdio_function
> > devices get reused.
> >
> > IIRC Ulf would look into writing this mmc_reprobe_device
> > function and then I would test it with the esp8089, but
> > Ulf never got around to writing the function and I ended
> > up working on other things too.
>
> Thanks for summary!
>
> Just to let you know, I haven't forgot about this problem. I am
> planning for a major update of the SDIO for power management support,
> within a not too far future.
> The issue described above, is then also one of the things I also plan
> to look into.
>

I'd like to know if any progress has been made on that problem (I may
have missed patches).
Had you had the time to look at the issue?

Thanks and kind regards,
Quentin

Attachments:

(No filename) (5.20 kB)
signature.asc (817.00 B)
Download all attachments

2018-02-08 21:34:05

by Ulf Hansson

[permalink] [raw]

Subject: Re: [PATCH 2/2] mmc: Add mmc_force_detect_change_begin / _end functions

On 8 February 2018 at 15:59, Quentin Schulz <[email protected]> wrote:
> Hi Ulf,
>
> On Wed, Aug 30, 2017 at 03:43:49PM +0200, Ulf Hansson wrote:
>> On 30 August 2017 at 14:44, Hans de Goede <[email protected]> wrote:
>> > Hi,
>> >
>> >
>> > On 21-07-17 16:35, Quentin Schulz wrote:
>> >>
>> >> From: Hans de Goede <[email protected]>
>> >>
>> >> Some sdio devices have a multiple stage bring-up process. Specifically
>> >> the esp8089 (for which an out of tree driver is available) loads firmware
>> >> on the first call to its sdio-drivers' probe function and then resets
>> >> the device causing it to reboot from its RAM with the new firmware.
>> >>
>> >> When this sdio device reboots it comes back up in 1 bit 400 KHz mode
>> >> again, and we need to walk through the whole ios negatiation and sdio
>> >> setup
>> >> again.
>> >>
>> >> There are 2 problems with this:
>> >>
>> >> 1) Typically these devices are soldered onto some (ARM) tablet / SBC
>> >> PCB and as such are described in devicetree as "non-removable", which
>> >> causes the mmc-core to scan them only once and not poll for the device
>> >> dropping of the bus. Normally this is the right thing todo but in the
>> >> eso8089 example we need the mmc-core to notice the module has disconnected
>> >> (since it is now in 1 bit mode again it will not talk to the host in 4 bit
>> >> mode). This can be worked around by using "broken-cd" in devicetree
>> >> instead of "non-removable", but that is not a proper fix since the device
>> >> really is non-removable.
>> >>
>> >> 2) When the mmc-core detects the device has disconnected it will poweroff
>> >> the device, causing the RAM loaded firmware to be lost. This can be worked
>> >> around in devicetree by using regulator-always-on (and avoiding the use of
>> >> mmc-pwrseq), but again that is more of a hack then a proper fix.
>> >>
>> >> This commmit fixes 1) by adding a mmc_force_detect_change function which
>> >> will cause scanning for device removal / insertion until a new device is
>> >> detected. 2) Is fixed by a keep_power flag to the mmc_force_detect_change
>> >> function which when set causes the mmc-core to keep the power to the
>> >> device
>> >> on during the rescan.
>> >>
>> >> Cc: Icenowy Zheng <[email protected]>
>> >> Cc: Maxime Ripard <[email protected]>
>> >> Cc: Chen-Yu Tsai <[email protected]>
>> >> Signed-off-by: Hans de Goede <[email protected]>
>> >
>> >
>> > So when I posted this patch quite a while back, there was some discussion
>> > about this and a consensus that this is not the right solution.
>> >
>> > So first of all lets describe the problem:
>> >
>> > The esp8089 sdio wifi chip is really an ARM core with a wifi phy
>> > connected to it (as many wifi chipsets are).
>> >
>> > But this one comes up in some really generic sdio capable boot-loader
>> > mode and we need to feed it firmware and then reboot it into the
>> > new firmware.
>> >
>> > The reboot is where the problems happens. It seems to fallback
>> > from the negotiated 4 wire sdio mode to single wire spi mode then.
>> >
>> > The out of tree version of the driver deals with this by not setting
>> > the non-removable flag as well as setting the broken_cd flag so that
>> > the mmc core polls the device, after the reboot the poll fails
>> > because the mmc-controller and the esp8089 are using a different
>> > amount of wires so the mmc-cmd the poll uses times out.
>> >
>> > After which the esp8089 drivers remove function gets called, and
>> > the mmc stack re-discovers the esp8089 by restarting the whole
>> > number of wires (and speed) used negotiation. After which the
>> > esp8089 driver's probe function gets called (again) and on
>> > firmware loading is has set a global flag, so now it actually
>> > acts as a wifi driver rather then trying to load the firmware
>> > a second time.
>> >
>> > Since I did not want to rely on broken_cd polling I came up
>> > with the hack which is this patch.
>> >
>> > So when this patch was first discussed we came to the conclusion
>> > that what we really need is some sort of mmc_reprobe_device
>> > function which the driver can call from probe which will
>> > redo the number of wires (and speed) used negotiation,
>> > while keeping the sdio_function device as is so that probe can
>> > simply continue after this and we also don't need the ugly
>> > global flag.
>> >
>> > The idea would be for this function to be some wrapper
>> > around mmc_init_card() which resets the ios settings as is
>> > normally done on remove and then call mmc_init_card()
>> > passing in the existing card the same way as is done
>> > one resume, so that the existing card / sdio_function
>> > devices get reused.
>> >
>> > IIRC Ulf would look into writing this mmc_reprobe_device
>> > function and then I would test it with the esp8089, but
>> > Ulf never got around to writing the function and I ended
>> > up working on other things too.
>>
>> Thanks for summary!
>>
>> Just to let you know, I haven't forgot about this problem. I am
>> planning for a major update of the SDIO for power management support,
>> within a not too far future.
>> The issue described above, is then also one of the things I also plan
>> to look into.
>>
>
> I'd like to know if any progress has been made on that problem (I may
> have missed patches).
> Had you had the time to look at the issue?

I have looked at the issue, but not manage to cook some patches for it.

However, it's on my top of my TODO list for mmc. No promises, but
perhaps and hopefully I manage to get something posted during the
coming release cycle.

Sorry for the delay!

Br
Uffe

2018-02-09 08:06:53

2018-10-09 14:04:15

by Frieder Schrempf

[permalink] [raw]

Subject: Re: [PATCH 2/2] mmc: Add mmc_force_detect_change_begin / _end functions

Hi Quentin,

On 09.10.2018 09:52, Quentin Schulz wrote:
> Hi Frieder,
>
> On Mon, Oct 08, 2018 at 11:53:21AM +0200, Frieder Schrempf wrote:
>> Hi,
>>
>> On 27.09.2018 10:14, Maxime Ripard wrote:
>>> On Wed, Sep 26, 2018 at 10:19:22PM +0200, Hans de Goede wrote:
>>>> On 26-09-18 16:44, Frieder Schrempf wrote:
>>>>> Hi,
>>>>>
>>>>> On Fri, Feb 09, 2018 at 03:01:00PM +0100, Ulf Hansson wrote:
>>>>>> [...]
>>>>>>
>>>>>>>>> I'd like to know if any progress has been made on that problem
>>>>> (I may
>>>>>>>>> have missed patches).
>>>>>>>>> Had you had the time to look at the issue?
>>>>>>>>
>>>>>>>> I have looked at the issue, but not manage to cook some patches
>>>>> for it.
>>>>>>>>
>>>>>>>> However, it's on my top of my TODO list for mmc. No promises, but
>>>>>>>> perhaps and hopefully I manage to get something posted during the
>>>>>>>> coming release cycle.
>>>>>
>>>>> I would be interested in a ESP8089 driver in mainline and that's why I want to pick up this discussion.
>>>>>
>>>>> What is the current status of the "mmc_reprobe_device" implementation, that Hans was explaining and Ulf wanted to provide some months ago?
>>>>
>>>> Ulf did eventually write a new way to deal with this and then Quentin
>>>> did manage to get the esp8089 driver to work with it, the new function
>>>> to use for this is added by this commit:
>>>>
>>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/mmc/core?id=1433269c4d2461be1f36db5dbb453976b38996ff
>>>>
>>>> I'm not sure what the status of upstreaming the ep8089 driver is now
>>>> that we've this in place.
>>>>
>>>> Quentin, do you have a version of the esp8089 driver somewhere
>>>> which will work correctly with the new mmc_sw_reset() function?
>>>>
>>>> Also what is the status of adding this driver to say staging?
>>>
>>> IIRC, we tried to get it into staging, and we got told that it was too
>>> nice for staging at this point. So we're basically stuck somewhere
>>> between staging and !staging, with the driver being too nice for the
>>> former, and not nice enough for the latter :)
>>
>> Ok, and is there someone willing to continue upstreaming the driver? Maybe
>> someone can rebase and resend the latest approach?
>>
>> After all it looks like a lot of work has already been done.
>>
>
> There's clean up to do. It's time consuming but shouldn't be too hard to
> do.
>
> Then, we stressed the driver with an iperf test and it crashes very
> often so we first need to identify if it happened with the "original"
> driver before Icenowy's, Hans's and my clean-up. If it happened, since
> we don't have a datasheet, it might be not that easy to fix. If it
> didn't happen, then we have to find out where I cleaned up too much :D
>
> I'm not currently working on this topic so anyone willing to take over
> the work is free to do so.

Thanks a lot for providing the details. It is currently not clear on our
side, if the project with the ESP8089 will happen, but if that's the
case we might pick up the work.

Thanks
Frieder