2020-04-27 11:08:52

by Wei Yongjun

[permalink] [raw]
Subject: [PATCH] mfd: wcd934x: Drop kfree for memory allocated with devm_kzalloc

It's not necessary to free memory allocated with devm_kzalloc
and using kfree leads to a double free.

Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/mfd/wcd934x.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/mfd/wcd934x.c b/drivers/mfd/wcd934x.c
index 90341f3c6810..da910302d51a 100644
--- a/drivers/mfd/wcd934x.c
+++ b/drivers/mfd/wcd934x.c
@@ -280,7 +280,6 @@ static void wcd934x_slim_remove(struct slim_device *sdev)

regulator_bulk_disable(WCD934X_MAX_SUPPLY, ddata->supplies);
mfd_remove_devices(&sdev->dev);
- kfree(ddata);
}

static const struct slim_device_id wcd934x_slim_id[] = {






2020-04-27 12:30:10

by Wei Yongjun

[permalink] [raw]
Subject: [PATCH] mfd: wcd934x: Drop kfree for memory allocated with devm_kzalloc

It's not necessary to free memory allocated with devm_kzalloc
and using kfree leads to a double free.

Fixes: 6ac7e4d7ad70 ("mfd: wcd934x: Add support to wcd9340/wcd9341 codec")
Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/mfd/wcd934x.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/mfd/wcd934x.c b/drivers/mfd/wcd934x.c
index 90341f3c6810..da910302d51a 100644
--- a/drivers/mfd/wcd934x.c
+++ b/drivers/mfd/wcd934x.c
@@ -280,7 +280,6 @@ static void wcd934x_slim_remove(struct slim_device *sdev)

regulator_bulk_disable(WCD934X_MAX_SUPPLY, ddata->supplies);
mfd_remove_devices(&sdev->dev);
- kfree(ddata);
}

static const struct slim_device_id wcd934x_slim_id[] = {



2020-04-28 10:41:16

by Lee Jones

[permalink] [raw]
Subject: Re: [PATCH] mfd: wcd934x: Drop kfree for memory allocated with devm_kzalloc

On Mon, 27 Apr 2020, Wei Yongjun wrote:

> It's not necessary to free memory allocated with devm_kzalloc
> and using kfree leads to a double free.
>
> Fixes: 6ac7e4d7ad70 ("mfd: wcd934x: Add support to wcd9340/wcd9341 codec")
> Signed-off-by: Wei Yongjun <[email protected]>
> ---
> drivers/mfd/wcd934x.c | 1 -
> 1 file changed, 1 deletion(-)

Applied, thanks.

--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog