Some SoC like i.MX8QXP use a power-domain for this IP. Add a SoC-specific
compatible, which also requires a power-domain.
Signed-off-by: Alexander Stein <[email protected]>
---
Thanks for the feedback.
Changes in v3:
* Move 'allOf' before 'additionalProperties'
* Remove superfluous 'minItems: 1'
.../interrupt-controller/fsl,irqsteer.yaml | 17 ++++++++++++++++-
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml
index 20ad4ad82ad64..3d33b75d6ecfa 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml
+++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml
@@ -14,7 +14,9 @@ properties:
oneOf:
- const: fsl,imx-irqsteer
- items:
- - const: fsl,imx8m-irqsteer
+ - enum:
+ - fsl,imx8m-irqsteer
+ - fsl,imx8qxp-irqsteer
- const: fsl,imx-irqsteer
reg:
@@ -42,6 +44,9 @@ properties:
clock-names:
const: ipg
+ power-domains:
+ maxItems: 1
+
interrupt-controller: true
"#interrupt-cells":
@@ -70,6 +75,16 @@ required:
- fsl,channel
- fsl,num-irqs
+allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: fsl,imx8qxp-irqsteer
+ then:
+ required:
+ - power-domains
+
additionalProperties: false
examples:
--
2.34.1
On Mon, Apr 22, 2024 at 08:49:49AM +0200, Alexander Stein wrote:
> Some SoC like i.MX8QXP use a power-domain for this IP. Add a SoC-specific
> compatible, which also requires a power-domain.
>
> Signed-off-by: Alexander Stein <[email protected]>
> ---
> Thanks for the feedback.
>
> Changes in v3:
> * Move 'allOf' before 'additionalProperties'
> * Remove superfluous 'minItems: 1'
>
> .../interrupt-controller/fsl,irqsteer.yaml | 17 ++++++++++++++++-
> 1 file changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml
> index 20ad4ad82ad64..3d33b75d6ecfa 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml
> @@ -14,7 +14,9 @@ properties:
> oneOf:
> - const: fsl,imx-irqsteer
> - items:
> - - const: fsl,imx8m-irqsteer
> + - enum:
> + - fsl,imx8m-irqsteer
> + - fsl,imx8qxp-irqsteer
> - const: fsl,imx-irqsteer
>
> reg:
> @@ -42,6 +44,9 @@ properties:
> clock-names:
> const: ipg
>
> + power-domains:
> + maxItems: 1
> +
> interrupt-controller: true
>
> "#interrupt-cells":
> @@ -70,6 +75,16 @@ required:
> - fsl,channel
> - fsl,num-irqs
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: fsl,imx8qxp-irqsteer
> + then:
> + required:
> + - power-domains
Provided the power domains are optional on the existing platforms,
Acked-by: Conor Dooley <[email protected]>
otherwise,
else:
properties:
power-domains: false
Cheers,
Conor.
> +
> additionalProperties: false
>
> examples:
> --
> 2.34.1
>
On Mon, Apr 22, 2024 at 08:49:49AM +0200, Alexander Stein wrote:
> Some SoC like i.MX8QXP use a power-domain for this IP. Add a SoC-specific
> compatible, which also requires a power-domain.
>
> Signed-off-by: Alexander Stein <[email protected]>
> ---
Next time, please cc [email protected]
Frank
> Thanks for the feedback.
>
> Changes in v3:
> * Move 'allOf' before 'additionalProperties'
> * Remove superfluous 'minItems: 1'
>
> .../interrupt-controller/fsl,irqsteer.yaml | 17 ++++++++++++++++-
> 1 file changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml
> index 20ad4ad82ad64..3d33b75d6ecfa 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml
> @@ -14,7 +14,9 @@ properties:
> oneOf:
> - const: fsl,imx-irqsteer
> - items:
> - - const: fsl,imx8m-irqsteer
> + - enum:
> + - fsl,imx8m-irqsteer
> + - fsl,imx8qxp-irqsteer
> - const: fsl,imx-irqsteer
>
> reg:
> @@ -42,6 +44,9 @@ properties:
> clock-names:
> const: ipg
>
> + power-domains:
> + maxItems: 1
> +
> interrupt-controller: true
>
> "#interrupt-cells":
> @@ -70,6 +75,16 @@ required:
> - fsl,channel
> - fsl,num-irqs
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: fsl,imx8qxp-irqsteer
> + then:
> + required:
> + - power-domains
> +
> additionalProperties: false
>
> examples:
> --
> 2.34.1
>
Hi Conor,
cc'ed [email protected]
Am Montag, 22. April 2024, 17:48:20 CEST schrieb Conor Dooley:
> On Mon, Apr 22, 2024 at 08:49:49AM +0200, Alexander Stein wrote:
> > Some SoC like i.MX8QXP use a power-domain for this IP. Add a SoC-specific
> > compatible, which also requires a power-domain.
> >
> > Signed-off-by: Alexander Stein <[email protected]>
> > ---
> > Thanks for the feedback.
> >
> > Changes in v3:
> > * Move 'allOf' before 'additionalProperties'
> > * Remove superfluous 'minItems: 1'
> >
> > .../interrupt-controller/fsl,irqsteer.yaml | 17 ++++++++++++++++-
> > 1 file changed, 16 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml
> > index 20ad4ad82ad64..3d33b75d6ecfa 100644
> > --- a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml
> > +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml
> > @@ -14,7 +14,9 @@ properties:
> > oneOf:
> > - const: fsl,imx-irqsteer
> > - items:
> > - - const: fsl,imx8m-irqsteer
> > + - enum:
> > + - fsl,imx8m-irqsteer
> > + - fsl,imx8qxp-irqsteer
> > - const: fsl,imx-irqsteer
> >
> > reg:
> > @@ -42,6 +44,9 @@ properties:
> > clock-names:
> > const: ipg
> >
> > + power-domains:
> > + maxItems: 1
> > +
> > interrupt-controller: true
> >
> > "#interrupt-cells":
> > @@ -70,6 +75,16 @@ required:
> > - fsl,channel
> > - fsl,num-irqs
> >
> > +allOf:
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + const: fsl,imx8qxp-irqsteer
> > + then:
> > + required:
> > + - power-domains
>
> Provided the power domains are optional on the existing platforms,
> Acked-by: Conor Dooley <[email protected]>
> otherwise,
> else:
> properties:
> power-domains: false
A power-domain is used on imx8mp, but imx8mq does not.
Best regards,
Alexander
--
TQ-Systems GmbH | M?hlstra?e 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht M?nchen, HRB 105018
Gesch?ftsf?hrer: Detlef Schneider, R?diger Stahl, Stefan Schneider
http://www.tq-group.com/
Hi Frank,
Am Montag, 22. April 2024, 18:38:09 CEST schrieb Frank Li:
> On Mon, Apr 22, 2024 at 08:49:49AM +0200, Alexander Stein wrote:
> > Some SoC like i.MX8QXP use a power-domain for this IP. Add a SoC-specific
> > compatible, which also requires a power-domain.
> >
> > Signed-off-by: Alexander Stein <[email protected]>
> > ---
>
> Next time, please cc [email protected]
I use the addresses from ./scripts/get_maintainer.pl, maybe you want to
add that to MAINTAINERS.
Thanks and best regards,
Alexander
> Frank
>
> > Thanks for the feedback.
> >
> > Changes in v3:
> > * Move 'allOf' before 'additionalProperties'
> > * Remove superfluous 'minItems: 1'
> >
> > .../interrupt-controller/fsl,irqsteer.yaml | 17 ++++++++++++++++-
> > 1 file changed, 16 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml
> > index 20ad4ad82ad64..3d33b75d6ecfa 100644
> > --- a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml
> > +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml
> > @@ -14,7 +14,9 @@ properties:
> > oneOf:
> > - const: fsl,imx-irqsteer
> > - items:
> > - - const: fsl,imx8m-irqsteer
> > + - enum:
> > + - fsl,imx8m-irqsteer
> > + - fsl,imx8qxp-irqsteer
> > - const: fsl,imx-irqsteer
> >
> > reg:
> > @@ -42,6 +44,9 @@ properties:
> > clock-names:
> > const: ipg
> >
> > + power-domains:
> > + maxItems: 1
> > +
> > interrupt-controller: true
> >
> > "#interrupt-cells":
> > @@ -70,6 +75,16 @@ required:
> > - fsl,channel
> > - fsl,num-irqs
> >
> > +allOf:
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + const: fsl,imx8qxp-irqsteer
> > + then:
> > + required:
> > + - power-domains
> > +
> > additionalProperties: false
> >
> > examples:
>
--
TQ-Systems GmbH | M?hlstra?e 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht M?nchen, HRB 105018
Gesch?ftsf?hrer: Detlef Schneider, R?diger Stahl, Stefan Schneider
http://www.tq-group.com/
On Tue, Apr 23, 2024 at 08:26:55AM +0200, Alexander Stein wrote:
> Hi Conor,
>
> cc'ed [email protected]
>
> Am Montag, 22. April 2024, 17:48:20 CEST schrieb Conor Dooley:
> > On Mon, Apr 22, 2024 at 08:49:49AM +0200, Alexander Stein wrote:
> > > Some SoC like i.MX8QXP use a power-domain for this IP. Add a SoC-specific
> > > compatible, which also requires a power-domain.
> > >
> > > Signed-off-by: Alexander Stein <[email protected]>
> > > ---
> > > Thanks for the feedback.
> > >
> > > Changes in v3:
> > > * Move 'allOf' before 'additionalProperties'
> > > * Remove superfluous 'minItems: 1'
> > >
> > > .../interrupt-controller/fsl,irqsteer.yaml | 17 ++++++++++++++++-
> > > 1 file changed, 16 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml
> > > index 20ad4ad82ad64..3d33b75d6ecfa 100644
> > > --- a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml
> > > +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml
> > > @@ -14,7 +14,9 @@ properties:
> > > oneOf:
> > > - const: fsl,imx-irqsteer
> > > - items:
> > > - - const: fsl,imx8m-irqsteer
> > > + - enum:
> > > + - fsl,imx8m-irqsteer
> > > + - fsl,imx8qxp-irqsteer
> > > - const: fsl,imx-irqsteer
> > >
> > > reg:
> > > @@ -42,6 +44,9 @@ properties:
> > > clock-names:
> > > const: ipg
> > >
> > > + power-domains:
> > > + maxItems: 1
> > > +
> > > interrupt-controller: true
> > >
> > > "#interrupt-cells":
> > > @@ -70,6 +75,16 @@ required:
> > > - fsl,channel
> > > - fsl,num-irqs
> > >
> > > +allOf:
> > > + - if:
> > > + properties:
> > > + compatible:
> > > + contains:
> > > + const: fsl,imx8qxp-irqsteer
> > > + then:
> > > + required:
> > > + - power-domains
> >
> > Provided the power domains are optional on the existing platforms,
> > Acked-by: Conor Dooley <[email protected]>
> > otherwise,
> > else:
> > properties:
> > power-domains: false
>
> A power-domain is used on imx8mp, but imx8mq does not.
So then make the contains be an enum with both of the one supporting it
& add the else please.