Fix two checkpatch warnings for 80 char
length and for a quoted string across multiple
line warnings.
Signed-off-by: Dan Murphy <[email protected]>
---
drivers/leds/leds-as3645a.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/leds/leds-as3645a.c b/drivers/leds/leds-as3645a.c
index 9a257f969300..f883616d9e60 100644
--- a/drivers/leds/leds-as3645a.c
+++ b/drivers/leds/leds-as3645a.c
@@ -360,7 +360,8 @@ static int as3645a_set_flash_brightness(struct led_classdev_flash *fled,
{
struct as3645a *flash = fled_to_as3645a(fled);
- flash->flash_current = as3645a_current_to_reg(flash, true, brightness_ua);
+ flash->flash_current = as3645a_current_to_reg(flash, true,
+ brightness_ua);
return as3645a_set_current(flash);
}
@@ -455,8 +456,8 @@ static int as3645a_detect(struct as3645a *flash)
/* Verify the chip model and version. */
if (model != 0x01 || rfu != 0x00) {
- dev_err(dev, "AS3645A not detected "
- "(model %d rfu %d)\n", model, rfu);
+ dev_err(dev, "AS3645A not detected (model %d rfu %d)\n",
+ model, rfu);
return -ENODEV;
}
--
2.15.0.124.g7668cbc60
Hi Dan,
Thank you for the patch.
On Tuesday, 12 December 2017 23:50:11 EET Dan Murphy wrote:
> Fix two checkpatch warnings for 80 char
> length and for a quoted string across multiple
> line warnings.
>
> Signed-off-by: Dan Murphy <[email protected]>
Acked-by: Laurent Pinchart <[email protected]>
> ---
> drivers/leds/leds-as3645a.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/leds/leds-as3645a.c b/drivers/leds/leds-as3645a.c
> index 9a257f969300..f883616d9e60 100644
> --- a/drivers/leds/leds-as3645a.c
> +++ b/drivers/leds/leds-as3645a.c
> @@ -360,7 +360,8 @@ static int as3645a_set_flash_brightness(struct
> led_classdev_flash *fled, {
> struct as3645a *flash = fled_to_as3645a(fled);
>
> - flash->flash_current = as3645a_current_to_reg(flash, true, brightness_ua);
> + flash->flash_current = as3645a_current_to_reg(flash, true,
> + brightness_ua);
>
> return as3645a_set_current(flash);
> }
> @@ -455,8 +456,8 @@ static int as3645a_detect(struct as3645a *flash)
>
> /* Verify the chip model and version. */
> if (model != 0x01 || rfu != 0x00) {
> - dev_err(dev, "AS3645A not detected "
> - "(model %d rfu %d)\n", model, rfu);
> + dev_err(dev, "AS3645A not detected (model %d rfu %d)\n",
> + model, rfu);
> return -ENODEV;
> }
--
Regards,
Laurent Pinchart
On Tue 2017-12-12 15:50:11, Dan Murphy wrote:
> Fix two checkpatch warnings for 80 char
> length and for a quoted string across multiple
> line warnings.
>
> Signed-off-by: Dan Murphy <[email protected]>
Acked-by: Pavel Machek <[email protected]>
> ---
> drivers/leds/leds-as3645a.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/leds/leds-as3645a.c b/drivers/leds/leds-as3645a.c
> index 9a257f969300..f883616d9e60 100644
> --- a/drivers/leds/leds-as3645a.c
> +++ b/drivers/leds/leds-as3645a.c
> @@ -360,7 +360,8 @@ static int as3645a_set_flash_brightness(struct led_classdev_flash *fled,
> {
> struct as3645a *flash = fled_to_as3645a(fled);
>
> - flash->flash_current = as3645a_current_to_reg(flash, true, brightness_ua);
> + flash->flash_current = as3645a_current_to_reg(flash, true,
> + brightness_ua);
>
> return as3645a_set_current(flash);
> }
> @@ -455,8 +456,8 @@ static int as3645a_detect(struct as3645a *flash)
>
> /* Verify the chip model and version. */
> if (model != 0x01 || rfu != 0x00) {
> - dev_err(dev, "AS3645A not detected "
> - "(model %d rfu %d)\n", model, rfu);
> + dev_err(dev, "AS3645A not detected (model %d rfu %d)\n",
> + model, rfu);
> return -ENODEV;
> }
>
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Hi Dan,
checkpatch.pl doesn't want to be mentioned in the patch subject :-)
"WARNING: A patch subject line should describe the change not the tool
that found it"
Preferably I'd see two separate patches.
Also, line length limit for the commit description is 75 characters.
Please use whole available space.
--
Best regards,
Jacek Anaszewski
On 12/12/2017 10:50 PM, Dan Murphy wrote:
> Fix two checkpatch warnings for 80 char
> length and for a quoted string across multiple
> line warnings.
>
> Signed-off-by: Dan Murphy <[email protected]>
> ---
> drivers/leds/leds-as3645a.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/leds/leds-as3645a.c b/drivers/leds/leds-as3645a.c
> index 9a257f969300..f883616d9e60 100644
> --- a/drivers/leds/leds-as3645a.c
> +++ b/drivers/leds/leds-as3645a.c
> @@ -360,7 +360,8 @@ static int as3645a_set_flash_brightness(struct led_classdev_flash *fled,
> {
> struct as3645a *flash = fled_to_as3645a(fled);
>
> - flash->flash_current = as3645a_current_to_reg(flash, true, brightness_ua);
> + flash->flash_current = as3645a_current_to_reg(flash, true,
> + brightness_ua);
>
> return as3645a_set_current(flash);
> }
> @@ -455,8 +456,8 @@ static int as3645a_detect(struct as3645a *flash)
>
> /* Verify the chip model and version. */
> if (model != 0x01 || rfu != 0x00) {
> - dev_err(dev, "AS3645A not detected "
> - "(model %d rfu %d)\n", model, rfu);
> + dev_err(dev, "AS3645A not detected (model %d rfu %d)\n",
> + model, rfu);
> return -ENODEV;
> }
>
>
Jacek
On 12/13/2017 02:29 PM, Jacek Anaszewski wrote:
> Hi Dan,
>
> checkpatch.pl doesn't want to be mentioned in the patch subject :-)
>
Ack
> "WARNING: A patch subject line should describe the change not the tool
> that found it"
>
> Preferably I'd see two separate patches.
>
So you want me to split them up? I have no issue with that.
> Also, line length limit for the commit description is 75 characters.
> Please use whole available space.
>
--
------------------
Dan Murphy
Dan,
On 12/13/2017 09:41 PM, Dan Murphy wrote:
> Jacek
>
> On 12/13/2017 02:29 PM, Jacek Anaszewski wrote:
>> Hi Dan,
>>
>> checkpatch.pl doesn't want to be mentioned in the patch subject :-)
>>
>
> Ack
>
>> "WARNING: A patch subject line should describe the change not the tool
>> that found it"
>>
>> Preferably I'd see two separate patches.
>>
>
> So you want me to split them up? I have no issue with that.
Yeah, it will be easier to come up with concise but meaningful
subjects.
>> Also, line length limit for the commit description is 75 characters.
>> Please use whole available space.
>>
>
>
--
Best regards,
Jacek Anaszewski
Pavel and Laurent
On 12/13/2017 02:43 PM, Jacek Anaszewski wrote:
> Dan,
>
> On 12/13/2017 09:41 PM, Dan Murphy wrote:
>> Jacek
>>
>> On 12/13/2017 02:29 PM, Jacek Anaszewski wrote:
>>> Hi Dan,
>>>
>>> checkpatch.pl doesn't want to be mentioned in the patch subject :-)
>>>
>>
>> Ack
>>
>>> "WARNING: A patch subject line should describe the change not the tool
>>> that found it"
>>>
>>> Preferably I'd see two separate patches.
>>>
>>
>> So you want me to split them up? I have no issue with that.
>
> Yeah, it will be easier to come up with concise but meaningful
> subjects.
>
When I split these up can I add your Acked-by to each patch or would you prefer to resend your
Acked-by for each patch?
Dan
>>> Also, line length limit for the commit description is 75 characters.
>>> Please use whole available space.
>>>
>>
>>
>
--
------------------
Dan Murphy
Hi Dan,
On Wednesday, 13 December 2017 22:49:38 EET Dan Murphy wrote:
> On 12/13/2017 02:43 PM, Jacek Anaszewski wrote:
> > On 12/13/2017 09:41 PM, Dan Murphy wrote:
> >> On 12/13/2017 02:29 PM, Jacek Anaszewski wrote:
> >>> Hi Dan,
> >>>
> >>> checkpatch.pl doesn't want to be mentioned in the patch subject :-)
> >>
> >> Ack
> >>
> >>> "WARNING: A patch subject line should describe the change not the tool
> >>> that found it"
> >>>
> >>> Preferably I'd see two separate patches.
> >>
> >> So you want me to split them up? I have no issue with that.
> >
> > Yeah, it will be easier to come up with concise but meaningful
> > subjects.
Well, given that one change splits a line that is too long and the other one
merges two lines that fit within the limit we could come up with a message
that covers both :-) This is nitpicking though, it doesn't matter much. I have
no issue with a patch that has some "while at it" portion anyway as long as
it's minor (I personally include white space fixes in patches that touch the
related code for instance).
> When I split these up can I add your Acked-by to each patch or would you
> prefer to resend your Acked-by for each patch?
Assuming you make no mistake, you can keep my ack :-) It will of course not
cover the commit message then.
> >>> Also, line length limit for the commit description is 75 characters.
> >>> Please use whole available space.
--
Regards,
Laurent Pinchart
On Wed 2017-12-13 21:29:29, Jacek Anaszewski wrote:
> Hi Dan,
>
> checkpatch.pl doesn't want to be mentioned in the patch subject :-)
>
> "WARNING: A patch subject line should describe the change not the tool
> that found it"
That is pretty stupid rule. Everyone and their dog knows what
"checkpatch fixes" are.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
On Wed 2017-12-13 14:49:38, Dan Murphy wrote:
> Pavel and Laurent
>
> On 12/13/2017 02:43 PM, Jacek Anaszewski wrote:
> > Dan,
> >
> > On 12/13/2017 09:41 PM, Dan Murphy wrote:
> >> Jacek
> >>
> >> On 12/13/2017 02:29 PM, Jacek Anaszewski wrote:
> >>> Hi Dan,
> >>>
> >>> checkpatch.pl doesn't want to be mentioned in the patch subject :-)
> >>>
> >>
> >> Ack
> >>
> >>> "WARNING: A patch subject line should describe the change not the tool
> >>> that found it"
> >>>
> >>> Preferably I'd see two separate patches.
> >>>
> >>
> >> So you want me to split them up? I have no issue with that.
> >
> > Yeah, it will be easier to come up with concise but meaningful
> > subjects.
> >
>
> When I split these up can I add your Acked-by to each patch or would you prefer to resend your
> Acked-by for each patch?
You can keep the ack...
...and my preference would be for trivial fixes like these to be just
applied. No need to resend 3 versions etc...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html