2020-11-11 09:50:27

by Zheng Zengkai

[permalink] [raw]
Subject: [PATCH] usb: dwc3: meson-g12a: disable clk on error handling path in probe

dwc3_meson_g12a_probe() does not invoke clk_bulk_disable_unprepare()
on one error handling path. This patch fixes that.

Fixes: 347052e3bf1b ("usb: dwc3: meson-g12a: fix USB2 PHY initialization on G12A and A1 SoCs")
Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zheng Zengkai <[email protected]>
---
drivers/usb/dwc3/dwc3-meson-g12a.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/dwc3/dwc3-meson-g12a.c b/drivers/usb/dwc3/dwc3-meson-g12a.c
index 417e05381b5d..bdf1f98dfad8 100644
--- a/drivers/usb/dwc3/dwc3-meson-g12a.c
+++ b/drivers/usb/dwc3/dwc3-meson-g12a.c
@@ -754,7 +754,7 @@ static int dwc3_meson_g12a_probe(struct platform_device *pdev)

ret = priv->drvdata->setup_regmaps(priv, base);
if (ret)
- return ret;
+ goto err_disable_clks;

if (priv->vbus) {
ret = regulator_enable(priv->vbus);
--
2.20.1


2020-11-11 19:46:52

by Martin Blumenstingl

[permalink] [raw]
Subject: Re: [PATCH] usb: dwc3: meson-g12a: disable clk on error handling path in probe

On Wed, Nov 11, 2020 at 10:48 AM Zheng Zengkai <[email protected]> wrote:
>
> dwc3_meson_g12a_probe() does not invoke clk_bulk_disable_unprepare()
> on one error handling path. This patch fixes that.
>
> Fixes: 347052e3bf1b ("usb: dwc3: meson-g12a: fix USB2 PHY initialization on G12A and A1 SoCs")
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zheng Zengkai <[email protected]>
Reviewed-by: Martin Blumenstingl <[email protected]>

many thanks for this fix!


Best regards
Martin

2020-11-27 08:54:26

by Zheng Zengkai

[permalink] [raw]
Subject: Re: [PATCH] usb: dwc3: meson-g12a: disable clk on error handling path in probe

Ping...

> On Wed, Nov 11, 2020 at 10:48 AM Zheng Zengkai <[email protected]> wrote:
>> dwc3_meson_g12a_probe() does not invoke clk_bulk_disable_unprepare()
>> on one error handling path. This patch fixes that.
>>
>> Fixes: 347052e3bf1b ("usb: dwc3: meson-g12a: fix USB2 PHY initialization on G12A and A1 SoCs")
>> Reported-by: Hulk Robot <[email protected]>
>> Signed-off-by: Zheng Zengkai <[email protected]>
> Reviewed-by: Martin Blumenstingl <[email protected]>
>
> many thanks for this fix!
>
>
> Best regards
> Martin
> .
>

2020-12-01 03:07:44

by Zheng Zengkai

[permalink] [raw]
Subject: Re: [PATCH] usb: dwc3: meson-g12a: disable clk on error handling path in probe

Hi Felipe and Greg,

> Ping...
>
>> On Wed, Nov 11, 2020 at 10:48 AM Zheng Zengkai
>> <[email protected]> wrote:
>>> dwc3_meson_g12a_probe() does not invoke clk_bulk_disable_unprepare()
>>> on one error handling path. This patch fixes that.
>>>
>>> Fixes: 347052e3bf1b ("usb: dwc3: meson-g12a: fix USB2 PHY
>>> initialization on G12A and A1 SoCs")
>>> Reported-by: Hulk Robot <[email protected]>
>>> Signed-off-by: Zheng Zengkai <[email protected]>
>> Reviewed-by: Martin Blumenstingl <[email protected]>
>>
>> many thanks for this fix!
>>
>>
>> Best regards
>> Martin
>>
>> .

Could you please get round to taking a glance and giving me a reply? ;-)

Thank you very much!

Best regards

Zengkai