From: Bjorn Helgaas <[email protected]>
There are no arch-specific things in arch_kexec_kernel_image_load(), so
remove it and just use the generic version.
Bjorn Helgaas (2):
x86/kexec: Remove unnecessary arch_kexec_kernel_image_load()
kexec: Remove unnecessary arch_kexec_kernel_image_load()
arch/x86/include/asm/kexec.h | 3 ---
arch/x86/kernel/machine_kexec_64.c | 11 -----------
include/linux/kexec.h | 8 --------
kernel/kexec_file.c | 6 +++---
4 files changed, 3 insertions(+), 25 deletions(-)
--
2.25.1
On 12/15/22 at 12:23pm, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <[email protected]>
>
> There are no arch-specific things in arch_kexec_kernel_image_load(), so
> remove it and just use the generic version.
I ever posted below patch to do the same thing, Andrew only picked the
memory leak fixing patch.
[PATCH v2 2/2] kexec_file: clean up arch_kexec_kernel_image_load
https://lore.kernel.org/all/[email protected]/T/#u
>
> Bjorn Helgaas (2):
> x86/kexec: Remove unnecessary arch_kexec_kernel_image_load()
> kexec: Remove unnecessary arch_kexec_kernel_image_load()
>
> arch/x86/include/asm/kexec.h | 3 ---
> arch/x86/kernel/machine_kexec_64.c | 11 -----------
> include/linux/kexec.h | 8 --------
> kernel/kexec_file.c | 6 +++---
> 4 files changed, 3 insertions(+), 25 deletions(-)
>
> --
> 2.25.1
>
>
> _______________________________________________
> kexec mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/kexec
>
On Sat, Dec 17, 2022 at 05:48:51PM +0800, Baoquan He wrote:
> On 12/15/22 at 12:23pm, Bjorn Helgaas wrote:
> > From: Bjorn Helgaas <[email protected]>
> >
> > There are no arch-specific things in arch_kexec_kernel_image_load(), so
> > remove it and just use the generic version.
>
> I ever posted below patch to do the same thing, Andrew only picked the
> memory leak fixing patch.
>
> [PATCH v2 2/2] kexec_file: clean up arch_kexec_kernel_image_load
> https://lore.kernel.org/all/[email protected]/T/#u
Indeed! Sorry, I wasn't aware of your previous work. If you repost
it, cc me and I'll be glad to help review it.
> > Bjorn Helgaas (2):
> > x86/kexec: Remove unnecessary arch_kexec_kernel_image_load()
> > kexec: Remove unnecessary arch_kexec_kernel_image_load()
> >
> > arch/x86/include/asm/kexec.h | 3 ---
> > arch/x86/kernel/machine_kexec_64.c | 11 -----------
> > include/linux/kexec.h | 8 --------
> > kernel/kexec_file.c | 6 +++---
> > 4 files changed, 3 insertions(+), 25 deletions(-)
On 12/17/22 at 09:58am, Bjorn Helgaas wrote:
> On Sat, Dec 17, 2022 at 05:48:51PM +0800, Baoquan He wrote:
> > On 12/15/22 at 12:23pm, Bjorn Helgaas wrote:
> > > From: Bjorn Helgaas <[email protected]>
> > >
> > > There are no arch-specific things in arch_kexec_kernel_image_load(), so
> > > remove it and just use the generic version.
> >
> > I ever posted below patch to do the same thing, Andrew only picked the
> > memory leak fixing patch.
> >
> > [PATCH v2 2/2] kexec_file: clean up arch_kexec_kernel_image_load
> > https://lore.kernel.org/all/[email protected]/T/#u
>
> Indeed! Sorry, I wasn't aware of your previous work. If you repost
> it, cc me and I'll be glad to help review it.
Sure, I will repost the patch for reviewing, thanks a lot.
>
> > > Bjorn Helgaas (2):
> > > x86/kexec: Remove unnecessary arch_kexec_kernel_image_load()
> > > kexec: Remove unnecessary arch_kexec_kernel_image_load()
> > >
> > > arch/x86/include/asm/kexec.h | 3 ---
> > > arch/x86/kernel/machine_kexec_64.c | 11 -----------
> > > include/linux/kexec.h | 8 --------
> > > kernel/kexec_file.c | 6 +++---
> > > 4 files changed, 3 insertions(+), 25 deletions(-)
>
On 12/15/22 at 12:23pm, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <[email protected]>
>
> There are no arch-specific things in arch_kexec_kernel_image_load(), so
> remove it and just use the generic version.
This patchset looks good to me, thx.
Acked-by: Baoquan He <[email protected]>
Since it cleans up the last arch specific version of
arch_kexec_kernel_image_load in x86, maybe this patchset can go into x86
branch?
Thanks
Baoquan
On 12/17/22 at 09:58am, Bjorn Helgaas wrote:
> On Sat, Dec 17, 2022 at 05:48:51PM +0800, Baoquan He wrote:
> > On 12/15/22 at 12:23pm, Bjorn Helgaas wrote:
> > > From: Bjorn Helgaas <[email protected]>
> > >
> > > There are no arch-specific things in arch_kexec_kernel_image_load(), so
> > > remove it and just use the generic version.
> >
> > I ever posted below patch to do the same thing, Andrew only picked the
> > memory leak fixing patch.
> >
> > [PATCH v2 2/2] kexec_file: clean up arch_kexec_kernel_image_load
> > https://lore.kernel.org/all/[email protected]/T/#u
>
> Indeed! Sorry, I wasn't aware of your previous work. If you repost
> it, cc me and I'll be glad to help review it.
When tried to rebase my old patch to the latest kernel, I realized this
patchset is what I can end up with. I would like to ack this patchset
to make it merged. Thanks a lot for the effort.
Hi Ingo, Boris,
On 12/21/22 at 02:05pm, Baoquan He wrote:
> On 12/15/22 at 12:23pm, Bjorn Helgaas wrote:
> > From: Bjorn Helgaas <[email protected]>
> >
> > There are no arch-specific things in arch_kexec_kernel_image_load(), so
> > remove it and just use the generic version.
>
> This patchset looks good to me, thx.
>
> Acked-by: Baoquan He <[email protected]>
>
> Since it cleans up the last arch specific version of
> arch_kexec_kernel_image_load in x86, maybe this patchset can go into x86
> branch?
Could you consider picking this patchset into x86 branch? This is a
clean up on kexec, while the last ARCH using it is x86.
Thanks
Baoquan
On 1/3/23 19:21, Baoquan He wrote:
>> Since it cleans up the last arch specific version of
>> arch_kexec_kernel_image_load in x86, maybe this patchset can go into x86
>> branch?
> Could you consider picking this patchset into x86 branch? This is a
> clean up on kexec, while the last ARCH using it is x86.
I'll stick it in my queue to take a closer look.
On 01/04/23 at 10:37am, Dave Hansen wrote:
> On 1/3/23 19:21, Baoquan He wrote:
> >> Since it cleans up the last arch specific version of
> >> arch_kexec_kernel_image_load in x86, maybe this patchset can go into x86
> >> branch?
> > Could you consider picking this patchset into x86 branch? This is a
> > clean up on kexec, while the last ARCH using it is x86.
>
> I'll stick it in my queue to take a closer look.
Thanks.