On Mon, May 29, 2023 at 10:07:08AM -0400, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <[email protected]>
>
> Some variants in this series of UART controllers have GPIO pins that
> are shared between GPIO and modem control lines.
>
> The pin mux mode (GPIO or modem control lines) can be set for each
> ports (channels) supported by the variant.
>
> This adds a property to the device tree to set the GPIO pin mux to
> modem control lines on selected ports if needed.
>
> Signed-off-by: Hugo Villeneuve <[email protected]>
> ---
> .../bindings/serial/nxp,sc16is7xx.txt | 46 +++++++++++++++++++
> 1 file changed, 46 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt
> index 0fa8e3e43bf8..74dfbbf7b2cb 100644
> --- a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt
> +++ b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt
> @@ -23,6 +23,9 @@ Optional properties:
> 1 = active low.
> - irda-mode-ports: An array that lists the indices of the port that
> should operate in IrDA mode.
> +- nxp,modem-control-line-ports: An array that lists the indices of the port that
> + should have shared GPIO lines configured as
> + modem control lines.
>
> Example:
> sc16is750: sc16is750@51 {
> @@ -35,6 +38,26 @@ Example:
> #gpio-cells = <2>;
> };
>
> + sc16is752: sc16is752@54 {
> + compatible = "nxp,sc16is752";
> + reg = <0x54>;
> + clocks = <&clk20m>;
> + interrupt-parent = <&gpio3>;
> + interrupts = <7 IRQ_TYPE_EDGE_FALLING>;
> + nxp,modem-control-line-ports = <1>; /* Port 1 as modem control lines */
> + gpio-controller; /* Port 0 as GPIOs */
> + #gpio-cells = <2>;
> + };
> +
> + sc16is752: sc16is752@54 {
> + compatible = "nxp,sc16is752";
> + reg = <0x54>;

If this were not a txt binding, dt_binding_check would likely complain
that you have two nodes with the same node address & 3 below.
If you end up re-submitting, could you change that please?
Otherwise,
Acked-by: Conor Dooley <[email protected]>

Thanks,
Conor.

Attachments:

(No filename) (2.15 kB)
signature.asc (235.00 B)
Download all attachments

2023-05-29 18:37:00

On Thu, Jun 1, 2023 at 2:57 AM Hugo Villeneuve <[email protected]> wrote:
> On Wed, 31 May 2023 00:56:57 +0300
> Andy Shevchenko <[email protected]> wrote:
> > On Tue, May 30, 2023 at 6:36 PM Hugo Villeneuve <[email protected]> wrote:
> > > On Tue, 30 May 2023 01:38:17 +0300
> > > [email protected] wrote:
> > > > Mon, May 29, 2023 at 10:07:09AM -0400, Hugo Villeneuve kirjoitti:

...

> > > > > + of_property_for_each_u32(dev->of_node, "nxp,modem-control-line-ports",
> > > > > + prop, p, u) {
> > > > > + if (u >= devtype->nr_uart)
> > > > > + continue;
> > > > > +
> > > > > + /* Use GPIO lines as modem control lines */
> > > > > + if (u == 0)
> > > > > + mctrl_mask |= SC16IS7XX_IOCONTROL_MODEM_A_BIT;
> > > > > + else if (u == 1)
> > > > > + mctrl_mask |= SC16IS7XX_IOCONTROL_MODEM_B_BIT;
> > > > > + }
> > > >
> > > > Can we use device properties, please?
> > >
> > > I have converted this section to use device_property_count_u32() and device_property_read_u32_array(). Is that Ok?
> >
> > Yes, thank you!
>
> Hi Andy,
> now that I am using the device property API, I think I no longer have the need to test for "if (dev->of_node)" before reading the new property "nxp,modem-control-line-ports"?
>
> If that is the case, I will leave the test "if (dev->of_node)" only for the "irda-mode-ports" property.
>
> The pseudo code woulk look like this:
>
> if (dev->of_node) {
> struct property *prop;
> const __be32 *p;
> u32 u;
>
> of_property_for_each_u32(dev->of_node, "irda-mode-ports",
> prop, p, u)
> if (u < devtype->nr_uart)
> s->p[u].irda_mode = true;
> }
>
> /* Read "nxp,modem-control-line-ports" using device property API. */
> sc16is7xx_setup_mctrl_ports(dev);

Looks good to me, thank you for following the advice!

--
With Best Regards,
Andy Shevchenko