2016-03-21 11:21:05

by Guenter Roeck

[permalink] [raw]
Subject: [PATCH] unicore32: mm: Add missing parameter to arch_vma_access_permitted

unicore32 fails to compile with the following errors.

mm/memory.c: In function ‘__handle_mm_fault’:
mm/memory.c:3381: error:
too many arguments to function ‘arch_vma_access_permitted’
mm/gup.c: In function ‘check_vma_flags’:
mm/gup.c:456: error:
too many arguments to function ‘arch_vma_access_permitted’
mm/gup.c: In function ‘vma_permits_fault’:
mm/gup.c:640: error:
too many arguments to function ‘arch_vma_access_permitted’

Fixes: d61172b4b695b ("mm/core, x86/mm/pkeys: Differentiate instruction fetches")
Cc: Dave Hansen <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Cc: Ingo Molnar <[email protected]>
Signed-off-by: Guenter Roeck <[email protected]>
---
arch/unicore32/include/asm/mmu_context.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/unicore32/include/asm/mmu_context.h b/arch/unicore32/include/asm/mmu_context.h
index e35632ef23c7..62dfc644c908 100644
--- a/arch/unicore32/include/asm/mmu_context.h
+++ b/arch/unicore32/include/asm/mmu_context.h
@@ -98,7 +98,7 @@ static inline void arch_bprm_mm_init(struct mm_struct *mm,
}

static inline bool arch_vma_access_permitted(struct vm_area_struct *vma,
- bool write, bool foreign)
+ bool write, bool execute, bool foreign)
{
/* by default, allow everything */
return true;
--
2.5.0


2016-03-23 20:25:33

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH] unicore32: mm: Add missing parameter to arch_vma_access_permitted

On Mon, Mar 21, 2016 at 07:47:29PM +0800, Xuetao Guan wrote:
> > unicore32 fails to compile with the following errors.
> >
> > mm/memory.c: In function 鈥榑_handle_mm_fault鈥&#65533;:
> > mm/memory.c:3381: error:
> > too many arguments to function 鈥榓rch_vma_access_permitted鈥&#65533;
> > mm/gup.c: In function 鈥榗heck_vma_flags鈥&#65533;:
> > mm/gup.c:456: error:
> > too many arguments to function 鈥榓rch_vma_access_permitted鈥&#65533;
> > mm/gup.c: In function 鈥榲ma_permits_fault鈥&#65533;:
> > mm/gup.c:640: error:
> > too many arguments to function 鈥榓rch_vma_access_permitted鈥&#65533;
> >
> > Fixes: d61172b4b695b ("mm/core, x86/mm/pkeys: Differentiate instruction
> > fetches")
> > Cc: Dave Hansen <[email protected]>
> > Cc: Thomas Gleixner <[email protected]>
> > Cc: Ingo Molnar <[email protected]>
> > Signed-off-by: Guenter Roeck <[email protected]>
>
> Thanks.
>
> Acked-by: Guan Xuetao <[email protected]>
>
Who is going to send the patch upstream ?

Guenter

> > ---
> > arch/unicore32/include/asm/mmu_context.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/unicore32/include/asm/mmu_context.h
> > b/arch/unicore32/include/asm/mmu_context.h
> > index e35632ef23c7..62dfc644c908 100644
> > --- a/arch/unicore32/include/asm/mmu_context.h
> > +++ b/arch/unicore32/include/asm/mmu_context.h
> > @@ -98,7 +98,7 @@ static inline void arch_bprm_mm_init(struct mm_struct
> > *mm,
> > }
> >
> > static inline bool arch_vma_access_permitted(struct vm_area_struct *vma,
> > - bool write, bool foreign)
> > + bool write, bool execute, bool foreign)
> > {
> > /* by default, allow everything */
> > return true;
> > --
> > 2.5.0
> >
>

2016-03-21 12:35:15

by Xuetao Guan

[permalink] [raw]
Subject: Re: [PATCH] unicore32: mm: Add missing parameter to arch_vma_access_permitted

> unicore32 fails to compile with the following errors.
>
> mm/memory.c: In function ‘__handle_mm_fault??&#65533;:
> mm/memory.c:3381: error:
> too many arguments to function ‘arch_vma_access_permitted??&#65533;
> mm/gup.c: In function ‘check_vma_flags??&#65533;:
> mm/gup.c:456: error:
> too many arguments to function ‘arch_vma_access_permitted??&#65533;
> mm/gup.c: In function ‘vma_permits_fault??&#65533;:
> mm/gup.c:640: error:
> too many arguments to function ‘arch_vma_access_permitted??&#65533;
>
> Fixes: d61172b4b695b ("mm/core, x86/mm/pkeys: Differentiate instruction
> fetches")
> Cc: Dave Hansen <[email protected]>
> Cc: Thomas Gleixner <[email protected]>
> Cc: Ingo Molnar <[email protected]>
> Signed-off-by: Guenter Roeck <[email protected]>

Thanks.

Acked-by: Guan Xuetao <[email protected]>

> ---
> arch/unicore32/include/asm/mmu_context.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/unicore32/include/asm/mmu_context.h
> b/arch/unicore32/include/asm/mmu_context.h
> index e35632ef23c7..62dfc644c908 100644
> --- a/arch/unicore32/include/asm/mmu_context.h
> +++ b/arch/unicore32/include/asm/mmu_context.h
> @@ -98,7 +98,7 @@ static inline void arch_bprm_mm_init(struct mm_struct
> *mm,
> }
>
> static inline bool arch_vma_access_permitted(struct vm_area_struct *vma,
> - bool write, bool foreign)
> + bool write, bool execute, bool foreign)
> {
> /* by default, allow everything */
> return true;
> --
> 2.5.0
>

2016-03-24 00:41:14

by Xuetao Guan

[permalink] [raw]
Subject: Re: [PATCH] unicore32: mm: Add missing parameter to arch_vma_access_permitted

> On Mon, Mar 21, 2016 at 07:47:29PM +0800, Xuetao Guan wrote:
>> > unicore32 fails to compile with the following errors.
>> >
>> > mm/memory.c: In function 鈥榑_handle_mm_fault??&#65533;&#65533;:
>> > mm/memory.c:3381: error:
>> > too many arguments to function
>> 鈥榓rch_vma_access_permitted??&#65533;&#65533;
>> > mm/gup.c: In function 鈥榗heck_vma_flags??&#65533;&#65533;:
>> > mm/gup.c:456: error:
>> > too many arguments to function
>> 鈥榓rch_vma_access_permitted??&#65533;&#65533;
>> > mm/gup.c: In function 鈥榲ma_permits_fault??&#65533;&#65533;:
>> > mm/gup.c:640: error:
>> > too many arguments to function
>> 鈥榓rch_vma_access_permitted??&#65533;&#65533;
>> >
>> > Fixes: d61172b4b695b ("mm/core, x86/mm/pkeys: Differentiate
>> instruction
>> > fetches")
>> > Cc: Dave Hansen <[email protected]>
>> > Cc: Thomas Gleixner <[email protected]>
>> > Cc: Ingo Molnar <[email protected]>
>> > Signed-off-by: Guenter Roeck <[email protected]>
>>
>> Thanks.
>>
>> Acked-by: Guan Xuetao <[email protected]>
>>
> Who is going to send the patch upstream ?
>
> Guenter

I will do. Thanks.

Xuetao

>
>> > ---
>> > arch/unicore32/include/asm/mmu_context.h | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/arch/unicore32/include/asm/mmu_context.h
>> > b/arch/unicore32/include/asm/mmu_context.h
>> > index e35632ef23c7..62dfc644c908 100644
>> > --- a/arch/unicore32/include/asm/mmu_context.h
>> > +++ b/arch/unicore32/include/asm/mmu_context.h
>> > @@ -98,7 +98,7 @@ static inline void arch_bprm_mm_init(struct
>> mm_struct
>> > *mm,
>> > }
>> >
>> > static inline bool arch_vma_access_permitted(struct vm_area_struct
>> *vma,
>> > - bool write, bool foreign)
>> > + bool write, bool execute, bool foreign)
>> > {
>> > /* by default, allow everything */
>> > return true;
>> > --
>> > 2.5.0
>> >
>>
>

2016-04-24 00:09:14

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH] unicore32: mm: Add missing parameter to arch_vma_access_permitted

ping ... still not upstream.

On 03/21/2016 04:20 AM, Guenter Roeck wrote:
> unicore32 fails to compile with the following errors.
>
> mm/memory.c: In function ‘__handle_mm_fault’:
> mm/memory.c:3381: error:
> too many arguments to function ‘arch_vma_access_permitted’
> mm/gup.c: In function ‘check_vma_flags’:
> mm/gup.c:456: error:
> too many arguments to function ‘arch_vma_access_permitted’
> mm/gup.c: In function ‘vma_permits_fault’:
> mm/gup.c:640: error:
> too many arguments to function ‘arch_vma_access_permitted’
>
> Fixes: d61172b4b695b ("mm/core, x86/mm/pkeys: Differentiate instruction fetches")
> Cc: Dave Hansen <[email protected]>
> Cc: Thomas Gleixner <[email protected]>
> Cc: Ingo Molnar <[email protected]>
> Signed-off-by: Guenter Roeck <[email protected]>
> ---
> arch/unicore32/include/asm/mmu_context.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/unicore32/include/asm/mmu_context.h b/arch/unicore32/include/asm/mmu_context.h
> index e35632ef23c7..62dfc644c908 100644
> --- a/arch/unicore32/include/asm/mmu_context.h
> +++ b/arch/unicore32/include/asm/mmu_context.h
> @@ -98,7 +98,7 @@ static inline void arch_bprm_mm_init(struct mm_struct *mm,
> }
>
> static inline bool arch_vma_access_permitted(struct vm_area_struct *vma,
> - bool write, bool foreign)
> + bool write, bool execute, bool foreign)
> {
> /* by default, allow everything */
> return true;
>

2016-04-24 12:47:21

by Xuetao Guan

[permalink] [raw]
Subject: Re: [PATCH] unicore32: mm: Add missing parameter to arch_vma_access_permitted

> ping ... still not upstream.
I'm sorry.
I'll do it in next week.

Xuetao

>
> On 03/21/2016 04:20 AM, Guenter Roeck wrote:
>> unicore32 fails to compile with the following errors.
>>
>> mm/memory.c: In function ‘__handle_mm_fault??&#65533;:
>> mm/memory.c:3381: error:
>> too many arguments to function ‘arch_vma_access_permitted??&#65533;
>> mm/gup.c: In function ‘check_vma_flags??&#65533;:
>> mm/gup.c:456: error:
>> too many arguments to function ‘arch_vma_access_permitted??&#65533;
>> mm/gup.c: In function ‘vma_permits_fault??&#65533;:
>> mm/gup.c:640: error:
>> too many arguments to function ‘arch_vma_access_permitted??&#65533;
>>
>> Fixes: d61172b4b695b ("mm/core, x86/mm/pkeys: Differentiate instruction
>> fetches")
>> Cc: Dave Hansen <[email protected]>
>> Cc: Thomas Gleixner <[email protected]>
>> Cc: Ingo Molnar <[email protected]>
>> Signed-off-by: Guenter Roeck <[email protected]>
>> ---
>> arch/unicore32/include/asm/mmu_context.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/unicore32/include/asm/mmu_context.h
>> b/arch/unicore32/include/asm/mmu_context.h
>> index e35632ef23c7..62dfc644c908 100644
>> --- a/arch/unicore32/include/asm/mmu_context.h
>> +++ b/arch/unicore32/include/asm/mmu_context.h
>> @@ -98,7 +98,7 @@ static inline void arch_bprm_mm_init(struct mm_struct
>> *mm,
>> }
>>
>> static inline bool arch_vma_access_permitted(struct vm_area_struct
>> *vma,
>> - bool write, bool foreign)
>> + bool write, bool execute, bool foreign)
>> {
>> /* by default, allow everything */
>> return true;
>>
>