[permalink] [raw]

Subject: [PATCH v3 04/28] drm/ast: switch to drm__get(), drm__put() helpers

2017-08-11 12:34:12

by Cihangir Akturk

[permalink] [raw]

Subject: [PATCH v3 07/28] drm/etnaviv: switch to drm__get(), drm__put() helpers

2017-08-11 12:34:22

by Cihangir Akturk

[permalink] [raw]

Subject: [PATCH v3 12/28] drm/imx: switch to drm__get(), drm__put() helpers

2017-08-11 12:34:29

by Cihangir Akturk

[permalink] [raw]

Subject: [PATCH v3 14/28] drm/mgag200: switch to drm__get(), drm__put() helpers

2017-08-11 12:34:46

by Cihangir Akturk

[permalink] [raw]

Subject: [PATCH v3 15/28] drm/msm: switch to drm__get(), drm__put() helpers

Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference()
and drm_*_unreference() helpers.

drm_*_reference() and drm_*_unreference() functions are just
compatibility alias for drm_*_get() and drm_*_put() and should not be
used by new code. So convert all users of compatibility functions to
use the new APIs.

Generated by: scripts/coccinelle/api/drm-get-put.cocci

Signed-off-by: Cihangir Akturk <[email protected]>
---
drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 10 +++++-----
drivers/gpu/drm/msm/adreno/a5xx_power.c | 2 +-
drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +-
drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c | 6 +++---
drivers/gpu/drm/msm/mdp/mdp4/mdp4_kms.c | 2 +-
drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c | 2 +-
drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c | 4 ++--
drivers/gpu/drm/msm/msm_drv.c | 8 ++++----
drivers/gpu/drm/msm/msm_fb.c | 4 ++--
drivers/gpu/drm/msm/msm_fbdev.c | 2 +-
drivers/gpu/drm/msm/msm_gem.c | 8 ++++----
drivers/gpu/drm/msm/msm_gem_submit.c | 4 ++--
drivers/gpu/drm/msm/msm_gpu.c | 4 ++--
drivers/gpu/drm/msm/msm_ringbuffer.c | 2 +-
14 files changed, 30 insertions(+), 30 deletions(-)

diff --git a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c
index b4b54f1..12d0f9c 100644
--- a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c
+++ b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c
@@ -303,7 +303,7 @@ static struct drm_gem_object *a5xx_ucode_load_bo(struct msm_gpu *gpu,

ptr = msm_gem_get_vaddr(bo);
if (!ptr) {
- drm_gem_object_unreference(bo);
+ drm_gem_object_put(bo);
return ERR_PTR(-ENOMEM);
}

@@ -311,7 +311,7 @@ static struct drm_gem_object *a5xx_ucode_load_bo(struct msm_gpu *gpu,
int ret = msm_gem_get_iova(bo, gpu->aspace, iova);

if (ret) {
- drm_gem_object_unreference(bo);
+ drm_gem_object_put(bo);
return ERR_PTR(ret);
}
}
@@ -697,19 +697,19 @@ static void a5xx_destroy(struct msm_gpu *gpu)
if (a5xx_gpu->pm4_bo) {
if (a5xx_gpu->pm4_iova)
msm_gem_put_iova(a5xx_gpu->pm4_bo, gpu->aspace);
- drm_gem_object_unreference_unlocked(a5xx_gpu->pm4_bo);
+ drm_gem_object_put_unlocked(a5xx_gpu->pm4_bo);
}

if (a5xx_gpu->pfp_bo) {
if (a5xx_gpu->pfp_iova)
msm_gem_put_iova(a5xx_gpu->pfp_bo, gpu->aspace);
- drm_gem_object_unreference_unlocked(a5xx_gpu->pfp_bo);
+ drm_gem_object_put_unlocked(a5xx_gpu->pfp_bo);
}

if (a5xx_gpu->gpmu_bo) {
if (a5xx_gpu->gpmu_iova)
msm_gem_put_iova(a5xx_gpu->gpmu_bo, gpu->aspace);
- drm_gem_object_unreference_unlocked(a5xx_gpu->gpmu_bo);
+ drm_gem_object_put_unlocked(a5xx_gpu->gpmu_bo);
}

adreno_gpu_cleanup(adreno_gpu);
diff --git a/drivers/gpu/drm/msm/adreno/a5xx_power.c b/drivers/gpu/drm/msm/adreno/a5xx_power.c
index 87af6ee..3333620 100644
--- a/drivers/gpu/drm/msm/adreno/a5xx_power.c
+++ b/drivers/gpu/drm/msm/adreno/a5xx_power.c
@@ -330,7 +330,7 @@ void a5xx_gpmu_ucode_init(struct msm_gpu *gpu)
if (a5xx_gpu->gpmu_iova)
msm_gem_put_iova(a5xx_gpu->gpmu_bo, gpu->aspace);
if (a5xx_gpu->gpmu_bo)
- drm_gem_object_unreference(a5xx_gpu->gpmu_bo);
+ drm_gem_object_put(a5xx_gpu->gpmu_bo);

a5xx_gpu->gpmu_bo = NULL;
a5xx_gpu->gpmu_iova = 0;
diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
index f1ab270..15de821 100644
--- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c
+++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
@@ -433,7 +433,7 @@ void adreno_gpu_cleanup(struct adreno_gpu *adreno_gpu)
if (adreno_gpu->memptrs_iova)
msm_gem_put_iova(adreno_gpu->memptrs_bo, gpu->aspace);

- drm_gem_object_unreference_unlocked(adreno_gpu->memptrs_bo);
+ drm_gem_object_put_unlocked(adreno_gpu->memptrs_bo);
}
release_firmware(adreno_gpu->pm4);
release_firmware(adreno_gpu->pfp);
diff --git a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c
index 47fa2ab..5d4aba1 100644
--- a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c
+++ b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_crtc.c
@@ -129,7 +129,7 @@ static void unref_cursor_worker(struct drm_flip_work *work, void *val)
struct msm_kms *kms = &mdp4_kms->base.base;

msm_gem_put_iova(val, kms->aspace);
- drm_gem_object_unreference_unlocked(val);
+ drm_gem_object_put_unlocked(val);
}

static void mdp4_crtc_destroy(struct drm_crtc *crtc)
@@ -375,7 +375,7 @@ static void update_cursor(struct drm_crtc *crtc)

if (next_bo) {
/* take a obj ref + iova ref when we start scanning out: */
- drm_gem_object_reference(next_bo);
+ drm_gem_object_get(next_bo);
msm_gem_get_iova(next_bo, kms->aspace, &iova);

/* enable cursor: */
@@ -460,7 +460,7 @@ static int mdp4_crtc_cursor_set(struct drm_crtc *crtc,
return 0;

fail:
- drm_gem_object_unreference_unlocked(cursor_bo);
+ drm_gem_object_put_unlocked(cursor_bo);
return ret;
}

diff --git a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_kms.c b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_kms.c
index f7f0874..4b646bf 100644
--- a/drivers/gpu/drm/msm/mdp/mdp4/mdp4_kms.c
+++ b/drivers/gpu/drm/msm/mdp/mdp4/mdp4_kms.c
@@ -164,7 +164,7 @@ static void mdp4_destroy(struct msm_kms *kms)

if (mdp4_kms->blank_cursor_iova)
msm_gem_put_iova(mdp4_kms->blank_cursor_bo, kms->aspace);
- drm_gem_object_unreference_unlocked(mdp4_kms->blank_cursor_bo);
+ drm_gem_object_put_unlocked(mdp4_kms->blank_cursor_bo);

if (aspace) {
aspace->mmu->funcs->detach(aspace->mmu,
diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c
index 5e3bc72..7aa4241 100644
--- a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c
+++ b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c
@@ -163,7 +163,7 @@ static void unref_cursor_worker(struct drm_flip_work *work, void *val)
struct msm_kms *kms = &mdp5_kms->base.base;

msm_gem_put_iova(val, kms->aspace);
- drm_gem_object_unreference_unlocked(val);
+ drm_gem_object_put_unlocked(val);
}

static void mdp5_crtc_destroy(struct drm_crtc *crtc)
diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c
index 818244a..cf4d63e 100644
--- a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c
+++ b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c
@@ -194,7 +194,7 @@ static void mdp5_plane_reset(struct drm_plane *plane)
struct mdp5_plane_state *mdp5_state;

if (plane->state && plane->state->fb)
- drm_framebuffer_unreference(plane->state->fb);
+ drm_framebuffer_put(plane->state->fb);

kfree(to_mdp5_plane_state(plane->state));
mdp5_state = kzalloc(sizeof(*mdp5_state), GFP_KERNEL);
@@ -237,7 +237,7 @@ static void mdp5_plane_destroy_state(struct drm_plane *plane,
struct mdp5_plane_state *pstate = to_mdp5_plane_state(state);

if (state->fb)
- drm_framebuffer_unreference(state->fb);
+ drm_framebuffer_put(state->fb);

kfree(pstate);
}
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
index f49f6ac..ba3c581 100644
--- a/drivers/gpu/drm/msm/msm_drv.c
+++ b/drivers/gpu/drm/msm/msm_drv.c
@@ -664,7 +664,7 @@ static int msm_ioctl_gem_cpu_prep(struct drm_device *dev, void *data,

ret = msm_gem_cpu_prep(obj, args->op, &timeout);

- drm_gem_object_unreference_unlocked(obj);
+ drm_gem_object_put_unlocked(obj);

return ret;
}
@@ -682,7 +682,7 @@ static int msm_ioctl_gem_cpu_fini(struct drm_device *dev, void *data,

ret = msm_gem_cpu_fini(obj);

- drm_gem_object_unreference_unlocked(obj);
+ drm_gem_object_put_unlocked(obj);

return ret;
}
@@ -722,7 +722,7 @@ static int msm_ioctl_gem_info(struct drm_device *dev, void *data,
args->offset = msm_gem_mmap_offset(obj);
}

- drm_gem_object_unreference_unlocked(obj);
+ drm_gem_object_put_unlocked(obj);

return ret;
}
@@ -776,7 +776,7 @@ static int msm_ioctl_gem_madvise(struct drm_device *dev, void *data,
ret = 0;
}

- drm_gem_object_unreference(obj);
+ drm_gem_object_put(obj);

unlock:
mutex_unlock(&dev->struct_mutex);
diff --git a/drivers/gpu/drm/msm/msm_fb.c b/drivers/gpu/drm/msm/msm_fb.c
index 6ecb7b1..0a2b4bb 100644
--- a/drivers/gpu/drm/msm/msm_fb.c
+++ b/drivers/gpu/drm/msm/msm_fb.c
@@ -50,7 +50,7 @@ static void msm_framebuffer_destroy(struct drm_framebuffer *fb)
for (i = 0; i < n; i++) {
struct drm_gem_object *bo = msm_fb->planes[i];

- drm_gem_object_unreference_unlocked(bo);
+ drm_gem_object_put_unlocked(bo);
}

kfree(msm_fb);
@@ -157,7 +157,7 @@ struct drm_framebuffer *msm_framebuffer_create(struct drm_device *dev,

out_unref:
for (i = 0; i < n; i++)
- drm_gem_object_unreference_unlocked(bos[i]);
+ drm_gem_object_put_unlocked(bos[i]);
return ERR_PTR(ret);
}

diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c
index 9c00fed..d959064 100644
--- a/drivers/gpu/drm/msm/msm_fbdev.c
+++ b/drivers/gpu/drm/msm/msm_fbdev.c
@@ -112,7 +112,7 @@ static int msm_fbdev_create(struct drm_fb_helper *helper,
/* note: if fb creation failed, we can't rely on fb destroy
* to unref the bo:
*/
- drm_gem_object_unreference_unlocked(fbdev->bo);
+ drm_gem_object_put_unlocked(fbdev->bo);
ret = PTR_ERR(fb);
goto fail;
}
diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c
index 65f3554..98dbf22 100644
--- a/drivers/gpu/drm/msm/msm_gem.c
+++ b/drivers/gpu/drm/msm/msm_gem.c
@@ -462,7 +462,7 @@ int msm_gem_dumb_map_offset(struct drm_file *file, struct drm_device *dev,

*offset = msm_gem_mmap_offset(obj);

- drm_gem_object_unreference_unlocked(obj);
+ drm_gem_object_put_unlocked(obj);

fail:
return ret;
@@ -839,7 +839,7 @@ int msm_gem_new_handle(struct drm_device *dev, struct drm_file *file,
ret = drm_gem_handle_create(file, obj, handle);

/* drop reference from allocate - handle holds it now */
- drm_gem_object_unreference_unlocked(obj);
+ drm_gem_object_put_unlocked(obj);

return ret;
}
@@ -955,7 +955,7 @@ static struct drm_gem_object *_msm_gem_new(struct drm_device *dev,
return obj;

fail:
- drm_gem_object_unreference_unlocked(obj);
+ drm_gem_object_put_unlocked(obj);
return ERR_PTR(ret);
}

@@ -1015,6 +1015,6 @@ struct drm_gem_object *msm_gem_import(struct drm_device *dev,
return obj;

fail:
- drm_gem_object_unreference_unlocked(obj);
+ drm_gem_object_put_unlocked(obj);
return ERR_PTR(ret);
}
diff --git a/drivers/gpu/drm/msm/msm_gem_submit.c b/drivers/gpu/drm/msm/msm_gem_submit.c
index 6bfca74..59982cf 100644
--- a/drivers/gpu/drm/msm/msm_gem_submit.c
+++ b/drivers/gpu/drm/msm/msm_gem_submit.c
@@ -139,7 +139,7 @@ static int submit_lookup_objects(struct msm_gem_submit *submit,
goto out_unlock;
}

- drm_gem_object_reference(obj);
+ drm_gem_object_get(obj);

submit->bos[i].obj = msm_obj;

@@ -375,7 +375,7 @@ static void submit_cleanup(struct msm_gem_submit *submit)
struct msm_gem_object *msm_obj = submit->bos[i].obj;
submit_unlock_unpin_bo(submit, i);
list_del_init(&msm_obj->submit_entry);
- drm_gem_object_unreference(&msm_obj->base);
+ drm_gem_object_put(&msm_obj->base);
}

ww_acquire_fini(&submit->ticket);
diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c
index 9f3dbc2..0d7c58b 100644
--- a/drivers/gpu/drm/msm/msm_gpu.c
+++ b/drivers/gpu/drm/msm/msm_gpu.c
@@ -417,7 +417,7 @@ static void retire_submit(struct msm_gpu *gpu, struct msm_gem_submit *submit)
/* move to inactive: */
msm_gem_move_to_inactive(&msm_obj->base);
msm_gem_put_iova(&msm_obj->base, gpu->aspace);
- drm_gem_object_unreference(&msm_obj->base);
+ drm_gem_object_put(&msm_obj->base);
}

pm_runtime_mark_last_busy(&gpu->pdev->dev);
@@ -496,7 +496,7 @@ void msm_gpu_submit(struct msm_gpu *gpu, struct msm_gem_submit *submit,
WARN_ON(is_active(msm_obj) && (msm_obj->gpu != gpu));

/* submit takes a reference to the bo and iova until retired: */
- drm_gem_object_reference(&msm_obj->base);
+ drm_gem_object_get(&msm_obj->base);
msm_gem_get_iova(&msm_obj->base,
submit->gpu->aspace, &iova);

diff --git a/drivers/gpu/drm/msm/msm_ringbuffer.c b/drivers/gpu/drm/msm/msm_ringbuffer.c
index 791bca3..2ba978b 100644
--- a/drivers/gpu/drm/msm/msm_ringbuffer.c
+++ b/drivers/gpu/drm/msm/msm_ringbuffer.c
@@ -62,7 +62,7 @@ void msm_ringbuffer_destroy(struct msm_ringbuffer *ring)
{
if (ring->bo) {
msm_gem_put_vaddr(ring->bo);
- drm_gem_object_unreference_unlocked(ring->bo);
+ drm_gem_object_put_unlocked(ring->bo);
}
kfree(ring);
}
--
2.7.4

2017-08-11 12:34:51

by Cihangir Akturk

[permalink] [raw]

Subject: [PATCH v3 17/28] drm/omapdrm: switch to drm__get(), drm__put() helpers

2017-08-11 12:34:57

by Cihangir Akturk

[permalink] [raw]

Subject: [PATCH v3 19/28] drm/radeon: switch to drm__get(), drm__put() helpers

On Fri, Aug 11, 2017 at 12:11 PM, Hans de Goede <[email protected]> wrote:
> Hi,
>
> On 11-08-17 18:04, Sean Paul wrote:
>>
>> On Fri, Aug 11, 2017 at 03:26:45PM +0200, Hans de Goede wrote:
>>>
>>> Hi,
>>>
>>> On 11-08-17 14:33, Cihangir Akturk wrote:
>>>>
>>>> Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference()
>>>> and drm_*_unreference() helpers.
>>>>
>>>> drm_*_reference() and drm_*_unreference() functions are just
>>>> compatibility alias for drm_*_get() and drm_*_put() and should not be
>>>> used by new code. So convert all users of compatibility functions to
>>>> use the new APIs.
>>>>
>>>> Generated by: scripts/coccinelle/api/drm-get-put.cocci
>>>>
>>>> Signed-off-by: Cihangir Akturk <[email protected]>
>>>
>>>
>>> Thank you for doing this, looks good to me:
>>>
>>> Reviewed-by: Hans de Goede <[email protected]>
>>>
>>
>> Applied to drm-misc-next, thank you for the review!
>
>
> Erm vboxvideo is in staging, does this mean all patches for
> it will now go through drm-misc-next despite it being in
> staging (*) ? Because if some patches get merged through
> drm-misc-next and some through Greg's staging repo that
> is not going to end well.
>

Hi Hans,
Thanks for pointing this out. I picked it up as I was vacuuming up the
rest of the set that was not yet applied, not realizing the staging
implications. It's not my intention to start taking vboxvideo through
-misc.

Hopefully this won't cause any nasty conflicts with Greg's staging
tree, and we can treat it as a one-off. If it does cause problems, I
can revert it in -misc in favor of taking it through staging.

Sean

> Regards,
>
> Hans
>
>
>
> *) that is fine, the same is done for e.g. the media drivers afaik
>
>
>
>>
>> Sean
>>
>>> Regards,
>>>
>>> Hans
>>>
>>>
>>>
>>>> ---
>>>> drivers/staging/vboxvideo/vbox_fb.c | 2 +-
>>>> drivers/staging/vboxvideo/vbox_main.c | 8 ++++----
>>>> drivers/staging/vboxvideo/vbox_mode.c | 2 +-
>>>> 3 files changed, 6 insertions(+), 6 deletions(-)
>>>>
>>>> diff --git a/drivers/staging/vboxvideo/vbox_fb.c
>>>> b/drivers/staging/vboxvideo/vbox_fb.c
>>>> index bf66358..c157284 100644
>>>> --- a/drivers/staging/vboxvideo/vbox_fb.c
>>>> +++ b/drivers/staging/vboxvideo/vbox_fb.c
>>>> @@ -343,7 +343,7 @@ void vbox_fbdev_fini(struct drm_device *dev)
>>>> vbox_bo_unpin(bo);
>>>> vbox_bo_unreserve(bo);
>>>> }
>>>> - drm_gem_object_unreference_unlocked(afb->obj);
>>>> + drm_gem_object_put_unlocked(afb->obj);
>>>> afb->obj = NULL;
>>>> }
>>>> drm_fb_helper_fini(&fbdev->helper);
>>>> diff --git a/drivers/staging/vboxvideo/vbox_main.c
>>>> b/drivers/staging/vboxvideo/vbox_main.c
>>>> index d0c6ec7..80bd039 100644
>>>> --- a/drivers/staging/vboxvideo/vbox_main.c
>>>> +++ b/drivers/staging/vboxvideo/vbox_main.c
>>>> @@ -40,7 +40,7 @@ static void vbox_user_framebuffer_destroy(struct
>>>> drm_framebuffer *fb)
>>>> struct vbox_framebuffer *vbox_fb = to_vbox_framebuffer(fb);
>>>> if (vbox_fb->obj)
>>>> - drm_gem_object_unreference_unlocked(vbox_fb->obj);
>>>> + drm_gem_object_put_unlocked(vbox_fb->obj);
>>>> drm_framebuffer_cleanup(fb);
>>>> kfree(fb);
>>>> @@ -198,7 +198,7 @@ static struct drm_framebuffer
>>>> *vbox_user_framebuffer_create(
>>>> err_free_vbox_fb:
>>>> kfree(vbox_fb);
>>>> err_unref_obj:
>>>> - drm_gem_object_unreference_unlocked(obj);
>>>> + drm_gem_object_put_unlocked(obj);
>>>> return ERR_PTR(ret);
>>>> }
>>>> @@ -472,7 +472,7 @@ int vbox_dumb_create(struct drm_file *file,
>>>> return ret;
>>>> ret = drm_gem_handle_create(file, gobj, &handle);
>>>> - drm_gem_object_unreference_unlocked(gobj);
>>>> + drm_gem_object_put_unlocked(gobj);
>>>> if (ret)
>>>> return ret;
>>>> @@ -525,7 +525,7 @@ vbox_dumb_mmap_offset(struct drm_file *file,
>>>> bo = gem_to_vbox_bo(obj);
>>>> *offset = vbox_bo_mmap_offset(bo);
>>>> - drm_gem_object_unreference(obj);
>>>> + drm_gem_object_put(obj);
>>>> ret = 0;
>>>> out_unlock:
>>>> diff --git a/drivers/staging/vboxvideo/vbox_mode.c
>>>> b/drivers/staging/vboxvideo/vbox_mode.c
>>>> index 996da1c..e5b6383 100644
>>>> --- a/drivers/staging/vboxvideo/vbox_mode.c
>>>> +++ b/drivers/staging/vboxvideo/vbox_mode.c
>>>> @@ -812,7 +812,7 @@ static int vbox_cursor_set2(struct drm_crtc *crtc,
>>>> struct drm_file *file_priv,
>>>> out_unreserve_bo:
>>>> vbox_bo_unreserve(bo);
>>>> out_unref_obj:
>>>> - drm_gem_object_unreference_unlocked(obj);
>>>> + drm_gem_object_put_unlocked(obj);
>>>> return ret;
>>>> }
>>>>
>>> _______________________________________________
>>> dri-devel mailing list
>>> [email protected]
>>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>>
>>
>

2017-08-13 13:30:26

by Cihangir Akturk

[permalink] [raw]

Cihangir Akturk <[email protected]> writes:

> Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference()
> and drm_*_unreference() helpers.
>
> drm_*_reference() and drm_*_unreference() functions are just
> compatibility alias for drm_*_get() and drm_*_put() and should not be
> used by new code. So convert all users of compatibility functions to
> use the new APIs.

Mind if I change the subject line to "drm/vc4: Continue the switch to
drm_*_put() helpers"? to distinguish from the patch that already landed?

(Looks like your previous patch was generated before my BO labeling code
landed, so we got another little patch here cleaning up the new code as
well)

Attachments:

signature.asc (832.00 B)

2017-08-14 20:07:53

by Cihangir Akturk

[permalink] [raw]

Subject: Re: [PATCH v3 24/28] drm/vc4: switch to drm__get(), drm__put() helpers

On Mon, Aug 14, 2017 at 12:47:01PM -0700, Eric Anholt wrote:
> Cihangir Akturk <[email protected]> writes:
>
> > Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference()
> > and drm_*_unreference() helpers.
> >
> > drm_*_reference() and drm_*_unreference() functions are just
> > compatibility alias for drm_*_get() and drm_*_put() and should not be
> > used by new code. So convert all users of compatibility functions to
> > use the new APIs.
>
> Mind if I change the subject line to "drm/vc4: Continue the switch to
> drm_*_put() helpers"? to distinguish from the patch that already landed?

It's OK with me. Go ahead, change to whatever you want.

>
> (Looks like your previous patch was generated before my BO labeling code
> landed, so we got another little patch here cleaning up the new code as
> well)

Thanks, Cihangir.

2017-08-14 21:17:44

On Fri, Aug 11, 2017 at 03:33:07PM +0300, Cihangir Akturk wrote:
> Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference()
> and drm_*_unreference() helpers.
>
> drm_*_reference() and drm_*_unreference() functions are just
> compatibility alias for drm_*_get() and drm_*_put() and should not be
> used by new code. So convert all users of compatibility functions to
> use the new APIs.
>
> Generated by: scripts/coccinelle/api/drm-get-put.cocci
>
> Signed-off-by: Cihangir Akturk <[email protected]>
> ---
> drivers/gpu/drm/tegra/drm.c | 12 ++++++------
> drivers/gpu/drm/tegra/fb.c | 8 ++++----
> drivers/gpu/drm/tegra/gem.c | 10 +++++-----
> 3 files changed, 15 insertions(+), 15 deletions(-)

Applied, thanks.

Thierry

Attachments:

(No filename) (744.00 B)
signature.asc (833.00 B)
Download all attachments

Subject: [PATCH v3 00/28] DRM API Conversions

Subject: [PATCH v3 01/28] drm/amdgpu: switch to drm_*_get(), drm_*_put() helpers

Subject: [PATCH v3 03/28] drm/armada: switch to drm_*_get(), drm_*_put() helpers

Subject: [PATCH v3 05/28] drm/bochs: switch to drm_*_get(), drm_*_put() helpers

Subject: [PATCH v3 04/28] drm/ast: switch to drm_*_get(), drm_*_put() helpers

Subject: [PATCH v3 07/28] drm/etnaviv: switch to drm_*_get(), drm_*_put() helpers

Subject: [PATCH v3 12/28] drm/imx: switch to drm_*_get(), drm_*_put() helpers

Subject: [PATCH v3 14/28] drm/mgag200: switch to drm_*_get(), drm_*_put() helpers

Subject: [PATCH v3 15/28] drm/msm: switch to drm_*_get(), drm_*_put() helpers

Subject: [PATCH v3 17/28] drm/omapdrm: switch to drm_*_get(), drm_*_put() helpers

Subject: [PATCH v3 19/28] drm/radeon: switch to drm_*_get(), drm_*_put() helpers

Subject: [PATCH v3 20/28] drm/rockchip: switch to drm_*_get(), drm_*_put() helpers

Subject: [PATCH v3 25/28] drm/vgem: switch to drm_*_get(), drm_*_put() helpers

Subject: [PATCH v3 27/28] drm/vmwgfx: switch to drm_*_get(), drm_*_put() helpers

Subject: [PATCH v3 28/28] drm: vboxvideo: switch to drm_*_get(), drm_*_put() helpers

Subject: [PATCH v3 24/28] drm/vc4: switch to drm_*_get(), drm_*_put() helpers

Subject: [PATCH v3 26/28] drm/virtio: switch to drm_*_get(), drm_*_put() helpers

Subject: [PATCH v3 23/28] drm/udl: switch to drm_*_get(), drm_*_put() helpers

Subject: [PATCH v3 21/28] drm/tegra: switch to drm_*_get(), drm_*_put() helpers

Subject: [PATCH v3 22/28] drm/tilcdc: switch to drm_*_get(), drm_*_put() helpers

Subject: [PATCH v3 18/28] drm/qxl: switch to drm_*_get(), drm_*_put() helpers

Subject: [PATCH v3 16/28] drm/nouveau: switch to drm_*_get(), drm_*_put() helpers

Subject: [PATCH v3 10/28] drm/hisilicon: switch to drm_*_get(), drm_*_put() helpers

Subject: [PATCH v3 13/28] drm/mediatek: switch to drm_*_get(), drm_*_put() helpers

Subject: [PATCH v3 11/28] drm/i915: switch to drm_*_get(), drm_*_put() helpers

Subject: [PATCH v3 08/28] drm/exynos: switch to drm_*_get(), drm_*_put() helpers

Subject: [PATCH v3 09/28] drm/gma500: switch to drm_*_get(), drm_*_put() helpers

Subject: [PATCH v3 06/28] drm/cirrus: switch to drm_*_get(), drm_*_put() helpers

Subject: [PATCH v3 02/28] drm: mali-dp: switch to drm_*_get(), drm_*_put() helpers

Subject: Re: [PATCH v3 12/28] drm/imx: switch to drm_*_get(), drm_*_put() helpers

Subject: Re: [PATCH v3 13/28] drm/mediatek: switch to drm_*_get(), drm_*_put() helpers

Subject: Re: [PATCH v3 28/28] drm: vboxvideo: switch to drm_*_get(), drm_*_put() helpers

Subject: RE: [PATCH v3 00/28] DRM API Conversions

Subject: Re: [PATCH v3 07/28] drm/etnaviv: switch to drm_*_get(), drm_*_put() helpers

Subject: Re: [PATCH v3 07/28] drm/etnaviv: switch to drm_*_get(), drm_*_put() helpers

Subject: Re: [PATCH v3 00/28] DRM API Conversions

Subject: Re: [PATCH v3 04/28] drm/ast: switch to drm_*_get(), drm_*_put() helpers

Subject: Re: [PATCH v3 06/28] drm/cirrus: switch to drm_*_get(), drm_*_put() helpers

Subject: Re: [PATCH v3 10/28] drm/hisilicon: switch to drm_*_get(), drm_*_put() helpers

Subject: Re: [PATCH v3 14/28] drm/mgag200: switch to drm_*_get(), drm_*_put() helpers

Subject: Re: [PATCH v3 20/28] drm/rockchip: switch to drm_*_get(), drm_*_put() helpers

Subject: Re: [PATCH v3 23/28] drm/udl: switch to drm_*_get(), drm_*_put() helpers

Subject: Re: [PATCH v3 25/28] drm/vgem: switch to drm_*_get(), drm_*_put() helpers

Subject: Re: [PATCH v3 13/28] drm/mediatek: switch to drm_*_get(), drm_*_put() helpers

Subject: Re: [PATCH v3 28/28] drm: vboxvideo: switch to drm_*_get(), drm_*_put() helpers

Subject: Re: [PATCH v3 28/28] drm: vboxvideo: switch to drm_*_get(), drm_*_put() helpers

Subject: Re: [PATCH v3 11/28] drm/i915: switch to drm_*_get(), drm_*_put() helpers

Subject: Re: [PATCH v3 28/28] drm: vboxvideo: switch to drm_*_get(), drm_*_put() helpers

Subject: [PATCH] drm/i915: switch to drm_*_get(), drm_*_put() helpers

Subject: Re: [PATCH v3 28/28] drm: vboxvideo: switch to drm_*_get(), drm_*_put() helpers

Subject: Re: [PATCH v3 28/28] drm: vboxvideo: switch to drm_*_get(), drm_*_put() helpers

Subject: Re: [PATCH v3 24/28] drm/vc4: switch to drm_*_get(), drm_*_put() helpers

Attachments:

Subject: Re: [PATCH v3 24/28] drm/vc4: switch to drm_*_get(), drm_*_put() helpers

Subject: Re: [PATCH v3 24/28] drm/vc4: switch to drm_*_get(), drm_*_put() helpers

Attachments:

Subject: Re: [PATCH v3 03/28] drm/armada: switch to drm_*_get(), drm_*_put() helpers

Subject: Re: [PATCH v3 21/28] drm/tegra: switch to drm_*_get(), drm_*_put() helpers

Attachments:

Subject: [PATCH v3 01/28] drm/amdgpu: switch to drm__get(), drm__put() helpers

Subject: [PATCH v3 03/28] drm/armada: switch to drm__get(), drm__put() helpers

Subject: [PATCH v3 05/28] drm/bochs: switch to drm__get(), drm__put() helpers

Subject: [PATCH v3 04/28] drm/ast: switch to drm__get(), drm__put() helpers

Subject: [PATCH v3 07/28] drm/etnaviv: switch to drm__get(), drm__put() helpers

Subject: [PATCH v3 12/28] drm/imx: switch to drm__get(), drm__put() helpers

Subject: [PATCH v3 14/28] drm/mgag200: switch to drm__get(), drm__put() helpers

Subject: [PATCH v3 15/28] drm/msm: switch to drm__get(), drm__put() helpers

Subject: [PATCH v3 17/28] drm/omapdrm: switch to drm__get(), drm__put() helpers

Subject: [PATCH v3 19/28] drm/radeon: switch to drm__get(), drm__put() helpers

Subject: [PATCH v3 20/28] drm/rockchip: switch to drm__get(), drm__put() helpers

Subject: [PATCH v3 25/28] drm/vgem: switch to drm__get(), drm__put() helpers

Subject: [PATCH v3 27/28] drm/vmwgfx: switch to drm__get(), drm__put() helpers

Subject: [PATCH v3 28/28] drm: vboxvideo: switch to drm__get(), drm__put() helpers

Subject: [PATCH v3 24/28] drm/vc4: switch to drm__get(), drm__put() helpers

Subject: [PATCH v3 26/28] drm/virtio: switch to drm__get(), drm__put() helpers

Subject: [PATCH v3 23/28] drm/udl: switch to drm__get(), drm__put() helpers

Subject: [PATCH v3 21/28] drm/tegra: switch to drm__get(), drm__put() helpers

Subject: [PATCH v3 22/28] drm/tilcdc: switch to drm__get(), drm__put() helpers

Subject: [PATCH v3 18/28] drm/qxl: switch to drm__get(), drm__put() helpers

Subject: [PATCH v3 16/28] drm/nouveau: switch to drm__get(), drm__put() helpers

Subject: [PATCH v3 10/28] drm/hisilicon: switch to drm__get(), drm__put() helpers

Subject: [PATCH v3 13/28] drm/mediatek: switch to drm__get(), drm__put() helpers

Subject: [PATCH v3 11/28] drm/i915: switch to drm__get(), drm__put() helpers

Subject: [PATCH v3 08/28] drm/exynos: switch to drm__get(), drm__put() helpers

Subject: [PATCH v3 09/28] drm/gma500: switch to drm__get(), drm__put() helpers

Subject: [PATCH v3 06/28] drm/cirrus: switch to drm__get(), drm__put() helpers

Subject: [PATCH v3 02/28] drm: mali-dp: switch to drm__get(), drm__put() helpers

Subject: Re: [PATCH v3 12/28] drm/imx: switch to drm__get(), drm__put() helpers

Subject: Re: [PATCH v3 13/28] drm/mediatek: switch to drm__get(), drm__put() helpers

Subject: Re: [PATCH v3 28/28] drm: vboxvideo: switch to drm__get(), drm__put() helpers

Subject: Re: [PATCH v3 07/28] drm/etnaviv: switch to drm__get(), drm__put() helpers

Subject: Re: [PATCH v3 07/28] drm/etnaviv: switch to drm__get(), drm__put() helpers

Subject: Re: [PATCH v3 04/28] drm/ast: switch to drm__get(), drm__put() helpers

Subject: Re: [PATCH v3 06/28] drm/cirrus: switch to drm__get(), drm__put() helpers

Subject: Re: [PATCH v3 10/28] drm/hisilicon: switch to drm__get(), drm__put() helpers

Subject: Re: [PATCH v3 14/28] drm/mgag200: switch to drm__get(), drm__put() helpers

Subject: Re: [PATCH v3 20/28] drm/rockchip: switch to drm__get(), drm__put() helpers

Subject: Re: [PATCH v3 23/28] drm/udl: switch to drm__get(), drm__put() helpers

Subject: Re: [PATCH v3 25/28] drm/vgem: switch to drm__get(), drm__put() helpers

Subject: Re: [PATCH v3 13/28] drm/mediatek: switch to drm__get(), drm__put() helpers

Subject: Re: [PATCH v3 28/28] drm: vboxvideo: switch to drm__get(), drm__put() helpers

Subject: Re: [PATCH v3 28/28] drm: vboxvideo: switch to drm__get(), drm__put() helpers

Subject: Re: [PATCH v3 11/28] drm/i915: switch to drm__get(), drm__put() helpers

Subject: Re: [PATCH v3 28/28] drm: vboxvideo: switch to drm__get(), drm__put() helpers

Subject: [PATCH] drm/i915: switch to drm__get(), drm__put() helpers

Subject: Re: [PATCH v3 28/28] drm: vboxvideo: switch to drm__get(), drm__put() helpers

Subject: Re: [PATCH v3 28/28] drm: vboxvideo: switch to drm__get(), drm__put() helpers

Subject: Re: [PATCH v3 24/28] drm/vc4: switch to drm__get(), drm__put() helpers

Subject: Re: [PATCH v3 24/28] drm/vc4: switch to drm__get(), drm__put() helpers

Subject: Re: [PATCH v3 24/28] drm/vc4: switch to drm__get(), drm__put() helpers

Subject: Re: [PATCH v3 03/28] drm/armada: switch to drm__get(), drm__put() helpers

Subject: Re: [PATCH v3 21/28] drm/tegra: switch to drm__get(), drm__put() helpers