by Andrew Halaney

[permalink] [raw]

Subject: Re: [PATCH 11/13] scsi: ufs: qcom: Remove unused ufs_qcom_hosts struct array

On Thu, Dec 07, 2023 at 11:01:59AM +0530, Manivannan Sadhasivam wrote:
> On Wed, Dec 06, 2023 at 12:54:43PM -0600, Andrew Halaney wrote:
> > On Fri, Dec 01, 2023 at 08:44:15PM +0530, Manivannan Sadhasivam wrote:
> > > ufs_qcom_hosts array is assigned, but not used anywhere. So let's remove
> > > it.
> > >
> > > Signed-off-by: Manivannan Sadhasivam <[email protected]>
> > > ---
> > > drivers/ufs/host/ufs-qcom.c | 5 -----
> > > 1 file changed, 5 deletions(-)
> > >
> > > diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
> > > index a86f6620abc8..824c006be093 100644
> > > --- a/drivers/ufs/host/ufs-qcom.c
> > > +++ b/drivers/ufs/host/ufs-qcom.c
> > > @@ -90,8 +90,6 @@ static const struct __ufs_qcom_bw_table {
> > > [MODE_MAX][0][0] = { 7643136, 307200 },
> > > };
> > >
> > > -static struct ufs_qcom_host *ufs_qcom_hosts[MAX_UFS_QCOM_HOSTS];
> > > -
> >
> > I think we can get rid of MAX_UFS_QCOM_HOSTS as well with this change in
> > place?
> >
>
> Yes, thanks for spotting.

With that in place please add:

Reviewed-by: Andrew Halaney <[email protected]>

>
> - Mani
>
> > > static void ufs_qcom_get_default_testbus_cfg(struct ufs_qcom_host *host);
> > > static int ufs_qcom_set_core_clk_ctrl(struct ufs_hba *hba, bool is_scale_up);
> > >
> > > @@ -1192,9 +1190,6 @@ static int ufs_qcom_init(struct ufs_hba *hba)
> > >
> > > ufs_qcom_setup_clocks(hba, true, POST_CHANGE);
> > >
> > > - if (hba->dev->id < MAX_UFS_QCOM_HOSTS)
> > > - ufs_qcom_hosts[hba->dev->id] = host;
> > > -
> > > ufs_qcom_get_default_testbus_cfg(host);
> > > err = ufs_qcom_testbus_config(host);
> > > if (err)
> > > --
> > > 2.25.1
> > >
> > >
> >
> >
>
> --
> மணிவண்ணன் சதாசிவம்
>

2023-12-07 13:51:36

by Andrew Halaney

[permalink] [raw]

Subject: Re: [PATCH 05/13] scsi: ufs: qcom: Remove the warning message when core_reset is not available

On Thu, Dec 07, 2023 at 10:48:35AM +0530, Manivannan Sadhasivam wrote:
> On Wed, Dec 06, 2023 at 12:36:41PM -0600, Andrew Halaney wrote:
> > On Fri, Dec 01, 2023 at 08:44:09PM +0530, Manivannan Sadhasivam wrote:
> > > core_reset is optional, so there is no need to warn the user if it is not
> > > available (that too not while doing host reset each time).
> >
> > What's the bit in the parenthesis mean here? I'm having a hard time
> > following. Otherwise, this looks good to me.
> >
>
> I was just mentioning that the core reset can happen multiple times depending on
> the scenario, so it doesn't make sense to print a warning each time if the reset
> was not available.

Ahh gotcha, maybe be a little more verbose in that part on the next
spin? As is I'm struggling to get that from the commit message's text.

Reviewed-by: Andrew Halaney <[email protected]>

>
> - Mani
>
> > >
> > > Signed-off-by: Manivannan Sadhasivam <[email protected]>
> > > ---
> > > drivers/ufs/host/ufs-qcom.c | 4 +---
> > > 1 file changed, 1 insertion(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
> > > index dc93b1c5ca74..d474de0739e4 100644
> > > --- a/drivers/ufs/host/ufs-qcom.c
> > > +++ b/drivers/ufs/host/ufs-qcom.c
> > > @@ -296,10 +296,8 @@ static int ufs_qcom_host_reset(struct ufs_hba *hba)
> > > struct ufs_qcom_host *host = ufshcd_get_variant(hba);
> > > bool reenable_intr;
> > >
> > > - if (!host->core_reset) {
> > > - dev_warn(hba->dev, "%s: reset control not set\n", __func__);
> > > + if (!host->core_reset)
> > > return 0;
> > > - }
> > >
> > > reenable_intr = hba->is_irq_enabled;
> > > disable_irq(hba->irq);
> > > --
> > > 2.25.1
> > >
> > >
> >
>
> --
> மணிவண்ணன் சதாசிவம்
>