by Daniele Ceraolo Spurio

[permalink] [raw]

Subject: Re: [Intel-gfx] [PATCH v8 14/16] mei: debugfs: add pxp mode to devstate in debugfs

On 9/7/2022 8:58 AM, Tomas Winkler wrote:
> Add pxp mode devstate to debugfs to monitor pxp state machine progress.
> This is useful to debug issues in scenarios in which the pxp state
> needs to be re-initialized, like during power transitions such as
> suspend/resume. With this debugfs the state could be monitored
> to ensure that pxp is in the ready state.
>
> CC: Vitaly Lubart <[email protected]>
> Signed-off-by: Tomas Winkler <[email protected]>
> Signed-off-by: Alexander Usyskin <[email protected]>

This is unchanged from the previously reviewed rev (apart from the
header update), so this still applies:

Reviewed-by: Daniele Ceraolo Spurio <[email protected]>

Daniele

> ---
> drivers/misc/mei/debugfs.c | 19 ++++++++++++++++++-
> 1 file changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/misc/mei/debugfs.c b/drivers/misc/mei/debugfs.c
> index 1ce61e9e24fc..3b098d4c8e3d 100644
> --- a/drivers/misc/mei/debugfs.c
> +++ b/drivers/misc/mei/debugfs.c
> @@ -1,6 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0
> /*
> - * Copyright (c) 2012-2016, Intel Corporation. All rights reserved
> + * Copyright (c) 2012-2022, Intel Corporation. All rights reserved
> * Intel Management Engine Interface (Intel MEI) Linux driver
> */
>
> @@ -86,6 +86,20 @@ static int mei_dbgfs_active_show(struct seq_file *m, void *unused)
> }
> DEFINE_SHOW_ATTRIBUTE(mei_dbgfs_active);
>
> +static const char *mei_dev_pxp_mode_str(enum mei_dev_pxp_mode state)
> +{
> +#define MEI_PXP_MODE(state) case MEI_DEV_PXP_##state: return #state
> + switch (state) {
> + MEI_PXP_MODE(DEFAULT);
> + MEI_PXP_MODE(INIT);
> + MEI_PXP_MODE(SETUP);
> + MEI_PXP_MODE(READY);
> + default:
> + return "unknown";
> + }
> +#undef MEI_PXP_MODE
> +}
> +
> static int mei_dbgfs_devstate_show(struct seq_file *m, void *unused)
> {
> struct mei_device *dev = m->private;
> @@ -112,6 +126,9 @@ static int mei_dbgfs_devstate_show(struct seq_file *m, void *unused)
> seq_printf(m, "pg: %s, %s\n",
> mei_pg_is_enabled(dev) ? "ENABLED" : "DISABLED",
> mei_pg_state_str(mei_pg_state(dev)));
> +
> + seq_printf(m, "pxp: %s\n", mei_dev_pxp_mode_str(dev->pxp_mode));
> +
> return 0;
> }
> DEFINE_SHOW_ATTRIBUTE(mei_dbgfs_devstate);

2022-09-07 22:25:53

by Daniele Ceraolo Spurio

[permalink] [raw]

Subject: Re: [Intel-gfx] [PATCH v8 13/16] mei: drop ready bits check after start

On 9/7/2022 8:58 AM, Tomas Winkler wrote:
> From: Alexander Usyskin <[email protected]>
>
> The check that hardware and host ready bits are set after start
> is redundant and may fail and disable driver if there is
> back-to-back link reset issued right after start.
> This happens during pxp mode transitions when firmware
> undergo reset. Remove these checks to eliminate such failures.
>
> Signed-off-by: Alexander Usyskin <[email protected]>
> Signed-off-by: Tomas Winkler <[email protected]>

Reviewed-by: Daniele Ceraolo Spurio <[email protected]>

Daniele

> ---
> drivers/misc/mei/init.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/drivers/misc/mei/init.c b/drivers/misc/mei/init.c
> index 1b4d5d7870b9..bac8852aad51 100644
> --- a/drivers/misc/mei/init.c
> +++ b/drivers/misc/mei/init.c
> @@ -218,16 +218,6 @@ int mei_start(struct mei_device *dev)
> goto err;
> }
>
> - if (!mei_host_is_ready(dev)) {
> - dev_err(dev->dev, "host is not ready.\n");
> - goto err;
> - }
> -
> - if (!mei_hw_is_ready(dev)) {
> - dev_err(dev->dev, "ME is not ready.\n");
> - goto err;
> - }
> -
> if (!mei_hbm_version_is_supported(dev)) {
> dev_dbg(dev->dev, "MEI start failed.\n");
> goto err;